From nobody Tue Feb 10 02:44:10 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B36CB3D3CF8; Tue, 3 Feb 2026 16:46:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770137201; cv=none; b=PnqvevPyhZ+H6oRAagKDPcpzKRCbYOCXyijclcQk/t8VCRWqzohvWITbWFLTYoNLYfGSK/Wg2ZhYMonEUSl72fqr3kt7qgG6SwAa52dWYVBjBABRDAjpQJPd3Azsfra5LypvodLEga9q2ahmTqPup7plaGVaK67evzFNNKZxV7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770137201; c=relaxed/simple; bh=651DjgUT7OtElKAM6DhUOfu2PEBxukKfO/3KX0XDgEo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CeSmfqSId1O41qPxtJ5SPKIeNd9A2o1FiuVluiM2S9a2Tj0HOygdQB/VLBlA5omu8/gH5AAsP+BUx3+/KSXwrKZRVVpTM1oPOTq9dRg0rgYKNVYJ0hlE4+HbgpGGLX1p+2cfKg1cH6b5tPpzrfBUNwHa7b8Dy6zsVmIjolTJ0wc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=MFflleT8; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="MFflleT8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770137195; bh=651DjgUT7OtElKAM6DhUOfu2PEBxukKfO/3KX0XDgEo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MFflleT8ajGdXL83egRe2hQ+74C//3tfK5E8IlzFZKbJFcdYbr1r5dBh5cO38YPWi JvzTws7k4w1DbZTMyi7eNIEnn8MB7Twt7kIKeh6MWL9hWvSqEd5YQvQVqeQzlrfZP/ vTw6NBldcxnekTnoH58mM8Ilb2NaXRPq97CpOxYeCddnd6a8rKVUcEJqhAX2DY7Rak GjfbiE7KHVlVHf4i8jDXrqx0FrfFkuLkvl7pTrzUljMqBQmqSWblEtvMvi7mZN2pD0 ELAPeCxMjERLX/+g8Q/mOhfoRX4QxSZIYSz2m7ALMPWib+P+a8AYAwiDITYeIYqYei gCT5D0Gxsq2bQ== Received: from jupiter.universe (dyndsl-091-248-189-143.ewe-ip-backbone.de [91.248.189.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id E377217E35D9; Tue, 3 Feb 2026 17:46:34 +0100 (CET) Received: by jupiter.universe (Postfix, from userid 1000) id 1829C48002B; Tue, 03 Feb 2026 17:46:34 +0100 (CET) From: Sebastian Reichel Date: Tue, 03 Feb 2026 17:46:28 +0100 Subject: [PATCH v2 06/10] ASoC: rockchip: spdif: Swap PCM and DAI component registration order Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260203-rockchip-spdif-cleanup-and-bsp-sync-v2-6-4412016cf577@collabora.com> References: <20260203-rockchip-spdif-cleanup-and-bsp-sync-v2-0-4412016cf577@collabora.com> In-Reply-To: <20260203-rockchip-spdif-cleanup-and-bsp-sync-v2-0-4412016cf577@collabora.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner Cc: Alexey Charkov , Sjoerd Simons , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Sebastian Reichel , Sugar Zhang X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1197; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=odke1hDY5a4eAB6A6L1moDVakX/wjeSZrUFRtUZjIjk=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGmCJmmBL0deZQgaga5PhJ4UNNNbnfNJgsiK0 ciM9yyZiL5W4IkCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJpgiZpAAoJENju1/PI O/qac+0QAKixPPhYunfCteZZoTxmKQtICZSEyrb+tQ5h+QtKulk4WVsW1duvvdVWRvrMRxir4UK i8gYvJayDoClHO1POC2ofOAplPhPsUt2E8C3LO2SglbJX2q0egcUSrJwbw5V+bdrpDsGhJYbjkB uBA7GLT9OqNaIEj0/yKMs25GYBZnP5FFzFCFhcIR/r1XymmRvPfKbfsrvdUr5clzerbaIEZVwCN W/axp68aT2WcACFtkJ7Y7PiahGrVoiKJNP4zTmEhnoazBsSHW28XOLKBgyQwJkScXQ6SZDeSaI0 D8ma9wUpnKMsDbk711MKiLlBIpqOjoXnONetWdwtNTDbZJshw9BcSUJzswnDRPln1ucBYlrh2oh 1sTbNU1vutIBDPNWJMh98ABqwuHOkpgegX5PSp9l+3P9iBMccq5lB55Sm35QaIOhwpf/ENa0aLa XS7BsRKIbu0Ji7xZ1NZ1RBEPQPwpUzJYxi+Jrt94YMwMl6koZ7jjfiSq2OFRmKx9YQMOq7oOn+o K0TWu2xD1jRsFHI4TgqivKTlsJikL+MO8RIMTSMz4CUZ0mtCW6793lBETO6mgGjef4/YhTUfJfL RuBj/HwVEKIaJzNAUjoPwB1f5LvttkGuT8baMrtDA5VzGAu9uPXflAwk3KX+nHisGqzZtf1uwaL LFRw78txTSxhuKIthMNArNg== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A From: Sugar Zhang PCM should be registered before the DAI component, as the second one triggers snd_soc_try_rebind_card. Signed-off-by: Sugar Zhang Signed-off-by: Sebastian Reichel --- sound/soc/rockchip/rockchip_spdif.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sound/soc/rockchip/rockc= hip_spdif.c index 55d64fd4c93b..c1221ff00ed7 100644 --- a/sound/soc/rockchip/rockchip_spdif.c +++ b/sound/soc/rockchip/rockchip_spdif.c @@ -325,16 +325,16 @@ static int rk_spdif_probe(struct platform_device *pde= v) return ret; } =20 + ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); + if (ret) + return dev_err_probe(&pdev->dev, ret, "Could not register PCM\n"); + ret =3D devm_snd_soc_register_component(&pdev->dev, &rk_spdif_component, &rk_spdif_dai, 1); if (ret) return dev_err_probe(&pdev->dev, ret, "Could not register DAI\n"); =20 - ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); - if (ret) - return dev_err_probe(&pdev->dev, ret, "Could not register PCM\n"); - return 0; } =20 --=20 2.51.0