From nobody Sat Feb 7 22:55:11 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D11A34AB01 for ; Tue, 3 Feb 2026 13:03:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770123840; cv=none; b=QHSQvk/ilJnUA5SZNs/YQUAlXSHtGdX+Z/nk7tWJ48k6OiVpjyruWuWIcJR4XngibSvqRP2gU6/5y1iHpOcWweGJ5+jxNB2WN28+Zc0wJPDsCP+6WM7nx+fPwmiA+32WtyPkviL7+Plzgefhx+wqcUneFNJ7V8YqPVuUZbTAytw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770123840; c=relaxed/simple; bh=o0U5ORS4ia6EHbTkAiNn4WLO7U36zOihVM23nqfZpFw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Uy6wKXIxv8uA8eAECJHjfYMQAqEBNf8LIRs7ZKgG1tz2MpHxPpURyFGMThjcVWBPIFDQcBCHg0fvNfNqU0qwJykXo9UWTMXSBolg5yF0tSXzS+ALtZBwzDNwQGzJw1prA4jXzQ8S93A/q3RNfgLlVCgkDtd/Z8VFJoOVFuuOTsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XA6L+7th; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XA6L+7th" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a07f8dd9cdso38598855ad.1 for ; Tue, 03 Feb 2026 05:03:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770123839; x=1770728639; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=ZIXyJm0lCseTe2hRs5ugea/FiAW2/mhs7M9O2I0yF5E=; b=XA6L+7th9GSCT6vzezForqXf0xsJtkmQ0ofAyPip1cO8NcBolDBYB8kkkHYOufwKL6 4aQxaR5CuaetR3j/U+PYB3epeHlWhIDRiXCUdfIOui2jv2e5XfHMHMHcNnXYW3gQXfjN hkT/b9x7xmF7HpQLmUcWVHKz0Ql28r5irI53z40nj4Zol+OqSCMi1srj9u2ztykGqpux 7CcI6tlpRY6DZtWR0+aynsEbY4xZMsE34+r6EVxaZACXKUAdH1On2xb2Xri11qddwxZM idWkwFAneP67gyq4wLrjjGAyGZXcTLcdpJPLp7WoZOa4E6pfvdQaas6QTQF5/Ya99xVD 6O+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770123839; x=1770728639; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZIXyJm0lCseTe2hRs5ugea/FiAW2/mhs7M9O2I0yF5E=; b=nkwcxiOZTPvT5lhkX4CVrzlAyWoeNMv4rVgT70KIpZsLYhEYU4iXtSLIP/KN45sgnr e336PWEeXJJcOp0/Wp8o5Ze3EH9FvN6L2dE5XQWRs6egaJBBxdXaKmAdWj2Xf1JCTRdU aQCr2XiB37M09Md9atn9So2SuVIHAxKz1Q4llHaEH0uirV8LqfAy/LvNmpYWbqo/9wo5 /pQiLf3oLw7AAoF7MPOSVdt9wF4CJXqbmLTlruUeWDP3zuD8mH8w/ztptyDwvc0Wr/sm LTXR/3/Ah7wJJxiUO6CPf6PJtAncW4fIofqs7YJ9GGn2cOM4NHg3hcGMpEL7E6JRNB7z 0j/g== X-Forwarded-Encrypted: i=1; AJvYcCW8tXX7RuggFSuueHNCHXiAhoQw64QiDaJwCqmbAgCp7ECWOm9RPaTjw05s1FFacc+/nu2LkdntwwuT478=@vger.kernel.org X-Gm-Message-State: AOJu0Yzrd8Al4mjuuS6510YCU95aYhom0UdGr7JnxUzeQtR6ed9FWVnN fiI7yjzBnhR6xXBRGZBG8JJKIBkMHwMR/D+ucw4i5pcEfQlrMBKkGbWzykmV0OJz X-Gm-Gg: AZuq6aIsiOip0cE1ETBISbLYx+OkrBc6e24/F5F6Pu20OjObk84wbILXy1Q310mMaG8 lKzlVeVmzwN2BhOJjH6PWgFAWEgW4tDuBGJ5ffSQF/+aoTkMVZaN/vTG6QNbk4AJ+XIUHKAgrfm dNvwT4JzmnaP1TuzwDD5zWwQA015qJrvbzMmePsAn9eEYVviOyQcyoLocu7WI+/GNIDV/8nZrOH 6lOpRGxTbqoBNJFBRzBBwMDUHolMz9HjEXPp+21Mkb8EIfh8gCHiKUvq4gWQK29MUNSq3IVXgAR KiCXSjqoomnV7NEwh6uLjlwkKcgWlKTqoW2Ecffo/BvA09Ew5d4ZW1lpVPu8GoZCg9AdFxtaY0A u+Q3qGyh70IvK9UqihVjZbSn/TbVZtfKxZuP5WHM/pbI8WGirog7TSjBETKWm1ht5DLFfUcLyEY PVwKEXNhQ5hcX/r1afB1cCMwbThR/pHFh18T5W X-Received: by 2002:a17:902:fc8d:b0:2a0:f47c:cfc with SMTP id d9443c01a7336-2a8d990b3e5mr134748725ad.34.1770123838660; Tue, 03 Feb 2026 05:03:58 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:f091:7dff:927e:f788]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b4c3b94sm169614815ad.48.2026.02.03.05.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 05:03:58 -0800 (PST) From: Felix Gu Date: Tue, 03 Feb 2026 21:03:52 +0800 Subject: [PATCH] soc: microchip: mpfs: Fix a memory leak in mpfs_sys_controller_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260203-mpfs-v1-1-666b8704f8f7@gmail.com> X-B4-Tracking: v=1; b=H4sIADfygWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDIwNj3dyCtGJdI3OjlBQTs6TUNEsDJaDSgqLUtMwKsDHRsbW1AOcFWY5 WAAAA X-Change-ID: 20260203-mpfs-272dd46bef90 To: Conor Dooley , Daire McNamara Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770123835; l=1333; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=o0U5ORS4ia6EHbTkAiNn4WLO7U36zOihVM23nqfZpFw=; b=JlIHm7wFByMVWo6XUG8fsK9kW363nQxUVozrhPyVnFdo6muGrr91WKWUcR2mz+6ykv2DrbjaH QV3hQN7eonXD2uRJIqBYLQMtaITlh+8VZSOHtFswzqs+j7GIWcl+J40 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In mpfs_sys_controller_probe(), when of_get_mtd_device_by_node() fails, the previously allocated sys_controller was leaked. Add kfree() to fix this. Fixes: 742aa6c563d2 ("soc: microchip: mpfs: enable access to the system con= troller's flash") Signed-off-by: Felix Gu --- drivers/soc/microchip/mpfs-sys-controller.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/soc/microchip/mpfs-sys-controller.c b/drivers/soc/micr= ochip/mpfs-sys-controller.c index 30bc45d17d34..a7401cb79e97 100644 --- a/drivers/soc/microchip/mpfs-sys-controller.c +++ b/drivers/soc/microchip/mpfs-sys-controller.c @@ -142,8 +142,11 @@ static int mpfs_sys_controller_probe(struct platform_d= evice *pdev) =20 sys_controller->flash =3D of_get_mtd_device_by_node(np); of_node_put(np); - if (IS_ERR(sys_controller->flash)) - return dev_err_probe(dev, PTR_ERR(sys_controller->flash), "Failed to get= flash\n"); + if (IS_ERR(sys_controller->flash)) { + ret =3D dev_err_probe(dev, PTR_ERR(sys_controller->flash), "Failed to ge= t flash\n"); + kfree(sys_controller); + return ret; + } =20 no_flash: sys_controller->client.dev =3D dev; --- base-commit: 193579fe01389bc21aff0051d13f24e8ea95b47d change-id: 20260203-mpfs-272dd46bef90 Best regards, --=20 Felix Gu