From nobody Sat Feb 7 04:47:32 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB2E6286A7 for ; Tue, 3 Feb 2026 04:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770094352; cv=none; b=O4WeQWRjYm740w+R+iHYxKk4bOiviAljw4VoEdTZtjBTc/fxkhJpbMH/wO4i1YJKjoXoMmZ6labjnEOfyt4VV4MAPCT6xIC4FkHiA9+CyVvz7R9gPfyYjhVF5IAA38nixgDQ+ZyUxZOiqYlEGSb7nPwd5K/J/ZG2lX/cjLdSxa4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770094352; c=relaxed/simple; bh=6+xXkjP8HsfHYdc9AmZVWGKssn+LkI6glLOud1OOl2U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=RXkG/Tch+QfScLRxfF+8nHTiBzw+ZwbjM5TNzIQOVNQ1rrbOJKXYqq4tqTJZscjC6xZjJXQZsRNoIOaVz10YMu2DQNVV7BcPzuG32ODj4UJlzLCfsB//YsVQvVoGEu4+G5Cj/M03TCM8z/Ayc+rzQ3ejBP5FhDxrNxFhFpsKF8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KhO2wJGX; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KhO2wJGX" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2a7bced39cfso54858785ad.1 for ; Mon, 02 Feb 2026 20:52:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770094350; x=1770699150; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=dQwV+HU/nzqnyraQQUxH1t9hmx22OT4HIQY8cfaKBV0=; b=KhO2wJGXfeCy6p6fMPixwmrSRqdVGwAPBi3skzLYvXP1mZKO9jpzjRzcttB9fXLHap nskLW/X0JSwXFfd5oALVHCOl1PK53+Ro7nSiPLmYCClwVptVX5iosuM+AaM5GE+QTdKJ KJip/cbq2KIukV6ik3rykSVwMrI9Qxtd5tnpJL4vr5WvXEls+etDJsoMBZC+EWcAaDH8 2LWOC2J/CGU1254ERrlThP0EDds/xD8eLZmh61V/brfLv04xeBYJGh2h6J4GazkK9yAY CBaNQlziiHx8JNsPyodqyQeWYsbFvDACnUgHKg9PEw3mYqEuwbTMgOuMUA7X4G6Y+IKL y6LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770094350; x=1770699150; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dQwV+HU/nzqnyraQQUxH1t9hmx22OT4HIQY8cfaKBV0=; b=vFqy/My2oOiAGeWz78E5INbXQoJLK8P2ecxmawMsnuQtY/TOoRgShjD/Ot0MX+mEa0 48elr4GrVL27IBwAZM4NWIhi8KGm4zoUMYMEEDdRwd+13FyonqqtKwC02+VdQgoaDVij +aqTKLWVBVjqojf1SOa7TlGKi59e8lpOJoITQEhLF80P09PoiaFMpHstljDNDROcd0og +JsXAg6lgQhXd8BNtQKBdUFxUupJY8RaajADqtlYmrFukpicHAGUbLCocbkV5iH4+Jo+ Otb3bQAuBRVGeZ37+n2a/fSuXNr4pzzwlCJfuYHCqMfvICDWtKLGPLgImTe381B7f1e6 EfJw== X-Gm-Message-State: AOJu0Yy39sdgJ4UWcHttRs0GmwQdW8x6ZdsNvMyhCxmfUFC4HXWbpcXf +tBYzdldLIdbs1hNssU9FFR9s+k56j6URkYFiuzyfg5GpUQnv+s8PSEfrzEvk/z7 X-Gm-Gg: AZuq6aKLpxq8enW7zXaqZJ6yhh8uw/y1TfDlZurJ1TRRb8lVPjGoUGQ+cLFUhKU3P97 tDPa9VLLXE+1VOproMkZEqm7guMaXQy5GqXHDXyLpC/tAThwO4MPw8K4JsPG5kbBdt7Pj08doEk iQiVDN9LaHA/LbQYELAkcJIPvZI/uQjO3L+1TzDhne2sQcQjnLop4I7wF+8aEi82+tdH3seGLO4 ufpCmTUJv4tdMXRPclQQ3eDuyMWV8QYS9H1YdyEo/emyN2ZpqlATZorjO5lUzhNOWuVEY4AhS/w oA3ozVomAicsCrO86caRD+m2NW1xtOiecjDlY1m+XBbP0La57ecOb83IwZzitJpMp8d3y+k0QJP kWVsFa2uz3RBuJ9nG5r7NHHHhmJoJjGj7SkXFSg46RoLgE7Aq20jV+5JOsXO+pFObNGABNmXafj 1YJwuxDax1XOBv4IWOBOEeL7FpJ48wCw== X-Received: by 2002:a17:902:ef08:b0:2a0:8be7:e3db with SMTP id d9443c01a7336-2a8d96c2519mr140302195ad.15.1770094349874; Mon, 02 Feb 2026 20:52:29 -0800 (PST) Received: from [172.16.80.107] ([210.228.119.9]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3547b1036e6sm514955a91.11.2026.02.02.20.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 20:52:29 -0800 (PST) From: Ryota Sakamoto Date: Tue, 03 Feb 2026 13:52:25 +0900 Subject: [PATCH v2] lib/tests: add KUnit test for argv_split() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260203-kunit-argv_split-v2-1-bed3a0a2ba02@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/2WNwQ6CMBBEf4Xs2Zruthj15H8YYiotsBEoabHRE P7dikdv8yaZNwtEF9hFOBcLBJc4sh8z0K6AujNj6wTbzECSDhIVisdz5FmY0KZbnPoca0MG7am xR7pDnk3BNfzalNcqc8dx9uG9PST8tj8ZSfUvSyhQSKtKXSrURuOlHQz3+9oPUK3r+gFLDjsjs AAAAA== X-Change-ID: 20260131-kunit-argv_split-ca2a1d9fd82b To: Andrew Morton Cc: linux-kernel@vger.kernel.org, kernel test robot , Ryota Sakamoto X-Mailer: b4 0.14.2 Add KUnit test for argv_split() to ensure that it correctly splits strings and handles edge cases such as multiple spaces, leading/trailing and whitespace. Currently, there is no dedicated test for argv_split. Moving towards KUnit allows for easier regression testing and validation of the function. Sample KUnit output: KTAP version 1 # Subtest: argv_split # module: argv_split_kunit 1..1 KTAP version 1 # Subtest: test_argv_split ok 1 basic words ok 2 single word ok 3 leading/trailing whitespace ok 4 mixing space ok 5 quotes are treated as literals ok 6 empty # test_argv_split: pass:6 fail:0 skip:0 total:6 ok 1 test_argv_split Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202602030650.7n64kb2g-lkp@int= el.com/ Signed-off-by: Ryota Sakamoto --- Changes in v2: - Fix build error on sparc-linux-gcc (GCC) 8.5.0 due to empty scalar initia= lizer - Add Reported-by tag --- lib/Kconfig.debug | 12 ++++++ lib/tests/Makefile | 1 + lib/tests/argv_split_kunit.c | 93 ++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 106 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ba36939fda79bf890834b586c366a28acd434ef9..7dacfdccdb83f639944fcdf1d95= 48245eb047a30 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -2817,6 +2817,18 @@ config CMDLINE_KUNIT_TEST =20 If unsure, say N. =20 +config ARGV_SPLIT_KUNIT + tristate "KUnit test for argv_split" if !KUNIT_ALL_TESTS + depends on KUNIT + default KUNIT_ALL_TESTS + help + This builds the argv_split unit tests. + + For more information on KUnit and unit tests in general please refer + to the KUnit documentation in Documentation/dev-tools/kunit/. + + If unsure, say N. + config BASE64_KUNIT tristate "KUnit test for base64 decoding and encoding" if !KUNIT_ALL_TESTS depends on KUNIT diff --git a/lib/tests/Makefile b/lib/tests/Makefile index 601dba4b7d966d568d0bb6671dffaf4d68489549..fa00737a9cf60ca881b58d915e7= f931df372594a 100644 --- a/lib/tests/Makefile +++ b/lib/tests/Makefile @@ -4,6 +4,7 @@ =20 # KUnit tests CFLAGS_bitfield_kunit.o :=3D $(DISABLE_STRUCTLEAK_PLUGIN) +obj-$(CONFIG_ARGV_SPLIT_KUNIT) +=3D argv_split_kunit.o obj-$(CONFIG_BASE64_KUNIT) +=3D base64_kunit.o obj-$(CONFIG_BITFIELD_KUNIT) +=3D bitfield_kunit.o obj-$(CONFIG_BITS_TEST) +=3D test_bits.o diff --git a/lib/tests/argv_split_kunit.c b/lib/tests/argv_split_kunit.c new file mode 100644 index 0000000000000000000000000000000000000000..5e6040dd8997a8b27c54cd05045= f737a865ff0ae --- /dev/null +++ b/lib/tests/argv_split_kunit.c @@ -0,0 +1,93 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Test cases for argv_split module. + */ + +#include +#include +#include +#include + +struct argv_split_test_case { + const char *str; + const char *input; + const int argc; + const char *const *argv; +}; + +KUNIT_DEFINE_ACTION_WRAPPER(argv_free_wrapper, argv_free, char **); + +static struct argv_split_test_case argv_split_cases[] =3D { + { + .str =3D "basic words", + .input =3D "foo bar", + .argc =3D 2, + .argv =3D (const char *[]){ "foo", "bar" }, + }, + { + .str =3D "single word", + .input =3D "foobar", + .argc =3D 1, + .argv =3D (const char *[]){ "foobar" }, + }, + { + .str =3D "leading/trailing whitespace", + .input =3D " hello world ", + .argc =3D 2, + .argv =3D (const char *[]){ "hello", "world" }, + }, + { + .str =3D "mixing space", + .input =3D " \t foo \n bar baz", + .argc =3D 3, + .argv =3D (const char *[]){ "foo", "bar", "baz" }, + }, + { + .str =3D "quotes are treated as literals", + .input =3D "ls \"my file/\"", + .argc =3D 3, + .argv =3D (const char *[]){ "ls", "\"my", "file/\"" }, + }, + { + .str =3D "empty", + .input =3D "", + .argc =3D 0, + .argv =3D NULL, + }, +}; + +KUNIT_ARRAY_PARAM_DESC(argv_split, argv_split_cases, str); + +static void test_argv_split(struct kunit *test) +{ + const struct argv_split_test_case *params =3D test->param_value; + int argc; + char **argv; + int i; + + argv =3D argv_split(GFP_KERNEL, params->input, &argc); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, argv); + kunit_add_action(test, argv_free_wrapper, argv); + + KUNIT_EXPECT_EQ(test, argc, params->argc); + for (i =3D 0; i < argc; i++) + KUNIT_EXPECT_STREQ(test, argv[i], params->argv[i]); + + KUNIT_EXPECT_NULL(test, argv[argc]); +} + +static struct kunit_case argv_split_test_cases[] =3D { + KUNIT_CASE_PARAM(test_argv_split, argv_split_gen_params), + {}, +}; + +static struct kunit_suite argv_split_test_suite =3D { + .name =3D "argv_split", + .test_cases =3D argv_split_test_cases, +}; + +kunit_test_suite(argv_split_test_suite); + +MODULE_AUTHOR("Ryota Sakamoto "); +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("argv_split testing module"); --- base-commit: 18f7fcd5e69a04df57b563360b88be72471d6b62 change-id: 20260131-kunit-argv_split-ca2a1d9fd82b Best regards, --=20 Ryota Sakamoto