From nobody Sat Feb 7 04:47:31 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0848224234 for ; Mon, 2 Feb 2026 16:34:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770050070; cv=none; b=LE67uQgVkpNghELrcJgxkGEjRiDLEy/ZGJG/xDYcyOaqn3BccVfuxAJmWnl5LmaX0pb8eEr46Fe+ihbDYJWB2FlhbVa2uhPFqYnL12LHaw5VY8kBekZaAo4htwKA7CPRozA4rfjTiH5gMfrdkybx9rj7hFBiJY9KolKHMS9R43Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770050070; c=relaxed/simple; bh=kRSKk8DafCJZ2vw0s9Wq9/ntecu1r9oWIgmeUVWDs0I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=BLlVMj7SPXJin/Gcvzyu9si/fkplTY0hYmOjS0cBu0s170Zl9B8J0+rGrk1TCxEbz8G26jnTXoDXhpsHG/hatpsMLmU0aJVbeOvh0CDHa6JqelDvI+OyT/I23IEXn4EaIBdAMjFc7pRqu3lX8klEtldGoRNXZE77JYt9ro7OZkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ihHTuFig; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ihHTuFig" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8217f2ad01eso3675696b3a.2 for ; Mon, 02 Feb 2026 08:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770050068; x=1770654868; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=eFMD5B7VFwEw5lPUuPTyCmDCDzZhDrQ6I2C5qQW60aw=; b=ihHTuFigauBH6xE8MqpGBZ2m9+Sj8eqSKkeQcq+3YwMCO/pH5GGKKAo0CKhWfIcYy5 Rmh7CQ8qCUn4TEoIPfb36kSjjgT1DPT4GZ/OTNavzybFM5zqDYDlzysilhQhwqE47/xL iXniZjqDU5wtrvgbsA4D0iirB8OMh0AcQH6jbZebewglF8/RuA2VuOS4/+PICTGdX64B 3Ja4RtzfeGGJf6406vqNva46erAhX/R+pMGuS2dE9KrOIqcUusdmZuxcY3K0lxXGRkSR RFpj0wJRad3ZPQDdg2GpD1pq6VmEGGxXjBzrnhq9/2YSj5H2douB79jpWvTVDnphQtyO 17rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770050068; x=1770654868; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eFMD5B7VFwEw5lPUuPTyCmDCDzZhDrQ6I2C5qQW60aw=; b=DTEIKLFOShFrroq+gJo99a7Qd3fCdVaZePI2wY2wwu/spRyAxJLqxQ0RVheBBDBcII nC6VRMiB4hPzL/sOM8JsPTalSKVIpnsvLZtLCsop38vK4MQuE+9s2Q8yhkgsMljv6w1x UBP7Ep4vCc9cO0DNe2QJamaC/WZHk1N4emnjApjdKUvnTXDZCz9cWWoB0S/h9a8a0KRM FCn5vIGg57e3zjsfvEP8tXr1d0BnXKq7weKtcj9IQxKzzozkgn7jH5mD5tSAbQq9TI/h 3UxYnwENfYedzaZUPeI4or6Zrega3fR+LThebR9yawzhfWLB8+DC3swQcCiZVp2vLQmv upqQ== X-Gm-Message-State: AOJu0YzjQ8sTv0l+vVHOic78siwSRgw9z++3juLdd1j+o3QNNZFUbCtB x4AupJOKv19Rk1Mn5Dhd5lsJKvNJbJLXyHbJeaxgBL+y7Rd91xrw7VDTJwpYGVrw X-Gm-Gg: AZuq6aLTIx6FcVaMW3B9vABnacN0PJmVFdoM8b8eZhBiR6wsY3qjpZ4pPEZj5wTqKvs 3gZvbbcsqloN4RdnvVpSbph3Z45fwVU/wfqgr1lqmEY1nQYxw6GSe9TqpHvvd9XT3wglpvpfQSj k61eF1t+wSeZ5wqDzECULkoPwRbphHM7e/GTemvGKFWBSk4ZNdnivFxGL9/w2i+AAFBpdhp0kHe GwBN/1tgz4IW2mjNW4VXKycW+y+LuuXvPiu/hWXrttPwCoHH+l7eiZHRYCEzQTrf30yMJe3Ajvk qrpG/iKbykrmGRGHAL1g/lKmwk7Qm8rP8ObDHIz9RL95wczQ9+GxClwpyYUtq0CWG7BloCLgGZG ewI8522JLFrH2opG7mkJi+Q75aGadbKDdcdnOXIdwFnWioFdxt+pA6DwQWKRxhW/ebt92PFRg/c edpIntFQ9IPbcEqrN7QRtDe/5lQue0yg== X-Received: by 2002:a05:6a00:4fd5:b0:7e8:4433:8f9a with SMTP id d2e1a72fcca58-823ab72daecmr11924258b3a.34.1770050068019; Mon, 02 Feb 2026 08:34:28 -0800 (PST) Received: from [172.16.80.107] ([210.228.119.9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c54febsm19968119b3a.59.2026.02.02.08.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 08:34:27 -0800 (PST) From: Ryota Sakamoto Date: Tue, 03 Feb 2026 01:34:23 +0900 Subject: [PATCH] lib/tests: add KUnit test for argv_split() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260203-kunit-argv_split-v1-1-0d3545314a41@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x2MQQqAIBAAvyJ7TlCDqL4SEZarLYWJVgTS35NuM 4eZDAkjYYKeZYh4U6LDF5EVg2XV3iEnUxyUUI2QteTb5enkOrp7SmEvuGilpemsadUMJQsRLT3 /chjf9wMuDZytYgAAAA== X-Change-ID: 20260131-kunit-argv_split-ca2a1d9fd82b To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Ryota Sakamoto X-Mailer: b4 0.14.2 Add KUnit test for argv_split() to ensure that it correctly splits strings and handles edge cases such as multiple spaces, leading/trailing and whitespace. Currently, there is no dedicated test for argv_split. Moving towards KUnit allows for easier regression testing and validation of the function. Sample KUnit output: KTAP version 1 # Subtest: argv_split # module: argv_split_kunit 1..1 KTAP version 1 # Subtest: test_argv_split ok 1 basic words ok 2 single word ok 3 leading/trailing whitespace ok 4 mixing space ok 5 quotes are treated as literals ok 6 empty # test_argv_split: pass:6 fail:0 skip:0 total:6 ok 1 test_argv_split Signed-off-by: Ryota Sakamoto --- lib/Kconfig.debug | 12 ++++++ lib/tests/Makefile | 1 + lib/tests/argv_split_kunit.c | 93 ++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 106 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ba36939fda79bf890834b586c366a28acd434ef9..7dacfdccdb83f639944fcdf1d95= 48245eb047a30 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -2817,6 +2817,18 @@ config CMDLINE_KUNIT_TEST =20 If unsure, say N. =20 +config ARGV_SPLIT_KUNIT + tristate "KUnit test for argv_split" if !KUNIT_ALL_TESTS + depends on KUNIT + default KUNIT_ALL_TESTS + help + This builds the argv_split unit tests. + + For more information on KUnit and unit tests in general please refer + to the KUnit documentation in Documentation/dev-tools/kunit/. + + If unsure, say N. + config BASE64_KUNIT tristate "KUnit test for base64 decoding and encoding" if !KUNIT_ALL_TESTS depends on KUNIT diff --git a/lib/tests/Makefile b/lib/tests/Makefile index 601dba4b7d966d568d0bb6671dffaf4d68489549..fa00737a9cf60ca881b58d915e7= f931df372594a 100644 --- a/lib/tests/Makefile +++ b/lib/tests/Makefile @@ -4,6 +4,7 @@ =20 # KUnit tests CFLAGS_bitfield_kunit.o :=3D $(DISABLE_STRUCTLEAK_PLUGIN) +obj-$(CONFIG_ARGV_SPLIT_KUNIT) +=3D argv_split_kunit.o obj-$(CONFIG_BASE64_KUNIT) +=3D base64_kunit.o obj-$(CONFIG_BITFIELD_KUNIT) +=3D bitfield_kunit.o obj-$(CONFIG_BITS_TEST) +=3D test_bits.o diff --git a/lib/tests/argv_split_kunit.c b/lib/tests/argv_split_kunit.c new file mode 100644 index 0000000000000000000000000000000000000000..608ec29d8688b94265d2ec920b5= fea59a5ce1b4f --- /dev/null +++ b/lib/tests/argv_split_kunit.c @@ -0,0 +1,93 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Test cases for argv_split module. + */ + +#include +#include +#include +#include + +struct argv_split_test_case { + const char *str; + const char *input; + const int argc; + const char *const *argv; +}; + +KUNIT_DEFINE_ACTION_WRAPPER(argv_free_wrapper, argv_free, char **); + +static struct argv_split_test_case argv_split_cases[] =3D { + { + .str =3D "basic words", + .input =3D "foo bar", + .argc =3D 2, + .argv =3D (const char *[]){ "foo", "bar" }, + }, + { + .str =3D "single word", + .input =3D "foobar", + .argc =3D 1, + .argv =3D (const char *[]){ "foobar" }, + }, + { + .str =3D "leading/trailing whitespace", + .input =3D " hello world ", + .argc =3D 2, + .argv =3D (const char *[]){ "hello", "world" }, + }, + { + .str =3D "mixing space", + .input =3D " \t foo \n bar baz", + .argc =3D 3, + .argv =3D (const char *[]){ "foo", "bar", "baz" }, + }, + { + .str =3D "quotes are treated as literals", + .input =3D "ls \"my file/\"", + .argc =3D 3, + .argv =3D (const char *[]){ "ls", "\"my", "file/\"" }, + }, + { + .str =3D "empty", + .input =3D "", + .argc =3D 0, + .argv =3D {}, + }, +}; + +KUNIT_ARRAY_PARAM_DESC(argv_split, argv_split_cases, str); + +static void test_argv_split(struct kunit *test) +{ + const struct argv_split_test_case *params =3D test->param_value; + int argc; + char **argv; + int i; + + argv =3D argv_split(GFP_KERNEL, params->input, &argc); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, argv); + kunit_add_action(test, argv_free_wrapper, argv); + + KUNIT_EXPECT_EQ(test, argc, params->argc); + for (i =3D 0; i < argc; i++) + KUNIT_EXPECT_STREQ(test, argv[i], params->argv[i]); + + KUNIT_EXPECT_NULL(test, argv[argc]); +} + +static struct kunit_case argv_split_test_cases[] =3D { + KUNIT_CASE_PARAM(test_argv_split, argv_split_gen_params), + {}, +}; + +static struct kunit_suite argv_split_test_suite =3D { + .name =3D "argv_split", + .test_cases =3D argv_split_test_cases, +}; + +kunit_test_suite(argv_split_test_suite); + +MODULE_AUTHOR("Ryota Sakamoto "); +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("argv_split testing module"); --- base-commit: 18f7fcd5e69a04df57b563360b88be72471d6b62 change-id: 20260131-kunit-argv_split-ca2a1d9fd82b Best regards, --=20 Ryota Sakamoto