From nobody Sun Feb 8 21:12:26 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 191A836606E for ; Tue, 3 Feb 2026 05:52:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770097927; cv=none; b=qMpF3vdz7oZQypD3hWdgRrO8+AIgeumxzwy+2eShcl+XjXIxcTcRwkPCQrA4afgtSv7nZbG4PbFd24ByLX0aIwCol7yULS1C+W1psNHWW3/HEgbxmmGWYpqa/Z3iis6bfTbzR3gzBKAAjQmQ+6/tvrNG4XL/HaNoQnjbk07e0h8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770097927; c=relaxed/simple; bh=CwCT5/x9boKhb1Ajkz+foUdUOzmm0/q81QDotkFpGzA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KCyeNP0qt4FsTotaBHZVoZtLre7gKK7VdED19nd7ZvTdKCFhB9d5RN3wW/rJIr5mTu60z4B1f9L44w6BPIpJ7qlpbiaPMthUvTUprtRgFQLcpNJW7BIaOAbLYyNaS0/om/g0j5Lul4WpH8h7Co9oY2eZ2ocg518fm5elThodSfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=En++TTvU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CgzovpqN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="En++TTvU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CgzovpqN" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6135bwKf2261751 for ; Tue, 3 Feb 2026 05:52:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 51VyzH5MVWt5pCU+WtqPfgt9gr9jXVE/0KTTZNnKYmU=; b=En++TTvUAIK5TZHQ J+sDgDrZmY2qq6ex6kuRa6RApo9SnxG2GekP3G1ttyHiaXDkoeeXtTymcq2GeTEC 6vurqtAYnx2eVeNyiIM5D5LhXL2/Leni3hhMnRgpCaB1aIoPm0EnsmmflmScYfND StkMisUmOHF1lkbrekNKJsv+4pGt7TIYvBb3aNRabaLMrBELzvJ15t7auLL4Uhin lgJBKlzgbfOyABwEsyi2ePj+NPOcwo36t8h4TqF0cGL2ZKlT8zM1xNRtp5qxi9lD FPneeTXzmQxXWfF8KialDDe08FOZvncl7I8yie/35FOtqQoRduiRVFQews+kNVJu XUPL5A== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2tmtk29c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 05:52:04 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0bb1192cbso44008775ad.1 for ; Mon, 02 Feb 2026 21:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770097924; x=1770702724; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=51VyzH5MVWt5pCU+WtqPfgt9gr9jXVE/0KTTZNnKYmU=; b=CgzovpqNi5MArdXDvAshvxh4xdE+GQhP2CogI8rZFPwwQH7yTBV6sphFpWYcXUHLbb tmSYtl/4CUk8wemqVjCioMhVpoAlnAv0F+LIZR3txDOY1S2rlcJitFdyVs8oeMAK5+cM 2zDw6on7ioyR2dTOtsSePxhyxCbXx/n6SXQgSYCawVjLcKxClqIkd6v/gcIyoj2K/1kb tHhHlcQt+bxVNsXhNnu9kJ+NLwlyFtQLp3Yk490WopL2vcS/1QFyr+m7Ho6SeOA8imtd QPePxZEsDxFV9xah/1lJFjklllIjBG33wSL6XL3859xBxxOUVcHeemLoydTqplQs/k6Z ueCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770097924; x=1770702724; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=51VyzH5MVWt5pCU+WtqPfgt9gr9jXVE/0KTTZNnKYmU=; b=eREiDIoK59cK/y1F4UvnUA6SQzWzKmiYux/nVYHslvvKjxzdcp5hKEWDEfgBUcgUSJ ZXTN3Mm3RVBlFy1rbdK5JRFvTv5NJi0nhPTjax3Foz3BzPSqIYn2MkSTtAVgh+azUqr8 k/xi3MngLqnYeRq8qaAdPlY70YJ1cQAx13AwQaVOjHsNwIuum62YhEsLmm1vaRRxOY6i PnOmkcEi4q3Tx2/qQGN4BvmGqtdWZJgnCjP33S2GOIPWKkfHRPSuDfGP6VLFpFHfzC7i mS0y0jl3ZSlAJtlq/a+S35TvIi2+0ATxNLO3FvTDiMXhJJX8fuAtA4Sp+8rrmbG+iug3 L7Dw== X-Forwarded-Encrypted: i=1; AJvYcCVa0CbysYEgYftLitFxnCuJk40OlZrG8gVKCztgCs+Bs03FtPkU7kU+yFxx1DooNzuIdWqeZVijVzO0KyM=@vger.kernel.org X-Gm-Message-State: AOJu0Yywx6eJuums1zY9ZC2dE79SaHBwcnh54Buy2yKXDjdIzkuxn25L Mg118afyrOE1rfcQkXc99vtncQu7GC+9IQQIsEIiZCV+jKrgDDSGjWx7Fisdxz6Z4ZBmk+LEnca TyZ16dkw8I9jYkjD3vsAPCMGDsUCOq3B8iBcOXubmbCiDSRyRqqfZh4TCuCS2pQWDy5k= X-Gm-Gg: AZuq6aLo41R3rNUmGHoFqld/KUcy9cgedGInRrb9GXfXeVa70y8/scZqt6aswWHrm6A lyV7WPrJ5N31crCpwY4UbRxVkxux41+BXMY1CGrRq+gkL86AOnTG4MQMgWkRxsH/6CRTfmC4awe NAXpCgWM0Hn8mwLr9ekifXgL++LT26/HU6PVz5rBV5SnAopPhZOQOyynMaqWi7ageaNBQNS1fVD M9nNHm3xG0XtVivAQb/ncfOD1Zrr2d4ooenHmtGX4iO2vwzbxYvlngtH7YshWz1RID1Io758DUJ x92XI8B7tXfcfTRcQOz0fBEOLiqMGCLCT2FkDTC0QC+P6xD4fO5slx7IhnmgDUBdiPDoFGhv9X2 xrnpVP0eAZ5knKnPTIJHjTNq0UQ0yotrRLmF8AOg7J+sKDDToJk4m6YNCwj+TJiwbMVtupHjz X-Received: by 2002:a17:902:868d:b0:2a0:9970:13fd with SMTP id d9443c01a7336-2a8d9943c36mr99480685ad.43.1770097923978; Mon, 02 Feb 2026 21:52:03 -0800 (PST) X-Received: by 2002:a17:902:868d:b0:2a0:9970:13fd with SMTP id d9443c01a7336-2a8d9943c36mr99480535ad.43.1770097923508; Mon, 02 Feb 2026 21:52:03 -0800 (PST) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b6e4189sm157424735ad.83.2026.02.02.21.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 21:52:03 -0800 (PST) From: Jie Gan Date: Tue, 03 Feb 2026 13:51:19 +0800 Subject: [PATCH v12 3/8] coresight: tmc: Introduce tmc_sysfs_ops to wrap sysfs read operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260203-enable-byte-cntr-for-ctcu-v12-3-7bf81b86b70e@oss.qualcomm.com> References: <20260203-enable-byte-cntr-for-ctcu-v12-0-7bf81b86b70e@oss.qualcomm.com> In-Reply-To: <20260203-enable-byte-cntr-for-ctcu-v12-0-7bf81b86b70e@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770097896; l=5212; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=CwCT5/x9boKhb1Ajkz+foUdUOzmm0/q81QDotkFpGzA=; b=kA+GBzzIvXNSvvOWRPmGgpNHQ4tzGkRgViKapki96YY2xM5iV5eA7MLSGbpTQeREnapw2+UDm sLP7eOQq/76Cxv3LJb0q7HMP+V2TISsKCLBlFP9H35U2ntJPBaC2O5K X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Authority-Analysis: v=2.4 cv=Xb6EDY55 c=1 sm=1 tr=0 ts=69818d05 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=ia3uihG--C1vaqsH_ucA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: C9yegeUndM2B-4ObPazWz8DyLGEUnQVc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA0NCBTYWx0ZWRfX00EdNDY4AtJZ zyjGkwolSZ2kVUZ7H/Rzfz5Vzns9SIzciRy1iRC4frSPrqeAu9PwLo9C8j0vJQMpk+p5+jttf4f jZl7wUAJ7ly4lN6238IyHmyvVKMJxidw8c5O59FpBrWYyQSEZoEID2zqXMkcisPuxDURCW0ohWw RZvUjxLwuQwcj2vVaI8tUqRLCbZ0yNsRkMP/OqouUpjKkTKsWG366Og2xj9aWMVUbbEe83fb9IP BlKm0bogcoL7zMvMvHVs7x3C7rlu5Rt+uou083ywP08yOAlFs7ar2KQTNf6vZ+87HFa+NDL/q9Q OpCD3Uf0uslAAkm+4SfZlPZyfClF/2C4a6GwtdWObz4eKduvmEmyd+xQgwWjgS7Cn4cPGB4PfXh GjfCdn09TNDFfLoiXtYmc9SbhIPCcOU6klhfzCcfx3+H4dXLB8xEYTq6im4hWCn3qNWCAoGpdTX y83lQckZOqgOC+W8SbA== X-Proofpoint-GUID: C9yegeUndM2B-4ObPazWz8DyLGEUnQVc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_01,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030044 Introduce tmc_sysfs_ops as a wrapper, wrap sysfs read operations, for readi= ng trace data from the TMC buffer. Reviewed-by: Mike Leach Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tmc-core.c | 51 ++++++++++----------= ---- drivers/hwtracing/coresight/coresight-tmc.h | 15 +++++++ 2 files changed, 37 insertions(+), 29 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index 1ea255ffa67c..32ca2ec994de 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -232,17 +232,10 @@ static int tmc_read_prepare(struct tmc_drvdata *drvda= ta) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_prepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_prepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_prepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read start\n"); @@ -254,17 +247,10 @@ static int tmc_read_unprepare(struct tmc_drvdata *drv= data) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_unprepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_unprepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_unprepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read end\n"); @@ -291,15 +277,7 @@ static int tmc_open(struct inode *inode, struct file *= file) static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos= , size_t len, char **bufpp) { - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - return tmc_etb_get_sysfs_trace(drvdata, pos, len, bufpp); - case TMC_CONFIG_TYPE_ETR: - return tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); - } - - return -EINVAL; + return drvdata->sysfs_ops->get_trace_data(drvdata, pos, len, bufpp); } =20 static ssize_t tmc_read(struct file *file, char __user *data, size_t len, @@ -769,6 +747,18 @@ static void register_crash_dev_interface(struct tmc_dr= vdata *drvdata, "Valid crash tracedata found\n"); } =20 +static const struct tmc_sysfs_ops etb_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etb, + .read_unprepare =3D tmc_read_unprepare_etb, + .get_trace_data =3D tmc_etb_get_sysfs_trace, +}; + +static const struct tmc_sysfs_ops etr_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etr, + .read_unprepare =3D tmc_read_unprepare_etr, + .get_trace_data =3D tmc_etr_get_sysfs_trace, +}; + static int __tmc_probe(struct device *dev, struct resource *res) { int ret =3D 0; @@ -828,6 +818,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.sink_subtype =3D CORESIGHT_DEV_SUBTYPE_SINK_BUFFER; desc.ops =3D &tmc_etb_cs_ops; dev_list =3D &etb_devs; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; case TMC_CONFIG_TYPE_ETR: desc.groups =3D coresight_etr_groups; @@ -841,6 +832,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) mutex_init(&drvdata->idr_mutex); dev_list =3D &etr_devs; INIT_LIST_HEAD(&drvdata->etr_buf_list); + drvdata->sysfs_ops =3D &etr_sysfs_ops; break; case TMC_CONFIG_TYPE_ETF: desc.groups =3D coresight_etf_groups; @@ -849,6 +841,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.link_subtype =3D CORESIGHT_DEV_SUBTYPE_LINK_FIFO; desc.ops =3D &tmc_etf_cs_ops; dev_list =3D &etf_devs; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; default: pr_err("%s: Unsupported TMC config\n", desc.name); diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index 9b3c4e6f0a5e..c780f6d5dede 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -258,6 +258,7 @@ struct etr_buf_node { * Used by ETR/ETF. * @etr_buf_list: List that is used to manage allocated etr_buf. * @reading_node: Available buffer_node for byte-cntr reading. + * @sysfs_ops: Read operations for sysfs mode. */ struct tmc_drvdata { struct clk *atclk; @@ -290,6 +291,20 @@ struct tmc_drvdata { struct tmc_resrv_buf crash_mdata; struct list_head etr_buf_list; struct etr_buf_node *reading_node; + const struct tmc_sysfs_ops *sysfs_ops; +}; + +/** + * struct tmc_sysfs_ops - read operations for TMC and its helper devices + * @read_prepare: prepare operation. + * @read_unprepare: unprepare operation. + * @get_trace_data: read operation. + */ +struct tmc_sysfs_ops { + int (*read_prepare)(struct tmc_drvdata *drvdata); + int (*read_unprepare)(struct tmc_drvdata *drvdata); + ssize_t (*get_trace_data)(struct tmc_drvdata *drvdata, loff_t pos, + size_t len, char **bufpp); }; =20 struct etr_buf_operations { --=20 2.34.1