From nobody Sun Feb 8 19:25:39 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0B6C1DEFE7 for ; Tue, 3 Feb 2026 05:51:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770097921; cv=none; b=IuPd07aQS6hS50Gjh3a/8uKVVeodOJDgulccK1St7A/WoYtMMP1CVjxolNbVCw5VPE7rw7Yp4OQRQxZ4XBDQ4vUbN+w4SCib3XAW4sJZieX/t5MwVMLk3+KN2hYrdBxU6yk0JY1QAiyBOzpM5qv+1+B83AChdFWPdFDszhitTIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770097921; c=relaxed/simple; bh=iOBlKE7wcNNqdQg697EHs/307n7EmzHjJxd5G5rMLIU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I94rl67EE1jcbHwfB2ctV4np+bMyxKM1/Rk7TTY1MvfwqPsvNmEtcytHijXGqo55DBQFpfiBudhX1eEACRsMfgIVQQogVdpbeltzEEJ8+mfx68JyvjDxlWpm/w1YQ+Gp8HB44fBSbC/AxbubGw5e57bRC2jQn71VzOO1EqaLu8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P2nCuFX7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NeCsMmMy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P2nCuFX7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NeCsMmMy" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61344uD62998767 for ; Tue, 3 Feb 2026 05:51:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4Jay9EfBX3UpMTwsvQnGvQgNS5FLBeKOwQWuoZ1I2KI=; b=P2nCuFX7safyPSt4 md3wzsabmXuDGIOuzhF+VIlU4aQol5XzPLFz9VR5mgZb2tF0EqW7wBeKb05L/Mk2 Twuu2UKx1g1XmLKBX+k4u+zKSiaPyEBrL1Z16MnPCEEPTpeU4k4NDluH5bVO5pvu Ylr4gZahpdoCJopOnL4MIiUznzvkhrB3WtBXUzpvu1l7TkfRJkOHSP35dDuamwnF btTQgB5uFIayj6PqjKtF6bPCzDHogxhSdcP5GZD8vsEvJMWCirIq2Bo9praryObV lI0uRINWiVAGIrpk8OCIFBZTVzagFGHbN1fMZjK7mBNS4WtGIy+LOKNtMxEFHMQI pTi6Tg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2v0massh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 05:51:58 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a75ed2f89dso46168955ad.1 for ; Mon, 02 Feb 2026 21:51:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770097918; x=1770702718; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4Jay9EfBX3UpMTwsvQnGvQgNS5FLBeKOwQWuoZ1I2KI=; b=NeCsMmMyIIHEvMeRIy02FsaZliS84DApvj+lh6qB07mh38+KYCSxYp948UPkEoa3Z0 uqdPDStUeXJew1eUxmt06TKWj+YWsJlKKNCbNJTM8JhPWSy4KeavaMBEvq/Y/mjG1oW0 R2TO/APJ49Fxsn9j/nnXKgxveNwUBPW2APyNqEzMhYA99Bg1p37732NW3hUPJW7TGtkU kRkklT+J4edv7UgU+vkHTUOPOsUBkPClrdIr+W+skjo8QuPALNpEQ4F53bLu+mpkfxRr e8wuMnOESu6TNU2i5iGndMsusmmLWdgEgKjxZqTfCKiNkD4wa+SkY+7S4S2OXH6FWl5J 6BfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770097918; x=1770702718; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4Jay9EfBX3UpMTwsvQnGvQgNS5FLBeKOwQWuoZ1I2KI=; b=WYO23H2C/5mEuuvAZfEAXf3aUWhW0A9tx9pEEhKi7jXELwU4yo/qdUzBnPQlFJc8IH frd12iSHQAkT2uXkAbc26VApeFGce0WBmW9wW53nYDBmaf7QNm0JFky6KRU1Tm+Dav5Y ybBQ9hw4GarKAe0K6RzgKb2hfkKEa/HU3usi7hJQaQRV4xeIJd288iqW0OdIMyDdV3o0 7Y41OSONyAynwhgXKlEKrJkk+tc3p7Lrle+G78D0c76HgVkd0ZZQX+MfdRxoMJ3zTzqx vYhq3ZJAiCJNJwGNcOjVNUxyRumyHY3PIgkmqh6RLNsNTfdV+HdyFBYtozVLfaDXGeiW TlFQ== X-Forwarded-Encrypted: i=1; AJvYcCUa0MSU+wjqz2/qwNOc9dkm4fgfulp1W/VWBBkDu2iQGa3h4+I9/c+yXoBcfb2SR+LpLpuwwPTnNremZ5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxZ9TyibMcF5cQEeVXeCep2n8Vy1Nk9n7IJNoStULGRPCyRiDLh vNbf9neya33Cl03uM00a1FFYax3CBD9nzIflkoNy4aT1Mw2TJvUJGN0+SCPVVdnrAOKM/iOxlw2 FZ1xSLDCqtmQatfyrIxIkYPNw6ODZ4ANHQF+wk4Jx1Tv5B1wMRaytUwD6FosjKXsGojA= X-Gm-Gg: AZuq6aJSwiwyPX26L2tbgKabZXaGxCWb+4qpQs6hvVqQYfoBQfxQD6fpbdR0a1TagGs o1KABin/UZnaVf4aBmdQ5/RBOI/wDHwk/JwSc1WYRVRoWKjyufadwbAgoFy4/YRKX+yWFDx9KDK AsNUFb/Hw3s4y62N1Lmymh0tF1MF/W+AWiIbzXPqO5qg21LlKXfA07Vsli2vxkNLUyXy6Yjd5Xf hICmLWd9J4WPASokEwiUsFZOHndyEcUpD4oJLeBsAbjbti+Ot3ABjA+gWlSphy3Xe2TgiUgJ6rR FsIOaeBJbm3sb1C02Q7MgpnBhdK2ouZ9cS3yZ22Zw1vM1AaBhLL+tEXSCAgHLlVaoOZTVPfIsay dZWpC0n32MHA7jNt9fvV7IeBZZpTWcm0uYA8Y6hTDqcK5BedoTtdLCmwDyMMacr1SE7MEoF8o X-Received: by 2002:a17:903:41c2:b0:29f:3042:407f with SMTP id d9443c01a7336-2a8d96a521cmr137241365ad.21.1770097917912; Mon, 02 Feb 2026 21:51:57 -0800 (PST) X-Received: by 2002:a17:903:41c2:b0:29f:3042:407f with SMTP id d9443c01a7336-2a8d96a521cmr137241115ad.21.1770097917398; Mon, 02 Feb 2026 21:51:57 -0800 (PST) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b6e4189sm157424735ad.83.2026.02.02.21.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 21:51:57 -0800 (PST) From: Jie Gan Date: Tue, 03 Feb 2026 13:51:18 +0800 Subject: [PATCH v12 2/8] coresight: tmc: add create/clean functions for etr_buf_list Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260203-enable-byte-cntr-for-ctcu-v12-2-7bf81b86b70e@oss.qualcomm.com> References: <20260203-enable-byte-cntr-for-ctcu-v12-0-7bf81b86b70e@oss.qualcomm.com> In-Reply-To: <20260203-enable-byte-cntr-for-ctcu-v12-0-7bf81b86b70e@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770097896; l=6192; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=iOBlKE7wcNNqdQg697EHs/307n7EmzHjJxd5G5rMLIU=; b=VqcnM4vNbyRGQwAS7LjKD/ijBNX9/5TItxTwYFrPQTUdNQ8N938fH6Incwj8y6Zf3Ls5c9MmF ihumcsv1vgPCwdqoLuvnKUdD2LhamMVlLN8dukCCpdJdg7i699WMtMU X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Authority-Analysis: v=2.4 cv=dceNHHXe c=1 sm=1 tr=0 ts=69818cff cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=AScg1gZdVb1XvqdcXssA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: 32PONw-Eodu6TkQWw-AWsZ-17jFaJmWi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA0NCBTYWx0ZWRfXy+Sh8tqpn1z8 a6xH17Re2xcqGqz+2FsC5ceE+cUEl/I7qQhEZaPok7oQK1fQjX26hsqAnnj7L3bN2rEWcHCrFOB 7VLd/my0OIWL+gB+K7MRLgOxe2CIxR44MOqFdm6Ka3wjlsKIESM49kc3vDGqFTU/2ReO5rYbr4u AUI1IAWH5UDMcNQ4Kqehmmh+HQzl9i8PWkO1ft+7DglQ7wBlnU11rlS50Xi49gqjhn8bMTTNupX UPnvpjjwEnpwD2/SamFYGIX5JT10WTqGBfLiYzgReKTciDSi4tNj6jUaV1NpjaYifi6LYakXRUR ShceDeuzAdwKGKOAI1O6tt8LPNpLD4RS1xgmoivte8FyUCL7ShO2/bMOZMVCBHGfqakY48oR7IA w8WevF7EWkJ10bUffTF1MXb+Mrjfiz4gNDkxTogUGnW+Dg2AasGO+M5ru+2G+gSHTHpftZKeQNE 5C8n97Eqm1UBdpTaBtg== X-Proofpoint-ORIG-GUID: 32PONw-Eodu6TkQWw-AWsZ-17jFaJmWi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_01,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030044 Introduce functions for creating and inserting or removing the etr_buf_node to/from the etr_buf_list. The byte-cntr functionality requires two etr_buf to receive trace data. The active etr_buf collects the trace data from source device, while the byte-cntr reading function accesses the deactivated etr_buf after is has been filled and synced, transferring data to the userspace. Reviewed-by: Mike Leach Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tmc-core.c | 1 + drivers/hwtracing/coresight/coresight-tmc-etr.c | 94 ++++++++++++++++++++= ++++ drivers/hwtracing/coresight/coresight-tmc.h | 19 +++++ 3 files changed, 114 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index 36599c431be6..1ea255ffa67c 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -840,6 +840,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) idr_init(&drvdata->idr); mutex_init(&drvdata->idr_mutex); dev_list =3D &etr_devs; + INIT_LIST_HEAD(&drvdata->etr_buf_list); break; case TMC_CONFIG_TYPE_ETF: desc.groups =3D coresight_etf_groups; diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtr= acing/coresight/coresight-tmc-etr.c index e0d83ee01b77..cbbb15648fb7 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -1919,6 +1919,100 @@ const struct coresight_ops tmc_etr_cs_ops =3D { .panic_ops =3D &tmc_etr_sync_ops, }; =20 +/** + * tmc_clean_etr_buf_list - clean the etr_buf_list. + * @drvdata: driver data of the TMC device. + * + * Remove the allocated node from the list and free the extra buffer. + */ +void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata) +{ + struct etr_buf_node *nd, *next; + + list_for_each_entry_safe(nd, next, &drvdata->etr_buf_list, node) { + if (nd->sysfs_buf =3D=3D drvdata->sysfs_buf) { + if (coresight_get_mode(drvdata->csdev) =3D=3D CS_MODE_DISABLED) { + drvdata->sysfs_buf =3D NULL; + tmc_free_etr_buf(nd->sysfs_buf); + nd->sysfs_buf =3D NULL; + } + list_del(&nd->node); + kfree(nd); + } else { + /* Free allocated buffers which are not utilized by ETR */ + list_del(&nd->node); + tmc_free_etr_buf(nd->sysfs_buf); + nd->sysfs_buf =3D NULL; + kfree(nd); + } + } +} +EXPORT_SYMBOL_GPL(tmc_clean_etr_buf_list); + +/** + * tmc_create_etr_buf_list - create a list to manage the etr_buf_node. + * @drvdata: driver data of the TMC device. + * @num_nodes: number of nodes want to create with the list. + * + * Return 0 upon success and return the error number if fail. + */ +int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes) +{ + struct etr_buf_node *new_node; + struct etr_buf *sysfs_buf; + int i =3D 0, ret =3D 0; + + /* We dont need a list if there is only one node */ + if (num_nodes < 2) + return -EINVAL; + + /* We expect that sysfs_buf in drvdata has already been allocated. */ + if (drvdata->sysfs_buf) { + /* Directly insert the allocated sysfs_buf into the list first */ + new_node =3D kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL); + if (IS_ERR(new_node)) + return PTR_ERR(new_node); + + new_node->sysfs_buf =3D drvdata->sysfs_buf; + new_node->is_free =3D false; + list_add(&new_node->node, &drvdata->etr_buf_list); + i++; + } + + while (i < num_nodes) { + new_node =3D kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL); + if (IS_ERR(new_node)) { + ret =3D PTR_ERR(new_node); + break; + } + + sysfs_buf =3D tmc_alloc_etr_buf(drvdata, drvdata->size, 0, cpu_to_node(0= ), NULL); + if (IS_ERR(sysfs_buf)) { + kfree(new_node); + ret =3D PTR_ERR(sysfs_buf); + break; + } + + /* We dont have a available sysfs_buf in drvdata, setup one */ + if (!drvdata->sysfs_buf) { + drvdata->sysfs_buf =3D sysfs_buf; + new_node->is_free =3D false; + } else + new_node->is_free =3D true; + + new_node->sysfs_buf =3D sysfs_buf; + list_add(&new_node->node, &drvdata->etr_buf_list); + i++; + } + + /* Clean the list if there is an error */ + if (ret) + tmc_clean_etr_buf_list(drvdata); + + return ret; +} +EXPORT_SYMBOL_GPL(tmc_create_etr_buf_list); + int tmc_read_prepare_etr(struct tmc_drvdata *drvdata) { int ret =3D 0; diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index 95473d131032..9b3c4e6f0a5e 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -208,6 +208,19 @@ struct tmc_resrv_buf { s64 len; }; =20 +/** + * @sysfs_buf: Allocated sysfs_buf. + * @is_free: Indicates whether the buffer is free to choose. + * @pos: Position of the buffer. + * @node: Node in etr_buf_list. + */ +struct etr_buf_node { + struct etr_buf *sysfs_buf; + bool is_free; + loff_t pos; + struct list_head node; +}; + /** * struct tmc_drvdata - specifics associated to an TMC component * @atclk: optional clock for the core parts of the TMC. @@ -243,6 +256,8 @@ struct tmc_resrv_buf { * (after crash) by default. * @crash_mdata: Reserved memory for storing tmc crash metadata. * Used by ETR/ETF. + * @etr_buf_list: List that is used to manage allocated etr_buf. + * @reading_node: Available buffer_node for byte-cntr reading. */ struct tmc_drvdata { struct clk *atclk; @@ -273,6 +288,8 @@ struct tmc_drvdata { struct etr_buf *perf_buf; struct tmc_resrv_buf resrv_buf; struct tmc_resrv_buf crash_mdata; + struct list_head etr_buf_list; + struct etr_buf_node *reading_node; }; =20 struct etr_buf_operations { @@ -445,5 +462,7 @@ struct etr_buf *tmc_etr_get_buffer(struct coresight_dev= ice *csdev, enum cs_mode mode, struct coresight_path *path); extern const struct attribute_group coresight_etr_group; +void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata); +int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes); =20 #endif --=20 2.34.1