From nobody Sat Feb 7 18:28:52 2026 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1EA72F290E for ; Mon, 2 Feb 2026 20:54:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770065695; cv=none; b=eHUIYfSsnhcPb1YaOn9ThxMb8qVEErth2uA2J6NtVBWPZkLx3QNj2jeY7G0zzhNPZKDP96hBlsNf5MwmawqlCtevSzzZb2yoQZN55EXZ9BEq00azr5XGa+oFQ3x4SumtGzB0QHlXeTyeIU/fKnAhWS7n5TlsaQomPrhe07W/OK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770065695; c=relaxed/simple; bh=xbzYJNxSCFjkiffSM6jyIjz1IvRu/q+sVuB3QG1dkqM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RI/DTxKXi6MAfXqOOq6zp1DzqFp6oNuZLJsyP6L1b7eHE6Ez3Phs/p3pczCKA/vvplE0aCTuzgFt2NE36nA4kF0ktrsh2DItK8QoypC9ZcNrJ/YALcrq/rkachRjmR7J6MSnTc5oJq8TaR30qOmVHc6Hf8gNzdbOAMaABrEI9L8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Npi9lyhQ; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Npi9lyhQ" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-79492a2a57bso48772677b3.2 for ; Mon, 02 Feb 2026 12:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770065693; x=1770670493; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1iTIQduAX8adZigUW+P0nUWVGs+OtfVrnk6DuA8/cXI=; b=Npi9lyhQj185gn+HBA/vW3MF6j5rEKWWuHNnJ5qcKy8svTcMr39WAsHFxvDtKNsnc5 LzSiB51D3y/9XXWTdowdv4lIv6O/rmzrbaLR68hqtQzmGCR6fflKB7nU6S9G6AVGNvx7 mUHP7esEMvnroKA7tu9/duT/BYoiCdgFcL2R+o9eI2C6pImF5Dwg/vwWSn/V2tAwux0O z8hutgVSa+fHkrOlen0Z7jKOdMPv5N7YZRa/7JwQVpMDtvfVs58lJ1z/X7PbdtglxsmD oZBjg+ZtLx+nBN8lxZtsBGlxGQcALno9rA2ulbsMrLfRk0H4kS3itcSNBduLg6Cstwee lGGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770065693; x=1770670493; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1iTIQduAX8adZigUW+P0nUWVGs+OtfVrnk6DuA8/cXI=; b=BZmHgARdmDulRtTxZe9rfoZDwfPhLm8pGtS7aj/HWTLfDjWbKmyEEK+L7XZMArZeio l7kECASnDaABFZe01Iii/T3tRJMDHAMiRZPth6Mb0jbmBFwvjGfITdGKdp0S8E5GqPNt smVUsEEgCjSugbmTQKgli1zMdEa31Gw5DK9RKrFyQBJuGMyYiRkyGsy9/pSli25E3rfF 73PeEmmC0FwImSQmxcKGr1h4uu6OAoQaTTO4EwR+8pVqzAnlVzM1YZS26bDm4bWG0WnH yYLG5bKNOGdxbR2EDB5sD2nbhLTrt3/vM1Hg55pdtzbAtEQvT0IfBCH1XuMyotF3hOOv JeZw== X-Forwarded-Encrypted: i=1; AJvYcCUS79ZFJvU9n08M6pLW5llfU/k3m2OLKBEEd9xcVdGrpuVfNPIRWbiFO+J9R4DwL9Ez5mkxAUboBucxxX0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr5zNLbJJNLiVuKF6yOf0trSHpfmUrId2+OnK8xsH9DFrPIwOr Piuwv43PxDQxaZqVyD67Nze4fppQfGbDtOWnQ3gGjlf4U3jqRI6JD4D+ X-Gm-Gg: AZuq6aKQTvn15Zo8H0mR94njgYNTjocEEhOU8d1Gd0MtL5sKiakPQhIb5ED2QFcxO5l T101djl3rr/OlKH71mYF0hDV/chVzCezlmBjQfhIkdLuV/h3YXgYfzFBSmoFoeLVl0M96h//U1u oHw+NntRW4ACR0vqMty99KVKSYecH6Wswnsn3j32m0nadOeUdrkuTnKH21UpXHYLhxXP/473IUT XtzeGpFkqwxUVKaoshxMXCh28CnRQat/ktlQGZBa0fsh4ExnvBRc4e1YrIPk06/kyL6sgsgCg+T 0fkDbMQZdAE1vVt/8HqdwlUbJpb+8a2i3Gvimg+2kvG4KZ5Njqh2/ZSM5gaH+ONs2RvfutCHlUI nou8/XyIEcmhjSQKWIqfmAFDMK0aXHwiz3HorRwLS4kGMXKdukay/1xVWAD7tQ3LSMuFi7Sq2xE 5UbXfvJT3gBtRP2dojraYb3zw= X-Received: by 2002:a05:690c:dc7:b0:78c:2916:3ef5 with SMTP id 00721157ae682-7949de63e70mr120040087b3.8.1770065692890; Mon, 02 Feb 2026 12:54:52 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-794b2468901sm55977777b3.22.2026.02.02.12.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 12:54:52 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org, straube.linux@gmail.com Cc: dan.carpenter@linaro.org, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore , stable@vger.kernel.org Subject: [PATCH v2] staging: rtl8723bs: fix null dereference in find_network Date: Mon, 2 Feb 2026 14:54:29 -0600 Message-ID: <20260202205429.20181-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable pwlan has the possibility of being NULL when passed into=20 rtw_free_network_nolock() which would later dereference the variable. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Ethan Tidmore --- v2: - Included more context to demonstrate possible null dereference. drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 8e1e1c97f0c4..e734d35c11a9 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -828,22 +828,24 @@ static void rtw_reset_rx_info(struct debug_priv *pdbg= priv) pdbgpriv->dbg_rx_ampdu_window_shift_cnt =3D 0; } =20 static void find_network(struct adapter *adapter) { struct wlan_network *pwlan =3D NULL; struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; struct wlan_network *tgt_network =3D &pmlmepriv->cur_network; =20 pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->networ= k.mac_address); - if (pwlan) - pwlan->fixed =3D false; + if (!pwlan) + return; + + pwlan->fixed =3D false; =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) && (adapter->stapriv.asoc_sta_count =3D=3D 1)) rtw_free_network_nolock(adapter, pwlan); } =20 /* rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock */ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_qu= eue) { struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; --=20 2.52.0