From nobody Mon Feb 9 20:10:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D6A638BF78 for ; Mon, 2 Feb 2026 18:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770055817; cv=none; b=bOfsO6kFyAXG+aTk+QQENGTKMJqt7gju2DyTCgqALcrXdjThR0XWiyg+ntrlnl/6WZqSuva2M2AabsLyq1rLKw1FSqBD//QYY4902uJTEFWYrdqpANNXSbOQKBf/K8uBqPbp20VirO2fdrPFw5k066SlgvkAnmqA7Oli78UP9fc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770055817; c=relaxed/simple; bh=J7umZZmSfRhKY3LLRN7ouVyVhZ3rw+sE94EggIM4Izg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Yt0A712OcYjsNyseBXotP317wK9zWlyeKMV12X+FaJcp4CTMUCldlpxTTtzASK9TqYwX15Wtmy0oVGceUmwmWU7AUkfKZ5yD5DVAjVPuGWs+Q0PN5rm4wUfWWvGFEHeN/GeGTpgPB34vcIhMgTDzZMjVgDNfPNIb4NQi0f689mM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fushtLL9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gfwSNIKL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fushtLL9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gfwSNIKL" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 612Fl5NF3387853 for ; Mon, 2 Feb 2026 18:10:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=dZlesKG7g2O 6ZF9+CCBwLzC2h/ppDaRw7tqwhdo9JsQ=; b=fushtLL9C46ac41xanwgl+JArFM j72b371Xuk34BWR/ztnsNEu5VbbRmbjtSl0BOi1rsmGmyPdFJ5W57uqgE2DLSy+d IcG0xtNGid+84vLhzpMdiMyvJ71hkLWh3cZftZmBCNNmpmiJSQR/EvfEKnfgQPEN 39BFMr+yP50jd3ADbVrWQ6S6+v4XDfLk3xMmD1LWRsOJyhcxg2dKiNzEsk/oZKM2 yor3XzTohEMtlMDZY/4Oh3WYnRgxh2qoqim9ub6qJyeoEQdCq34ycaA2e1jdj7K5 osFAZ6qJqFO+ly5xUdjTIDHg1hcDhsSp5wiZdP/Q9FgqzkDwGym2uSA09Kw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2xvbrfya-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 18:10:15 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-822426d844aso9670b3a.0 for ; Mon, 02 Feb 2026 10:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770055814; x=1770660614; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dZlesKG7g2O6ZF9+CCBwLzC2h/ppDaRw7tqwhdo9JsQ=; b=gfwSNIKLI8sa54EPy0B6V7XhdBF8BjqgACPTVEglBCA1m14cfxrk9CAAlGPtkPfEqC kuIc4zyZh4LJsIjGMcH3uvEQFfBhtezpvovUM89F+QhgzdWxFqx7b52XWbYRW/xP0wVb tHS/D1Jb3UaVJc0RVxipi+C8DlyhR8LrOSfk0DCMfTj4IrQQNbhxtFSO7GtF7KhFPHpC sYB9BExjO3G9eXn8Hg99/eRcrvXeT4kyOCQqJLs8G7hJqr8hbuURddZ0eQ4xgvZ++nPg 1vxR0aNN1ffamfObCoLY4POMVuQm3OBAZ7MthOz+9l+jlwA8VfjNYuqmcuQj9z7Tuwf9 Bdog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770055814; x=1770660614; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dZlesKG7g2O6ZF9+CCBwLzC2h/ppDaRw7tqwhdo9JsQ=; b=P3w5bR3fjHUCStRwyyPVnm+La9yWHipdg5ux2P9qWOgW6Hv9SWDUo3kLKJI72P5Om3 AD7LXkfSLTuUxEki1CuSLNkKMp+5+ScUVAGM14gGbquLrrcdXR9lG+9Lm2/ies2U4/l/ MGmgm1LuUMi0JSPyQZkq7DPZHHxU0XcSVEAYVHB9J5c7Bc9sg6QikchTS4HTnqcj71jL jGxn+G4CeabsoqRaWQZzUcdCEZw8y5fBn0lvZni9q9jzo5RpPSanteFMyZQhVs0GiECT ceDwyEam1OxSkbbjeotq5PwslaR3fkjdZfNkT0Z9yE9oQBq31RUuSM5o52HqsnWzh8bB Bq+g== X-Forwarded-Encrypted: i=1; AJvYcCX3L8ik0LoZCvqa88WFcd0dMlORlyAAl0aPWtdD4jXIyeE/tFwIDz4QrNjyZDzNmhy/oMcqhXaljb249Ts=@vger.kernel.org X-Gm-Message-State: AOJu0YwzvX38rQOlUgn/eljgNcDPxKkzyikPCoNd20PNmOp9aRMkwPqf hqjY+aQvme2ktlfuz7/kSCQf7yPfaG0wqlGbLUxh0jApcG2mUwl5PwfeydyiQYY1vLa0FXxrS22 KkHqvkn6L6m+SfHIMMl8i5E4BdX2342ulV6M/RDgAk5853fqraFWYmBMmiFYBVxIYBMs= X-Gm-Gg: AZuq6aKtADykAZoNq9lAcDLaGMVRVK3GMgmfH4DBhLfigfzE2jDSGvCYle/V/W7vhVI bBTP6sjUWAasWfIBxUdf3Yqwi2jTZPDBFUEM98WogOPAP+8PIG+3gfo9tCKDxPWTH18NTEqwj8m 5X2PvEmRROvN8s8xaBU4MPOf+MuJdStoJgjurqzBsKjp1Qw6GZqqcP+S0y0WT1wwy85jtMqYNYr NDdY7B3x4cCX+A0ZSwlbsOGpZuQO69XiJBEoDqF8dqy30lLeWJAMiEEfcJd60OEZoNugzZoC0Z7 2inhOKNv2cXfidUNfPKYDr2lHVZazeXkNyDuD12uCHBCicpyxwXSLvpNYR4RGCbDj1DRCVikiqY so66eGB1aHMOo0Sboc3t+4KHi7rc9RH0XgN2nwTx19Ls= X-Received: by 2002:a05:6a00:3cd6:b0:81f:4e1c:1d3b with SMTP id d2e1a72fcca58-824042c6213mr237441b3a.23.1770055814200; Mon, 02 Feb 2026 10:10:14 -0800 (PST) X-Received: by 2002:a05:6a00:3cd6:b0:81f:4e1c:1d3b with SMTP id d2e1a72fcca58-824042c6213mr237412b3a.23.1770055813643; Mon, 02 Feb 2026 10:10:13 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379bfc712sm17476780b3a.40.2026.02.02.10.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 10:10:13 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com Subject: [PATCH v4 05/13] soc: qcom: geni-se: Add resources activation/deactivation helpers Date: Mon, 2 Feb 2026 23:39:14 +0530 Message-Id: <20260202180922.1692428-6-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: jPlKfDVI2HWgm4vYURz2AnXQZKDVLfIp X-Proofpoint-ORIG-GUID: jPlKfDVI2HWgm4vYURz2AnXQZKDVLfIp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDE0MiBTYWx0ZWRfX7v+HcuG6g1iR 1N95uV9vkPLPy+6MpRH56BCQzea8g/2Y0GuZ47sWa5fHM2lV/AK9hZ6x1r/Ci0U+mVzIIovr8dg T8QDC3PBiRAaDCPGnhILYnruvcv+HPe+WqaH9lOQ+5T57I/Xz30CobvytzjmEUNKcwrmatjWLv/ 0JHiExRkC2mvQ7HQl72JVOGcRzCVWBc204hbby2yEBB0ttX5zR/2L+ubX4NqkkCg4TuW3hCemBn rqLum9DIOaV0lQsphbicKvWtmolLMyj9dnBakrWgMNxwmQBgZIBO40aAcN4YC/VARpfs4QPDp+c Ihb8WCD5BTZoUHOFIZxuBZuD72kWH0Vhd3lgNZOfBHQGuBx/XGUYpTteKXJu+6GqP/ZAJTEdgDL SpbEW26iWGRI2UO6iHSGmt6Um39y6cprmUHhmdyV41tc9A6Z3OzMLlF8OdRQszWFbZze1FvfFld MiwiPUocmelKVcXiBpw== X-Authority-Analysis: v=2.4 cv=AurjHe9P c=1 sm=1 tr=0 ts=6980e887 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KBRiQYpxJDLEvAb9SdYA:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_05,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020142 Content-Type: text/plain; charset="utf-8" The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource activation/deactivation sequences independently, leading to code duplication. Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to power on/off resources.The activate function enables ICC, clocks, and TLMM whereas the deactivate function disables resources in reverse order including OPP rate reset, clocks, ICC and TLMM. Signed-off-by: Praveen Talari --- v3 -> v4 Konrad - Removed core clk. v2 -> v3 - Added export symbol for new APIs. v1 -> v2 Bjorn - Updated commit message based code changes. - Removed geni_se_resource_state() API. - Utilized code snippet from geni_se_resources_off() --- drivers/soc/qcom/qcom-geni-se.c | 67 ++++++++++++++++++++++++++++++++ include/linux/soc/qcom/geni-se.h | 4 ++ 2 files changed, 71 insertions(+) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 2e41595ff912..17ab5bbeb621 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -1025,6 +1025,73 @@ int geni_icc_disable(struct geni_se *se) } EXPORT_SYMBOL_GPL(geni_icc_disable); =20 +/** + * geni_se_resources_deactivate() - Deactivate GENI SE device resources + * @se: Pointer to the geni_se structure + * + * Deactivates device resources for power saving: OPP rate to 0, pin contr= ol + * to sleep state, turns off clocks, and disables interconnect. Skips ACPI= devices. + * + * Return: 0 on success, negative error code on failure + */ +int geni_se_resources_deactivate(struct geni_se *se) +{ + int ret; + + if (has_acpi_companion(se->dev)) + return 0; + + if (se->has_opp) + dev_pm_opp_set_rate(se->dev, 0); + + ret =3D pinctrl_pm_select_sleep_state(se->dev); + if (ret) + return ret; + + geni_se_clks_off(se); + + return geni_icc_disable(se); +} +EXPORT_SYMBOL_GPL(geni_se_resources_deactivate); + +/** + * geni_se_resources_activate() - Activate GENI SE device resources + * @se: Pointer to the geni_se structure + * + * Activates device resources for operation: enables interconnect, prepare= s clocks, + * and sets pin control to default state. Includes error cleanup. Skips AC= PI devices. + * + * Return: 0 on success, negative error code on failure + */ +int geni_se_resources_activate(struct geni_se *se) +{ + int ret; + + if (has_acpi_companion(se->dev)) + return 0; + + ret =3D geni_icc_enable(se); + if (ret) + return ret; + + ret =3D geni_se_clks_on(se); + if (ret) + goto out_icc_disable; + + ret =3D pinctrl_pm_select_default_state(se->dev); + if (ret) { + geni_se_clks_off(se); + goto out_icc_disable; + } + + return ret; + +out_icc_disable: + geni_icc_disable(se); + return ret; +} +EXPORT_SYMBOL_GPL(geni_se_resources_activate); + /** * geni_se_resources_init() - Initialize resources for a GENI SE device. * @se: Pointer to the geni_se structure representing the GENI SE device. diff --git a/include/linux/soc/qcom/geni-se.h b/include/linux/soc/qcom/geni= -se.h index c182dd0f0bde..36a68149345c 100644 --- a/include/linux/soc/qcom/geni-se.h +++ b/include/linux/soc/qcom/geni-se.h @@ -541,6 +541,10 @@ int geni_icc_disable(struct geni_se *se); =20 int geni_se_resources_init(struct geni_se *se); =20 +int geni_se_resources_activate(struct geni_se *se); + +int geni_se_resources_deactivate(struct geni_se *se); + int geni_load_se_firmware(struct geni_se *se, enum geni_se_protocol_type p= rotocol); #endif #endif --=20 2.34.1