From nobody Mon Feb 9 20:59:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 858E738BF85 for ; Mon, 2 Feb 2026 18:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770055810; cv=none; b=UGUbrrF/gqW3C8vOFYoWJq6uKYQjsIUVjqL4rEs947KI7YLgR5ATiIXG8abAAI4mdYFJQA3hnI7A3c/7E3M6h1vqMOwpxhc3LmkANq2FCixVLZ6rlUj8N6RYlxo84ABNg0lXMbNe5dMx3Kdt8fm0QWOduB8sLH+yoXytSpwCqRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770055810; c=relaxed/simple; bh=jI29xu22h/aOLZUcJch+Uw8kf8cbeFFY9Pk+gWe9Kig=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F4SveaSnWDb9ls//vtJorIoctDmsFxtr2qOJxEFM1Ee5t7GiwNJCC8JSjnBrRT9SwXH14YteAocEzM7HESScEdJU3Bfdc189eZQiQz7+MENUUYeiz4WabbjdB4Ut14ssQCl5qYZzGxE6w77YKwwpNDbyqEIsxMCNbkeNhqVW+/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AFGdS8eP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gtD/ALvP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AFGdS8eP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gtD/ALvP" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 612FlDFw3388084 for ; Mon, 2 Feb 2026 18:10:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=qe3vIqAk4Km 3Plesr4c+NFgSaiZDJPqNZPQYZwG4wuw=; b=AFGdS8eP37rD+sXQSFDnIkiieoI RGO9hMpu2rX1VsUB8eV5JtfkZ3ABWzot3jB35bcHWyhb2W/XpI3M4IOLr3vmrljk TnEbRmJXqK0G+ZU2VX4cssocaOSpasKbm0XBgHZydqjSglxjY6ikJPK6nC6NHAV8 1aHji5BXQOMbpTjSfiJqtKbgaJzd9npec/zY36mtzAE3ngTMJFa25FH1UUssk3Ru PYeDFU9Dsg/Emwq4VQ1zWn2f6Qftuk1luokMimIDiII60MlOa7g5P7unVDa/igUO 3dT7ycHKMIOMDYr/abTQZ2FUHUoOsCtu7WQTHBedTR9/CJcjZAJ7yr9AExw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2xvbrfxw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 18:10:08 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-822426d21a8so8696233b3a.3 for ; Mon, 02 Feb 2026 10:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770055807; x=1770660607; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qe3vIqAk4Km3Plesr4c+NFgSaiZDJPqNZPQYZwG4wuw=; b=gtD/ALvPdVVyFOIW5s8VWjijwxxNRXW6hta0oJi5+bBoSYcQiCLRwnzkm/OUsPHq9E VFZtiS90Tl3pmy3V6rabbYwJ53eivVy/PH0oQ1QYD61DTKJk0bsXZ/dcHd17AZtFjile nvUn3s7Strdo9aoHuzDOlB1XPKCYTrQIbj2WKaupiVtKbmh9VBk2b5qE836rFuWJiljF vOU6SYB96Aa1EqA5AWL+qUb93PuiHS73Si3qsEhvS4T6dmyuhfsae2q3+bmr1C34mRXb gxcApizvhQxHg4nd0e4kt3oZN5YhW640wpaPhpAHY3+1Qv7UB2MatmBRDSYCsQjyf8ng 2Dtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770055807; x=1770660607; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qe3vIqAk4Km3Plesr4c+NFgSaiZDJPqNZPQYZwG4wuw=; b=jGHYmnY1uqM6ks3v59/b36+hu1VEf4mEQf6EVx4TpW5BhEXvCVM9N6sLL1QJUtP63d WpIbIkU0i5K5/jn/95zw6bgaTzqe8Z14nHqq1yBRutbYLEwTOUhAivn7FmoK+ootlODB Lgdsotqq6yd12W6DARkrcVFCc21lOtjkndjUDJctyPLIcFAusoq05tyGDMEBWWDPqEpj NPivTuVEyYvOwah1YkK/s00EakO3g3yTVXyYUWSEEbz7NumLWRPNIKlHkrbTA6ooWxqI Bd9HUI8uHaQi1u9IFNxUGmdXh6IRSRYJQ6JQHW53pBu/1KXfFSnqSI8PEQXBVW4TbUGU YKZQ== X-Forwarded-Encrypted: i=1; AJvYcCUIbO6O/2XjI1822Z828iJiZZdwcdn9bcns3Bv96t7rxF8x1fUFVKWlqFso18hvFr4p+FFMRBAGWrLpxKg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl4Atr9sMRmPzMM9cXByUlPljswsrs7VYHQQ5W7/7l4geUSR8/ 3fTp/Q+nDPl79T1heq41kBDoXyTtha1aAr3LCURqyZPwL5knmdThCjkN4QgUOBFsNH+qv6hD9cP kbyptJS0yVt5Ltwz2ntvey/f53lYnSKzj71sM2lNjl7NV4i5Z86lB6R0kMr4Y6dMknvM= X-Gm-Gg: AZuq6aJeDcmngAlay6SK57qo2ZMG+RxJMY2SRkIOQDNXeCdGyoDt9kHdPik+/tWjTjj SywgjDjLv2Wf67U/bKJipRGgBb/xuaO4u2V1esOelFuRsSX77IqHCQQ1Pg9JYAcmAo2mW8NIR88 HOL5CIjwlaVzcX4RDmTwqnH+ZBPFu2LKRHs6wI11lly2lUVrScC5NeskovQKZFspEIIBqrURGwd iqAovbwQe/KLo2oQEwSV+yyHKb8K/P6kzgqFDVll2vmvEUGVgeqL/bZ1GVh9XlB3tnrQwl0vnUM o+kDxfadQAVBB5lLMUV4qwN/6I+dW8G1qjU4r+iLOVWfHWn0z4tj9g3SdndqSA9qkoJGmNpZbXh GafReiZDb8fcl5kMIJQNbJm3enAs42WYDL8NzFSr4k8E= X-Received: by 2002:a05:6a00:2ea3:b0:823:1212:8e87 with SMTP id d2e1a72fcca58-823ab748a2amr10756612b3a.32.1770055807142; Mon, 02 Feb 2026 10:10:07 -0800 (PST) X-Received: by 2002:a05:6a00:2ea3:b0:823:1212:8e87 with SMTP id d2e1a72fcca58-823ab748a2amr10756572b3a.32.1770055806518; Mon, 02 Feb 2026 10:10:06 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379bfc712sm17476780b3a.40.2026.02.02.10.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 10:10:06 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com Subject: [PATCH v4 04/13] soc: qcom: geni-se: Handle core clk in geni_se_clks_off() and geni_se_clks_on() Date: Mon, 2 Feb 2026 23:39:13 +0530 Message-Id: <20260202180922.1692428-5-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 0jP-s8_nI8Ge44XODHm79xzqDsdBUC5f X-Proofpoint-ORIG-GUID: 0jP-s8_nI8Ge44XODHm79xzqDsdBUC5f X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDE0MiBTYWx0ZWRfXyZ1107owfaak CAajfAPPBx+lUSoOdvzHF/OI4AfbJypjB9X5av79CYi5hgA2IdNIRKOZ5E7qel0esF1rdVQQO2P m88SQwpJGTCktp09w1NZLSFPi7xDNNpzVG8OUbwZX6jXWnComDcnNsqE+DtXGltfiotDCdaa5u2 Map4oj97ruCa5UQKBe8DF7WfWvvmazYk0WLBHi/6Mi1NbNXGrRG7YLJXQwd8nN76YqrXruk5Bxn c/it36kmLu/AMIpvQkQ+oCqgFDjln6so+GQwkQeu7oDyRu6rqEK1X1WFoojPeEkj76YObRR+gnC RvtL4iY3RcsFtNCBRrbL1tW4Vl4BmI+Pqe1153mDIjxb3lo4Y1YuTFfyBkDmJLYoQqHcPjr3oRo CIZwpXo4McgVe+/zay49tYq5v/JnX/9ijoCQvX66NMuZ54SbhE2x/Csl1axoBJbD+bu+HChnzTk aXEy5xxOQcJHDb3BxVA== X-Authority-Analysis: v=2.4 cv=AurjHe9P c=1 sm=1 tr=0 ts=6980e880 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=fzsqq50RfsZR9heXkngA:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_05,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020142 Content-Type: text/plain; charset="utf-8" Currently, core clk is handled individually in protocol drivers like the I2C driver. Move this clock management to the common clock APIs (geni_se_clks_on/off) that are already present in the common GENI SE driver to maintain consistency across all protocol drivers. Core clk is now properly managed alongside the other clocks (se->clk and wrapper clocks) in the fundamental clock control functions, eliminating the need for individual protocol drivers to handle this clock separately. Signed-off-by: Praveen Talari Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/qcom-geni-se.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 75e722cd1a94..2e41595ff912 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -583,6 +583,7 @@ static void geni_se_clks_off(struct geni_se *se) =20 clk_disable_unprepare(se->clk); clk_bulk_disable_unprepare(wrapper->num_clks, wrapper->clks); + clk_disable_unprepare(se->core_clk); } =20 /** @@ -619,7 +620,18 @@ static int geni_se_clks_on(struct geni_se *se) =20 ret =3D clk_prepare_enable(se->clk); if (ret) - clk_bulk_disable_unprepare(wrapper->num_clks, wrapper->clks); + goto err_bulk_clks; + + ret =3D clk_prepare_enable(se->core_clk); + if (ret) + goto err_se_clk; + + return 0; + +err_se_clk: + clk_disable_unprepare(se->clk); +err_bulk_clks: + clk_bulk_disable_unprepare(wrapper->num_clks, wrapper->clks); return ret; } =20 --=20 2.34.1