From nobody Tue Feb 10 16:18:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 458252798ED for ; Mon, 2 Feb 2026 18:10:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770055803; cv=none; b=YIQp/nfq8NaNv6Ss4FXfl/i8mruNsH2t0A3Z/d/1FcWH0Z2Ya9NnuMbgBnDYC+3ucZMx/SUq4eOkvy8lLw5cbINtkmu8soexCyp07o29/nTYe2jhxRSgiIepd9FdSPYZIFAXCga7cxqLsVoNu8jhXWJ2KlIvAy6WtnnGnUcgIQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770055803; c=relaxed/simple; bh=aNFoPhCzK98jZhwkTUn8Ng4tLog3h9ErdlG5j8XEi8I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=P4Wc/pHGPeew8hMUTYB6/kCRyg3s26ARwcqLTkqsJUSsC5iJYvzD9ce/D3Cf+Vc+l35/6udRlKmOjlRuHb5piu5QTwZpr9ltxw9ZcWbH3Q70e8vIpmi8KZm+N3IKkiUdySvkUcfSeknyeoe0VCFAvmxeyUqu1EaIK6a7Ip/6HN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZwfvJWbl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T2FEQIzd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZwfvJWbl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T2FEQIzd" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 612AvuT42262003 for ; Mon, 2 Feb 2026 18:10:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=coMCstee7sz aR5m5p6HnyI6xCasetiM+wXF6qx7XZKc=; b=ZwfvJWbl05rJkF43azl8gEzwJLP wfDisdYRdeRuxJyeTlXFRYRMA9sgZZCbTfdz/GRjy6mr76BRYY20BCG7SNEFmvEL UeitmEOf7hy1SR6NEqTVP56qPUCXDPFXXWj7CsaEZsafo9cxrsgJaHs86y5Ma4N1 gWyaS9fjJRYR6KgDT0G0q3vLOEks1Q6flS4S81SzUo3itoSFbZOFexEF57tqZTM+ wbnokE8bbGHRhEVpeyzaXG8iI0tKonMiLDqds4KowOU56JUdldjduL/oblpWv1V5 qqdzYKhVFVpo8faY053FQnKzuv///PoiwLn2TrdFyt25siaGIJi66g7mu+w== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2tmth98x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 18:10:01 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-81f53036ac9so3876553b3a.3 for ; Mon, 02 Feb 2026 10:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770055800; x=1770660600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=coMCstee7szaR5m5p6HnyI6xCasetiM+wXF6qx7XZKc=; b=T2FEQIzdLiEH3l8VzgjfwcQ62Tgpq6yeA0uacInxKo5cx35s1m3bhy3cb6Djw4jp7k 89cAILX2t9lYcYOi1iljKMjiW3PJ4+7ZS50rszfTr1HUq8BnlNqIRTpfGVMvV8tDbw2V +6v+v5T1oUjmhizliR/qJvBB8p1K4EwOnW5s1x1eaV+dl/0ABgRNLnSzXT63w2OvL8nc sBSvk1NroNAHoWPzG2O6XPsy4pRhudjLqe2FIIr0TNAtsRKdNLBPaWUpfir/ztYV44yy rjk5tlUQ0L98XDLdvP8EyVTz41V46iE/2F2q4VsS9Eob9hzx8is30RUX2hO65drbeX62 ItBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770055800; x=1770660600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=coMCstee7szaR5m5p6HnyI6xCasetiM+wXF6qx7XZKc=; b=KgSQ11p2wtbxLMeB54VHKtf3k5T1mR0ltUgXR4vm9b6Ec61aKOYPCvPOm8NWivLQ5D zaczq7FlITv9rBocdDFw56Fe0WjZ3Xrjsd3PAZp8q52A1WpfMi0Owxrc3nnTEhQj5D2A EUsvdOjlAP3AOsB8d26rqS7trwDWIu1dllaloxkp6CqThM56BmHfMpJVJ44DEMRL2s7I vDl3ldpHuyqGEsAw/1a66Ul4++xloyP1pqcFQzRhdvfekmD2C22ImvQ5J4YJ1H7RKZIP GiemgGgZEvd01sBv/dR9S4OdQKb7MipU2/tvYfCrHTHvxeBIzTeUzDNhPUSn6bBJpoz9 tQYg== X-Forwarded-Encrypted: i=1; AJvYcCWve3i+pLe4+9UOqgnprnuKCUY15Ppv/u0X/2/VJKGys5TXO2F5kPSKyGEPjkk14UNRr1H3Lpkk8JHUvuU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2jbaasq/02LMNMIF8nZ0PoAx6SGo4SmAnHHlBDpLmHk3Rkj1a WxXP+foNs+aipN91Ee67abMWhVjWf7/PiPLXIyQ83Ls20btiCxw7qpoPdMqh5wlJiYARjFTFqWU oJ8epYPKuZLXyl2M1uIERHMv0QIGLIoVmgYe632r705mucRrRrDnnLDoJPlx2lrHvu54= X-Gm-Gg: AZuq6aIoe1mfbpumu3cRze3DhR31dz+782xv93/GbgkEPDZWhlK89q5IkVPguVXElus bEjdtIaro7uOqH0de+kDVFKIJTuXYUhHFLonLFT2u7ToE8bPXagPv9KCp385aEx4nT4C00mfQZ8 gyJHOvDQVoil0rgkvIFrcSYJwVlhnrE6tAZVEzg07vYvcoITSn7MTiAcqXjtMiDsydSh6D8moBl HDIHgTdTJuispkf63BJfMIIWqGqvlybQOnjAhWq4kUwrB4mORD9pwjENsP9+mCwFEj05AoKeZt1 gBExc4sYn98d4lkzYzGPW1Dtsl9GGzC7iuul91HZ5EhNUQGmy06U+z9U0FZXwLPNYQpmJOtIFtN c9/7RMEuIK3fku3nuLLytsV6PxoKKDgibT+SEpFrgfOk= X-Received: by 2002:a05:6a00:218e:b0:81c:717b:9d35 with SMTP id d2e1a72fcca58-823ab6be188mr12337622b3a.28.1770055800044; Mon, 02 Feb 2026 10:10:00 -0800 (PST) X-Received: by 2002:a05:6a00:218e:b0:81c:717b:9d35 with SMTP id d2e1a72fcca58-823ab6be188mr12337588b3a.28.1770055799418; Mon, 02 Feb 2026 10:09:59 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379bfc712sm17476780b3a.40.2026.02.02.10.09.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 10:09:59 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com Subject: [PATCH v4 03/13] soc: qcom: geni-se: Introduce helper API for resource initialization Date: Mon, 2 Feb 2026 23:39:12 +0530 Message-Id: <20260202180922.1692428-4-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Xb6EDY55 c=1 sm=1 tr=0 ts=6980e879 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=OYYzyx7XpuDNtx8IVW4A:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: eKK1iKMXqtSnwKv5xZpOHEuzwwr3YaEz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDE0MiBTYWx0ZWRfX4eTluHl/6hOR SK7lwbmfQ6VBGlH7Iux+p7OS/cUEwdTdWc4L1AH6/hMI7KKmFCG7SnTXoFuhzwsTcaX2MSOxrhA qSf3zmHsX/jI7TDQccxSjKFDEyzraTYNMdVgkO9cmVU8fUGcVRkQUplnaxLcUXVpvoQ+ytoaMZG IBMlMCWlbtgDesaU7Rw2qE5iJegN3SOZMfNDn+Jog7cJb6OARpTS6b8I2cxevnyxptyNPe3xCuB kd3tXeHRnHqlxOuf107KifpCg1HW/IOUOu5POt+VwvZGsCUyCo7fM8ZtgtMpS6eCq3MGTfgm3N1 euyaKOA2zLwo5aNxdL61+6hZPiecEMLpQkVhVkTP9m1EqNWzNQjhXT4hqqpeh2w/DDuyWVDy26S JmlnjJ+0D+zGmNIAq6D9G1FeBdY58av8mGS1nq4g9HfWIABeAQ1+fTz5ugtTMFeP8RIEatENBXk Dw2tK9iihQkKgm+Y1eA== X-Proofpoint-GUID: eKK1iKMXqtSnwKv5xZpOHEuzwwr3YaEz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_05,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020142 Content-Type: text/plain; charset="utf-8" The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently duplicate code for initializing shared resources such as clocks and interconnect paths. Introduce a new helper API, geni_se_resources_init(), to centralize this initialization logic, improving modularity and simplifying the probe function. Signed-off-by: Praveen Talari Reviewed-by: Konrad Dybcio --- v1 -> v2: From kernel test robot - Updated proper return value for devm_pm_opp_set_clkname() --- drivers/soc/qcom/qcom-geni-se.c | 47 ++++++++++++++++++++++++++++++++ include/linux/soc/qcom/geni-se.h | 6 ++++ 2 files changed, 53 insertions(+) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index b0542f836453..75e722cd1a94 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -19,6 +19,7 @@ #include #include #include +#include #include =20 /** @@ -1012,6 +1013,52 @@ int geni_icc_disable(struct geni_se *se) } EXPORT_SYMBOL_GPL(geni_icc_disable); =20 +/** + * geni_se_resources_init() - Initialize resources for a GENI SE device. + * @se: Pointer to the geni_se structure representing the GENI SE device. + * + * This function initializes various resources required by the GENI Serial= Engine + * (SE) device, including clock resources (core and SE clocks), interconne= ct + * paths for communication. + * It retrieves optional and mandatory clock resources, adds an OF-based + * operating performance point (OPP) table, and sets up interconnect paths + * with default bandwidths. The function also sets a flag (`has_opp`) to + * indicate whether OPP support is available for the device. + * + * Return: 0 on success, or a negative errno on failure. + */ +int geni_se_resources_init(struct geni_se *se) +{ + int ret; + + se->core_clk =3D devm_clk_get_optional(se->dev, "core"); + if (IS_ERR(se->core_clk)) + return dev_err_probe(se->dev, PTR_ERR(se->core_clk), + "Failed to get optional core clk\n"); + + se->clk =3D devm_clk_get(se->dev, "se"); + if (IS_ERR(se->clk) && !has_acpi_companion(se->dev)) + return dev_err_probe(se->dev, PTR_ERR(se->clk), + "Failed to get SE clk\n"); + + ret =3D devm_pm_opp_set_clkname(se->dev, "se"); + if (ret) + return ret; + + ret =3D devm_pm_opp_of_add_table(se->dev); + if (ret && ret !=3D -ENODEV) + return dev_err_probe(se->dev, ret, "Failed to add OPP table\n"); + + se->has_opp =3D (ret =3D=3D 0); + + ret =3D geni_icc_get(se, "qup-memory"); + if (ret) + return ret; + + return geni_icc_set_bw_ab(se, GENI_DEFAULT_BW, GENI_DEFAULT_BW, GENI_DEFA= ULT_BW); +} +EXPORT_SYMBOL_GPL(geni_se_resources_init); + /** * geni_find_protocol_fw() - Locate and validate SE firmware for a protoco= l. * @dev: Pointer to the device structure. diff --git a/include/linux/soc/qcom/geni-se.h b/include/linux/soc/qcom/geni= -se.h index 980aabea2157..c182dd0f0bde 100644 --- a/include/linux/soc/qcom/geni-se.h +++ b/include/linux/soc/qcom/geni-se.h @@ -60,18 +60,22 @@ struct geni_icc_path { * @dev: Pointer to the Serial Engine device * @wrapper: Pointer to the parent QUP Wrapper core * @clk: Handle to the core serial engine clock + * @core_clk: Auxiliary clock, which may be required by a protocol * @num_clk_levels: Number of valid clock levels in clk_perf_tbl * @clk_perf_tbl: Table of clock frequency input to serial engine clock * @icc_paths: Array of ICC paths for SE + * @has_opp: Indicates if OPP is supported */ struct geni_se { void __iomem *base; struct device *dev; struct geni_wrapper *wrapper; struct clk *clk; + struct clk *core_clk; unsigned int num_clk_levels; unsigned long *clk_perf_tbl; struct geni_icc_path icc_paths[3]; + bool has_opp; }; =20 /* Common SE registers */ @@ -535,6 +539,8 @@ int geni_icc_enable(struct geni_se *se); =20 int geni_icc_disable(struct geni_se *se); =20 +int geni_se_resources_init(struct geni_se *se); + int geni_load_se_firmware(struct geni_se *se, enum geni_se_protocol_type p= rotocol); #endif #endif --=20 2.34.1