From nobody Tue Feb 10 01:31:06 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0593D38E105 for ; Mon, 2 Feb 2026 18:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770055854; cv=none; b=OHhSdzh5aBDUheO4eCQNpLGDFi+qZW8hUwgQX4UH6+J2QZ11L5JdPKoW1X/P/qDYtpq0BFw3QBpMqaR76q+D4jTWTd2pb63pYjl7bk/y/Q3BWggUXWVwFAzeIrHYyuGyoFpqfknpbiprlvkJQpfT4lGFEP+FmtisY+3BhPz8ULY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770055854; c=relaxed/simple; bh=q5H/RASP+JYgwH0bdr301c8q+Zkx+NKRl1umY8vHydU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F144Ug2Hk2s4lmfUjQjrxB7CP18PwLnKf9mCqfNvlDW2hnkaVJpryUWI/7OYHIoEQTKz0DdgEBsznj3gwuIckoCCQRYpKtChwMJNg5P35fZjNwnaBIx3fcOmFTTAZQK3yUzJJtVkUHEcqnaSoXrXOZnzrLTBshH996TnkZYeAsE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W6fU/XjN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S6WW7S0m; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W6fU/XjN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S6WW7S0m" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 612CVVtM2357173 for ; Mon, 2 Feb 2026 18:10:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xF2mxTu7XWu 0fOGjlOPA26q/bJtyJkxmS7bvT+KJNWM=; b=W6fU/XjN5BvbFLN6u8+4I24gyn9 EDEPOVlNpfV33c02eVNnxmo7yZmoaqQI73LC34gFZGULe3c8GKobbIbG04tcOUgs w3sPRHh7VUidFef5MILgmWE3S6RrppWfo1WaTaVK44ODs9zs1EluxeoJM6GhtT7u qbYluIZ0RPjudLA3NIEjGB/PeXsWa7813mr7L6lqDbKBMfWsnyDzLyss9DDv7b5g JwRQGTKbq1Dgw0oEmaf3TEpIM3tPJYeoxPo8dOj75D3VZVrfI0Z6gRyYTnh9Uezn h/Yg61nouDhcMY7GFBVXqbqfnSEaqn69F02hNt/joOA2E4EVwXTtKG8YwpA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2v0m92kj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 18:10:52 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81ed3e6b917so3930175b3a.1 for ; Mon, 02 Feb 2026 10:10:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770055851; x=1770660651; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xF2mxTu7XWu0fOGjlOPA26q/bJtyJkxmS7bvT+KJNWM=; b=S6WW7S0mjsdVLWoFk8MGC0X5zMTxzy02Re8GtmIqiadO94BKSzIj2H9PxW1JnpCUJY bomKtGi6F37olvgt+NC4JN917eYzuDU2WXLAK3mgwfKjTd+VK+LaZq1wVW9P96rM9ojN 7fZFJkMVn6X5cZuL58BOKJPb0ljAwDwaT8Vs402lnR3G81/UN7sNroYIoTULjQMy8o25 pclBjNdPJ0hxYEjfo486dUpF/gJBZ5lgSc0yFwQuhk0T95hFhvN20M0jEJnEq2261qOS 7yxJ047BA41DBFXKZxJZIXOlaO7Tebgs0KKkdMmkzHQn/3oa42Lb6qc5XwEecnbuAcgc /rjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770055851; x=1770660651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xF2mxTu7XWu0fOGjlOPA26q/bJtyJkxmS7bvT+KJNWM=; b=gklsf0W6B02HY53ZOsVexW/rn6JY2FO5xh1nsSkKgy9h7QoON7ns0IWNyf7zgeQCar flEvY6yCKfjffSTC5K+7J9NMLwqkV4h64X9mTaHSir3KXUQE062LcIIou4JMqyW5rsI7 EdvTFz4UMouPnkuj4XdtnUkCQk63qr0D1e7GB20xJLExJGLhkgkE2t8ZBwTSmQ/4hHYM XWwmfA5qvM6pfFt9A+Dilm+pMvEybM7zGOW6k4VT+G3cLL9oxbaRtx3aoWQlqdRosaQ+ QDe/YrfC11bmRNxP4SlL3UbbJq0VDaVT8Prr5QaEI/36HGLriHkt1rZiXtJtlwXw2wEf PU4w== X-Forwarded-Encrypted: i=1; AJvYcCU5WxnoBx4rkRaOd3ZzaH/WV6nUXesMeeFBlLAfL52GIPF1Eth7Iy8+YtT+3AO4OYzY6DB+5sz7WofYcqs=@vger.kernel.org X-Gm-Message-State: AOJu0YxHsYIFbcTFEcl+VylyZzYf6Vb/g0RM7dmYKRwFeIYWeDgIuf2I p+3KwwPGUb4IpaCyX32wBUMiz7u8DWc3htTr3jdCqYQ6Wq/jk4yr4KbpGspYeQ4ShNjBQM7mKco TlbBhkUNh38KJ/XA4d1YUfwPrI6xQuu8WLmW58wzfr8JUI5exH6r7phG980kguYkif2Y= X-Gm-Gg: AZuq6aIXmQcX1jkmpZswCbgCh8u6hyZdIwRtiLOl6l4uW12lQfHSRrNKOQXI5a5bp3t j0HTX+8g2Sm7FtNrmlN/W2SGpmzPbYzKdfU/uRxjPJWIJFKE9NvCmclNLmRgGyovP1FrZ7nhVyp V+B7VTgzpmBcI9K7H7tvx6+YuknYjrKtt02b+ps98Jiyw9ik5iVZQjQg7WdTW+q38LzdXYFolPl SsMIvrGruj94LpSKCrj1wvYKVo28aQ3C8Klrqt+3aSv4VP4l6+kWyVN7ApmCMCopwJPNDMqmSFN HnXUnCAVH5oK+6/ZqlU4r8kFdOB3ZgfXrc0PfPJ3k4vXo9hyGXk1ScUUgsQmmBht7K1qChERj1v 2tnbYXu9j3W+kZbroi8DOmelk7cx37y2cGJjmgz19S80= X-Received: by 2002:a05:6a00:1483:b0:823:3079:7c7 with SMTP id d2e1a72fcca58-823ab6964f0mr12400674b3a.29.1770055850915; Mon, 02 Feb 2026 10:10:50 -0800 (PST) X-Received: by 2002:a05:6a00:1483:b0:823:3079:7c7 with SMTP id d2e1a72fcca58-823ab6964f0mr12400626b3a.29.1770055850331; Mon, 02 Feb 2026 10:10:50 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379bfc712sm17476780b3a.40.2026.02.02.10.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 10:10:49 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com Subject: [PATCH v4 10/13] i2c: qcom-geni: Move resource initialization to separate function Date: Mon, 2 Feb 2026 23:39:19 +0530 Message-Id: <20260202180922.1692428-11-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=dceNHHXe c=1 sm=1 tr=0 ts=6980e8ac cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=V89BwkbFsXdiYDgkWuoA:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: uTgwd9plOfl_zCBX-z4sJA5HV0Hl9H1d X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDE0MiBTYWx0ZWRfXyEswYJ3Y88Uj 1qPYzlogvKfHfr5PhbFantODpcpz6MudIu5OYyHrIbIqDIybl4+tsrfdv/ZgXVTA6bDRJIUlLEj QDAhQoz1OKB/u+v+7P37DpOOYUIgyNgCzQN4v7p659+AjPfLYoLO6DzGz6wbFKKJc6J/cL3Ue+j cXLoVQStQgfBJwkizLLiIVdp5seglO67XWYdWtMI4zSFzkn6+2Rm/Lo0k7Jr+BwJ8e1sAFwAORT OPKcsYmgvTHMf880jKeXN2HOeBRowX0Gh10NlNZd0q++HBk9QkRAZZEWVOniexnj8K2CA3K2QYX 41j8CsSPDwtf+JRL+CX0a/kPsgGaEJR689jxew/iJmp7UOvq89cj51OWhOApoh/ZymMKtkRhXhV yYz39CXsDSjt24joW0MMAEqsoTj/jHb4qdJhqyjnx6NLtRLfVXOKfAaMpO0rrExgfdtpspBCZq0 6kW8Gww6kjjDVBkud/g== X-Proofpoint-ORIG-GUID: uTgwd9plOfl_zCBX-z4sJA5HV0Hl9H1d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_05,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020142 Content-Type: text/plain; charset="utf-8" Refactor the resource initialization in geni_i2c_probe() by introducing a new geni_i2c_resources_init() function and utilizing the common geni_se_resources_init() framework and clock frequency mapping, making the probe function cleaner. Acked-by: Viken Dadhaniya Signed-off-by: Praveen Talari Reviewed-by: Konrad Dybcio --- v3->v4: - Added Acked-by tag. v1->v2: - Updated commit text. --- drivers/i2c/busses/i2c-qcom-geni.c | 53 ++++++++++++------------------ 1 file changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qc= om-geni.c index 81ed1596ac9f..56eebefda75f 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -1045,6 +1045,23 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) return ret; } =20 +static int geni_i2c_resources_init(struct geni_i2c_dev *gi2c) +{ + int ret; + + ret =3D geni_se_resources_init(&gi2c->se); + if (ret) + return ret; + + ret =3D geni_i2c_clk_map_idx(gi2c); + if (ret) + return dev_err_probe(gi2c->se.dev, ret, "Invalid clk frequency %d Hz\n", + gi2c->clk_freq_out); + + return geni_icc_set_bw_ab(&gi2c->se, GENI_DEFAULT_BW, GENI_DEFAULT_BW, + Bps_to_icc(gi2c->clk_freq_out)); +} + static int geni_i2c_probe(struct platform_device *pdev) { struct geni_i2c_dev *gi2c; @@ -1064,16 +1081,6 @@ static int geni_i2c_probe(struct platform_device *pd= ev) =20 desc =3D device_get_match_data(&pdev->dev); =20 - if (desc && desc->has_core_clk) { - gi2c->core_clk =3D devm_clk_get(dev, "core"); - if (IS_ERR(gi2c->core_clk)) - return PTR_ERR(gi2c->core_clk); - } - - gi2c->se.clk =3D devm_clk_get(dev, "se"); - if (IS_ERR(gi2c->se.clk) && !has_acpi_companion(dev)) - return PTR_ERR(gi2c->se.clk); - ret =3D device_property_read_u32(dev, "clock-frequency", &gi2c->clk_freq_out); if (ret) { @@ -1088,16 +1095,15 @@ static int geni_i2c_probe(struct platform_device *p= dev) if (gi2c->irq < 0) return gi2c->irq; =20 - ret =3D geni_i2c_clk_map_idx(gi2c); - if (ret) - return dev_err_probe(dev, ret, "Invalid clk frequency %d Hz\n", - gi2c->clk_freq_out); - gi2c->adap.algo =3D &geni_i2c_algo; init_completion(&gi2c->done); spin_lock_init(&gi2c->lock); platform_set_drvdata(pdev, gi2c); =20 + ret =3D geni_i2c_resources_init(gi2c); + if (ret) + return ret; + /* Keep interrupts disabled initially to allow for low-power modes */ ret =3D devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN, dev_name(dev), gi2c); @@ -1110,23 +1116,6 @@ static int geni_i2c_probe(struct platform_device *pd= ev) gi2c->adap.dev.of_node =3D dev->of_node; strscpy(gi2c->adap.name, "Geni-I2C", sizeof(gi2c->adap.name)); =20 - ret =3D geni_icc_get(&gi2c->se, desc ? desc->icc_ddr : "qup-memory"); - if (ret) - return ret; - /* - * Set the bus quota for core and cpu to a reasonable value for - * register access. - * Set quota for DDR based on bus speed. - */ - gi2c->se.icc_paths[GENI_TO_CORE].avg_bw =3D GENI_DEFAULT_BW; - gi2c->se.icc_paths[CPU_TO_GENI].avg_bw =3D GENI_DEFAULT_BW; - if (!desc || desc->icc_ddr) - gi2c->se.icc_paths[GENI_TO_DDR].avg_bw =3D Bps_to_icc(gi2c->clk_freq_out= ); - - ret =3D geni_icc_set_bw(&gi2c->se); - if (ret) - return ret; - gi2c->suspended =3D 1; pm_runtime_set_suspended(gi2c->se.dev); pm_runtime_set_autosuspend_delay(gi2c->se.dev, I2C_AUTO_SUSPEND_DELAY); --=20 2.34.1