From nobody Sat Feb 7 04:47:28 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 008E436D503 for ; Mon, 2 Feb 2026 16:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770050815; cv=none; b=XsPKe6/zBF2JxbX3/pMYO74DZZ8Vixf1J5Zi6au9RmiDV8qw3Ef/cBRubjNmUqTI8uqoq3vmrcXAgnoQCIbX515GXY/ZcI6mPghEt8rzxehAGv/QYJcMA1EmRCg0iZ9utksE+P+9iUrZlJwZ9Ud+ghW0QQ7RXW4hTKsNnBryRVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770050815; c=relaxed/simple; bh=uZupMsY12grTXtbViH2uDs9GyHCl34p6SlRSawPH9Tk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TodFfcLsFX7n6737YU3l5DYHuPAg5qJEkD2UtIs527Cm/oECIsLS39OJc9Fu+wCKZsfdc/aPN/JDa1484MCEEt1kccMlcQ8lmFy2o6/sw/mFU0Q2lDTQ4HYDRDybxIhZ+iitmxWMVHqos0NkmlYi3Ra7fFKb2q4k1ZMesFndTRI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PhAuOV3R; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PhAuOV3R" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4806e0f6b69so34448045e9.3 for ; Mon, 02 Feb 2026 08:46:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770050812; x=1770655612; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=INIFCBCUJTQI/9LdXmCI4Y+qu/4cGnWjRRdFLeUHGsM=; b=PhAuOV3Rfj02H0JgXBCDguOv4oa+Lsv6QRHSt17L48d+Wtxxx+HA6fYH5Pob43HBD3 ml4IjPHMFqMXIF961myF3BTVm44QftEUvmojUTTxXH9GZcCAI+GQyib4Vp8m/fHtpOzb Du4JHs7jUB0gsPNgpYV/aieU2OIpabjK/BQYXsmDu4zdtDyAEMFBtyLVj8PZA+5jJdLA MCoxgZ470r+EoXIQ2rxDnefT5FdhMLZwGmT13KLFAvgdqpI0j47HRydNMf/0S4HMR8hQ EnIn4cv0dVVegXxVesGOeHr1/57zhyeVFM+1Q1dqd7b/DqG66DZC0NTStHOby82lPIjI 4vdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770050812; x=1770655612; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=INIFCBCUJTQI/9LdXmCI4Y+qu/4cGnWjRRdFLeUHGsM=; b=K15ofs8erIOmGUtpx+C77/0vZLQI3J1to3aUQrIKrgMN5B9xti5hsPYZSDjkyxkuvt oAH1MFvlPRKK1Tp5sVK1NbzU3KOMyP8oV4/YxUIIrUA7SZDb8DtSO0NDEPdO0VYqRvyR 1e0cpl6At+sOm+TI9B/mo/nu2oMal0d37UDHdwHkof2y4M6VOPQ6eaYp0Tjja2e4wO3i IZ0K892MJEzkqe69I5yC/b696xV5KVKPYHTw0i5cXi9Zx1uQixDSJ7mUTDYVr0op+jd9 xdWP/WtqdN5uNeCL3R1hwwy/bcvS92HWYUm9vJ5wGeYBAQi12kBDFn+CW8JIX9utDKeA o1+w== X-Forwarded-Encrypted: i=1; AJvYcCWue2h/4yHbXrubLgR4MB8xhiVVKh97hn8cWpBXv7INRQj/bm2TP3xsZQtdniYouKHIifh/w7nJT9+adKo=@vger.kernel.org X-Gm-Message-State: AOJu0YwQu1rQ3ZxX+i9ibey6oY5aHRIPyGswFBLDTNfU36S2E4b2eB+Z utnPUT7ad6XGANKb/jFe7WC+2+u3fmh0iaOx/x79XFTkUDBQyuq1JQgz X-Gm-Gg: AZuq6aJkPGodVyWpusj3jnR4l5j4eBl3CVwDmc4Ja9AJWQ1diEoTPcBXxMiDRU8PeE+ T2Tx/LaNPzmwqR6mzfAQi0uAYL58DQHc9liAtAmrnxjAN4LZdjxBKFw2SjBfeADZfyHiNpZ4Siq qCvxs+kZhIFNdCa18vo8B06VKtxwGGxDxnIham5aq1bZNFKutW3u4mrpSW/yTu+nGNjXxhgMdHr LeMGZ2TsgK9o+lYbq7ssz8I5l3okpd59wK1XuGUhxw8oMoSgKLbB0mk2fdGIIVrjQ8qHLMJkLRJ CUVqzmtjXYUdobCSo0Y/g4vxMXX87Qv67b+bICBH+CqlIjarA1vWM3nfB/kvKYtJAMvksTuAq7F Z675EkHEldm37dhtbNor4oTKPpybQDpAmaYdYzrrBiaCHUQ7kDGV/GH7mD8DZjiBDiTpXJaTqJG DysXMDYpjES1giHZcy+AEPHHveBg9hH0zG17/cmmAj5qkzDJtiT28= X-Received: by 2002:a05:6000:400e:b0:435:98c6:7f06 with SMTP id ffacd0b85a97d-435f3a6f562mr16178743f8f.6.1770050812146; Mon, 02 Feb 2026 08:46:52 -0800 (PST) Received: from yehudis-VirtualBox.. ([195.60.235.90]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm45122422f8f.16.2026.02.02.08.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 08:46:51 -0800 (PST) From: yehudis9982 To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, yehudis9982 Subject: [PATCH v2] staging: sm750fb: rename Bpp to bytes_per_pixel Date: Mon, 2 Feb 2026 18:46:45 +0200 Message-ID: <20260202164645.133806-1-y0533159982@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260202145413.132435-1-y0533159982@gmail.com> References: <20260202145413.132435-1-y0533159982@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelC= ase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 --- drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750f= b/sm750_accel.c index 046b9282b..3fe9429e1 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -48,7 +48,7 @@ void sm750_hw_de_init(struct lynx_accel *accel) DE_STRETCH_FORMAT_ADDRESSING_MASK | DE_STRETCH_FORMAT_SOURCE_HEIGHT_MASK; =20 - /* DE_STRETCH bpp format need be initialized in setMode routine */ + /* DE_STRETCH bytes_per_pixel format need be initialized in setMode routi= ne */ write_dpr(accel, DE_STRETCH_FORMAT, (read_dpr(accel, DE_STRETCH_FORMAT) & ~clr) | reg); =20 @@ -76,7 +76,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int f= mt) { u32 reg; =20 - /* fmt=3D0,1,2 for 8,16,32,bpp on sm718/750/502 */ + /* fmt=3D0,1,2 for 8,16,32,bytes_per_pixel on sm718/750/502 */ reg =3D read_dpr(accel, DE_STRETCH_FORMAT); reg &=3D ~DE_STRETCH_FORMAT_PIXEL_FORMAT_MASK; reg |=3D ((fmt << DE_STRETCH_FORMAT_PIXEL_FORMAT_SHIFT) & @@ -85,7 +85,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int f= mt) } =20 int sm750_hw_fillrect(struct lynx_accel *accel, - u32 base, u32 pitch, u32 Bpp, + u32 base, u32 pitch, u32 bytes_per_pixel, u32 x, u32 y, u32 width, u32 height, u32 color, u32 rop) { @@ -102,14 +102,14 @@ int sm750_hw_fillrect(struct lynx_accel *accel, =20 write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ write_dpr(accel, DE_PITCH, - ((pitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((pitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (pitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ =20 write_dpr(accel, DE_WINDOW_WIDTH, - ((pitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((pitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ + (pitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ =20 write_dpr(accel, DE_FOREGROUND, color); /* DPR14 */ =20 @@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @sy: Starting y coordinate of source surface * @dBase: Address of destination: offset in frame buffer * @dPitch: Pitch value of destination surface in BYTE - * @Bpp: Color depth of destination surface + * @bytes_per_pixel: Bytes per pixel (color depth / 8) of destination surf= ace * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value @@ -149,7 +149,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int sBase, unsigned int sPitch, unsigned int sx, unsigned int sy, unsigned int dBase, unsigned int dPitch, - unsigned int Bpp, unsigned int dx, unsigned int dy, + unsigned int bytes_per_pixel, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2) { @@ -249,9 +249,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * pixel values. Need Byte to pixel conversion. */ write_dpr(accel, DE_PITCH, - ((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((dPitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (sPitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ =20 /* * Screen Window width in Pixels. @@ -259,9 +259,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * for a given point. */ write_dpr(accel, DE_WINDOW_WIDTH, - ((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((dPitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ + (sPitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ =20 if (accel->de_wait() !=3D 0) return -1; --=20 2.43.0