From nobody Sat Feb 7 04:47:33 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012029.outbound.protection.outlook.com [52.101.53.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3794C246762; Mon, 2 Feb 2026 15:36:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770046582; cv=fail; b=P7HkULg+pshzQSiSyA/C/eSV9OL0eiMOfETopmNvOv7niBYQBjYjFyGH25IB3i4Sw73EAw+EhGDZnFihdhHr2uVqTle0K3fR0AP82+3elFH4kj3EZ7R3UfJHApZaWhazTo3NPhjlUoWyJAVjDf+K99/a+uWxAemlVMU9mObRgKU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770046582; c=relaxed/simple; bh=RI+HOslyILUyYC8R2GvivRWZrIDF2LkoMUS2gPZ7L4Q=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sC/pft90KPYTyQ2zruP++6prwROniZykGq+Ryzd04GfRtrdjScyM8g3RhG4odCflfjm5MLNudbkNKCOn5m8/h7coarPOPAWJUqMkRpnTY+WDf1r27ZF5PhJtCnwqZtNJOqUipnUdYHDyL0dMqyyv/7/yIZP0QwNNdV32as9eDj4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Q3/3YS2D; arc=fail smtp.client-ip=52.101.53.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Q3/3YS2D" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iWGvlMr6vPgXjcWaRkX7U268JgNjK7z9jeChlgN2KfhRUyCCJ68ITyQVUULWgpCK7YGDko/josofDeqHhdnZfVOzBPmoexrOZUMcs2Aip0t/iamrr3hSTkJeCmoU47s2id0dLqTnCDofYHbeKj5Y16au9tShnKV/q7qhkfVFfYnxgmJhWCKGVtv+s6ITYMN3Cu5U9k9Ijwy6V91zn1TAU5CJX55vENCn+1SGr/TDmUNLvrpZXvGcacmcGSPz6OZSQiES9qreMd9CMf8kPGpVuybAp13LXKRSlKZjZfRYiw7sxth3ye9zmiwNda/4TS7BfU2tWseKFtZeTsfIWyYcxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CKsGUMRiQFel3OqRAJH4y4gWAjpsbfjV0QSjXx6SJEk=; b=HuRQyPG0OEKa335nFDjYo7u2hD2s3zSh1S15NED61OgG5k+p6LdS3ziopYmHzxgSnTTDHCPfb0Qeb/lDTlLup9xZYjWNIBH98XpyVYVHbHu9XZPT1CNnCkmN9M+s7IsrHJqsoYFUQ5X5aXNrqcanI0GSEAElYZXNq3C6/tfN+NPl0hyiGc5K96+Ot87Dxnkpf6H1vZe7OGX1O0MZo3d11OLVZl1gfuFJujRrz4fg/AIH357U9WAWzXUz0pcrKYHDMAdZyMs+cRNGZfvneCXrfORjfUCImkTQ03ii0hytVj4Iz3BcGgeq5j9EXX1liSV5PwRNsXvdMtmSh9GYCa4dDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CKsGUMRiQFel3OqRAJH4y4gWAjpsbfjV0QSjXx6SJEk=; b=Q3/3YS2Dcy8SqlaY0QrpPDPs1cYRVmmxQVcpuTLESl+K1aKTPGf0EmlRSwc6yJ/7MPspI0CYhyxUfJavZfjPrVsEo3WT1SmEDpvRBHBZMkOMRHC26tAHFgM+rVqotl1aE6BAdm4EvFPCB+V/KVUA4iFZ06b/vMZYsbak89HK4nE= Received: from BN9PR03CA0734.namprd03.prod.outlook.com (2603:10b6:408:110::19) by LV9PR12MB9831.namprd12.prod.outlook.com (2603:10b6:408:2e7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.16; Mon, 2 Feb 2026 15:36:16 +0000 Received: from BN3PEPF0000B078.namprd04.prod.outlook.com (2603:10b6:408:110:cafe::bb) by BN9PR03CA0734.outlook.office365.com (2603:10b6:408:110::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9564.8 via Frontend Transport; Mon, 2 Feb 2026 15:35:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BN3PEPF0000B078.mail.protection.outlook.com (10.167.243.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.10 via Frontend Transport; Mon, 2 Feb 2026 15:36:16 +0000 Received: from airavat.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 2 Feb 2026 09:36:13 -0600 From: Raju Rangoju To: CC: , , , , , , , , Raju Rangoju Subject: [PATCH 1/3] net: amd-xgbe: add hardware ARP offload support Date: Mon, 2 Feb 2026 21:05:40 +0530 Message-ID: <20260202153542.1727429-2-Raju.Rangoju@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260202153542.1727429-1-Raju.Rangoju@amd.com> References: <20260202153542.1727429-1-Raju.Rangoju@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B078:EE_|LV9PR12MB9831:EE_ X-MS-Office365-Filtering-Correlation-Id: 0aee7c1c-5f9b-4cef-a1ac-08de6270cddd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LtU/NneyFLetyg9WUClAr4Jq0+jADJCCK5dGlBSjpdS0JvR0RB57ZPDi5gsE?= =?us-ascii?Q?F/W7xwjtQtPvzy8GxYrCeoUprFOjfZ3EmLoG4fv2nUqqlXc9GUaCAlIjWbM0?= =?us-ascii?Q?plzQCY3y9jGY6OORYmQetzuCqH5NZESYekRLubWX5Nl/nUmbw3xjO+aoQU0B?= =?us-ascii?Q?/aFuvlSEcgPn9cmH0uEkJhWwUQvtgT1Xy0alxmSkJETIJZwTdIUuUYkQ7wuT?= =?us-ascii?Q?xKizoWaCyYt4YPMXT77rN1TfWGrgunpm+8iPFbt0QOu9mUcYe0cmtI3JnGSI?= =?us-ascii?Q?MzIMLt1lO15wh6dMixL4MaY6nshGYCeL/IUX5v9sIPLtKWgRzey8/e7jmHzi?= =?us-ascii?Q?UC/ovBL0RtMUE1+17jpcTG7+ic3TCs4vxKDqqSpLCDaTfavSRce2Jro6vSKA?= =?us-ascii?Q?TB6Id4HrupKjOLHxgJSaSHR6Eo31b3LSBH2s5gPF+m/sLcZF75+Zfw0lAl1g?= =?us-ascii?Q?qKchG/g8rylHbM50pDuSKIjQBCYRaGovnw89EMl6vRQmZsb34nTTqO88iRv4?= =?us-ascii?Q?WJGZxOWoMXZO6USZvkC/f4hmyTNkOLUrKyiBwWE7Pqw79fOAKT50/jhrGhsT?= =?us-ascii?Q?nY1gkr1EFfes9B7z8mwD6CFmxeiHPJuhq/6oMMk294gvZ49bYkNOhqTo1bcD?= =?us-ascii?Q?yAE/viSi2A+xUIDCsVhdt0zuSRGXEADvAPZkg61yHjXmV8rW0Aje8KQ12jLO?= =?us-ascii?Q?ywvkCb5EW6tP/KnMrj7+PTbhnytgqb7FxkjUwKrukKfPGCaMvY+g1gwpJJd/?= =?us-ascii?Q?nDPeqTiMfjqokJLoV/Rpx7mJKB4GFKPLNHKoEMquJYtYY7Wzw9bt6VimrwtL?= =?us-ascii?Q?ojhfC7V/Vi0jadjTjeZTsb8INGBTfjun4N3fX84fR4R32t+AbclP+jdr5hs1?= =?us-ascii?Q?1tpCC+aflBXiNbv1JeIlK+F5qmD9AId34nW+MXpgib5FUo2YojsIKEPIftiv?= =?us-ascii?Q?rDp8AcstQUuQGs4ANN9HlgkIDbsOg1QNAYaFy8UZjGSFHsyTfsSrDNyOhV4E?= =?us-ascii?Q?FG2t+Ouuyg2ZdahBYGdL37OSZ7oK2P9n7apyrP+QObG9Tsq8yfTX/R6z6MOS?= =?us-ascii?Q?JXi4Y9iMZHPbGKUDksbcvuOWNIIgyTRnnyYBpvbl6DE/MmqznPbXt9coot+l?= =?us-ascii?Q?Alk5hibQ+4+G0sIVGcAdbCfJn/txTAQIahjpk/Oe6m/YlNDtMlP2vhca1Uqu?= =?us-ascii?Q?EDvi8jJfbRHZE+cX2Inr7VDe5hlu4JnWWfF6BJlt/J8Z7GcFh/+a/aTz5HA7?= =?us-ascii?Q?CXzaZ1Q3haYBjknvoq+pSKh4Wm6lPKMixl81DvZbyOP8bHNG7G/kgu/CJu8V?= =?us-ascii?Q?uvHm041vHsTXDbB0Y9H4AZG5yp5GszGK3QVIsX9miSlyZtWaw6YmI1CWaGg4?= =?us-ascii?Q?SMzoFZkL7FST7euj6nlBpEWq7+TZ9UUtjn0vbH/NsxAsugWygy0SP4ZeHB0R?= =?us-ascii?Q?ue2sQm0dgfam/42FMEMvkwkNCoAeLRCAl0gWJrnVEsV0PpPN698VgGNtAA06?= =?us-ascii?Q?haVn4MTNT7J9Tqnb1cgctgbY/mxtNZ/b25SyZRm5DHA4QTt+0SfV3c2RayfP?= =?us-ascii?Q?2mG01f6RNE0lnsS6qODSDsa5ApEz/01NH3KulDs7ah5e6ZkOwL7fGVR6nP4V?= =?us-ascii?Q?1ocfTzvB86/Hh0w+PN6X9WgboEwysZlL2iBlI8rmtcz4klS4Hs356YxDTdgq?= =?us-ascii?Q?QGqkPA=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1S+QaG7eWb8nwqS6sQc6mUwavWofMI1o9W/Oxz7A+FkfBKoFmGzuCNZEvUKPzIM9jRF9rZaDTwotvTQYKaLVxchrIwmeYu7qkL8kx6DkzP6WaBCf7sxSsjAd8aIIFBVhgUpbLB8iU3xBfhAFS+8UZtNrRYs0RqvcxfiWoPkmfTDUMv2yW0dReY9jsEwusbzzNTGR7vKOIKgEmHnH76gl1G3j4kg5Y/yAUZqmqXi+1BOQjbSMK5dOHLfmZiSUxpv9/8LK1CO7u67kcd1ztbUbJmYZHWpyXchEXbrC2BTkhBNVzCggtftthMtO8y4MM4XQJwbTPj+eO4KjJ/Akoji9+1T4o/KUKFxfGEMrdJ+kp23uU/W6a6zx9tpY2Jz+sh6Mx3PhdPOpJVl4P7F9Yw2H660HlkAe0bZplJSqjy5DhZt4zx6pnAYp5Qx81ouZyT7D X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2026 15:36:16.2481 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0aee7c1c-5f9b-4cef-a1ac-08de6270cddd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B078.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9831 Content-Type: text/plain; charset="utf-8" Add ARP offload functionality to the XGBE driver that enables the MAC hardware to automatically respond to ARP requests without CPU intervention, reducing system latency and power consumption. The XGBE MAC supports ARP offloading through: - MAC_ARP_ADDR register (offset 0x0c10): stores the IPv4 address for which the hardware should respond to ARP requests - ARPEN bit in MAC_RCR register (bit 31): enables/disables the ARP offload feature When enabled, the MAC hardware will automatically generate ARP replies for requests targeting the configured IP address, without involving the host CPU. The feature requires the aoe (ARP Offload Engine) hardware capability bit (ARPOFFSEL) to be set in the MAC_HWF0R register, which is checked before enabling. Signed-off-by: Raju Rangoju --- drivers/net/ethernet/amd/xgbe/xgbe-common.h | 3 +++ drivers/net/ethernet/amd/xgbe/xgbe-dev.c | 24 +++++++++++++++++++++ drivers/net/ethernet/amd/xgbe/xgbe.h | 4 ++++ 3 files changed, 31 insertions(+) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-common.h b/drivers/net/ethe= rnet/amd/xgbe/xgbe-common.h index 62b01de93db4..af95326c6b51 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-common.h +++ b/drivers/net/ethernet/amd/xgbe/xgbe-common.h @@ -210,6 +210,7 @@ #define MAC_MACA0LR 0x0304 #define MAC_MACA1HR 0x0308 #define MAC_MACA1LR 0x030c +#define MAC_ARP_ADDR 0x0c10 #define MAC_RSSCR 0x0c80 #define MAC_RSSAR 0x0c88 #define MAC_RSSDR 0x0c8c @@ -400,6 +401,8 @@ #define MAC_RCR_RE_WIDTH 1 #define MAC_RCR_GPSL_INDEX 16 #define MAC_RCR_GPSL_WIDTH 14 +#define MAC_RCR_ARPEN_INDEX 31 +#define MAC_RCR_ARPEN_WIDTH 1 #define MAC_RFCR_PFCE_INDEX 8 #define MAC_RFCR_PFCE_WIDTH 1 #define MAC_RFCR_RFE_INDEX 0 diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/etherne= t/amd/xgbe/xgbe-dev.c index b646ae575e6a..761195911f13 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c @@ -3597,3 +3597,27 @@ void xgbe_disable_mac_loopback(struct xgbe_prv_data = *pdata) /* Disable MAC loopback mode */ XGMAC_IOWRITE_BITS(pdata, MAC_RCR, LM, 0); } + +/** + * xgbe_enable_arp_offload - Enable hardware ARP offload + * @pdata: pointer to driver private data + * @ip_addr: IPv4 address (in host byte order) to respond to ARP requests + * + * Configures the MAC to automatically respond to ARP requests for the + * specified IP address without CPU intervention. + */ +void xgbe_enable_arp_offload(struct xgbe_prv_data *pdata, u32 ip_addr) +{ + XGMAC_IOWRITE(pdata, MAC_ARP_ADDR, ip_addr); + XGMAC_IOWRITE_BITS(pdata, MAC_RCR, ARPEN, 1); +} + +/** + * xgbe_disable_arp_offload - Disable hardware ARP offload + * @pdata: pointer to driver private data + */ +void xgbe_disable_arp_offload(struct xgbe_prv_data *pdata) +{ + XGMAC_IOWRITE_BITS(pdata, MAC_RCR, ARPEN, 0); + XGMAC_IOWRITE(pdata, MAC_ARP_ADDR, 0); +} diff --git a/drivers/net/ethernet/amd/xgbe/xgbe.h b/drivers/net/ethernet/am= d/xgbe/xgbe.h index 03ef0f548483..bf08628a7ce3 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe.h +++ b/drivers/net/ethernet/amd/xgbe/xgbe.h @@ -1333,6 +1333,10 @@ int xgbe_selftest_get_count(struct xgbe_prv_data *pd= ata); int xgbe_enable_mac_loopback(struct xgbe_prv_data *pdata); void xgbe_disable_mac_loopback(struct xgbe_prv_data *pdata); =20 +/* ARP offload */ +void xgbe_enable_arp_offload(struct xgbe_prv_data *pdata, u32 ip_addr); +void xgbe_disable_arp_offload(struct xgbe_prv_data *pdata); + #ifdef CONFIG_DEBUG_FS void xgbe_debugfs_init(struct xgbe_prv_data *); void xgbe_debugfs_exit(struct xgbe_prv_data *); --=20 2.34.1 From nobody Sat Feb 7 04:47:33 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011051.outbound.protection.outlook.com [40.93.194.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0EA536683B; Mon, 2 Feb 2026 15:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770046589; cv=fail; b=c51HW9YV59JSjbH2eI2OC44jdm1nNyNB3arfTcKlJBxRiLIlTmmigxGENPAJI8bLkX7jM5Ae4VIaoJIcRTcqJjXeZXaeStNXffLxKcMItRk4qWFmqQoFpAaJjMp0kufrVR0vvQkom3be+zeKQTkcifDLQdt6rtlWMFsRih+oWgU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770046589; c=relaxed/simple; bh=wxr9mwqu+Mwfpz0o/WGMzLzcldrp0eYOtEjH6c1YQzs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GwKYEJ2FDmh6r6+Xu12qFmyJPCmbNzeYFP8gKw9Dp7nGJk1AgAUCpUdZyoMJn9CMAChV/WJ3Ux09i4aA6y6IwXv4SZnWgB4CZN1PwFohVhgNl5GfrV4n8tv1cjLHzGGurTAg7rLcu5MdN+U6gd6RCWwn9rta+G8EYczCTYV9VwA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pwz7lsDt; arc=fail smtp.client-ip=40.93.194.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pwz7lsDt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IRLvnSd4nokFY1YGL05odxhVPGMTHAmbjw0Yq2rJC2qtTrtLAAsBoh3jLMkt28YS1BXuWGgvuMFpD1E/aWm2V8DhbRKAhA2shMqib0AeTH8N7zg614Rd7N2ELo0b/O+Ka/Xk2I4njWVB7s9ZAAa8e43faMZjRcxPNa2Z79arReocPEqH3LSXfxyhYjG4VHpkCPoPgSgbc00tzAowohNvL5gqaObplrgC/7LImG9NZYaG+W0bjbQ4uURke9Ey9PWzKW7eZsPqLrPgXF/wSgeRqc4mcMRabd6FNto07Fs1DHc3TJMur/eSefWa9Jyr7jkIWYY02HyZ7j5uqieCFuTQiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dKre1zuBvctbNw3zvxpsqq/gJWtM6nT5OQSLpSQbYlc=; b=nr3ZLvKv+PPpxZqVsLAgRkjVGU0NYK+BvUFp4Lvne8iGw9cQ3s58eqMWmUlBFm/JxP4hOZDqWgoS44Jv/UieGU2cQwK22JL8ZXegdNuQ95qZWPo9CA/GgegeMidimBTg6LZOiSVE819t7no2IkBY0W+7ZBmO+fDu+VNEL9bRnozXGM3LGBwCHJq44QEsDyWWTaP8hd9iY/w2Hf9xWOcCC7GSmP/vCOWxs73gseqM6YwQ7eQ31ZZnZjBpmvQhdiv5rCm+Srh28KcfB8PNjMJ3mywymWnulRSZYpnC3hk1KyClsVCH/jqs7ORL46tkPAemX6yiwgqPRZDTE488U46NYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dKre1zuBvctbNw3zvxpsqq/gJWtM6nT5OQSLpSQbYlc=; b=pwz7lsDtAr2qAKZlUtGnPybJtR7YYp2y//eVLwtHlGNuYI49neYREjfbKTcMAnddhZfvgYRogVJ2+m/+97WnFZUn84osyV1sZuWbn7Uulw/662qDA2nAvLmAWFkfS0obmFS/9d07NL0O2bvxT+J2wqSO7aBk4nVooKVeoJ3exA4= Received: from BL1P223CA0036.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:5b6::18) by DS2PR12MB9752.namprd12.prod.outlook.com (2603:10b6:8:270::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.16; Mon, 2 Feb 2026 15:36:21 +0000 Received: from BN3PEPF0000B076.namprd04.prod.outlook.com (2603:10b6:208:5b6:cafe::f5) by BL1P223CA0036.outlook.office365.com (2603:10b6:208:5b6::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9564.16 via Frontend Transport; Mon, 2 Feb 2026 15:36:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BN3PEPF0000B076.mail.protection.outlook.com (10.167.243.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.10 via Frontend Transport; Mon, 2 Feb 2026 15:36:20 +0000 Received: from airavat.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 2 Feb 2026 09:36:18 -0600 From: Raju Rangoju To: CC: , , , , , , , , Raju Rangoju Subject: [PATCH 2/3] net: amd-xgbe: add ARP offload ethtool self-test Date: Mon, 2 Feb 2026 21:05:41 +0530 Message-ID: <20260202153542.1727429-3-Raju.Rangoju@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260202153542.1727429-1-Raju.Rangoju@amd.com> References: <20260202153542.1727429-1-Raju.Rangoju@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B076:EE_|DS2PR12MB9752:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ae56176-02fe-4413-bdea-08de6270d09b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lsaubipPqkXGv9emtDWk9JtMK7LefUXwsDrAY3psWWtwLztJtEXEDXWGUXVZ?= =?us-ascii?Q?X5ftkeu1VviltXdxit4GdRE8b0Y+8dcoBO34i0K/3/X4g93A2nxBedl1q6Zo?= =?us-ascii?Q?6thOFN1R9/4TaZBDmyeKBIaaTuJeCluRJz+nwpQfR/e9cIEzTvsFOG3uWyme?= =?us-ascii?Q?+6ttT3oOts5FPb9NSTQjZJOntwkELpKzh/Vw1r+qJqMrHIxApbSxBix+7+Ab?= =?us-ascii?Q?5yORIFgv1oHImSZjHppLipAgnaHjln4i+O5TXIf7KgAlFt5SmLQNo18UAvv7?= =?us-ascii?Q?j1aMXD2MZx65TIVbc6iht7CpWq68q26JDOMLgzsnGTj/+nXyrI63aunDQCNS?= =?us-ascii?Q?x+WvwdhMsaS8FbXTFmoI87SzqS4GWrofQPicW/LQGsp4sIJohgWaTMCFBhy+?= =?us-ascii?Q?JAuFj/2Z0Iahc9OBbVf4Lm9trefqkgTM2V3ogCdor4q3cPG5crEhfblwASp+?= =?us-ascii?Q?juXLC6vZss0IPBmLrxTL7j6Z8bBfJdS0Fx7N36/rZx30ZxypuI74jvgjRekk?= =?us-ascii?Q?NVee94fMB2bvFzjsm45RJWImfAs3ryZAxDeUZX9nDEZLz1V/4w+fZZJzsCpL?= =?us-ascii?Q?iSgSnII1lE2CfHpqYuam4K+9x/mG2hkNbSBAtAJdhvK0CV6E6JWK4Pau2hC/?= =?us-ascii?Q?oQF2YoF3qSzu8XaMEcV5ivwJV4iJ4H5NwyLS85yJSSrmJrGeq9s/tCFcvEcc?= =?us-ascii?Q?y8iC9e15gAbnjcSikHvsHYB6sYxuA8gyfujkhB6arOTwp/tEPRtj98QTnCfR?= =?us-ascii?Q?U2NYvPFMMXCM4bx8jVPGiBhQsOcUtlDPdX5hncAk0kmmZPWu4w7djvPno+ij?= =?us-ascii?Q?hpPIYWNVk63Mi0ITnhVzv/JOoSZAVamVy8mOaEV95iYkISXI2wux+twCzv7R?= =?us-ascii?Q?W8VEnp0UnJ/jFLs9NQZ55c8Od8RZQNkHaHz5SdhB6HZLCzXPkvM+ES2naSFg?= =?us-ascii?Q?iGlszho96pezVGnyRhM/3Olv7x06uhdf8bnONPDdzi5d1O2N9ov4MSHz870y?= =?us-ascii?Q?wo+dsEQqDPI2K85lSj8CrOP5Sr06S0fAmryTQY/DTBBQGuahc/SBfHaidUtA?= =?us-ascii?Q?uxS0v9wW4ZVylhHHrzBKAopruO7R++pGuwX2HNHOBYzSgiwGX9MqiDrNMgFb?= =?us-ascii?Q?SGG9BqjFy0XqbvqghLHEikc2pbCn+OEUlAsVlH3CTsMYNMCfNHP67Ea1ve8E?= =?us-ascii?Q?7BnicgKVKAiF8QRu+iV5Kr3pX3LB107y4jBUPj9Tqea+FKpGANDFFOrN3Zwo?= =?us-ascii?Q?Fb9k3sWubC10VW/HlS2Wc3JDUOrWBTAJS9DOwwkot3W3WybiIBGeZ36aCC99?= =?us-ascii?Q?rsRK+qSpgXlWRn7+FKsw7AkMRWQVMZuF+urfr389mKxnw+N4K7tSet7eBwC2?= =?us-ascii?Q?DMhMgYkShRjuVjm12a9mO8/R9NxNU8qmDU8OP6GtA2itZJFkGn/gfEhfMT/k?= =?us-ascii?Q?2IoCTiUeRhZ4q3k/nVh7lsfFZpEPlJpHV3TcTpH2zzc1RMOCBDLKub4P25rW?= =?us-ascii?Q?1qf5XDBZNt/WCnsxURzAlo/LQ/Q5SMFv1NBnACpc1R8M0CaLbdl4pIX4JJCh?= =?us-ascii?Q?cU+JRuuq9fVsDKiasrvA3Sabmx9dtaK5I93lbTemaN7oC/Fhj8xkcfXA+Gpl?= =?us-ascii?Q?nJRhTe5VY8T94N2qwKKvv7EdzyxidPWsMFqU7eFYbD9wKvldHDuKwbPnMWIs?= =?us-ascii?Q?ZJ5wLQ=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: c7VqX2yVOY6Yixz1NNpYd343JWqYqDdDLT2lyzSSzr2TRbrLROllLJKXvRFPYssbOU6MvJJ0TfFiNeelmR8E1RyKz2Dr24cFfIjOd+y2Pppru57yDfxj6k1wYbJB2XJiV8Z84KWdYUMDJIFPKl1eWU9lPIztNw6NgmVOAyEvMWYX3diGtB5HE2RlkzZR/mpfNmMGjgNG7swCayDJB1P9u8JZQoU3HVVepfKq85fS0J2/yMjnTVhdgLLN4eKleivgRC8iJUCXEhHJahAHslQPiPThhK4d7+6+orFoJPgqLRzl/v0KGjPtrzlZcuLqkH8A224lXeKksdcVYuWPf7kxyKcSLgsKjuk/Ihibsm+Lq8dBxnSibIM0jOUy1UncTRcuk5lYFax4/tsgCj5CQxTvamtgfTx5ZUvnOcS7Wb6Kt25+9W/xHVCx7n69rarrzCvP X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2026 15:36:20.8485 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ae56176-02fe-4413-bdea-08de6270d09b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B076.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9752 Content-Type: text/plain; charset="utf-8" Add an ethtool self-test to verify the hardware ARP offload functionality. The test validates that the MAC correctly responds to ARP requests without CPU intervention. Test procedure: 1. Check for aoe (ARP Offload Engine) hardware capability 2. Create an ARP request packet with test IP addresses 3. Enable ARP offload with the target IP address 4. Transmit the ARP request in PHY loopback mode 5. Verify that an ARP reply is received from the hardware 6. Clean up and restore configuration The test requires the device to be in PHY loopback mode and runs as part of offline ethtool self-test suite. Usage: $ ethtool -t Signed-off-by: Raju Rangoju --- drivers/net/ethernet/amd/xgbe/xgbe-selftest.c | 117 ++++++++++++++++++ 1 file changed, 117 insertions(+) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-selftest.c b/drivers/net/et= hernet/amd/xgbe/xgbe-selftest.c index 55e5e467facd..ae4825578c59 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-selftest.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-selftest.c @@ -9,8 +9,10 @@ #include #include #include +#include #include #include +#include #include #include =20 @@ -152,6 +154,117 @@ static int __xgbe_test_loopback(struct xgbe_prv_data = *pdata, return ret; } =20 +static int xgbe_test_arp_validate(struct sk_buff *skb, + struct net_device *ndev, + struct packet_type *pt, + struct net_device *orig_ndev) +{ + struct net_test_priv *tdata =3D pt->af_packet_priv; + struct ethhdr *eth_hdr; + struct arphdr *ah; + + skb =3D skb_unshare(skb, GFP_ATOMIC); + if (!skb) + goto out; + if (skb_linearize(skb)) + goto out; + + eth_hdr =3D (struct ethhdr *)skb_mac_header(skb); + + /* Verify the reply is destined to our test source MAC */ + if (!ether_addr_equal_unaligned(eth_hdr->h_dest, tdata->packet->src)) + goto out; + + /* Verify this is an ARP packet */ + if (eth_hdr->h_proto !=3D htons(ETH_P_ARP)) + goto out; + + ah =3D arp_hdr(skb); + + /* Verify this is an ARP reply */ + if (ah->ar_op !=3D htons(ARPOP_REPLY)) + goto out; + + tdata->ok =3D true; + complete(&tdata->comp); +out: + kfree_skb(skb); + return 0; +} + +static int xgbe_test_arpoffload(struct xgbe_prv_data *pdata) +{ + unsigned char src[ETH_ALEN] =3D {0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f}; + unsigned char bcast[ETH_ALEN] =3D {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; + struct net_packet_attrs attr =3D {}; + struct net_test_priv *tdata; + struct sk_buff *skb =3D NULL; + u32 dst_ip =3D 0xabcdefab; + u32 src_ip =3D 0xefdcbaef; + int ret; + + /* Check if ARP offload is supported */ + if (!pdata->hw_feat.aoe) + return -EOPNOTSUPP; + + tdata =3D kzalloc(sizeof(*tdata), GFP_KERNEL); + if (!tdata) + return -ENOMEM; + + tdata->ok =3D false; + init_completion(&tdata->comp); + + tdata->pt.type =3D htons(ETH_P_ARP); + tdata->pt.func =3D xgbe_test_arp_validate; + tdata->pt.dev =3D pdata->netdev; + tdata->pt.af_packet_priv =3D tdata; + tdata->packet =3D &attr; + dev_add_pack(&tdata->pt); + + attr.src =3D src; + attr.ip_src =3D src_ip; + attr.dst =3D bcast; + attr.ip_dst =3D dst_ip; + + /* Create ARP request packet */ + skb =3D arp_create(ARPOP_REQUEST, ETH_P_ARP, htonl(dst_ip), + pdata->netdev, htonl(src_ip), NULL, src, bcast); + if (!skb) { + ret =3D -ENOMEM; + goto free; + } + + skb->pkt_type =3D PACKET_HOST; + skb->dev =3D pdata->netdev; + skb->protocol =3D htons(ETH_P_ARP); + + /* Enable ARP offload */ + xgbe_enable_arp_offload(pdata, dst_ip); + + ret =3D dev_set_promiscuity(pdata->netdev, 1); + if (ret) { + kfree_skb(skb); + goto cleanup; + } + + ret =3D dev_direct_xmit(skb, 0); + if (ret) + goto cleanup_promisc; + + /* Wait for ARP reply */ + wait_for_completion_timeout(&tdata->comp, NET_LB_TIMEOUT); + ret =3D tdata->ok ? 0 : -ETIMEDOUT; + +cleanup_promisc: + dev_set_promiscuity(pdata->netdev, -1); +cleanup: + xgbe_disable_arp_offload(pdata); + dev_remove_pack(&tdata->pt); +free: + kfree(tdata); + return ret; +} + static int xgbe_test_mac_loopback(struct xgbe_prv_data *pdata) { struct net_packet_attrs attr =3D {}; @@ -251,6 +364,10 @@ static const struct xgbe_test xgbe_selftests[] =3D { .name =3D "Jumbo Frame ", .lb =3D XGBE_LOOPBACK_PHY, .fn =3D xgbe_test_jumbo, + }, { + .name =3D "ARP Offload ", + .lb =3D XGBE_LOOPBACK_PHY, + .fn =3D xgbe_test_arpoffload, }, }; =20 --=20 2.34.1 From nobody Sat Feb 7 04:47:33 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010061.outbound.protection.outlook.com [40.93.198.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C1D3376473; Mon, 2 Feb 2026 15:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770046594; cv=fail; b=LdWMC1sAlKqEK68WzqmLzIfmiDDTRDmB25EqNMhAB8cVyM8Att4FpjZgyGWBOSEh3bjWY+rSJwequngUuqpYVQ/XXVbsDQYrVdebt9MlilkuEWV1CppR68xid0wbIbY/ys+qIGLBfJJeDWpeAxzqg7BIfhep/vmrRuQ+uiB7nOw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770046594; c=relaxed/simple; bh=NS6qMoYPUBz0czti+ftdmNH4ua7NaUWbwHLjhvOOzeA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PTTAqWWL1BQrKkQnak/4LeB7o4/Q6uCF5UirbWSB1RnrGePToB4MPwcG54l+ok83GHLsZJdZgyL80RLTATPfTPEIaAz8Ndr0DlP7vxUe1bLhqno+Tpq49g0rTewXUWo6PXnvh0+/7FW72kUZ6ZvyuCsMfB6gJBouKPcrw5szzM4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=20YJIzYn; arc=fail smtp.client-ip=40.93.198.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="20YJIzYn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=avauC/E0L9QmgUZ8FI2LEPx7N7N1z8PIvo5FVhWQuIc9HMetFH7kOZHkd8vyg52dEAIq+ll4zVY0mNUrtn6WxtVYHkABrgad2cTkNl1v0owkwnuUx+GNYXlqN00Vz3ZRcJzziKVttBBdfM4Vvh2iA6IZd/JAENlB5iJ2m95dRs+eXd+mirgoIElUPQ4eusKU+UgQxU0WIcaxgePl1Y/bc2RCOKYh+iV6i4EBfbRLeJgIgSwluodqmce2mtZPdoAikpTyBglHF2DinFj/4UtOXSF4FFXWADQVl054pgoGaPepI790YZ8q8elRHv4sC1Do2qEB1I9Cgs+PCfnx005I+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z+FKkQ6eA9hPX76uv/+empPxjJdGb1uIDyQyPja2Bog=; b=AGwcjbtduZgJGmJsAekbXdDLdxCWc5FRDF4yO/u2YqONjVoz88vn13hOTGm9G7l92xjAYH8zI53LM4OG1ACRkNCCg8GU8Y3o6NLz0X39Gx8IK0YovBfIFPpQ+U5b9n6HHIEdxK39OvhTcpJklq36rzi8LMthR4/0cWBTqToODdrxA75ZGgA7l3LqlAm9B6snUrewxRy5D49CdN6uY/P601WiM1AKgWO4AqYuYtXCazyRR0pD8gWO4DdIOssSrkP1OKqJBqDhfr4oIdAt2gW2cgvaXLrDIzSy9XDbrIuBY0V9fcyU6kJVEJqmo+O1ejR+udYBoVP5kYOg8RxzFJHfXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z+FKkQ6eA9hPX76uv/+empPxjJdGb1uIDyQyPja2Bog=; b=20YJIzYntHoGs7K8wSSA7mOIMe6+SGeM7JtozQJ9moq/UV5l2MYIA4F+E1QgQQtnndpXnvgAfyEJj7XlRu/9yWPe5f3KWvTZ7Y/tDDc0qi8pNMEnq0StG4FwK7TQzRZ1HYbmr+0B6B+BLtBcsOJigDYOkOevx4+TmWvxilMLXl8= Received: from BN9PR03CA0096.namprd03.prod.outlook.com (2603:10b6:408:fd::11) by LV3PR12MB9260.namprd12.prod.outlook.com (2603:10b6:408:1b4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.16; Mon, 2 Feb 2026 15:36:29 +0000 Received: from BN3PEPF0000B073.namprd04.prod.outlook.com (2603:10b6:408:fd:cafe::2d) by BN9PR03CA0096.outlook.office365.com (2603:10b6:408:fd::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9564.15 via Frontend Transport; Mon, 2 Feb 2026 15:35:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BN3PEPF0000B073.mail.protection.outlook.com (10.167.243.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.10 via Frontend Transport; Mon, 2 Feb 2026 15:36:26 +0000 Received: from airavat.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 2 Feb 2026 09:36:24 -0600 From: Raju Rangoju To: CC: , , , , , , , , Raju Rangoju Subject: [PATCH 3/3] net: amd-xgbe: add RSS ethtool self-test Date: Mon, 2 Feb 2026 21:05:42 +0530 Message-ID: <20260202153542.1727429-4-Raju.Rangoju@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260202153542.1727429-1-Raju.Rangoju@amd.com> References: <20260202153542.1727429-1-Raju.Rangoju@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B073:EE_|LV3PR12MB9260:EE_ X-MS-Office365-Filtering-Correlation-Id: fcc9ae67-6351-4551-f9b5-08de6270d43c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026|7142099003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QqSHtQsoAPpA9BhkgoTUAxJnFQ9S5bqZB5Qj1XMNERKcUYFMpVvscyu6rUlB?= =?us-ascii?Q?KjaTo4jOQnEA/78fGA6oNDDtxvw9CrbjI4UvoFZRVgx32CUSqF+oBb3ov0ln?= =?us-ascii?Q?txg2P6JtYQtCR3yWLnKz9Bk1JXzMSdHXqfGAWS6D4NN4h0OsgnEqGUKj+w3W?= =?us-ascii?Q?u/FxjQVeDWzNoc8hoIbXO1khGfD0h/dHcjMMsVOKrozTe6GUpPLQLtukvPCL?= =?us-ascii?Q?SfNlP2lj8H0xdQuCEmwD+0kLuMFDmA4R4rLFiQgpNu9PUsJqjJK7ZaLCCs6i?= =?us-ascii?Q?bBoKzZnqHiK+H/Nrx7eHb02R6eCDA5RpP6hqGcLV6l6KmoTvruY6iXh+VLrJ?= =?us-ascii?Q?eTHfSkxaJ5GKBkvY/Kg5Jhu89XQIlJKl9knW0Tsw4iC8rL6WmIFU13rn/Adh?= =?us-ascii?Q?dMRjMLx+fgx0/U0hhT0SXt1xzuI1jWI7+TeJdcWzCiTI1pFVMgE3A0LRPRqF?= =?us-ascii?Q?yfcLRTBfBtasaa8xufc4EZwjSFR3Gnh7jzm/oVWDA9gg3o4lKrYy/2uCTKhN?= =?us-ascii?Q?fYbf5aAa1oOX65jGOWP+Ac1FHIIG7T6swYJPpQ27sJJ8lTKBBbY1ZSi+1V6g?= =?us-ascii?Q?arebAyszYVgYilB7XmrAKU0kL7rqmIBb2MhsN683UPCUdxlyjdOsTcxc+7t+?= =?us-ascii?Q?Ba1fSCeapO+rnVO7yGU+UOytx7N3az1sh3AOe+7sDosTHALv8NOTqx10BIXh?= =?us-ascii?Q?gaLvST2ytQ/tU+P+TqxO0GG2t6rN0gYIV+v/9Qc38ZzEYSH6JTk0d373ldHC?= =?us-ascii?Q?03IH50Da6KZOpL79OerP8XHNeBDS1YHZlUchh7sZboFw26a+dDHu9PUCcmam?= =?us-ascii?Q?FusrLX0VtOIIJvq5EY/j7yI5pMZxW3VfkO0UuqI8+8t/OgvXqUqL8LUTmZ5j?= =?us-ascii?Q?qGYv1Ag8CTZY6tLmk1OdC22WTCDp8TWHaEVuf72jQg3VnV5DhPnbXSuAQZYL?= =?us-ascii?Q?gHix0M/xruZISbnhe+dcm49pLtQ4P15oqBtZ1RjUv8jtvyf840l81uzeY/tH?= =?us-ascii?Q?M++qf1+2huFwBl94QRNNSE76vIMl91xljyUEVu7FLJZW/GFGazo5idiqXghF?= =?us-ascii?Q?yimMmzHH1ZU4zRFICS7LfBs43p52vy4sx2Uuout1QScvCyfYw0fILVPO9RHu?= =?us-ascii?Q?oSZN/urz5qdhAJla4kl3dvS65m/tcuWrVVlW3xj5O5Iw0eZHR2OD17s8SYCr?= =?us-ascii?Q?LB1Pd3pPP9Fg3xKYlThQWwfkjPCmOh8Kb2DFw5tD4haFmWsfEEdVZWIpd2/G?= =?us-ascii?Q?2r4q18iMMxUuTEVe8GpzNFigwL5XqSbNp7iTCYc42xoK/raUdPgeMkubVYTM?= =?us-ascii?Q?5V2VQH0QqhkmgM/fPNWSUV4xq21ovVZA8t2nJlXb1Glopz0K7EGY4kx0C7Dy?= =?us-ascii?Q?kThb98SkxHPqzXJuvfZk5puZvWS+1Gix6Ga4BS+9ylJNlOf5iPvDuSj4yOiw?= =?us-ascii?Q?sEpLX9H6zaci0yQ4fnwSA1md5M4d+GPJbz4rwgjIyh6lqpbDjALJVMs2B3yc?= =?us-ascii?Q?n0HnH552EdrpCGwqW7teCwlV/GbnbE9zHJg/8e8uFr1PksmW2JeumBSoNPSs?= =?us-ascii?Q?0x3kYmEau5Jj5dgkkKWyZcsxknXPKz6Z6capuFb5TioauCXaU6jK7dZcEeHP?= =?us-ascii?Q?4F1FelQQR1LYGlXsg2YWdhdpqOJRSdqmKrxtl2qAfmvoDtYyDJR3itDZvSVd?= =?us-ascii?Q?e+pZWQ=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026)(7142099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: WTeqdhscydENLCH8eH2HPQTvEvQmKMNJFfxXZZ0VmEjVaFiMz7tDoJ5l2NlZ52RZ9jIOOo0cqA+5b+dWE5btwDhTjHWpwyqoON3NpL4UBI3C48rhnMM1wZ+43j2SFzPbtSsLrlRuxyfsPfITGfTD0QmGSLA9mDl2Mp0OLvEgLkn3RV7xOYIT6gc1ge8FerWnWwwBeO+QPs+JyAA3gXbEHKXxxHKJvf8E5dY15f0DnNDSrUpa4aMdUgRQKS+CLrEQKznhwOWboR7gMIeRPOa7F8cwGAW5ZHFKjkc051Acas8GQWyMYNKfVqmeB5VAmC9dFvzghY0dQg3/yonZq1mGiFCMIj1/pBrOd8VHMMNKdAKK9lxL0l5WIgp2Q6p/FJtsg5ivQETaOFHtelpmBEmY2cGZoXeSLTz4Ou4WQ5GdwTOjhuxmtV4YaHClB6J13lsz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2026 15:36:26.9419 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fcc9ae67-6351-4551-f9b5-08de6270d43c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B073.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9260 Content-Type: text/plain; charset="utf-8" Add a Receive Side Scaling (RSS) self-test to the ethtool diagnostic suite to verify that the hardware correctly computes hash values for incoming packets. The test validates RSS functionality by: 1. Checking for RSS hardware feature support (rss bit in MAC_HWF1R) 2. Sending a test packet with specific TCP/UDP ports to trigger hash computation 3. Verifying that the received packet has a non-zero hash value computed by the hardware The test uses the existing loopback infrastructure and requires PHY loopback mode. It uses specific port values (sport=3D0xabc, dport=3D0xdef) to generate a deterministic hash that exercises the RSS hash computation logic. This test helps users verify that RSS is properly configured and functioning, which is essential for multi-queue performance on multi-core systems. Usage: $ ethtool -t Signed-off-by: Raju Rangoju --- drivers/net/ethernet/amd/xgbe/xgbe-selftest.c | 32 +++++++++++++++++++ include/net/selftests.h | 1 + 2 files changed, 33 insertions(+) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-selftest.c b/drivers/net/et= hernet/amd/xgbe/xgbe-selftest.c index ae4825578c59..bd1c757bbc3f 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-selftest.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-selftest.c @@ -100,8 +100,13 @@ static int xgbe_test_loopback_validate(struct sk_buff = *skb, if (tdata->packet->id !=3D hdr->id) goto out; =20 + /* Validate RSS hash if expected */ + if (tdata->packet->exp_hash && !skb->hash) + goto out; + tdata->ok =3D true; complete(&tdata->comp); + out: kfree_skb(skb); return 0; @@ -154,6 +159,29 @@ static int __xgbe_test_loopback(struct xgbe_prv_data *= pdata, return ret; } =20 +static int xgbe_test_rss(struct xgbe_prv_data *pdata) +{ + struct net_packet_attrs attr =3D {}; + int ret; + + /* Check for RSS hardware support */ + if (!pdata->hw_feat.rss) + return -EOPNOTSUPP; + + attr.dst =3D pdata->netdev->dev_addr; + /* + * Use specific port values to generate a hash. + * The asymmetric port values ensure the hash computation + * produces a non-zero result for test validation. + */ + attr.sport =3D 0xabc; + attr.dport =3D 0xdef; + attr.exp_hash =3D true; + ret =3D __xgbe_test_loopback(pdata, &attr); + + return ret; +} + static int xgbe_test_arp_validate(struct sk_buff *skb, struct net_device *ndev, struct packet_type *pt, @@ -368,6 +396,10 @@ static const struct xgbe_test xgbe_selftests[] =3D { .name =3D "ARP Offload ", .lb =3D XGBE_LOOPBACK_PHY, .fn =3D xgbe_test_arpoffload, + }, { + .name =3D "RSS Hash ", + .lb =3D XGBE_LOOPBACK_PHY, + .fn =3D xgbe_test_rss, }, }; =20 diff --git a/include/net/selftests.h b/include/net/selftests.h index c36e07406ad4..18a9b4830dfc 100644 --- a/include/net/selftests.h +++ b/include/net/selftests.h @@ -19,6 +19,7 @@ struct net_packet_attrs { u8 id; u16 queue_mapping; bool bad_csum; + u32 exp_hash; }; =20 struct net_test_priv { --=20 2.34.1