From nobody Sat Feb 7 04:47:01 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46DDE366052 for ; Mon, 2 Feb 2026 15:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770045061; cv=none; b=k+Uv9y799bnRa9ujMmwH5b8pua2vSLUWX5IWG4h37ijofXsJM+EJcdUF7jAzLRatwlNu9r0TbXljSW21+i2Q0OJv+Vn+BRg/cZDrNF2BxQHtsElfOuTsQO3znov61/kr+lVAXFyQSl20rEDVfpDazyTqpkcRsRfIc3gBTIA57mY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770045061; c=relaxed/simple; bh=btc952EXnNWwdQlMg+H9RbtOd9pcgav+Aeu0irDTT9A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=po16EmdGQDtNBCu+Vv7jLU/bVEYKlvNHfS71zQ4LJTPm4jqLiJVADkaIaC0MWHVF/2asYCtfFIbQs/XoOKr3QOejGB9vimVKExJ4SqXO5cUe/eNQTzdOQyWt5L1dYJtyWWlJZjf2r1X+i9Gaw80pClMcpZlA0A7DNK0wP5CWNBE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vMdVBndC; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vMdVBndC" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-435a11957f6so3616628f8f.0 for ; Mon, 02 Feb 2026 07:11:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770045059; x=1770649859; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QLQJlIi1xp3GOgxJrSuyTGl+kKtHgLV5lTV9J+BYkDY=; b=vMdVBndCHwhhq8lTTOrA0HVYARA+uPLK78PeYrJ+tXombRUvfjKfM+e5VL8wZPAPWG 0HJXfV8+WE3QklokxNX3mdXUcdK7cWVEHEf0czMfi7swxn9RnkmFVnxGrahr+moX76OY 3laWrtHTKzAF/DnsrSWjPEs2BHo58m/cAPVYEx/NrJHvhJIBUXhDu8c6RypC0BX67448 tkfg5v3dCwjFJM73ygCLbfdlI15F2/V8NRBn9mngPviHWXDBQPUqbzPQN+ke7+ihezr5 dFftO2Nh9TfXi/AHR+a8TXHP+q32S7n1hMJJmWbdq91AR8upRYgKZY3z1yWWygW7pZfs x2Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770045059; x=1770649859; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QLQJlIi1xp3GOgxJrSuyTGl+kKtHgLV5lTV9J+BYkDY=; b=JlswE9r2+Cip5zoB6hGL8POLfXyh5hg5m26AcrvvrC50B3nmePveX7UmNKTGoH6rR3 uZxLSnMqQG5dKMhYf1jlaScqIu2krGNjQui02ZDU70j/rogSjk/iI3lJcv+ctJYGx2Mr KZhh4WCBMGjvuhLSBohGzL11oGi3AZGzCl+of/1mkJqFXPOBfq7TBsn4AncWevHejqwb 1X5vF3p2UnKjjLXj6NAMey+GDeSMwGpkV1VkxoGm/s0rzDSmp7G0Wrnx1zEniG1YD0WT KLSOrsY2v7Kzqof0Fs4wlV5aJjboASKJ9FJrfTCATcVwCBGYc4XS7d9YPfH7W50mgOgq OgHg== X-Forwarded-Encrypted: i=1; AJvYcCVz9+PugjxnBFVBAxBO8AklNsUzRZasGG6ROVgOKx1ZWBkHYvXpe5b6km3dDe0sU4yrQjV6V2ljjPYxdbk=@vger.kernel.org X-Gm-Message-State: AOJu0YxWdmQucmdsb3SG3AYGYgjJSmSN0lPSRtZzqsdNCkux8KynLRXX jcQNRI8E7d1V5pQAriuOCq6yNrPkqlDle/mz7ZBw1wfgFmLhq4Q5zC0PriFeVrTwYzo= X-Gm-Gg: AZuq6aKGMwHSQYiiHsnQ9U/ZUlSFOjX/czpvYFgl5BsjVGcAEu9Z4jO4A1lU+vrt/em /p9X0X//ykmHEtlCkcecN1bnMvo6gcNtFtfoopJZZMbKIJEqYJhBMJ0yFCOxple+06yy2VVEmUS jDsTU23hiRBKDLImh2SapC+TMNaIR6XjZPHnqC/g4r4cTPEwmcf5V2AtNRXLzDaxIl6qwWnMBvy piahnbdsXDgkGLPKYDVj2083rO0J8niOTSjwq+lD5om39FhalXu6NZ565n/h32/Pt7M2HsHdSfX NjuauRlHS4xhPxp0eEcxSqChUId4hILB7aY8DqjvTeT508c2UMAI14G9xbHk0LhIPQw1at429Oh VqcNiZ9JuTgakAnP4sUY/r7q2VUQthU+lUeUjmpDCcdmixMgvYyPS1VrQd7HpXD6jr16HFu2x8W vwsnlxHuXhIqGRjyTfT3/hIRn1PSY= X-Received: by 2002:a5d:64e6:0:b0:435:982d:97ee with SMTP id ffacd0b85a97d-435f3ab9a44mr19652025f8f.57.1770045055569; Mon, 02 Feb 2026 07:10:55 -0800 (PST) Received: from vingu-cube.. ([2a01:e0a:f:6020:7cf3:628:f0e:cd4d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edfccsm42845021f8f.17.2026.02.02.07.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 07:10:54 -0800 (PST) From: Vincent Guittot To: ciprianmarian.costea@oss.nxp.com, s32@nxp.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Vincent Guittot Subject: [PATCH v2] PCI: s32g: Fix ports parsing Date: Mon, 2 Feb 2026 16:10:50 +0100 Message-ID: <20260202151050.1446165-1-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" No error return is missing after the loop resulting in removing the ports from the list. Fixes: 5cbc7d3e316e ("PCI: s32g: Add NXP S32G PCIe controller driver (RC)") Signed-off-by: Vincent Guittot --- Change since v1: - handle correctly the case when there is no child port drivers/pci/controller/dwc/pcie-nxp-s32g.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-nxp-s32g.c b/drivers/pci/contr= oller/dwc/pcie-nxp-s32g.c index 47745749f75c..b3ec38099fa3 100644 --- a/drivers/pci/controller/dwc/pcie-nxp-s32g.c +++ b/drivers/pci/controller/dwc/pcie-nxp-s32g.c @@ -282,12 +282,12 @@ static int s32g_pcie_parse_ports(struct device *dev, = struct s32g_pcie *s32g_pp) =20 ret =3D s32g_pcie_parse_port(s32g_pp, of_port); if (ret) - goto err_port; + break; } =20 -err_port: - list_for_each_entry_safe(port, tmp, &s32g_pp->ports, list) - list_del(&port->list); + if (ret) + list_for_each_entry_safe(port, tmp, &s32g_pp->ports, list) + list_del(&port->list); =20 return ret; } --=20 2.43.0