From nobody Tue Feb 10 07:40:10 2026 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5A2D376473 for ; Mon, 2 Feb 2026 14:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770044257; cv=none; b=rzeCj3H1M5ZU1127He3ScINzsfB7sryUg25df/NYOAdad3rMx3Tqnxuplb8KSNklkrk0nRPnzY7guNL1tShXqRxamQS/03/RuL4FMk+VtbPbiqMMtTnk6xj2xDC70wC7dCt/hH9n3iflqP3eKb2cBw4najHdyT1VHpHmV0D7lSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770044257; c=relaxed/simple; bh=jvIqWr/roJaqitIQaLbC5TmcuXVJ+whYeT8cykKkXQg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s2hwOFY2L+zPyuH+YjLgxXfSITZDrwVX+wmiF/klUv9OfnLkyfobp9CcJYpOMY1h0sq4sX0OEFDyQjID0uElziBxuDVybzj9QZTrUJwmucW+fNHk3L4khexHqwpoOW2Lp5jzF6tKMbnueBjRq7acvi9fw/PlidnvanP6/mlGHIE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei-partners.com; spf=pass smtp.mailfrom=huawei-partners.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei-partners.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei-partners.com Received: from mail.maildlp.com (unknown [172.18.224.107]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4f4V7Q6JvLzHnH83; Mon, 2 Feb 2026 22:56:34 +0800 (CST) Received: from mscpeml500003.china.huawei.com (unknown [7.188.49.51]) by mail.maildlp.com (Postfix) with ESMTPS id 6F48440584; Mon, 2 Feb 2026 22:57:32 +0800 (CST) Received: from mscphis01197.huawei.com (10.123.65.218) by mscpeml500003.china.huawei.com (7.188.49.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 2 Feb 2026 17:57:32 +0300 From: To: , , , , , , , , , , Subject: [RFC PATCH v1 1/4] mm/damon: Generic context creation for modules Date: Mon, 2 Feb 2026 14:56:46 +0000 Message-ID: <20260202145650.1795854-2-gutierrez.asier@huawei-partners.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260202145650.1795854-1-gutierrez.asier@huawei-partners.com> References: <20260202145650.1795854-1-gutierrez.asier@huawei-partners.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: mscpeml100003.china.huawei.com (10.199.174.67) To mscpeml500003.china.huawei.com (7.188.49.51) Content-Type: text/plain; charset="utf-8" From: Asier Gutierrez Damon_modules_new_paddr_ctx_target. This works only for physical contexts. In case of virtual addresses, we should duplicate the code. It is more elegant to have a generic version of new context creation which receives the mode as a parameter. Signed-off-by: Asier Gutierrez Co-developed-by: Anatoly Stepanov --- mm/damon/lru_sort.c | 6 ++++-- mm/damon/modules-common.c | 7 ++++--- mm/damon/modules-common.h | 5 +++-- mm/damon/reclaim.c | 5 +++-- 4 files changed, 14 insertions(+), 9 deletions(-) diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c index 49b4bc294f4e..ac34b02dace8 100644 --- a/mm/damon/lru_sort.c +++ b/mm/damon/lru_sort.c @@ -201,7 +201,8 @@ static int damon_lru_sort_apply_parameters(void) unsigned int hot_thres, cold_thres; int err; =20 - err =3D damon_modules_new_paddr_ctx_target(¶m_ctx, ¶m_target); + err =3D damon_modules_new_ctx_target(¶m_ctx, ¶m_target, + DAMON_OPS_PADDR); if (err) return err; =20 @@ -375,7 +376,8 @@ static int __init damon_lru_sort_init(void) err =3D -ENOMEM; goto out; } - err =3D damon_modules_new_paddr_ctx_target(&ctx, &target); + err =3D damon_modules_new_ctx_target(&ctx, &target, + DAMON_OPS_PADDR); if (err) goto out; =20 diff --git a/mm/damon/modules-common.c b/mm/damon/modules-common.c index 86d58f8c4f63..5ba24e0ad9a1 100644 --- a/mm/damon/modules-common.c +++ b/mm/damon/modules-common.c @@ -14,8 +14,9 @@ * @ctxp: Pointer to save the point to the newly created context * @targetp: Pointer to save the point to the newly created target */ -int damon_modules_new_paddr_ctx_target(struct damon_ctx **ctxp, - struct damon_target **targetp) +int damon_modules_new_ctx_target(struct damon_ctx **ctxp, + struct damon_target **targetp, + enum damon_ops_id mode) { struct damon_ctx *ctx; struct damon_target *target; @@ -24,7 +25,7 @@ int damon_modules_new_paddr_ctx_target(struct damon_ctx *= *ctxp, if (!ctx) return -ENOMEM; =20 - if (damon_select_ops(ctx, DAMON_OPS_PADDR)) { + if (damon_select_ops(ctx, mode)) { damon_destroy_ctx(ctx); return -EINVAL; } diff --git a/mm/damon/modules-common.h b/mm/damon/modules-common.h index f103ad556368..87d8058d7d85 100644 --- a/mm/damon/modules-common.h +++ b/mm/damon/modules-common.h @@ -45,5 +45,6 @@ module_param_named(nr_##qt_exceed_name, stat.qt_exceeds, ulong, \ 0400); =20 -int damon_modules_new_paddr_ctx_target(struct damon_ctx **ctxp, - struct damon_target **targetp); +int damon_modules_new_ctx_target(struct damon_ctx **ctxp, + struct damon_target **targetp, + enum damon_ops_id mode); diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index 36a582e09eae..b64fb810e096 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -197,7 +197,8 @@ static int damon_reclaim_apply_parameters(void) struct damos_filter *filter; int err; =20 - err =3D damon_modules_new_paddr_ctx_target(¶m_ctx, ¶m_target); + err =3D damon_modules_new_ctx_target(¶m_ctx, ¶m_target, + DAMON_OPS_PADDR); if (err) return err; =20 @@ -379,7 +380,7 @@ static int __init damon_reclaim_init(void) err =3D -ENOMEM; goto out; } - err =3D damon_modules_new_paddr_ctx_target(&ctx, &target); + err =3D damon_modules_new_ctx_target(&ctx, &target, DAMON_OPS_PADDR); if (err) goto out; =20 --=20 2.43.0