From nobody Mon Feb 9 03:10:51 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A1FA3624BE for ; Mon, 2 Feb 2026 11:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770031965; cv=none; b=n8LRt3JklwR/D+HQwrmrdqGMfhwxHFUljAE1j1nASiXNke6ux7J1oysSdZOOaUdf76fMSiQeBG53Rt/LbA1c3k8rl5p/FPS2WngysxLrIv80gtStO3IlOL8K4kSNE+Zg6KhOYZdFRgj53TcPCNXhlwOP200Q/FyvW5SA9lsC938= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770031965; c=relaxed/simple; bh=mXXZ/E8iu1icugw56rUDGM02NHGVORn+CKASFjCuOLY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=REsxkLPbvsg83x/HGJvjKZqBswMick6mo0AlVZL5xX1fHMo4BQgOGggaeRkd4CKmRrDH8fMeynX1l1ItgAtm0cMBRrTn95nerkK4G2qYqI1x38AG4gb1vs0gWkt+l5Y/VRFR8t07XwNlzyQaw54GvKetTqaraNlN2Det1r+uC0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IPStKWyw; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IPStKWyw" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-81c72659e6bso3834664b3a.0 for ; Mon, 02 Feb 2026 03:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770031963; x=1770636763; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l+souS7YaNTH8HrRQ+fNkEhlVU7efydlW/fF0+nylSc=; b=IPStKWywAd6GT7botAZvDrXyxJCBVghn0tlVaWymWaC635+BE6dDjH23Xbedw9QZS1 Dh71ebqcBQ7FypNOvHyUqWsXK88qRcoR58U6uy04Gj+VXDApviCTnK1tj2tAOJNYpSLn Y4aWinaL5TXxc16XGeS+MOixpdH4J/TOakjFYYfNRaiOwfebjEwFkSct9m8J+FhgnGsK TeTFljB7FpqMA2MLuZK1kR5DsUv/Sxrmzhp/mV95EYt8Cprv3wIcIxERhlEyu3KGC5wU V+Dctyr+w349wsX5KUGJQyj2XZlZjpb0wM+oopwIAdB/NO+59IozAh3OHvsRvSD9u7yZ R0Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770031963; x=1770636763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=l+souS7YaNTH8HrRQ+fNkEhlVU7efydlW/fF0+nylSc=; b=ERlVlE/t5rHKrb8JTGSIUrgbC6WeT81LO3uPRJh7HSrTQjKBtjDeJLdO9UXfGwMS40 PrEeeuWFLYQfqKaP0oF1+JIjFp3G0L4gaw1EqL9gZOX2bm7X0ZmlSQ/FcRgkenIsWrXY j7atIoANen+8QLhhZxX+GmLO11WdJ/9YvOjmWI+2lHDsJo6RDM/H7CVf4jTNLypzefh1 y/XPzHEzlDCqqwubJYgQ0qGpVKsSfWZpXnoQtKbqzNsDHtNFIEaLUFak2GXH4N4Z7Asd M/5h6in3muQcuo/WABlkDJMxCttGd1kSmML4yheuqyDZvacwpp5fwK9ztudYZTizToBL ThBw== X-Forwarded-Encrypted: i=1; AJvYcCXcbtmvpkK7vrNTVdOMJWu3fQNHTpE7OAQTNpJ7LvBs1oUnw0X5LBb3jRU9c8tSTEx/mdg9JAheFOjnw9M=@vger.kernel.org X-Gm-Message-State: AOJu0YyZAsAqng3ZvfX7QbckHUIm14oQUWIFeeq7/rprV3vizbs8KHxm 8AzuScDhvDpU1vyQHGNBb2yigTD0E7yRWzMW0hYR6DIZ3yYbliuNegnZo6qXJw== X-Gm-Gg: AZuq6aJXeXKH4HACOqvIpLijPLUp7rx3MnzhbrjzubIjs0Bz/8o7dXU0E+YtJnnNzml 26Wcv8tZq1b/zsFsSXD4TR4Q+IyuzaBedKEGN8B3Tv1gC2czkQbKw/yXCKQahKe7akjPC7/pIJE ofjtkTHNA/rxEI27wUNJwEKDFOxWjXSi7mNVCxhgbK8eN8uTtJeg8oxxKy02cq4E2dvcFKrcItL DbMycglmEWW1XP8la/3rGiBABx0uEqQVLbWToQWDpzqegHBGolXkSgKCMZwLcx0SFbyLYQM3tqX FpHP9YUY8SDNNo8WoliYETU6BUFtX17kx2MwfkhG+yRRfh7xFSWE57oEQibc3NAvK3AczaPYsl5 ubluFmpDz38Br7BNAeKYcWlHD9Xac4CVuId7T4VwYDmsh9iOVid+xbPrO05qSQD5nhmCdbzxh68 FmdEqOZEye2u/lI/Hmuz1mcl/Y4S3qKld/yU0Phg== X-Received: by 2002:a05:6a21:7804:b0:393:8fc:5284 with SMTP id adf61e73a8af0-39308fc8453mr4806502637.70.1770031963552; Mon, 02 Feb 2026 03:32:43 -0800 (PST) Received: from name2965-Precision-7820-Tower.. ([121.185.186.233]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c642a9f539dsm13743190a12.26.2026.02.02.03.32.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 03:32:43 -0800 (PST) From: Jeongjun Park To: Inki Dae , Seung-Woo Kim , Kyungmin Park Cc: David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jeongjun Park Subject: [PATCH 1/3 v2] drm/exynos: vidi: use priv->vidi_dev for ctx lookup in vidi_connection_ioctl() Date: Mon, 2 Feb 2026 20:32:32 +0900 Message-Id: <20260202113234.183393-2-aha310510@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260202113234.183393-1-aha310510@gmail.com> References: <20260202113234.183393-1-aha310510@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vidi_connection_ioctl() retrieves the driver_data from drm_dev->dev to obtain a struct vidi_context pointer. However, drm_dev->dev is the exynos-drm master device, and the driver_data contained therein is not the vidi component device, but a completely different device. This can lead to various bugs, ranging from null pointer dereferences and garbage value accesses to, in unlucky cases, out-of-bounds errors, use-after-free errors, and more. To resolve this issue, we need to store/delete the vidi device pointer in exynos_drm_private->vidi_dev during bind/unbind, and then read this exynos_drm_private->vidi_dev within ioctl() to obtain the correct struct vidi_context pointer. Cc: Fixes: cf67cc9a29ac ("drm/exynos: remove struct exynos_drm_display") Signed-off-by: Jeongjun Park --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 + drivers/gpu/drm/exynos/exynos_drm_vidi.c | 14 +++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exyn= os/exynos_drm_drv.h index 23646e55f142..06c29ff2aac0 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h @@ -199,6 +199,7 @@ struct drm_exynos_file_private { struct exynos_drm_private { struct device *g2d_dev; struct device *dma_dev; + struct device *vidi_dev; void *mapping; =20 /* for atomic commit */ diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exy= nos/exynos_drm_vidi.c index e094b8bbc0f1..1fe297d512e7 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -223,9 +223,14 @@ ATTRIBUTE_GROUPS(vidi); int vidi_connection_ioctl(struct drm_device *drm_dev, void *data, struct drm_file *file_priv) { - struct vidi_context *ctx =3D dev_get_drvdata(drm_dev->dev); + struct exynos_drm_private *priv =3D drm_dev->dev_private; + struct device *dev =3D priv ? priv->vidi_dev : NULL; + struct vidi_context *ctx =3D dev ? dev_get_drvdata(dev) : NULL; struct drm_exynos_vidi_connection *vidi =3D data; =20 + if (!ctx) + return -ENODEV; + if (!vidi) { DRM_DEV_DEBUG_KMS(ctx->dev, "user data for vidi is null.\n"); @@ -371,6 +376,7 @@ static int vidi_bind(struct device *dev, struct device = *master, void *data) { struct vidi_context *ctx =3D dev_get_drvdata(dev); struct drm_device *drm_dev =3D data; + struct exynos_drm_private *priv =3D drm_dev->dev_private; struct drm_encoder *encoder =3D &ctx->encoder; struct exynos_drm_plane *exynos_plane; struct exynos_drm_plane_config plane_config =3D { 0 }; @@ -378,6 +384,8 @@ static int vidi_bind(struct device *dev, struct device = *master, void *data) int ret; =20 ctx->drm_dev =3D drm_dev; + if (priv) + priv->vidi_dev =3D dev; =20 plane_config.pixel_formats =3D formats; plane_config.num_pixel_formats =3D ARRAY_SIZE(formats); @@ -423,8 +431,12 @@ static int vidi_bind(struct device *dev, struct device= *master, void *data) static void vidi_unbind(struct device *dev, struct device *master, void *d= ata) { struct vidi_context *ctx =3D dev_get_drvdata(dev); + struct drm_device *drm_dev =3D data; + struct exynos_drm_private *priv =3D drm_dev->dev_private; =20 timer_delete_sync(&ctx->timer); + if (priv) + priv->vidi_dev =3D NULL; } =20 static const struct component_ops vidi_component_ops =3D { --