From nobody Mon Feb 9 04:44:39 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011033.outbound.protection.outlook.com [52.101.70.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD4633343D; Mon, 2 Feb 2026 09:59:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026383; cv=fail; b=gr2QZdFh4wLPOBZu7MVkLdUCBD7gMRresN/qDSK+kawI1UxzH3BJHXuTii5jXJogFO9jMPQ8gAZ3r882Gbj17o35KbiaGf8MpQpuFY7Ww8Cv4/BuAoN4zl7jqRLrr/Qkz360K25YuSd6tnOeC8Za3R4jt1m/KJ5+KlYLQLsD4ds= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026383; c=relaxed/simple; bh=cOGiiu5JGnU3kXf7mmwJqKJLxtvooq1m2p4IePYwjGM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=nVki3VCrCTmPPgG3VbUaA3dnVIk1u0iYj3VyVTY1b2zzHXm4GDmHz8kp7EABxl9dKVdAgB70Z8JGJWkgdynYdmu+ieDFWcrh/HSsmyMJzgyjSungpSJ97YZkOprwNdJ2KVCTo6Fl1bSwCkHTz7namdw06i3q3oLoyneC5dqPNzI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=DDffLlpO; arc=fail smtp.client-ip=52.101.70.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="DDffLlpO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WPnMSyulPYRu/kKfMOfJWzPxuF/MPSTRpA7ndYlXk9veaTXzGzJIzpMNYye0tvT4mIELFhiSw1TooU4qXnbhFl38wuT/BmMm+Um07KmgJITuBEZF7N4y1Vgi+QT3zf01N1TEIuKYefGhYk6/h6GyPX9WX0XIZr5mLc/58ZWfazQgwrCEy+qb09Gt7PJaUdn/Z5bypitG5/v5CsI9CzgNyZTKqAAka59A4cX8e/SL+4mZgHQqdDWmziEgdc0h4rTAjgVqrJBGFmtVOOKS+XDgp+EFFcb6jIgASEE1CItmxQ1pGpoluYU0rJ/JdFd3CF0W5rjuBWrUVJhBJBCvqPeTHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TJfTIh2o2CFn2GacROj6QyU093eEqXT+XuL5cbsLKGo=; b=AmnO2csidTpdYAd2No8a9hNQhXuXcG6Brfc+gUEhGTbJk8YqsJEhRHLhV3aR001356FvBZrCKqiueALkTmAyWVsSJ+Nf6vlB0ZDvSq3WB0ZTla442d0WsX20s9SAs6p5YeGpdIrsP8ElLI6zu1FtlDnYRovFNZrIA9tan1XmCEREKWx8yWWVLDLN7hMTDAc2O0oYoMGgUANWEhgkUUCNJeSkz3wupR6MpqMh0hVAHvE2l025Z0fQ9WED+6YBtzAZKOsAy4NbVoV3e+KqqOUuBjkn7903yAyph/pain3KJ6xo/MUtFau9y17Z8IXHeLNg5F8tX29ncX/MZWm9ZxGXUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJfTIh2o2CFn2GacROj6QyU093eEqXT+XuL5cbsLKGo=; b=DDffLlpOLrAuyNkty0zLzx07J/rp79mLiFdFXNC5mHiNzy5zxUcDXl+dr/aroshNQEqjKAabJ5lEeU6FZKh6r8/utLKtc7YpE2y1H9uIDRbvqc0vqh5UV7R3Sp7OIbOFTL71sCGodxe/zUAcfIhLWyb+kT6nYVGJhlBj0TipJwmfotOW/3gNATjg+S63d03z64GR3IbsR3FNttM2755wjjH2nWCS5gO1nZmZ2ih3cOk1dP8eeSONhB3ofrTwG2JKmFlsI1bWKUjeZDT9PDx90sryhbBBuXOX+b4VuQiOjL09WvYDOQUOm2idItBf83l5X7/pOHEyXDKhFBtnwJJcog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) by DUZPR04MB9726.eurprd04.prod.outlook.com (2603:10a6:10:4e3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.16; Mon, 2 Feb 2026 09:59:38 +0000 Received: from PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87]) by PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87%4]) with mapi id 15.20.9564.016; Mon, 2 Feb 2026 09:59:38 +0000 From: ming.qian@oss.nxp.com To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, mirela.rabulea@oss.nxp.com Cc: nicolas@ndufresne.ca, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com, linux-imx@nxp.com, Frank.li@nxp.com, imx@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/3] media: imx-jpeg: Simplify descriptor initialization with memset Date: Mon, 2 Feb 2026 17:58:34 +0800 Message-ID: <20260202095843.1030-2-ming.qian@oss.nxp.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20260202095843.1030-1-ming.qian@oss.nxp.com> References: <20260202095843.1030-1-ming.qian@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR06CA0188.apcprd06.prod.outlook.com (2603:1096:4:1::20) To PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8254:EE_|DUZPR04MB9726:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b0ec59c-b3cb-4e20-c2a3-08de6241c69e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|19092799006|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dOPWfQu33PupCZgIc0pN3UztgaUAP7yMusVPk7QNqnfDESAdMMxesrQSPZH2?= =?us-ascii?Q?60MCJisgovf8ZO5u+MSJiCYFLP7xm/kf05AO5lQJBncINmaAAjC+1V6iWA2X?= =?us-ascii?Q?4rzG5vQoUOmPMcBFUSJ+d0rr5+2Dv5oJ577q/ZTmlHaRIwiRrhE9/hZ7Iylr?= =?us-ascii?Q?QFzQNyS6gSogxuWfj2hQxAveRQsF0Cfk/GDCuzeyGTSOLQD/+pctFGOoBk2Z?= =?us-ascii?Q?YS6fyKDxyZ+QsNzIsCQBE1/SLeBNe0QT821gGhKsYBmsuDqYo5Y/LsAzfA8E?= =?us-ascii?Q?LjrX2pAK1FoZzZJvL4QQQjI/HAGHbHCGiuQLlI1Fc2Xd7AP4SCIup90Y7xPX?= =?us-ascii?Q?Jowf1DoMRVSKQvM1VO/Uk8DeWMoiLQl+gPQVJ1TaZLTS2dtM48KLiGniPhfP?= =?us-ascii?Q?Chrj1+ElnXLbmWF+SDb9XbLgje3xetu49Bpt8zQdVE6mqJ7xl/zh+8VyjTeU?= =?us-ascii?Q?FC7aLcSWlR/VrNQmt9H+c9pTs/6CvX7yEWNRfYVaxo0HeiyRTU/c5l8SEraL?= =?us-ascii?Q?gALwxzdufyj4qgQiT51E1FMEVbpX3AW4PEBQ06aZXxqE1evMUW68arQHG3nz?= =?us-ascii?Q?LdO42Osl/iR+5h5ZAkTfFOLCL64PkERcT7QmFxDNZ2sl4nrwuxZtDpBRB4D9?= =?us-ascii?Q?taj3aFN7MKgUQQPunOLOvIAD+bJxamPOzig2OXUwu41dTbzFaIlbftq5u54k?= =?us-ascii?Q?RICWhKpIEGiRLj1AJ6/Hntb9MSCbcZ64DQSj1dt1gXVXGaMTB5uIWY59E3Yh?= =?us-ascii?Q?54+oSr0E03MU15XsjjFgrdPShDI04pqAXviFhKladAMsLrRlbGz9EQmKQ0rL?= =?us-ascii?Q?JXJ0z7tWtZl2p45zCIro8xyDU1fzwoJR9ynq3TMX99jiaSorEPHH9WdZX4nE?= =?us-ascii?Q?Wvzxid5kaKAnNNEkT98/B0fb1Hot/5Ik5OCohjWQWrnbteMNx5CbNnWk+15v?= =?us-ascii?Q?/9v0iockkXtISRVGlBJgo866j2z9E4QL1u/PYuTKt/BI//ykwqvjcDg93M8t?= =?us-ascii?Q?FrpGt4Pbr2wa9guGXlNrRESLCqF6/Ja0gyIoQoc88l++JWCM/nop0K9ZSL9r?= =?us-ascii?Q?iKtuEeEOsYN/K0MM0Sqv7pIVkzYBC1GW65RRFuAaSyGj8SQ4wRdjN766jtAp?= =?us-ascii?Q?a5/Qo/zp2S5RZA2vnsHfLqKADcB89OU2Lp7W7sdjQE8u7utFS2wLku+SsoIK?= =?us-ascii?Q?ACA28d555CNn+a7JaPA1klF/cvA8i1hGitNLSma/bWXQwDBFDYybRXYAIMNj?= =?us-ascii?Q?ORbxaMvv6arYbc0wJURxmJj1p5wLMZHV+MXFaqY1o/VqBU6O+2TVmhviQpQX?= =?us-ascii?Q?genl56M/CWt+Sb0QTtbgECtbG2JGku6zLmOUDBDm+GI6GK6ywCGw8uFnMgVa?= =?us-ascii?Q?++VIQ6CmVW9Kt1T4R+puD5351ypo2RFtfjJGx3HPZcNfbHyZdFj5jN2yEMgW?= =?us-ascii?Q?R3l1COA5quEn4OZf2mO+24nRloB6DmZq6C98IH3qePuA1CFC4zs61nyDyQYv?= =?us-ascii?Q?1HcPfnMug7Yfsmwa24vgK+u4YorXLXCuv1LCIk5DOe9bkWv4dBe1Q1pAFtc6?= =?us-ascii?Q?thqpYstZKv3eYrkRLcSNV5/KsRy3eSWFw1Tn1rRrT4nzkqFQjpg3KSnr5OhP?= =?us-ascii?Q?oSwBNkFZyo66MF0qdd8qYkI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8254.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(19092799006)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KA6v4VG7KK6UDymdF40PjxZu9FN7hc20xs90WVI9YBWzUQDCBpdd0sClrBEc?= =?us-ascii?Q?3sxcTYM2LZZIIWmPmoIa+rgZ7AiP01KO9D3ET0HOWwkiSKq9pS7y4v67MbPa?= =?us-ascii?Q?B5t25JwGB+geioeq3sXfKJaA65kkTmgVxuKEu8412HViACHW5miekG4ssRHp?= =?us-ascii?Q?IK6C8cxbXWsArLpl2tJ7pEZjTYFsa5RIE5cnxNJUoWMil13ib1jKBHEFuDEH?= =?us-ascii?Q?c6CL5r5pK0Qux6tY/5SYoVsORevDW5vYG2Q+xHXqoJHcpVzYRBoEyk1naoR9?= =?us-ascii?Q?Vyr+l9e9n38SLKYyKyW+BBlsJH5C1VjzLfRreF5RlyGIsK98iXj8+3bk1Rqx?= =?us-ascii?Q?IiW7m2Rc50oDH6J2L3DM2YYHfHXP6zIcaDbXxuk+HC3UHswAMWkwGT5ZD9AO?= =?us-ascii?Q?KH0ZI251iKVnAEHbNBOI4/U/jxMfQfY6Zi0vXXo2ilNe1do7VEHKJgXFctrt?= =?us-ascii?Q?q3q+gJ5fg3kbPC1KrTBsEFbv67Vqob0Ti0Fn+mn7VAvADbOLix2WdchfbwN6?= =?us-ascii?Q?v7HinO9CgHEu7Xx43/vGtByBJG7LlvGUep8OmIIBpwNHWVkBcrqxEVUnnZy0?= =?us-ascii?Q?xoz1zJ7n5vH0xWxbmc6PjnV1JLGgyXVlFuAGCUVxTrhxSA5hSIRur+d5qqOR?= =?us-ascii?Q?lHBI73dY2WB8BSn84ML4/GPIax4f/puk44QJWRKomCGxRlFLFwR0Az901mDZ?= =?us-ascii?Q?BHK218+7qxiUWdAgCAxYj1o0cwBeqE/jzZQSxR5qXBcNa/VV1dySvByjr1hO?= =?us-ascii?Q?zMX1vnrqTdVkOu9qwOKjZEc1VjiYkrBrD596JtlztGsPHQ39YO7sViQ5A1PJ?= =?us-ascii?Q?ua4j9Li0j+Zaxq8owm/5XyT5mNMlkiDmObY0q1SMKXq8GINiJRTSE5f34b+X?= =?us-ascii?Q?jqxk4ZnyiYYZxhFtn9MBnShcqu2D6e3SfChbUgU1TUIienulSR7O8TuMmTio?= =?us-ascii?Q?OMAmiYbc++15n1CxXAh+3ZyXuFby+TcKOK20ePMFvCkZKrOhfKVD3DT6tz8P?= =?us-ascii?Q?mYUJeiCJ+DEDNCGrawkCSy13Uwu392DHb8RP953YneDWG9wcetJjrRrIGw5g?= =?us-ascii?Q?hWqE/iosgfGuPMgqVWdBAMbmonb/E3F5DYRbvxuBxBAjHiESbL52AyqmUUil?= =?us-ascii?Q?i3dsSJvinHW1vSpGOoVJnB7bl9jW59Phh16kCdQ1iM2crF3uKKGPZ6hel94V?= =?us-ascii?Q?7K1XE+OS7V/5MbkyxjvieEbb3WNAxpSXQVe943tshYkJqe/LWCMjr4ES9Uqp?= =?us-ascii?Q?VcIqJ5LMQK8/MpPpsI34lSa3RWGGIfbfdn9ZJwEa2VgDctbwZAloC3GggU6Y?= =?us-ascii?Q?EBjsjySTFR11uYqgRR9EYwglCmlMwuQOiwiL+59gDbnGdYSXyFaFBOobR4hM?= =?us-ascii?Q?ZWDjDvP1omb+GGFjEDJpSxNUiIK1lNfTw5T2/MJPDlFwj5XSpExY2YQit/P+?= =?us-ascii?Q?+KzqldJiUC+4Jg+RMHrSpS2wjuapr8PuhFV4u6xHPxpVA1VQRJXxhdhLjvH9?= =?us-ascii?Q?E7+VtxlHUvu5ci7dIaVMgGnbfs/zrady6EHM+zoCW+V5vjLXSVxTVvT4LjwJ?= =?us-ascii?Q?IScdHn20Rx+/I8dZj+B5bmhzjfrj/gM6HUVdWn6TqmhqE8/EWqxtjRo725fD?= =?us-ascii?Q?SpC8+rcNRwe2+oeT9WJO2Ct+8JD6rTu/bM7jbNeBcJ9Dti5yuKKL/An5Kkg7?= =?us-ascii?Q?bv5H9XMQLIo4Aub+MevW3x43soanUMDBO+tYJyrGDxEo3T4xIRqYCSLQ84N7?= =?us-ascii?Q?I9Epgx8R5A=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b0ec59c-b3cb-4e20-c2a3-08de6241c69e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8254.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2026 09:59:38.1694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3rWTWrT1xgVLeFB3yD7rHdjaYwnY8t4epI6FRWsDMCi+BTYWIbDNb2oYf9HsbIgC9MhIxrx3+e4Ur/ZdvCVYtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9726 Content-Type: text/plain; charset="utf-8" From: Ming Qian Use memset() to zero-initialize desc and cfg_desc structures instead of assigning individual fields to zero. This is cleaner and ensures all descriptor fields are properly initialized. No functional change. Signed-off-by: Ming Qian Reviewed-by: Frank Li --- drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media= /platform/nxp/imx-jpeg/mxc-jpeg.c index b558700d1d96..39022c1bf36d 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c @@ -1338,6 +1338,8 @@ static void mxc_jpeg_config_enc_desc(struct vb2_buffe= r *out_buf, =20 q_data =3D mxc_jpeg_get_q_data(ctx, src_buf->vb2_queue->type); =20 + memset(desc, 0, sizeof(struct mxc_jpeg_desc)); + memset(cfg_desc, 0, sizeof(struct mxc_jpeg_desc)); jpeg->slot_data.cfg_stream_size =3D mxc_jpeg_setup_cfg_stream(cfg_stream_vaddr, q_data->fmt->fourcc, @@ -1348,11 +1350,6 @@ static void mxc_jpeg_config_enc_desc(struct vb2_buff= er *out_buf, cfg_desc->next_descpt_ptr =3D desc_handle | MXC_NXT_DESCPT_EN; =20 cfg_desc->buf_base0 =3D jpeg->slot_data.cfg_stream_handle; - cfg_desc->buf_base1 =3D 0; - cfg_desc->line_pitch =3D 0; - cfg_desc->stm_bufbase =3D 0; /* no output expected */ - cfg_desc->stm_bufsize =3D 0x0; - cfg_desc->imgsize =3D 0; cfg_desc->stm_ctrl =3D STM_CTRL_CONFIG_MOD(1); cfg_desc->stm_ctrl |=3D STM_CTRL_BITBUF_PTR_CLR(1); =20 --=20 2.52.0 From nobody Mon Feb 9 04:44:39 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013019.outbound.protection.outlook.com [40.107.159.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51545356A12; Mon, 2 Feb 2026 09:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026389; cv=fail; b=qI6IntU2+nr+Ux5bBbi2bTnIjuW9PruIJA3sMIS2UkQgMy//qeOlLW15l9CHTVtEGKBIRA92V8rwG5UZxiziXT3z0MLYWSp+7Xo44mc3mA8KZnImOaPjIoJnMipWGk+bS7g/Vf5YBDemMfSxitU9uVJ1x9RIwgTbTLoPa7bIfeU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026389; c=relaxed/simple; bh=Goy9Sup1d1F+i115Dh2jbgwoMFyFl4+lkoSF08wf1g8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=jrgoU/CRT7rUAv2SW2Tcx22fpEC1cYvgugu2dgNmYUTghSWTuA+QiGMP10W02S6oPkkF17v8Mg7n/hStACuepwAuyfx/wLZeZgLz5NMKOS1T9Jv33pVOIFjThRh9xRWnoctLujeJYR/hKMbNeOTGlYdfmP7IVhAwWBokfjHiQrg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=fsTi0CFN; arc=fail smtp.client-ip=40.107.159.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="fsTi0CFN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oVE9T95qS/gxxN9wXcXbbs6Z/WTb2+U8IV7psd4DZKsdnRbVyICXoX11gEFbmxCgATAjofqW2Xm73EeWbylamgy+NnT249eDGvaTVOZsWMNYGGsjTTLElGMb3AOi2UTFbkFiIL8t01q6BV7MkPXE+M+njFs5JJCKo7iGk1QJ1Vje97wkezZBjIBZ0qEV8KnEJh8ncjfP/NJlbUtNaz3Fsi6v819lxsfhnWeUFIFmvmNu0f9Qxu2hJMb+/I9co4F5+1X/ntgfEeRJF9zkmWuQywQzXvvTGypaBSMg0G8Jf/CmSR+Rcyyy2/z+Te8x3gdxMLB41lGPkEQkuiZACP//hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qLf0FsMRjGe5K0pKOu5rUcsYypKS1yvGOLWeDxy63QU=; b=HM4M1Y3kqQLDax9WwKWazRc+OuCqIqZ5P59hZafjNMahN0hv+s/v5K1YweA+3x2nVGCa6qtUsI7lX8xu8+7L0vMBVgmvHbMMKj/0l0uz+IAKOnnrPDaAPKSNT6BMK9XnouIIsVzbrkbzYzCZtVrpOrv4eYWmxG2hdWXd2j3WI0bgg9kOE7r3o53X+cautgWMwWgZXAWfYbpYiHDNzJKihUTR8j/WQOOuxzudrH5LBMJJBOISnwnAeLLKe0hyZ6lScJUmh8chbJs+VpSN8Z3kkO42mRRQxe5j7tEOprEB4gI4IILEpdiU6CaDi0nnbYHkcpqtLuqalhHWDrdENO9MJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qLf0FsMRjGe5K0pKOu5rUcsYypKS1yvGOLWeDxy63QU=; b=fsTi0CFN6jAoZ53s88eZTYSebSw+pQQkRuM4WHm6Xp/nGkav2fKnfbLFcn8eR69Clrbrcown3hsPslXnYSlkldrCjXCrgcbRA4zVtJQmi68yUM0WupUxNj1t4ooXHI2+QhdMlbJdn0qkMtNmSrovNI6JQTqPWXzBS9jFs0J7N0qrstwVofVJXHu4a+HDoXlZthgfwmj39vFScYwW36Ee5x0UFwksdm01zEbubcc4Hj/IR5eAfxAseWuNAocaiLodUI+TRv6IQwg9MgCO3SW3wQkDe0OfP0NG+84A40/3xnBUaybSsXuGd911vFKup0uQ1jqJGSTUjO6mAOCXU2TaqA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) by DUZPR04MB9726.eurprd04.prod.outlook.com (2603:10a6:10:4e3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.16; Mon, 2 Feb 2026 09:59:44 +0000 Received: from PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87]) by PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87%4]) with mapi id 15.20.9564.016; Mon, 2 Feb 2026 09:59:44 +0000 From: ming.qian@oss.nxp.com To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, mirela.rabulea@oss.nxp.com Cc: nicolas@ndufresne.ca, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com, linux-imx@nxp.com, Frank.li@nxp.com, imx@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/3] media: mxc-jpeg: Add encoder ops layer for hardware abstraction Date: Mon, 2 Feb 2026 17:58:35 +0800 Message-ID: <20260202095843.1030-3-ming.qian@oss.nxp.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20260202095843.1030-1-ming.qian@oss.nxp.com> References: <20260202095843.1030-1-ming.qian@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR06CA0188.apcprd06.prod.outlook.com (2603:1096:4:1::20) To PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8254:EE_|DUZPR04MB9726:EE_ X-MS-Office365-Filtering-Correlation-Id: ee20ddb3-a594-4839-8454-08de6241ca0f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|19092799006|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Fx/BMJhviY1QLrISefMUlZeYYYGMnQRcJALoY23fDuUOy/aUNfxD0KYJ55zj?= =?us-ascii?Q?za6mcdfVnF4gDI7r8VICbYQAmJlUwfJ+tnzgg6EI7+nl/uhAOFE2rnMSsCih?= =?us-ascii?Q?nMXicPTwz+qILJLm5rabmrpk1Ocl9J7Xec29XPKqFjIdQp5Klq8kMw3iEcKv?= =?us-ascii?Q?XCP1ucNWKJ3Jut4fYWDNmox12540azrJRCZo7ExvCxJJO0v4WPY5PvW0AIF6?= =?us-ascii?Q?JOVsxhOmPC/GODzlyy3DMrpfpWhedYw6J7loiIiO3YrA01bBYNRnc/HoE+xV?= =?us-ascii?Q?iLv+oZFfDw5Y/MG8TzuMBlaD186bWBqQrfLDbEP6uLUZGAiY7ULj9W5C/kI8?= =?us-ascii?Q?8aqSZTmrPrZoqt/gvpCmZnr7ON/FwlcUdMGFqWL6kZPDN80fUL1g4C57oRfm?= =?us-ascii?Q?II+RMp8IoMcdiPB9IJBeg5HOGYu6KEXqJgju7221OfK4/eNp3WnZAIMn+9DF?= =?us-ascii?Q?fhKSGka3mp9mnx6dzt0eJ35qJEz3wOgHFx4mnvn1LTDPhf8K+YhI6Eoueq+r?= =?us-ascii?Q?00/3GGqHBR98+cIHuaVFYQt3Au+ItOIzj8UIcZZZY1NYPT3J4AXnd+33cHbC?= =?us-ascii?Q?0X+0UUq9qU8fTATBIKzOEFlEagvLxi2LXWDjevbOoBiLJzgRwXhwd+wM6NSV?= =?us-ascii?Q?jZ01n6Wd3iJKhYQV92EJ79UlGWSQNnt90mrU7zm5UZUyx12ZkyYEdb13Jdsb?= =?us-ascii?Q?ZDLVHEz1n1hgbEhb1gkei74EDoGDQxoWmzIv94mkarXNZtEPRVgeSuhTBzGi?= =?us-ascii?Q?R1DRAO94Ve24CRUbjTyjfNlVGFNJU4sFVlhg4RE7NdL55Av3HwzRs81cC3Hn?= =?us-ascii?Q?FZKyqZ31zcH/tXDdKMXXfpn8uniXJEGWQyNO2kJXgRHs3eZPetA415R4gD69?= =?us-ascii?Q?q/tLS382G7EUu4d+RabHuP1k+I0yzGoe038XkX4B0A6sKNoR/m21fIl9TEJY?= =?us-ascii?Q?hyHn/ars3gElQG2D93kyR1YfnnhCvKq/yVKheGDv5FP/bEju1VWPrZs/ctoB?= =?us-ascii?Q?8TdR2+QT+T1IEo5sEv/fgCH8bC6CpCXBszbTx7JWl1wG2Y+qkWMnSvnvFcgn?= =?us-ascii?Q?8rdj8eHPo41tsm/+ytpMUJNQfOuyk1XvspGyuRwmp96iChUdgseVSuIdXyVC?= =?us-ascii?Q?zwT3smWARqPz2lsIncJvZ2KyK088NRXmeOoZCtxJM32l+rerec4TH/oHY0jG?= =?us-ascii?Q?RDM7kL/M+RJAyN4m7vtzvpL0f/ULpOdO5qOMtmI+dmGY1Ogufk7p/MbuTw4u?= =?us-ascii?Q?4wdBn4jbB/24rPEFLAkIAN1/Gtd3Q2+hjl3KtfpgCdCdhJfCBVsoK9EzOUA4?= =?us-ascii?Q?rUcyf93Zzc/KRVw4DaODFVwVyDqcQYP3wtcmPqxYzU777ivlbqnMX0a/xjkW?= =?us-ascii?Q?9VHJvlRZ3KvsYZpffRFBxKKaQq0csWy5Sxx+BtePCqpRNP4nFEKHR45szEJe?= =?us-ascii?Q?ZTLIk5aEKYtkvDEbPuwutolCxha2ql0Okl9gwjmc/bod2FptzcXOwdp5XlD6?= =?us-ascii?Q?LiRCq9ZxQzB/05xjbEasnyzkkTaKXQsDd+JDUzuWPKvi0OKwVdUx3oibFm4m?= =?us-ascii?Q?nkKvzjitQiWRTV7z8QMTY7xyP6Oz8iV/dnQR7lwOuuzh5NTaUoOmDh6rD8wQ?= =?us-ascii?Q?stpKo96vwA9gKwOm7JTBgPc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8254.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(19092799006)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wecc/yzJ+8Dv4j2gbm/COpT90bfS1XWghK4Oy4TQFAT3PqKhpbhxTMn7Gmkf?= =?us-ascii?Q?gd0IeYo5sLiv8WTBJ0m5kD+j07aYPzddpF93bMAxikyBRAOSuDji9Iu/lwse?= =?us-ascii?Q?zTG98SQ2SWs2g84YC1zsYYXwBS0YU6sncpdJAmi9QpLGTRmv04N78QcKnjnl?= =?us-ascii?Q?W2rJHXhdHywr2a0CS60teTlOZ5buve/2uhtiyo0kxbZHhTFISuW1OiZ6DG9Y?= =?us-ascii?Q?AeYRA9gFL+Lm1XQGlpOz6BdSB7rSHqjebsiN7oFgszLhEDEPt0D4OlTwrf5q?= =?us-ascii?Q?1EhKX2uwV/TjSwS3vhuKBpy26IjgFAVOFu+3cbs+f6Pkio0UcDGfZfb2LluG?= =?us-ascii?Q?jGdVUf6eBeTUC2GRB8T+jeTnLIDs+YlvX00wBwctC5KX5Me9s5RjGCLKzRPy?= =?us-ascii?Q?VNiDmJxcCZI/pFNkDMhDULhZ93zFw8ufxKbjZ5bIsAHy3H0k+j29G4OIV/cI?= =?us-ascii?Q?Zrv7pJnI8E8OX0lMuGG87Irs/naF7NWCHLw02zjC3B+jr9SgaKeOERrAW7OC?= =?us-ascii?Q?Vubd6CC4AGENUYPf9hll1pVCXtAIkqhM/aDuh/sqxQ3Y5vFudejgInDYaR4Q?= =?us-ascii?Q?jGOlbykyXZQ9t/glmQo5hVtoul4Dj/kDRLn5SRejUiWtl6lQfI9jixRGEfcC?= =?us-ascii?Q?/hfDiyfAOOHaiQjF03DcVLsnQDC5n8Hmes9qIDZQ+/aNFFbVp+0ZcOoY5Qn7?= =?us-ascii?Q?jWxKqsFKK4MLLauKf1rYcN4xRnilIYz/YyzYdyAkXagnYMMaIS1/yAENCP75?= =?us-ascii?Q?vZX3Aeik14EtK/xnqiK0KqRkL/4+pHTEj4ycOZL0vyMi2oVHYOag0uY0yv4c?= =?us-ascii?Q?3W4Cv0+OxAw8gvRc+eeXhWHsKAYqRRyNnkQMzuP8ghWN5Mzl/AMTZCgpB12J?= =?us-ascii?Q?4vEarSE5Zl/2CRIU69mN7rEFJQjoxx6oZxkKOSzyzO8QF7aVfOx2SzSjZCgJ?= =?us-ascii?Q?zYD6mYq6zmhmP/gSsO+qDWEke5QJKykWOe45W2v08IK5V67tDjdry+8Dbcd3?= =?us-ascii?Q?9D8XC8Kixcv8jhoVALFSjf477IsCmmUeHbdPYwgZrQTL+WvZDhvuJ/F5AX86?= =?us-ascii?Q?Wo4I/lut8YzD8i2PmnfNKMWgJ4KJn1R2DnM9AQHUbeI6Hka3gJoWjR/uWnCJ?= =?us-ascii?Q?JJXcrejov4Xe2KguE8S16gK3nM5mO1zbQ9wfQSlItBT+P9QxtV+uqTgxPIah?= =?us-ascii?Q?QWFuOIdUPkb+MhZqkWWALzFFgxr99jGjSIaVZcVIpLgu57dQ2PitheGBOVSU?= =?us-ascii?Q?PmBymw2NdYgrOaDQBuXU50hGqjf/nUOaWlRC3yHMWfSxHvW5qDNdYkGmws1y?= =?us-ascii?Q?PkOZ7JRtANRLmwhi4Y3qXJMUxty7ZHUV/aK5CG0ms7CDPGrI4QgtGwHAAZ1L?= =?us-ascii?Q?5Z+MrDlibNsfAYwYhDBfXAhqGVvk7yXj2RsdJqP0cxkqs1XxViVXdWCm+/Jy?= =?us-ascii?Q?Of2T6irKiv4RNPvFCh3XJ83Qt4Ziirp8M/mnBzsaZvbm/3ZiIHWeNc7GfIZn?= =?us-ascii?Q?k0tH6vh/AW3J6PBpDYQ6wvR1w5Gk+NxGzXkfrWk08GedqyHEo4e+kodlo/tH?= =?us-ascii?Q?iIW0k7xob/6Q+ZrmksRFiZxKWpkL2Zw/j6zXMHzRWtgLu7BE7xsQ0nqrDybU?= =?us-ascii?Q?FSFnVsNKtPjpO4p+MUrEYpRYlOfCfiC0JoArTzUn/I/3KIFgRM37tzNpBRrB?= =?us-ascii?Q?W+T/IoVcMsKRoDSacylkljL+r7ELDsT6gOzKoUgbnN34bZaiFIfveX7GKUKT?= =?us-ascii?Q?HBjvBInX4g=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee20ddb3-a594-4839-8454-08de6241ca0f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8254.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2026 09:59:43.9210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CVAsWOzh0qw57d5Pg5qAE4PEIX0AqqPBBwEBy1fQb6wsQbbsCkJ9RizJj/BQFV1IKu6dtVGpdtACl7wMcQqnsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9726 Content-Type: text/plain; charset="utf-8" From: Ming Qian Introduce mxc_jpeg_enc_ops function pointer structure to abstract encoder configuration differences between hardware versions. Extract the existing two-phase manual configuration into dedicated functions (enter_config_mode/exit_config_mode) for v0 hardware. Add setup_desc callback placeholder for future v1 hardware support which will use descriptor-based configuration. Store the extended sequential mode flag in the context to avoid recalculating it during configuration phases. No functional change. Signed-off-by: Ming Qian Reviewed-by: Frank Li --- .../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 56 ++++++++++++++++--- .../media/platform/nxp/imx-jpeg/mxc-jpeg.h | 11 ++++ 2 files changed, 58 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media= /platform/nxp/imx-jpeg/mxc-jpeg.c index 39022c1bf36d..ede422364f9b 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c @@ -64,6 +64,12 @@ #include "mxc-jpeg-hw.h" #include "mxc-jpeg.h" =20 +#define call_void_jpeg_enc_ops(jpeg, op, args...) \ + do { \ + if ((jpeg)->enc_cfg_ops && (jpeg)->enc_cfg_ops->op) \ + (jpeg)->enc_cfg_ops->op(args); \ + } while (0) + static const struct mxc_jpeg_fmt mxc_formats[] =3D { { .name =3D "JPEG", @@ -1030,11 +1036,7 @@ static irqreturn_t mxc_jpeg_dec_irq(int irq, void *p= riv) =20 if (jpeg->mode =3D=3D MXC_JPEG_ENCODE && ctx->enc_state =3D=3D MXC_JPEG_ENC_CONF) { - q_data =3D mxc_jpeg_get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE); - ctx->enc_state =3D MXC_JPEG_ENCODING; - dev_dbg(dev, "Encoder config finished. Start encoding...\n"); - mxc_jpeg_enc_set_quality(dev, reg, ctx->jpeg_quality); - mxc_jpeg_enc_mode_go(dev, reg, mxc_jpeg_is_extended_sequential(q_data->f= mt)); + call_void_jpeg_enc_ops(jpeg, exit_config_mode, ctx); goto job_unlock; } if (jpeg->mode =3D=3D MXC_JPEG_DECODE && jpeg_src_buf->dht_needed && @@ -1272,6 +1274,7 @@ static void mxc_jpeg_config_dec_desc(struct vb2_buffe= r *out_buf, =20 jpeg_src_buf =3D vb2_to_mxc_buf(src_buf); =20 + ctx->extseq =3D mxc_jpeg_is_extended_sequential(jpeg_src_buf->fmt); /* setup the decoding descriptor */ desc->next_descpt_ptr =3D 0; /* end of chain */ q_data_cap =3D mxc_jpeg_get_q_data(ctx, cap_type); @@ -1335,8 +1338,12 @@ static void mxc_jpeg_config_enc_desc(struct vb2_buff= er *out_buf, struct mxc_jpeg_q_data *q_data; enum mxc_jpeg_image_format img_fmt; int w, h; + bool extseq; =20 q_data =3D mxc_jpeg_get_q_data(ctx, src_buf->vb2_queue->type); + extseq =3D mxc_jpeg_is_extended_sequential(q_data->fmt); + + ctx->extseq =3D extseq; =20 memset(desc, 0, sizeof(struct mxc_jpeg_desc)); memset(cfg_desc, 0, sizeof(struct mxc_jpeg_desc)); @@ -1369,11 +1376,14 @@ static void mxc_jpeg_config_enc_desc(struct vb2_buf= fer *out_buf, desc->stm_ctrl =3D STM_CTRL_CONFIG_MOD(0) | STM_CTRL_IMAGE_FORMAT(img_fmt); desc->stm_ctrl |=3D STM_CTRL_BITBUF_PTR_CLR(1); - if (mxc_jpeg_is_extended_sequential(q_data->fmt)) + if (extseq) desc->stm_ctrl |=3D STM_CTRL_PIXEL_PRECISION; else desc->stm_ctrl &=3D ~STM_CTRL_PIXEL_PRECISION; mxc_jpeg_addrs(desc, src_buf, dst_buf, 0); + + call_void_jpeg_enc_ops(jpeg, setup_desc, ctx); + dev_dbg(jpeg->dev, "cfg_desc:\n"); print_descriptor_info(jpeg->dev, cfg_desc); dev_dbg(jpeg->dev, "enc desc:\n"); @@ -1385,6 +1395,33 @@ static void mxc_jpeg_config_enc_desc(struct vb2_buff= er *out_buf, mxc_jpeg_set_desc(cfg_desc_handle, reg, slot); } =20 +static void mxc_jpeg_enc_start_config_manually(struct mxc_jpeg_ctx *ctx) +{ + struct mxc_jpeg_dev *jpeg =3D ctx->mxc_jpeg; + void __iomem *reg =3D jpeg->base_reg; + struct device *dev =3D jpeg->dev; + + ctx->enc_state =3D MXC_JPEG_ENC_CONF; + mxc_jpeg_enc_mode_conf(dev, reg, ctx->extseq); +} + +static void mxc_jpeg_enc_finish_config_manually(struct mxc_jpeg_ctx *ctx) +{ + struct mxc_jpeg_dev *jpeg =3D ctx->mxc_jpeg; + void __iomem *reg =3D jpeg->base_reg; + struct device *dev =3D jpeg->dev; + + ctx->enc_state =3D MXC_JPEG_ENCODING; + dev_dbg(dev, "Encoder config finished. Start encoding...\n"); + mxc_jpeg_enc_set_quality(dev, reg, ctx->jpeg_quality); + mxc_jpeg_enc_mode_go(dev, reg, ctx->extseq); +} + +static const struct mxc_jpeg_enc_ops mxc_jpeg_enc_cfg_ops_v0 =3D { + .enter_config_mode =3D mxc_jpeg_enc_start_config_manually, + .exit_config_mode =3D mxc_jpeg_enc_finish_config_manually +}; + static const struct mxc_jpeg_fmt *mxc_jpeg_get_sibling_format(const struct= mxc_jpeg_fmt *fmt) { int i; @@ -1590,12 +1627,10 @@ static void mxc_jpeg_device_run(void *priv) =20 if (jpeg->mode =3D=3D MXC_JPEG_ENCODE) { dev_dbg(dev, "Encoding on slot %d\n", ctx->slot); - ctx->enc_state =3D MXC_JPEG_ENC_CONF; mxc_jpeg_config_enc_desc(&dst_buf->vb2_buf, ctx, &src_buf->vb2_buf, &dst_buf->vb2_buf); /* start config phase */ - mxc_jpeg_enc_mode_conf(dev, reg, - mxc_jpeg_is_extended_sequential(q_data_out->fmt)); + call_void_jpeg_enc_ops(jpeg, enter_config_mode, ctx); } else { dev_dbg(dev, "Decoding on slot %d\n", ctx->slot); print_mxc_buf(jpeg, &src_buf->vb2_buf, 0); @@ -2973,6 +3008,9 @@ static int mxc_jpeg_probe(struct platform_device *pde= v) platform_set_drvdata(pdev, jpeg); pm_runtime_enable(dev); =20 + if (mode =3D=3D MXC_JPEG_ENCODE) + jpeg->enc_cfg_ops =3D &mxc_jpeg_enc_cfg_ops_v0; + return 0; =20 err_vdev_register: diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h b/drivers/media= /platform/nxp/imx-jpeg/mxc-jpeg.h index 9c5b4f053ded..cdfefb68346a 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h @@ -105,6 +105,7 @@ struct mxc_jpeg_ctx { unsigned int source_change; bool need_initial_source_change_evt; bool header_parsed; + bool extseq; struct v4l2_ctrl_handler ctrl_handler; u8 jpeg_quality; struct delayed_work task_timer; @@ -125,6 +126,15 @@ struct mxc_jpeg_slot_data { dma_addr_t cfg_dec_daddr; }; =20 +struct mxc_jpeg_enc_ops { + /* Manual configuration (v0 hardware) - two-phase process */ + void (*enter_config_mode)(struct mxc_jpeg_ctx *ctx); + void (*exit_config_mode)(struct mxc_jpeg_ctx *ctx); + + /* Descriptor-based configuration (v1 hardware) - single-phase */ + void (*setup_desc)(struct mxc_jpeg_ctx *ctx); +}; + struct mxc_jpeg_dev { spinlock_t hw_lock; /* hardware access lock */ unsigned int mode; @@ -142,6 +152,7 @@ struct mxc_jpeg_dev { struct device **pd_dev; struct device_link **pd_link; struct gen_pool *sram_pool; + const struct mxc_jpeg_enc_ops *enc_cfg_ops; }; =20 /** --=20 2.52.0 From nobody Mon Feb 9 04:44:39 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013004.outbound.protection.outlook.com [52.101.72.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 780913570CC; Mon, 2 Feb 2026 09:59:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026398; cv=fail; b=A4QhE5f9gc9W9OCUXwkm2zMyskw1CTPbyYf8au2gvQgej4cRw0kUWpvULybpXr1jUeaSa0V872GKFCQ9dzN3nTTcadIve6APh5P6nO6+w8PRO975qczFF4kDU7waAhExZLm20HyBY6oqsvFXdZ3DCOI8TACKd9d3ujetYwk/Kq0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026398; c=relaxed/simple; bh=QNtmxr82//s74WSHLz85+izt8S4w7Ngbbq9SQZ04gU0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=TKIn2g/e47mJGZCiFPhqpCdBU0jMDZlRwDEz3ohA/pG4wUgHByUbspzF3TFYCQpf6FmKgJPYpR6j3ipmhJ4NmEx2OEo7o54iWk3Jw40hPPtkjV7hRMLwM0k39o1F/sbH77WXmqSIgN0jFk/aJ9ptGG0Q7ueB4rD6gzz5tjaXYIY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=NhocvgSf; arc=fail smtp.client-ip=52.101.72.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="NhocvgSf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SQ+U3hGL9Y9y23AA6Adj4ieL2J0qNvnAJFIy6Y7MhuXk9QpHmSXYhvylKkUZKSM9nIps0N7lJPOXKWRdAbF4p/MaR72C0US2n1dKf67swcjIag5qgkS+rGMSm+B2GRAocKufSPNxR/sAa1WgeAxW+I6JndSas5NWjFvFeJrEnOfFbKDFU9mn1Znx30gOiBLCefmO23lgIdMS+SGpqE2HZWDKhPD4QhApoz73L6knUdkyasKx1w4IfD3kNqAdYxgd4TDyBYAgFi0G1SV8wIZr9/Ci8Vq6Ye8vuePxLqD2aK+BFGY7dBJpAv88en/2LcnFb4yOHhMLTLFtn0b0PrgBkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ahHhO6Dbye2yWV3LKflr1tW8HSOHh+LavQO69gU4IEI=; b=ZmzLURMgBKN4PFJ/DBgEdtf71qFXBTidirtLR4NXw6ThNvtQg0C6pynD17nh9mPAOlrogn7I0kdMchDI94zauHQ7JYuLZV+GnWifVziGLj4vYx2C8s5znpwq4r58GCT3tQai0dN9Rkc/7CHyy8tqIT1GUSLlyqSfFkY48XhvzTl9csKEA0kKIvXEsAxAiZq7Hz6PXvzGslwlEfnavzZ9gb0fAsD0kke1v/PlnFvbHW6NSw1ejwRvjinZoZlLQcJtnRI75B3oFdF1PGmG5cw+d/AQjPRdT1hSpMf+qvoWSIm+Gxd/ah4Ka4JYG0gXQvlY0t3/cwyt773W5WPiNFoiGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ahHhO6Dbye2yWV3LKflr1tW8HSOHh+LavQO69gU4IEI=; b=NhocvgSfw6mdyiylgXi7zJgTXp7mGYSIZwzkTNaEUnwA/jtOhE+vmcmIV6rnE1AbTeHJdeZbGEfERLb3oniwjJvdUyJjbkDvilBj+VrVncO80/y+NIdtURKYde2W60KQgT81M/1QTkc3prv5jEkQjI3C8XpQ2N7ZS+ClCV3F0AQ3QGwyvKze69LISTe5SJ3WKbW3RnqOsLMYTyCo2qbM7DSRb027GkEufvPDYYLRVvgcVaB0s/C9eqppkN4om1qbn8uSJ5ItnY5H1H3X9nASVOos/nJ7JcR4yVrBdDdsfVeSnX2eyhNnTgsJ/Di+I8HCNg4pE6tDCfc4Mdk4Q6+LEA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) by DUZPR04MB9726.eurprd04.prod.outlook.com (2603:10a6:10:4e3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.16; Mon, 2 Feb 2026 09:59:50 +0000 Received: from PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87]) by PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87%4]) with mapi id 15.20.9564.016; Mon, 2 Feb 2026 09:59:50 +0000 From: ming.qian@oss.nxp.com To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, mirela.rabulea@oss.nxp.com Cc: nicolas@ndufresne.ca, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com, linux-imx@nxp.com, Frank.li@nxp.com, imx@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 3/3] media: mxc-jpeg: Add support for encoder v1 descriptor configuration Date: Mon, 2 Feb 2026 17:58:36 +0800 Message-ID: <20260202095843.1030-4-ming.qian@oss.nxp.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20260202095843.1030-1-ming.qian@oss.nxp.com> References: <20260202095843.1030-1-ming.qian@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR06CA0188.apcprd06.prod.outlook.com (2603:1096:4:1::20) To PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8254:EE_|DUZPR04MB9726:EE_ X-MS-Office365-Filtering-Correlation-Id: 789299a2-0337-47ce-da5b-08de6241cdb0 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|19092799006|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6FdbFswLhUsJ71mdfOvSOHhT1V4XXekkI9zCeQKZK+B4atWEYyGfIUL9r/+H?= =?us-ascii?Q?APKqTxwgA84rLZWlr1OlKgOE/WA7YIhEuUUL72AYfnkBNw/jTzSLcpmqJevP?= =?us-ascii?Q?lwuhgYlzpLQwepTURV2UNA19ZmKbJoLXye0m4HGAlgNlcaUv18Idp6vN1Cko?= =?us-ascii?Q?/VHx9eMocPmJgE9lmG/JbmTJAY0Z8rMQ42RwjXab1I9dqVCLCuY1dCrb/vgr?= =?us-ascii?Q?bjM1xlJwgiNOhtlYRJi2/QhupmdXa6IyZ1CUw6vpMNA6FtTkHysmSNemv3oi?= =?us-ascii?Q?QuFR857YXDR/J2RSqrZOgoUZxuvNKavUqRDtHHe2/eVslD7SzNlYkcI4Gpkj?= =?us-ascii?Q?XUoshSIpubc4WjRMuWc8eJPjt77hy1vw5EvxfoS819y4axO3d9w672xkDwBG?= =?us-ascii?Q?HbFtp+x0zrSbwgGLG7dEKy+Gyt3fbqo7AzbxKJHyLUy+iykEASoKz/kPYnlG?= =?us-ascii?Q?sTgtnvLr8TdwPuzl+MobRX6Xy4/XUeZW8nvzDdoAwBRDa2c6aVl2S1LK+BJp?= =?us-ascii?Q?n/lv3QXNpfzfXKNyZw4wGbcKSE7907AYfcuEsxDgCANd+TYDCmrTFD81mD5Z?= =?us-ascii?Q?ENc+2rI80ySLCcu4M4gVAOtCjLmwiMZIGFhsJZdCk5u9t5nTF1ZGusa+/Bq3?= =?us-ascii?Q?30/cxocyENPmXOhSV1D5Ga6QJu7ongBM2q4lz6ezmwY3stzeLu0F6a3AjcFo?= =?us-ascii?Q?72cFZYVljGCpEEPekQfZ1bfdfV1Dgy739vXGpTX8O1bfF9J9MGRgzWBhLGS1?= =?us-ascii?Q?4FcAkP0oKVzq1gzxF9PZs7pcEYJRll9mtJg4i2mR08tEOl7c+sDa4VVJITL9?= =?us-ascii?Q?/6S1AHp2GESxjl+06HOAQPNNgB3sUR94Zw0Cyxd+1iveDgKd4/JwW4lRpzdy?= =?us-ascii?Q?d0q0PVD8q1Op2kU32NE/dXKAKAvp0/5DQ2UrC4ly8pS3PhLaG2TsZGAeiVNq?= =?us-ascii?Q?aAmfyyIfZicComMf0sekygweh/GNgi1p36KKMmaHMblf2ugdOyILIsLdeYz8?= =?us-ascii?Q?wOGzyZXucKbweQ7rj8/z54yDu6i8LESXLYhpWNmm9fsL2U2/x5YKi2ftjVJZ?= =?us-ascii?Q?Es/JZsZXDh4cDWywYj+Bg1xFlMK+s0dFZedlNdKXCe1gDGQcOsgkgkXOgK5Q?= =?us-ascii?Q?28FyhKMLO7YrFjvCFaCbn0nYvHJJlb5+Uy3wEztIitzokryObpFvSQwPmBT7?= =?us-ascii?Q?4nHm9LDRf+q6+Um7BXA41Px97GR7lifoKxLtCXAOGgdxxTz5h+/1bHn+i8w8?= =?us-ascii?Q?5zjrxQ8YrJ9u51eP9IOOtPOtzERQTzfFoK4+bnJx0J+MYLkvgN3sEnpBtPcQ?= =?us-ascii?Q?V1plhpW43EhOxRbh8I8AYIKguwG72EWStkPLrLvrjjjxfTd3IdOf0KdbnMrs?= =?us-ascii?Q?ygbk2pXj5AHVOZw1XgYKkUQhrSYdU0oQfZQx6deANG6+6CWXQYoaAsfuIbym?= =?us-ascii?Q?dbBnfCNBOvLTXkU3bD1b9xnC+uZFUknR//PpWoY2RzKe0Z1Cz8yOtLeUxwA3?= =?us-ascii?Q?PEgTMafpsHwdOGIuzoGzmlz5bsOxCV9N+pPTND1epjzMC+E+gC6VyjgWd0ck?= =?us-ascii?Q?IBH4uEmFPBe39w5wvK8bPvWrR6xaNz/sAJ1cMRfhDEk1csIncr6VjyR4PQz1?= =?us-ascii?Q?bvYp1Ykjk/5wPd/TjHh3qCk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8254.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(19092799006)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y0EaVkdgoQFU7QTadqGsLKG1M7vqRmabLX2tA/9RaerCun99JWvVRAkiP64u?= =?us-ascii?Q?UwLFuHXajLufpBLFn1usgkzbi4+oUdG7b/hFfjZN4onmKPIO82AvaWKXCFVP?= =?us-ascii?Q?s/vn8daCSwtk8AmLpGZPLw90FJ2KAS8o6jagN12KKHcESCnYBOB+RXzA+Hgk?= =?us-ascii?Q?ISRCs7koyoXYDFnJnKppasLz72xf9iRyfsjN8dpyOFqGsVfh7b6IPI3YJmug?= =?us-ascii?Q?bn+vYbPSHJHLBXR6TAkP0g/MTa75cJaxsCSVznWhB+gZ8zt5aB7NAbqSbdUa?= =?us-ascii?Q?xptu9zM/q45W+yfKmOYdIHeOIELKVRbHKOuVfZCp3SEhSb23cDcnSgVTHicS?= =?us-ascii?Q?eHUHYcB15Nt+HKts1Ci/BpG8s1SNy2UE4icFQJ2LhoURUV3k3zf0PGg5L9Hi?= =?us-ascii?Q?MmlaqL6tCEJkvMNEgoVMwZTE5bcTJ0MPtTbsshCTAu3rg7IwxJx9TmUQMmVp?= =?us-ascii?Q?2oiMXYsfvgwaAFu3+xrnt/8GNQbG5hCwYWDbF5HgH8qqWqQXSU7zGWyUoE5Y?= =?us-ascii?Q?4bGNS17jDJgPz4nruKfRb5RrNBQCunRDaNJK2xKyS0vIh9chuk1BH3JaCVAc?= =?us-ascii?Q?w1ICKyouTgK2QV7hi1WY1xFhLeypB7Xxs/JIg4/pHLGiuzX7luPfJHNvtUbk?= =?us-ascii?Q?vytKi/dW1kGct5ym12g9M2iCNWnDL3BjGD8p+qGL+fDKsH/GJLCj1lSjyQW1?= =?us-ascii?Q?5K1dhDSoamle0/ggMFFujWdMi36nOvNHdrxE1S7lFW3UIxcEpfxvK05BmXHG?= =?us-ascii?Q?gj9BTx/ZpP+ltBU2ph6DkwzX1oevhPE0doWAlFIM5QMAp/MkJkw6O4I2T04K?= =?us-ascii?Q?48xfaBOy7nrBYyjtfU9W508hwfrfChmsgeFIZDNHQWznhw3w8YtvcY1ZZTcS?= =?us-ascii?Q?0HGA9vxRPtnZ8taWOF9chAt+gjNUhHRvERUY5SSryAxc2VJjT428sqrrTR/g?= =?us-ascii?Q?zZ4xtvFmHzGRYBQ6s9h8ZjsLH5qL4YJjKZh08wU59JOY13/ua+oeO8N+9n5g?= =?us-ascii?Q?cyz2ZRwby1BJ2Sxpue4k6fpEpnUo+K3ljE0yFe/DRusMVqvRPVPMaD46ZmDl?= =?us-ascii?Q?GL7sXQjB0CVpRFuLgd9aLlnW1ADu23F37CCmsRcDf3mrgoKJe9L1hlCkIIbp?= =?us-ascii?Q?gvY1M4W3fgmGx4gpaf+WAwj4332Chi2oWAmwsCvlABWLx+whaJZjqBFFuAU9?= =?us-ascii?Q?0e5PdSv1/wLmq/g0+QzEQwY4WvhpcuLo+tYBu3tbu31K2LHUPpPPQ2uvzdr7?= =?us-ascii?Q?6O8T6IeFvsins39e6On9Xon0VsWKIFlHI/77XEdw8Rp9zDgW5+AVc3gY0cd0?= =?us-ascii?Q?BpYTIdWnY+sX8lIVG1YbCDXlm7LWshmWo0L5VRyUGh6h/vjjrsGfFP8w4H6C?= =?us-ascii?Q?gBWSZFMPkHLfHzmgByqVR04FHkhxWooWnMAwNtMmGZWl5UseyKVbyteCDV1j?= =?us-ascii?Q?WnIdZEbdWaOLKKNg329DI8Yt8D3WbAlckq96qgxT+PoZ1CFAiEWcSXUNfsRr?= =?us-ascii?Q?86+Hak+POI1X0188VvVmT3uqsbMmyQrZ47kTonw1E/hGgoS1ZlGrjRAPtd6l?= =?us-ascii?Q?6EoPGKE8dqmvMo8QpkYEr5ao9EIwewj7zbP/sZfavD2Agnta44DnDmTy9vga?= =?us-ascii?Q?NoPMYfS7fBwNSkmR+7r/qzAy6h4A1wcrBfy203EDStT3TU/ylAXIB3JnBaeC?= =?us-ascii?Q?riTcHr9HYfZQrJOBo9J3G6gJa+ndTeRaiWM++XDKlveDnUwg3jpkhuhGfBtd?= =?us-ascii?Q?U6plqnX9Kg=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 789299a2-0337-47ce-da5b-08de6241cdb0 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8254.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2026 09:59:50.0991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZaocOj9yWLt5NU0co4fVl2cyE31dsctd/xdKZLmG7NrXLllL719WZT0t2qM+5kKc7b+E/nlcYn+NjGFw7ZpEyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9726 Content-Type: text/plain; charset="utf-8" From: Ming Qian Support the upgraded JPEG encoder v1 found on i.MX952 SoC. Detect the encoder hardware version via the version register. The v1 encoder uses an expanded descriptor format that allows all encoding parameters, including JPEG quality, to be configured directly in the descriptor. This removes the manual register-based configuration step required by v0 and reduces the interrupt count from two to one per frame. V0 encoding flow: 1. Write quality to registers -> trigger config interrupt 2. Start encoding -> trigger completion interrupt V1 encoding flow: 1. Configure descriptor with all parameters including quality 2. Start encoding -> trigger completion interrupt Signed-off-by: Ming Qian Reviewed-by: Frank Li --- .../media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h | 1 + .../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 45 ++++++++++++++++++- .../media/platform/nxp/imx-jpeg/mxc-jpeg.h | 11 +++++ 3 files changed, 55 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h b/drivers/me= dia/platform/nxp/imx-jpeg/mxc-jpeg-hw.h index adb93e977be9..0d78443cb270 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h @@ -73,6 +73,7 @@ #define GLB_CTRL_DEC_GO (0x1 << 2) #define GLB_CTRL_L_ENDIAN(le) ((le) << 3) #define GLB_CTRL_SLOT_EN(slot) (0x1 << ((slot) + 4)) +#define GLB_CTRL_CUR_VERSION(r) FIELD_GET(GENMASK_U32(19, 16), r) =20 /* COM_STAUS fields */ #define COM_STATUS_DEC_ONGOING(r) (((r) & (1 << 31)) >> 31) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media= /platform/nxp/imx-jpeg/mxc-jpeg.c index ede422364f9b..71f4a1d292ac 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c @@ -1417,11 +1417,32 @@ static void mxc_jpeg_enc_finish_config_manually(str= uct mxc_jpeg_ctx *ctx) mxc_jpeg_enc_mode_go(dev, reg, ctx->extseq); } =20 +static void mxc_jpeg_enc_configure_desc(struct mxc_jpeg_ctx *ctx) +{ + struct mxc_jpeg_dev *jpeg =3D ctx->mxc_jpeg; + struct mxc_jpeg_desc *desc =3D jpeg->slot_data.desc; + struct mxc_jpeg_desc *cfg_desc =3D jpeg->slot_data.cfg_desc; + + ctx->enc_state =3D MXC_JPEG_ENCODING; + cfg_desc->mode =3D (ctx->extseq) ? 0xb0 : 0xa0; + cfg_desc->cfg_mode =3D 0x3ff; + + desc->mode =3D (ctx->extseq) ? 0x150 : 0x140; + desc->cfg_mode =3D 0x3ff; + desc->quality =3D ctx->jpeg_quality; + desc->lumth =3D 0xffff; + desc->chrth =3D 0xffff; +} + static const struct mxc_jpeg_enc_ops mxc_jpeg_enc_cfg_ops_v0 =3D { .enter_config_mode =3D mxc_jpeg_enc_start_config_manually, .exit_config_mode =3D mxc_jpeg_enc_finish_config_manually }; =20 +static const struct mxc_jpeg_enc_ops mxc_jpeg_enc_cfg_ops_v1 =3D { + .setup_desc =3D mxc_jpeg_enc_configure_desc +}; + static const struct mxc_jpeg_fmt *mxc_jpeg_get_sibling_format(const struct= mxc_jpeg_fmt *fmt) { int i; @@ -2874,6 +2895,14 @@ static int mxc_jpeg_attach_pm_domains(struct mxc_jpe= g_dev *jpeg) return ret; } =20 +static int mxc_jpeg_get_version(void __iomem *reg) +{ + u32 regval; + + regval =3D readl(reg + GLB_CTRL); + return GLB_CTRL_CUR_VERSION(regval); +} + static int mxc_jpeg_probe(struct platform_device *pdev) { struct mxc_jpeg_dev *jpeg; @@ -3008,11 +3037,23 @@ static int mxc_jpeg_probe(struct platform_device *p= dev) platform_set_drvdata(pdev, jpeg); pm_runtime_enable(dev); =20 - if (mode =3D=3D MXC_JPEG_ENCODE) - jpeg->enc_cfg_ops =3D &mxc_jpeg_enc_cfg_ops_v0; + if (mode =3D=3D MXC_JPEG_ENCODE) { + ret =3D pm_runtime_resume_and_get(dev); + if (ret < 0) + goto err_check_version; + + if (mxc_jpeg_get_version(jpeg->base_reg) =3D=3D 0) + jpeg->enc_cfg_ops =3D &mxc_jpeg_enc_cfg_ops_v0; + else + jpeg->enc_cfg_ops =3D &mxc_jpeg_enc_cfg_ops_v1; + + pm_runtime_put_sync(dev); + } =20 return 0; =20 +err_check_version: + pm_runtime_disable(&pdev->dev); err_vdev_register: video_device_release(jpeg->dec_vdev); =20 diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h b/drivers/media= /platform/nxp/imx-jpeg/mxc-jpeg.h index cdfefb68346a..c00c13549746 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h @@ -81,6 +81,17 @@ struct mxc_jpeg_desc { u32 stm_bufsize; u32 imgsize; u32 stm_ctrl; + /* below parameters are valid for v1 */ + u32 mode; + u32 cfg_mode; + u32 quality; + u32 rc_regs_sel; + u32 lumth; + u32 chrth; + u32 nomfrsize_lo; + u32 nomfrsize_hi; + u32 ofbsize_lo; + u32 ofbsize_hi; } __packed; =20 struct mxc_jpeg_q_data { --=20 2.52.0