From nobody Sun Feb 8 12:36:53 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 291E52F60CC for ; Mon, 2 Feb 2026 09:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770022884; cv=none; b=HS6UvhU07z+EWRVvMcuuMwDiIShoerjpFBd0FFMDXRUl+DTxTXXQe+QAUpYIxIZ4QNQaBy2+8yFjvW0IkyHyXCkaNpTcOEv6QvIwAHo4SBOInALxfLD9aOa/QHCGtaePQO3mtyyXBI+ZTpC6imCPHJCkf6yeJ9wZhq3EETLi5Kc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770022884; c=relaxed/simple; bh=sWh4qRJW5wuJPUJ9xDpga/kqSm/hNDUxwTBOVpO7yLY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s9oSFOcpJnLhYvRzjIfpVR3Wl6Rscg8uNGQNG0MvPVyMNthf2EhVQ0w5xbGdQ8lTs3qMzcMqxlk7nb68noXvytk6J9ALXdDNwPCBw7z/VTI71Vxt162zgr+qdXmhzETJU0k1RK7mg/aSvePp1UHTWGVgaQSNBt/rNIr9USSsucY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K5DyN+K/; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K5DyN+K/" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a79998d35aso27595155ad.0 for ; Mon, 02 Feb 2026 01:01:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770022882; x=1770627682; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sMhSx+6lEu+8jKPgVw5bypgKSiK+gEAAE/MS9cV7FQc=; b=K5DyN+K/ykuG0nMpJdIqx3TXUKG1DU0NSoItf7Lh0wuFTUOnAQY7yfVrD76ZzZg8yc n0A/SwYqISxuNCNMJ1/A5ru+OQUdjWCxrBijUodkr79r9+/4mZnrWmGIs6kJttOrhjM7 71qhhu9z0RR9HExXV3K70oDlZ45sbldnimrPgtHMCEUuB522QresnBeG2kFI4DzTGqji NRm4KsYSQ24sMPIULrTDofKTBzKY3wgFLz9X4kjPaIiFiDScvG3PbwKuaHlMRc4YjUF7 nA2w6tnSrpuX/vXVK2MiXfaRaJJUH42dYIrIu8gCkNpGjTVA2N24s0pHECtVG3btuR0R WIPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770022882; x=1770627682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sMhSx+6lEu+8jKPgVw5bypgKSiK+gEAAE/MS9cV7FQc=; b=kjl7UEaM9KAGL43uEoiEtvB+G8X98JHrcXy2RtYlz+QyhT/rLI9Jt2ALuPiprBetvn Cb3TLTrG7aASwbPgZ8RNuLwfaeD0veyT3uwsCWtT0z2ZEllYRqApG6/vRhDw8CgwX/Tq o3KkI+OUrNykxi2stRmlYC6ezdPTZ1jHpzWo9T8xr6lSeOrSnDG2ERZYSWQu4UGtCYU8 1yGLI1ZMPNPi0Mf1sxKq8VQWV5IwCGG5a9STFqpv1E8gMdnWTSPBYLma2PHl2MpWnY7P G/dy8VVm8BEQRI+zF3sxg470douMHgZPfI5HZx4YAaOAyUcjEXUNyT5utgtkCa7zRiZ8 Pxww== X-Gm-Message-State: AOJu0YwKahjVkqVopgvjz4V6a/vdRw7pclLaufCFdx1LmwwUf1hNgPEz +HDbJNXjyZfnFtTM5fmuroxGu170piFbxOpMpTYKjGT/G96twDaAz+W1 X-Gm-Gg: AZuq6aJ0ks38ve4N4JUHqcGM5hd6/BtDrqzow7pvWbjzrktPetGUpw9ud6IFSwC/+ko ioHpH65/ltlSAC2QjGBs5R63t0/bJUL+2cRqoe67vsfY2xKm0I5NURnFcn1X+mkbTtL1HGHoyZf RCpmVzK+Ve2mYCOZUcBF3Y/4JL10zbCOIjYEMMPx+YDlabcQJm/pb83bn/L6OFjzVnBfrcN7DoM tOQhDRzHGGZwDAJzo739Xk7XN8XbJTQGrRhRVeVm/B3eZZ6phV98GrWGhBdlf52C6/VQkJGGOEn ZM8zsyKgJHkrO26ryPXJ/lLPWe2qbR4m8EaugmsbQW3FEyJ3B+KaCFVV05YSBtkRHmh8jhlMrn4 QhmyQoh8Oem1z5imXhOt0aZIgbhLRWI8JeiyvSsr31KIXGNvsZJXnAawWkWnKZaAVPmIHlOExuO Yg2O9UeR+Bbia7ZHOAA/BSrwQiDDYWBfofkMgQrIoYfHKehJfk/bbQ X-Received: by 2002:a17:903:f85:b0:2a7:77ce:d75d with SMTP id d9443c01a7336-2a8d9a7b20emr99363765ad.61.1770022882405; Mon, 02 Feb 2026 01:01:22 -0800 (PST) Received: from localhost.localdomain ([116.128.244.171]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b414f1esm139167635ad.24.2026.02.02.01.01.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 02 Feb 2026 01:01:22 -0800 (PST) From: Chengkaitao To: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, yangfeng@kylinos.cn, alexei.starovoitov@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Chengkaitao Subject: [PATCH v4 2/3] bpf/verifier: allow using bpf_kptr_xchg even if the NON_OWN_REF flag is set Date: Mon, 2 Feb 2026 17:00:50 +0800 Message-ID: <20260202090051.87802-3-pilgrimtao@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260202090051.87802-1-pilgrimtao@gmail.com> References: <20260202090051.87802-1-pilgrimtao@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chengkaitao When traversing an rbtree using bpf_rbtree_left/right, if bpf_kptr_xchg is used to access the __kptr pointer contained in a node, it currently requires first removing the node with bpf_rbtree_remove and clearing the NON_OWN_REF flag, then re-adding the node to the original rbtree with bpf_rbtree_add after usage. This process significantly degrades rbtree traversal performance. The patch enables accessing __kptr pointers with the NON_OWN_REF flag set while holding the lock, eliminating the need for this remove-read-readd sequence. Signed-off-by: Chengkaitao Signed-off-by: Feng Yang --- kernel/bpf/verifier.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 05a6a6606b6c..bb3ff4bbb3a2 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -9260,7 +9260,8 @@ static const struct bpf_reg_types timer_types =3D { .= types =3D { PTR_TO_MAP_VALUE } static const struct bpf_reg_types kptr_xchg_dest_types =3D { .types =3D { PTR_TO_MAP_VALUE, - PTR_TO_BTF_ID | MEM_ALLOC + PTR_TO_BTF_ID | MEM_ALLOC, + PTR_TO_BTF_ID | MEM_ALLOC | NON_OWN_REF } }; static const struct bpf_reg_types dynptr_types =3D { @@ -9420,6 +9421,7 @@ static int check_reg_type(struct bpf_verifier_env *en= v, u32 regno, } case PTR_TO_BTF_ID | MEM_ALLOC: case PTR_TO_BTF_ID | MEM_PERCPU | MEM_ALLOC: + case PTR_TO_BTF_ID | MEM_ALLOC | NON_OWN_REF: if (meta->func_id !=3D BPF_FUNC_spin_lock && meta->func_id !=3D BPF_FUNC= _spin_unlock && meta->func_id !=3D BPF_FUNC_kptr_xchg) { verifier_bug(env, "unimplemented handling of MEM_ALLOC"); --=20 2.50.1 (Apple Git-155)