From nobody Mon Feb 9 16:17:06 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 363B82E266C; Mon, 2 Feb 2026 08:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770019541; cv=none; b=ILDsdZV0GqVfPo5FBUY/IAeuNUzyFt8VyNJ/lig8lQjxsef0TNgUnC5oupT1+d4Kup+nkwCKaF3qGGalbsPyqDVtt+wATKx6ReKpz6vLA+87tp/oOC6scG0mn13S6PVXpd1pOdbLvZfIfHqK6//8wh0v47Gfoz5Qd3FOmQtlngg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770019541; c=relaxed/simple; bh=71dJ0wHPodFp3HMbfG6GxWJmkGY5vzMEvhmKs2UQ40E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=odh/TZ1jDri7DlNmSpUnbUPKQACZw+xT62rUXgUA72PTu0FHu4EO1KEKoiUdb3rSLp5O/EbU7NX3BKyJwFOiIc9ASUECjzaKr9gzclaCbJ6qUgjk4MubWqwX0hTUjucMXaH2kU1jxauJ3kITTt0nAbVbnR9Ce4fyid5wrmZNlNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AB68C19421; Mon, 2 Feb 2026 08:05:38 +0000 (UTC) From: Yu Kuai To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ming Lei , Nilay Shroff , Hannes Reinecke , yukuai@fnnas.com Subject: [PATCH v9 6/8] blk-mq-debugfs: remove blk_mq_debugfs_unregister_rqos() Date: Mon, 2 Feb 2026 16:05:21 +0800 Message-ID: <20260202080523.3947504-7-yukuai@fnnas.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260202080523.3947504-1-yukuai@fnnas.com> References: <20260202080523.3947504-1-yukuai@fnnas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Because this helper is only used by iocost and iolatency, while they don't have debugfs entries. Signed-off-by: Yu Kuai Reviewed-by: Nilay Shroff Reviewed-by: Ming Lei Reviewed-by: Hannes Reinecke --- block/blk-mq-debugfs.c | 10 ---------- block/blk-mq-debugfs.h | 4 ---- block/blk-rq-qos.c | 4 ---- 3 files changed, 18 deletions(-) diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index 11f00a868541..22c182b40bc3 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -734,16 +734,6 @@ static const char *rq_qos_id_to_name(enum rq_qos_id id) return "unknown"; } =20 -void blk_mq_debugfs_unregister_rqos(struct rq_qos *rqos) -{ - lockdep_assert_held(&rqos->disk->queue->debugfs_mutex); - - if (!rqos->disk->queue->debugfs_dir) - return; - debugfs_remove_recursive(rqos->debugfs_dir); - rqos->debugfs_dir =3D NULL; -} - static void blk_mq_debugfs_register_rqos(struct rq_qos *rqos) { struct request_queue *q =3D rqos->disk->queue; diff --git a/block/blk-mq-debugfs.h b/block/blk-mq-debugfs.h index d94daa66556b..49bb1aaa83dc 100644 --- a/block/blk-mq-debugfs.h +++ b/block/blk-mq-debugfs.h @@ -34,7 +34,6 @@ void blk_mq_debugfs_register_sched_hctx(struct request_qu= eue *q, void blk_mq_debugfs_unregister_sched_hctx(struct blk_mq_hw_ctx *hctx); =20 void blk_mq_debugfs_register_rq_qos(struct request_queue *q); -void blk_mq_debugfs_unregister_rqos(struct rq_qos *rqos); #else static inline void blk_mq_debugfs_register(struct request_queue *q) { @@ -78,9 +77,6 @@ static inline void blk_mq_debugfs_register_rq_qos(struct = request_queue *q) { } =20 -static inline void blk_mq_debugfs_unregister_rqos(struct rq_qos *rqos) -{ -} #endif =20 #if defined(CONFIG_BLK_DEV_ZONED) && defined(CONFIG_BLK_DEBUG_FS) diff --git a/block/blk-rq-qos.c b/block/blk-rq-qos.c index d7ce99ce2e80..85cf74402a09 100644 --- a/block/blk-rq-qos.c +++ b/block/blk-rq-qos.c @@ -371,8 +371,4 @@ void rq_qos_del(struct rq_qos *rqos) if (!q->rq_qos) blk_queue_flag_clear(QUEUE_FLAG_QOS_ENABLED, q); blk_mq_unfreeze_queue(q, memflags); - - mutex_lock(&q->debugfs_mutex); - blk_mq_debugfs_unregister_rqos(rqos); - mutex_unlock(&q->debugfs_mutex); } --=20 2.51.0