From nobody Sun Feb 8 18:15:45 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABC1030F7F2 for ; Mon, 2 Feb 2026 07:08:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770016100; cv=none; b=NtfbQ4Pk/9oIxr+0vcXiAobbzASgNMWXLidNJaKW1igiWN2BO0mpWoJRZ4BHVqhrKKhsbxqkpFU9Yw29RO/LNeCJm9JuRu0gVcUFfjrCUTATo6Cj/EwnlzLvenKzYre8pmej1RBKJcoWqPDIsjTxu3rv2u3zrt4fsfq7fPzfkZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770016100; c=relaxed/simple; bh=Y2TihLrOXjfbjF9u/PEFAJ1IZQVaQ8uExnYSn5AvcKo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BP7WtMtJX99KhW3fWkZz+pgC7QkW4D47ZJSOk7R6oxGI4nt1H6D6RJFUGIheNVDuLM8qW7FPvsCw8NR5jQyuaIBPU9vNqHJd5ndKU4FyWJLw3yHA3x9JIz9LwuvxQT4AnZb/RZPrx9niYa3KNABChHMFHWjLTraj2PL4bUJXoSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i2C9DS7z; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i2C9DS7z" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47ee0291921so37456745e9.3 for ; Sun, 01 Feb 2026 23:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770016097; x=1770620897; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4WkmcG7TJgIhlqZphFb6n3UZ0JclZwmZQJHhSQXufXg=; b=i2C9DS7zcp69pXJoJxaPHEN3N+z0KWEspRXnVA46p+GDRNCxr3qUv2VUMeDJdrUnfp E4g7btZljX1sodFIktIwdYlr2pBf6uG4wJJOYTJ0liWMqkQ6DHPE5+wTiVeslfM4zSSr PJqAyvW4UCQIvXuyNjDqGVKeR+RhCu8Pmkx00siFfse5lCmW9hjjXV8hAmWYO90g5Y48 ltJz/7NQPyL1lp+lnj9Hoek/Im4GtcSK73zSe+JBAcA+itfUTWHNoDVloKOkrd0OcvWf px7tb1l2SKdNapHk4PxUEPdbQk+XxnbZ1nU9GzgrrtbOVdCvaJdGqxqU0lNWtFDE8c3l LJwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770016097; x=1770620897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4WkmcG7TJgIhlqZphFb6n3UZ0JclZwmZQJHhSQXufXg=; b=rv/uRqIm7FicZRNJIdMPkes7CosOCVbUSShfVa4mcuApAieAfvmjFIPNztm5TnUZUt /ZLC1HM809Vxx2/4TAXJHhWdNG9r0Dck1OfKDmwBs1RI2w77wznvqhpTOT87Vin6vzmt vcTH7QNOrb5CzbR+Iy6DSzrC6fS9YEG3fsGF9AlhwuKKNZcz7StWUfbYTZzGVrhmoV0R u5L1VE+2jb1wHEBTWOMipdgQiHgs/tEitMRtd95EjnILqPh+C6HicH8mWqC+8I1jTAUK 8cDvOZOucrrGC8ReBymPJLnW6K78AEWVLdoTSYnlVaGbKxOm0t7h995ioKjtLKf1YIOt RMYQ== X-Forwarded-Encrypted: i=1; AJvYcCUU4i/Cvkg9RCABbVcbtPRiwB0vwCphvHpkcKWKOMic8Sv5wJG1kdo8bDX8JyUZ9JoRbvMJ4JXGW1sPB5E=@vger.kernel.org X-Gm-Message-State: AOJu0YzVAVuMMRljqbWgrsJObXDcL1TwEtGhOEtUQCzRQfKEPqky4dR3 C2UuRNCsGZnWhEAKTeUjQKssP7+TBMS/zRDuCTYMIG4Z5lxHa7qTxIZxJTCDr5U= X-Gm-Gg: AZuq6aJDPglOG/5hpJZrLbHHiiTFukRqPaJNOF3XpiNU3Ny1/G87e0Wxz6s8FcSzDhH 39QhAIm4yZmdHFsTlsOiXRASLzgd04eZXZ+73Fo3XMM/OvijcejLtiHr1+NQmurhxMRO6MHajMk KU0lk9FaAlKhm08L1O/LxU7jrpGAfpLxGDJZgjaDZH8gCzEU9Xeqb3Y+VKk6K9AWeBdr1XWv+nA j+Gi//ZSlSgfbvgTs8w1ZieG+qFUl5oB/YqLk6XqPRDFmn9gDv77IclNgmrq2jrVZ5inUGtb4sc 8/EmMV8bXu5Zrzz3yL9N7KV1Kr6BbzArf1Eb2FryXtW/PKd4su3i6xiYiScfw+jR3t6yPhj09Y3 0vQNSE1IYIsSoUx8Z1mxzC/Uilt0skhr0e0fTejA0MRrrWXAsKkXLDrXTWwaNjizfVFAsp7eWZm TSQ32nrJhmBd0AhMAAQAMODVTz51QBQjEL5mWx+T+Uw2Uv3h7wlFQgMMVWVgZw9w== X-Received: by 2002:a05:600c:4e0b:b0:480:6dff:e786 with SMTP id 5b1f17b1804b1-482db4f6f67mr120444815e9.37.1770016096807; Sun, 01 Feb 2026 23:08:16 -0800 (PST) Received: from LGPC ([31.223.131.66]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cde00e8sm371369315e9.6.2026.02.01.23.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 23:08:16 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v1 4/5] staging: rtl8723bs: remove redundant MAC_ARG macro Date: Mon, 2 Feb 2026 08:07:51 +0100 Message-ID: <20260202070752.3391-5-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260202070752.3391-1-lukagejak5@gmail.com> References: <20260202070752.3391-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver already uses the kernel's %pM format specifier for printing MAC addresses. The MAC_ARG() macro was a no-op that simply returned its argument, making it redundant when used with %pM. Remove the MAC_ARG() macro definitions from ieee80211.h and osdep_service.h, and update all call sites to pass the MAC address pointer directly to %pM. Also remove the unused IP_ARG() macro. This addresses TODO item: find codes that can use %pM formatting. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 ++++---- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 2 -- drivers/staging/rtl8723bs/include/osdep_service.h | 4 ---- 5 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index ef2d92b5588a..27eddd22e064 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -930,7 +930,7 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, struct= sta_info *sta, u8 enqueu while ((cam_id =3D rtw_camid_search(padapter, sta->hwaddr, -1)) >=3D 0) { netdev_dbg(padapter->pnetdev, "clear key for addr:%pM, camid:%d\n", - MAC_ARG(sta->hwaddr), cam_id); + sta->hwaddr, cam_id); clear_cam_entry(padapter, cam_id); rtw_camid_free(padapter, cam_id); } diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index b61841bf16a5..8297cf85eb7b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -5595,7 +5595,7 @@ u8 setkey_hdl(struct adapter *padapter, u8 *pbuf) write_cam(padapter, cam_id, ctrl, addr, pparm->key); netdev_dbg(padapter->pnetdev, "set group key camid:%d, addr:%pM, kid:%d, type:%s\n", - cam_id, MAC_ARG(addr), pparm->keyid, + cam_id, addr, pparm->keyid, security_type_str(pparm->algorithm)); } =20 @@ -5625,7 +5625,7 @@ u8 set_stakey_hdl(struct adapter *padapter, u8 *pbuf) psta =3D rtw_get_stainfo(pstapriv, pparm->addr); if (!psta) { netdev_dbg(padapter->pnetdev, "%s sta:%pM not found\n", - __func__, MAC_ARG(pparm->addr)); + __func__, pparm->addr); ret =3D H2C_REJECTED; goto exit; } @@ -5640,14 +5640,14 @@ u8 set_stakey_hdl(struct adapter *padapter, u8 *pbu= f) while ((cam_id =3D rtw_camid_search(padapter, pparm->addr, -1)) >=3D 0) { netdev_dbg(padapter->pnetdev, "clear key for addr:%pM, camid:%d\n", - MAC_ARG(pparm->addr), cam_id); + pparm->addr, cam_id); clear_cam_entry(padapter, cam_id); rtw_camid_free(padapter, cam_id); } } else { netdev_dbg(padapter->pnetdev, "set pairwise key camid:%d, addr:%pM, kid:%d, type:%s\n", - cam_id, MAC_ARG(pparm->addr), pparm->keyid, + cam_id, pparm->addr, pparm->keyid, security_type_str(pparm->algorithm)); ctrl =3D BIT(15) | ((pparm->algorithm) << 2) | pparm->keyid; write_cam(padapter, cam_id, ctrl, pparm->addr, pparm->key); diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 5ffefa50699e..3f71e62d0198 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -617,7 +617,7 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta= _info *sta, u8 kid) netdev_dbg(adapter->pnetdev, FUNC_ADPT_FMT " pairwise key with %pM id:%u no room\n", FUNC_ADPT_ARG(adapter), - MAC_ARG(sta->hwaddr), kid); + sta->hwaddr, kid); else netdev_dbg(adapter->pnetdev, FUNC_ADPT_FMT " group key id:%u no room\n", diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/stagin= g/rtl8723bs/include/ieee80211.h index 1098b0209200..8ae6fa6dd63e 100644 --- a/drivers/staging/rtl8723bs/include/ieee80211.h +++ b/drivers/staging/rtl8723bs/include/ieee80211.h @@ -506,8 +506,6 @@ Total: 28-2340 bytes =20 #define DEFAULT_MAX_SCAN_AGE (15 * HZ) #define DEFAULT_FTS 2346 -#define MAC_ARG(x) (x) -#define IP_ARG(x) (x) =20 static inline int is_multicast_mac_addr(const u8 *addr) { diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/st= aging/rtl8723bs/include/osdep_service.h index 8b1634f4091e..6458ff95ff9d 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service.h +++ b/drivers/staging/rtl8723bs/include/osdep_service.h @@ -91,10 +91,6 @@ static inline int rtw_bug_check(void *parg1, void *parg2= , void *parg3, void *par =20 #define _RND(sz, r) ((((sz)+((r)-1))/(r))*(r)) =20 -#ifndef MAC_ARG -#define MAC_ARG(x) (x) -#endif - extern void rtw_free_netdev(struct net_device *netdev); =20 /* Macros for handling unaligned memory accesses */ --=20 2.52.0