From nobody Sat Feb 7 13:41:36 2026 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DF6E2FDC55 for ; Mon, 2 Feb 2026 06:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770014308; cv=none; b=X0nseOljhryoS6W7GJdamXW6VkCtBZq2rFRz0p2rd//KkmjxbqitQ8JJ4r1P4DvuFG9oGuY5gcJGMBxv93P31TUYUe6Yi4dRxvccewkag1517DhFYxzhTvckBK/DgJIDl+K9aRPYyeRkK3vQ/WwlPPTs8YF9WdK2oEpCcD+RYr4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770014308; c=relaxed/simple; bh=c2qyeHjVaOmyrtgY42eDuxJJm5mkYDGCfcQLnxJhSbk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pjMG71zN7kilY91x9WNW1yBK/LUJPnQwMBy/nmYmTAIJs+QV4bSCFcpEUwmiuXX5lDOUyf5FNT1OcYTn90KGZyLCacHVR7VWUl26Vr1HIow9zwdguUyAxJ4iwXTQM3POUcCCMpL0uQ7qwnDSn2nhsuWE7JrrgYmog6v8+0m+czE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gfUCXixJ; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gfUCXixJ" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-649655f14daso3627944d50.0 for ; Sun, 01 Feb 2026 22:38:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770014306; x=1770619106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fAfwHYV8/UgKwbTNXtNiOxc4+en9+lyKeBe4ZozbvW0=; b=gfUCXixJssuagAm4kqhHdDDUyuZ205dOp9sX1frcpd57hlz/8tYoI8cR0G0/TDPtkQ xDxjz68us98hsYSGU2s487PuP533lfB0J7mR0dcl3PbJGlXIROztzjuam/Ay+dJ6MTOz PLUq76jQO2yH71FHlUylbvmNKfY0JvsrgUcpPYE37R8xFkzF5WeAb6HWZWOq4l4J2myF ISWmCAvJW5TQC0ZEF7IRZ8kmzmt3+dW1mUfYwmLmLdaL7+NizxyE5TIRhAxq4VnV6KW2 yugmWKtH1og6AfWWlzzDxW+uEJBdWv4lFexcP8oTM661GS0eSeRORrCRHgZPk9idHeWb ykPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770014306; x=1770619106; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fAfwHYV8/UgKwbTNXtNiOxc4+en9+lyKeBe4ZozbvW0=; b=eveYYjEnPy8h2Mid8EO261OwAJxx/7DebOCNraPpnwo7k+KZ31tiFNdHM5bJctvC59 Lgc5mxT5854dYRAxrYgaPvEyGAUiJTCazkJKQFYam+zoMJkSUtWEMKFXQwEIIyzJMiMt jxA7DN2hrRpAtfBHOMWK1Iro+H3cLZV/ogyLff5LLEaoCCCy87JIv57KxpEj7kk6lcv2 v+Cb7DQ2p+7xvPBmdU/kEeuFA/k61knPFSmW1xWQo5bz5pw8kkJQ5P5MTA1zUztA6Qxw 68RfVK7v9MUOlvffynW1P60ZxND6qTT87b8zlUsLbOatXi0asKOEDWlpX8mOluNqax/q QQNw== X-Forwarded-Encrypted: i=1; AJvYcCVEw16os8TJLTojIBnOX8nlKWofw+3K90cmDqiIA2ECpeJEJf7EEMdwDT8gSppwMDS4HcfqNRDX7xFh0xQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzY5f0dJbByX2FHQwv5maV87Dm1tWFV/r+S47GZzzVSThfhwzha BGuB59HxhOEryj+u7PKnC782HEOnQ+cl9fhz3mpQKMDqX51flaG4cKdu X-Gm-Gg: AZuq6aLimioQM7lc9LWjjTJLQPsbQ0sA8b08R/C/xjFn8bO54KvLlSLMfUgD/Uo3pCU OncwlvSXcH73o3+ilKAZlM8+Lbtth/ZJUMicrh9MBk7P9OBJWM/Oxmgt74npBfMsj/4DzpCwdpc 16B/onZFzBbRSBEJk/D9fbzMWG6K3kjrR7EokgapbY0pe1BVtR3QKcgITwD/r0OwSZcL5uT3AW8 /gH4CgRLheDEZbPND8pLNQXU2Pb2Oa8YW8eGTu8bo4hW/A+HyBwlN5kjqDud2uS+Map2HPi+XRQ oW9tBFfp9HVsXLT0ltnZLxT8W6n6VBRheFKTz+sFnAkD6751s0lT8ceuw3uGHqlBQ6PgKDRB9kS ElYJJrtUkkDp10prNf96QvmS+Ixo/w8EB/wxvFVbdNwH5/qEjZUdazgrELBnaW3M77O3fVcH/v5 lz0l71A0oWOKx9lTc9MhZTpdk= X-Received: by 2002:a53:ac82:0:b0:649:2e3c:7d76 with SMTP id 956f58d0204a3-649a84e5c58mr8022667d50.69.1770014306344; Sun, 01 Feb 2026 22:38:26 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-649960e0965sm8478547d50.13.2026.02.01.22.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 22:38:26 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org, straube.linux@gmail.com Cc: dan.carpenter@linaro.org, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore , stable@vger.kernel.org Subject: [PATCH v1] staging: rtl8723bs: fix null dereference in find_network Date: Mon, 2 Feb 2026 00:38:08 -0600 Message-ID: <20260202063808.664468-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The pwlan variable has the possibility of returning NULL and is not checked for NULL and then later dereferenced. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index f81a29cd6a78..29dd0b56223a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -835,8 +835,11 @@ static void find_network(struct adapter *adapter) struct wlan_network *tgt_network =3D &pmlmepriv->cur_network; =20 pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->networ= k.mac_address); - if (pwlan) - pwlan->fixed =3D false; + + if (!pwlan) + return; + + pwlan->fixed =3D false; =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) && (adapter->stapriv.asoc_sta_count =3D=3D 1)) --=20 2.52.0