From nobody Sat Feb 7 05:52:33 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9D2020C00A for ; Mon, 2 Feb 2026 03:12:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770001980; cv=none; b=eNliYMTLZovaIPYsFVwPN4H6e4y4SdkxeOH+FBn95HLVF4+kMpTdJqBckJp0XqwCdFU+d3+KBvhVjm0b3fQmCYIZ+KTUvyqFwcUNuIcEQBZS/p/CRj6t5wgRCtxydawUC19ywUPMaRyy8waKSxwMO5J8RPTH/lVjSrE4czC1Ojc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770001980; c=relaxed/simple; bh=7yhISprganOOYxh69Ev9h0O7lWNMFwfj4PHkG6GLE90=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=h3s5XXe9dThuVlz66jyDSv3g44Shb3f1HUfw8SmLWm7/L1Z9+hkqg2seMCpITK/BAOu9Nvn4hqcnnK0drTZsP8sTHP7mwxAVZFBwtF13NS9UzRfCQApABGtiqGUyXili8nulG336R/DK9xbnK1J1a6rnfkinbNvQwQhJWbovoW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=gu90QR33; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="gu90QR33" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a8ff2ca490so4784175ad.2 for ; Sun, 01 Feb 2026 19:12:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1770001978; x=1770606778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WmjllnZw+5iXRdcSzwZdOKzRNkr16JL8ICqTiH9EaYg=; b=gu90QR33m99cVjtP00mOl9I97DGmLN7kJ4ZgSdTavgiPv0fbD7rOz5qOsYzMxQXBWS uNnEICUAGnJ/GZ3HyTtWgoVlZ+FcGikc0xgjO4nC5jeFpny52OvR9pML5X/EgWSW0Z3w 2womIXO+jB8jSdw+BcvBX/7fZlyYshZHeFUfgnZQQHUkT+x4hfnq0hPosAUAbtaNa95n w99SwYzHBrEa61boQu3M7n6dDZbPXpDZkdtmuLOTb6gaQa9xfjTFC7qHkc7dYl6gT+fN WBysgIHvH/n/nadOtwOhidLuLunyVHDCABok247gxv0GMSgbkX+JIXveclKMFJ6Yls9K kt0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770001978; x=1770606778; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WmjllnZw+5iXRdcSzwZdOKzRNkr16JL8ICqTiH9EaYg=; b=e07UJS9ZLMbz+ahe52mEQ/9lYeLh0Rd3xvsLDYRAnAOAr+k9ijP5WGUJDw8Mw8Q7tQ NG72mHcvXQu2myR6TaHOddVKXAel0iwqpY5SWL18u1LdNZCpgdIaAJnnq8xOWY5GCvcW nz0tM1PYDv2Je1OjvyRwrQ70nEETczND4lPiDVCGYBnzhILBVHtdSkdl5WgveDtE8R3x kNQn0MDvtp3Yqj6ukItB4dl+u+DxOyhv6OlDu88voB+BHf5AAkyfbjzPXXeVmKb/fo17 mt7Q5+DdSyiksFgXI8js+CUGF57CF+NWJuAwpqfopyCEMO9BY15U4nnCEDw6w0o9+NJ/ Gl6A== X-Forwarded-Encrypted: i=1; AJvYcCVuzRLN11i6s7v7iBERnnI94TQL+u+N6BwUfUqxERxHGEFV+WUUrVOY8DyPgIiGCkMcjA7NIpMe7DZIdWs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw97T5aVmxU3Gk/sqDQcEa3+ckZvMYpA61iR1itQMCmKk0fvcx4 liFiTb3p5C8Z3WK8ugglyg4TEn17xfiysWNc3zbbUED7byiGI8D8fnXhxfMUfbAfgCQ= X-Gm-Gg: AZuq6aLkDxXSSSrbR20Snpipcl1AgjET38bzDYXM74bihSIzm4Yg3yuBPEYY8Ev48dd zql2Qz1zsJmCDEewp/KaDicPCq+Xe4W6xGhx7DJhZBMIq8X/GRs7+lfKxzyGa909Xo6A3SzvVvA gPQk3ICQgl0w9Y1xV7EdzNOYvXBVyAhH30dCyFxi9NRAy1opLIbLuhPzRXsF7AjSdYyshMkEy1k NdoG6X9OINsiOWT1KC81i7twMuobZM7qsTMxFIGw8wjz9hxbSQU3jhKTmUYNrxVa3/j0ePbj0iN laQBBpUwtj7FFj1JUbZRYDuqKjojvrRpcz6sGB1/aUnec0QTI7KOtFHZGGcHdcQt/S2sM6QabD+ nY5aBx8co2HEu4aKZ4iEq/3O+aod9AJh4xABmsOfbefH3i8kePwpiykxFEKijG55lr6YIMUQAxU 9dVGfPGn6Z1KNq87L5hVnputDbPLDc9eBwVHNsl3iJdXC/FCBuCAm2ErEPbg== X-Received: by 2002:a17:903:190:b0:2a0:34ee:3725 with SMTP id d9443c01a7336-2a8d7ed32ecmr103955495ad.14.1770001978153; Sun, 01 Feb 2026 19:12:58 -0800 (PST) Received: from tianci-mac.bytedance.net ([63.216.146.167]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b5d93cdsm127466295ad.70.2026.02.01.19.12.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 19:12:57 -0800 (PST) From: Zhang Tianci To: mst@redhat.com, jasowang@redhat.com Cc: xuanzhuo@linux.alibaba.com, eperezma@redhat.com, marco.crivellari@suse.com, anders.roxell@linaro.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Zhang Tianci , stable@vger.kernel.org, Xie Yongji Subject: [PATCH v2] vduse: Fix race in vduse_dev_msg_sync and vduse_dev_read_iter Date: Mon, 2 Feb 2026 11:12:12 +0800 Message-ID: <20260202031212.26871-1-zhangtianci.1997@bytedance.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is one race case in vduse_dev_msg_sync and vduse_dev_read_iter: vduse_dev_read_iter(): lock(msg_lock); dequeue_msg(send_list); unlock(msg_lock); vduse_dev_msg_sync(): wait_timeout() finish lock(msg_lock); check msg->complete is false list_del(msg); <- double list_del() crash! To fix this case, we shall ensure vduse_msg is on send_list or recv_list outside the msg_lock critical section. Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace") Cc: stable@vger.kernel.org Signed-off-by: Zhang Tianci Reviewed-by: Xie Yongji --- v2: - Rewrite commit message. [Michael] - Add Fixes tag and cc stable email list. [Eugenio] - Rewrite one comment. [Michael] v1: https://lkml.org/lkml/2026/1/30/323 drivers/vdpa/vdpa_user/vduse_dev.c | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vd= use_dev.c index ae357d014564c..a70d0580d54e8 100644 --- a/drivers/vdpa/vdpa_user/vduse_dev.c +++ b/drivers/vdpa/vdpa_user/vduse_dev.c @@ -325,6 +325,7 @@ static ssize_t vduse_dev_read_iter(struct kiocb *iocb, = struct iov_iter *to) struct file *file =3D iocb->ki_filp; struct vduse_dev *dev =3D file->private_data; struct vduse_dev_msg *msg; + struct vduse_dev_request req; int size =3D sizeof(struct vduse_dev_request); ssize_t ret; =20 @@ -339,7 +340,7 @@ static ssize_t vduse_dev_read_iter(struct kiocb *iocb, = struct iov_iter *to) =20 ret =3D -EAGAIN; if (file->f_flags & O_NONBLOCK) - goto unlock; + break; =20 spin_unlock(&dev->msg_lock); ret =3D wait_event_interruptible_exclusive(dev->waitq, @@ -349,17 +350,30 @@ static ssize_t vduse_dev_read_iter(struct kiocb *iocb= , struct iov_iter *to) =20 spin_lock(&dev->msg_lock); } + if (!msg) { + spin_unlock(&dev->msg_lock); + return ret; + } + + memcpy(&req, &msg->req, sizeof(req)); + /* + * We must ensure vduse_msg is on send_list or recv_list before unlock + * dev->msg_lock. Because vduse_dev_msg_sync() may be timeout when we + * copy data to userspace, and will call list_del() for this msg. + */ + vduse_enqueue_msg(&dev->recv_list, msg); spin_unlock(&dev->msg_lock); - ret =3D copy_to_iter(&msg->req, size, to); - spin_lock(&dev->msg_lock); + + ret =3D copy_to_iter(&req, size, to); if (ret !=3D size) { + spin_lock(&dev->msg_lock); + /* Roll back: move msg back to send_list if still pending. */ + msg =3D vduse_find_msg(&dev->recv_list, req.request_id); + if (msg) + vduse_enqueue_msg(&dev->send_list, msg); + spin_unlock(&dev->msg_lock); ret =3D -EFAULT; - vduse_enqueue_msg(&dev->send_list, msg); - goto unlock; } - vduse_enqueue_msg(&dev->recv_list, msg); -unlock: - spin_unlock(&dev->msg_lock); =20 return ret; } --=20 2.39.5