From nobody Sun Feb 8 07:58:24 2026 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC118366DAA for ; Mon, 2 Feb 2026 13:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770040345; cv=none; b=GlBxd3sdzbAPE5iK3GV18E5rf0Q5hwz6J6P48KM5aUNB1veJ7fTeR3y2LySJ5LapNOat68bHjeP7boqdhYml4UJtQJshvViduX5VpbtCHj/pTJpULACYI/o2ROHphNz5bHhR9vScErHMv2coCH6aEsYob8IJhYc8wiqZ9bvUUJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770040345; c=relaxed/simple; bh=4JqWnMhK6PLoPiefZoNEA93GP07694S3Z1Hk/HpgYUM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SV/Qjm9w/CfXd9/KyKSF2R0IFoXOBaX/u1fAxKbWSRMJRDmSf7mKAZWGeZ1CaIyz1rKwI+nUpIpT5i6pMl1OFEF3Vw3rtqo1GB/iqni81nOF9YyxNIQFtZ6i++HQHEfSyRDlTKq/pKno24LDwDOtEQaWmtNXYnexmYfNkhFNWTk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=CGpB9aMB; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="CGpB9aMB" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 50278240028 for ; Mon, 2 Feb 2026 14:52:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017; t=1770040341; bh=Raakbe0iRcI1qlqt5QiVs+83FkT9mKWPg/BdaQTh87U=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=CGpB9aMBI/gGicGNVa/QS2knlHMl7QLIRXC+bWml4uWuXgf/Wr1BY9hvDVm3zYfDr 6FCPmVQf5fI8RufUMYwZLxnHX5fWYWCzJIq3hqlD0axxArVO5uI1JGuwmdjcDmTCX1 5b4359mcUV30VCmvkc9weU2BScPEa7B8P7yYxCzIlj7SsvuaUniwSQk8LOrgIUaEBh mH+ZQT9aFXvczJwpDwow8cXnvY6SjWfemjT0cHGW6ktf7pYDFxefTs7qtcklvYQV2S a9jSyUFHbDiaLltAVF1494PlBHQEVC06kTC3rbmRjuUb3qV4twaSn7AdBbP4R4hPNM DVmO/9OvxQBQQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4f4SjF72Ccz6tsb; Mon, 2 Feb 2026 14:52:17 +0100 (CET) From: Markus Probst Date: Mon, 02 Feb 2026 13:52:20 +0000 Subject: [PATCH v11 1/3] rust: leds: add basic led classdev abstractions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260202-rust_leds-v11-1-585d1c8be20c@posteo.de> References: <20260202-rust_leds-v11-0-585d1c8be20c@posteo.de> In-Reply-To: <20260202-rust_leds-v11-0-585d1c8be20c@posteo.de> To: Lee Jones , Pavel Machek , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= Cc: rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=18258; i=markus.probst@posteo.de; h=from:subject:message-id; bh=4JqWnMhK6PLoPiefZoNEA93GP07694S3Z1Hk/HpgYUM=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBpgKwI+hPrJlE5BZ7bu6wBoZGIj/FAHSen8LQod qTZA5ekekSJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaYCsCBsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMSwyLDIACgkQNHYf+OetQ9LY+Q//S/qbX/hjPII9nLWMbYmsLo+PgrtZkli 6JYH9CS7ddYIr2oULxu4J2fHCS1XF/a3dGXERepH8tt0oHeObAlukraThHJb5e2Ke5ACQ6PcPFL VHwLzFEuRmGMuUQjWvEre7tS0CohUFVn6I/o+XL2kxMyDDH1jEzj/14TwSnJnzMFJSECc+nHx6P 2qbL/wH2v+knB/Rv2D9LTPswucDGYOb8W/WKkrVuQGUrJVM4k66sYxaRUDIaBHt9sxVK0XG3UId UaCQzSQI4mXNOSPl12n8armssKh8ctdb56TPRzdbR9NY0kDcpTOH0F0CD7/qhfYlDcxk5JxSuLy /TDesmitSP4qxpqQ4FK/aBkSQPQBrgocGJ2hL6zt+O/vAoXqv98g5BcRbDxmoj98qJhM0kAj0LB a8NAuWZ1XJITAFZgc+0kd+q4r4O4y2JV4hi40TLo8bou+JjVIQszvak0sirstYL9VVkoObpkwIo B7tUVjvcFTe5qW0NLTLe0T8TYS3+vr2/r7SFmZJysZIXouPgXb1Tw7ZmPMsLCRbUgXie0950PBJ TaIdlEt1OuWldd7UWUCyUOKsBCXNTCIo+7CKlorFSleVPfZTlcb2DcHq7UDWlVORrpCHVKKhO5F 76AxkSNdsdB2o3Uvdlz6GDklM6+buCJ+aQpoEXLcmvKSzLjwnNwQ= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Implement the core abstractions needed for led class devices, including: * `led::LedOps` - the trait for handling leds, including `brightness_set`, `brightness_get` and `blink_set` * `led::InitData` - data set for the led class device * `led::Device` - a safe wrapper around `led_classdev` Signed-off-by: Markus Probst --- MAINTAINERS | 7 + rust/kernel/led.rs | 453 +++++++++++++++++++++++++++++++++++++++++++++++++= ++++ rust/kernel/lib.rs | 1 + 3 files changed, 461 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0efa8cc6775b..26765fecb9a9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14279,6 +14279,13 @@ F: drivers/leds/ F: include/dt-bindings/leds/ F: include/linux/leds.h =20 +LED SUBSYSTEM [RUST] +M: Markus Probst +L: linux-leds@vger.kernel.org +L: rust-for-linux@vger.kernel.org +S: Maintained +F: rust/kernel/led.rs + LEGO MINDSTORMS EV3 R: David Lechner S: Maintained diff --git a/rust/kernel/led.rs b/rust/kernel/led.rs new file mode 100644 index 000000000000..9acb6946f3da --- /dev/null +++ b/rust/kernel/led.rs @@ -0,0 +1,453 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Abstractions for the leds driver model. +//! +//! C header: [`include/linux/leds.h`](srctree/include/linux/leds.h) + +use core::{ + marker::PhantomData, + mem::transmute, + ptr::NonNull, // +}; + +use crate::{ + container_of, + device::{ + self, + property::FwNode, + AsBusDevice, + Bound, // + }, + devres::Devres, + error::{ + from_result, + to_result, + VTABLE_DEFAULT_ERROR, // + }, + macros::vtable, + prelude::*, + str::CStrExt, + types::{ + ARef, + Opaque, // + }, // +}; + +/// The led class device representation. +/// +/// This structure represents the Rust abstraction for a C `struct led_cla= ssdev`. +#[pin_data(PinnedDrop)] +pub struct Device { + #[pin] + ops: T, + #[pin] + classdev: Opaque, +} + +/// The led init data representation. +/// +/// This structure represents the Rust abstraction for a C `struct led_ini= t_data` with additional +/// fields from `struct led_classdev`. +#[derive(Default)] +pub struct InitData<'a> { + fwnode: Option>, + devicename: Option<&'a CStr>, + devname_mandatory: bool, + initial_brightness: u32, + default_trigger: Option<&'a CStr>, + color: Color, +} + +impl InitData<'static> { + /// Creates a new [`InitData`]. + pub fn new() -> Self { + Self::default() + } +} + +impl<'a> InitData<'a> { + /// Sets the firmware node. + pub fn fwnode(self, fwnode: Option>) -> Self { + Self { fwnode, ..self } + } + + /// Sets the device name. + pub fn devicename(self, devicename: &'a CStr) -> Self { + Self { + devicename: Some(devicename), + ..self + } + } + + /// Sets if a device name is mandatory. + pub fn devicename_mandatory(self, mandatory: bool) -> Self { + Self { + devname_mandatory: mandatory, + ..self + } + } + + /// Sets the initial brightness value for the led. + /// + /// The default brightness is 0. + /// If [`LedOps::brightness_get`] is implemented, this value will be i= gnored. + pub fn initial_brightness(self, brightness: u32) -> Self { + Self { + initial_brightness: brightness, + ..self + } + } + + /// Set the default led trigger. + /// + /// This value can be overwritten by the "linux,default-trigger" fwnod= e property. + pub fn default_trigger(self, trigger: &'a CStr) -> Self { + Self { + default_trigger: Some(trigger), + ..self + } + } + + /// Sets the color of the led. + /// + /// This value can be overwritten by the "color" fwnode property. + pub fn color(self, color: Color) -> Self { + Self { color, ..self } + } +} + +/// Trait defining the operations for a LED driver. +/// +/// # Examples +/// ``` +/// use kernel::{ +/// device, +/// devres::Devres, +/// led, +/// macros::vtable, +/// platform, +/// prelude::*, // +/// }; +/// +/// struct MyLedOps; +/// +/// +/// #[vtable] +/// impl led::LedOps for MyLedOps { +/// type Bus =3D platform::Device; +/// const BLOCKING: bool =3D false; +/// const MAX_BRIGHTNESS: u32 =3D 255; +/// +/// fn brightness_set( +/// &self, +/// _dev: &platform::Device, +/// _classdev: &led::Device, +/// _brightness: u32 +/// ) -> Result<()> { +/// // Set the brightness for the led here +/// Ok(()) +/// } +/// } +/// +/// fn register_my_led( +/// parent: &platform::Device, +/// ) -> Result>>>> { +/// KBox::pin_init(led::Device::new( +/// parent, +/// led::InitData::new(), +/// Ok(MyLedOps), +/// ), GFP_KERNEL) +/// } +/// ``` +/// Led drivers must implement this trait in order to register and handle = a [`Device`]. +#[vtable] +pub trait LedOps: Send + 'static + Sized { + /// The bus device required by the implementation. + #[allow(private_bounds)] + type Bus: AsBusDevice; + /// If set true, [`LedOps::brightness_set`] and [`LedOps::blink_set`] = must perform the + /// operation immediately. If set false, they must not sleep. + const BLOCKING: bool; + /// The max brightness level. + const MAX_BRIGHTNESS: u32; + + /// Sets the brightness level. + /// + /// See also [`LedOps::BLOCKING`]. + fn brightness_set( + &self, + dev: &Self::Bus, + classdev: &Device, + brightness: u32, + ) -> Result<()>; + + /// Gets the current brightness level. + fn brightness_get(&self, _dev: &Self::Bus, _classdev: &Device) -= > u32 { + build_error!(VTABLE_DEFAULT_ERROR) + } + + /// Activates hardware accelerated blinking. + /// + /// delays are in milliseconds. If both are zero, a sensible default s= hould be chosen. + /// The caller should adjust the timings in that case and if it can't = match the values + /// specified exactly. Setting the brightness to 0 will disable the ha= rdware accelerated + /// blinking. + /// + /// See also [`LedOps::BLOCKING`]. + fn blink_set( + &self, + _dev: &Self::Bus, + _classdev: &Device, + _delay_on: &mut usize, + _delay_off: &mut usize, + ) -> Result<()> { + build_error!(VTABLE_DEFAULT_ERROR) + } +} + +/// Led colors. +#[derive(Copy, Clone, Debug, Default)] +#[repr(u32)] +#[non_exhaustive] +#[expect( + missing_docs, + reason =3D "it shouldn't be necessary to document each color" +)] +pub enum Color { + #[default] + White =3D bindings::LED_COLOR_ID_WHITE, + Red =3D bindings::LED_COLOR_ID_RED, + Green =3D bindings::LED_COLOR_ID_GREEN, + Blue =3D bindings::LED_COLOR_ID_BLUE, + Amber =3D bindings::LED_COLOR_ID_AMBER, + Violet =3D bindings::LED_COLOR_ID_VIOLET, + Yellow =3D bindings::LED_COLOR_ID_YELLOW, + Ir =3D bindings::LED_COLOR_ID_IR, + Multi =3D bindings::LED_COLOR_ID_MULTI, + Rgb =3D bindings::LED_COLOR_ID_RGB, + Purple =3D bindings::LED_COLOR_ID_PURPLE, + Orange =3D bindings::LED_COLOR_ID_ORANGE, + Pink =3D bindings::LED_COLOR_ID_PINK, + Cyan =3D bindings::LED_COLOR_ID_CYAN, + Lime =3D bindings::LED_COLOR_ID_LIME, +} + +impl TryFrom for Color { + type Error =3D Error; + + fn try_from(value: u32) -> core::result::Result { + const _: () =3D { + assert!(bindings::LED_COLOR_ID_MAX =3D=3D 15); + }; + if value < bindings::LED_COLOR_ID_MAX { + // SAFETY: + // - `Color` is represented as `u32` + // - the const block above guarantees that no additional color= has been added + // - `value` is guaranteed to be in the color id range + Ok(unsafe { transmute::(value) }) + } else { + Err(EINVAL) + } + } +} + +// SAFETY: A `led::Device` can be unregistered from any thread. +unsafe impl Send for Device {} + +// SAFETY: `led::Device` can be shared among threads because all methods o= f `led::Device` +// are thread safe. +unsafe impl Sync for Device {} + +impl Device { + /// Registers a new led classdev. + /// + /// The [`Device`] will be unregistered on drop. + pub fn new<'a>( + parent: &'a T::Bus, + init_data: InitData<'a>, + ops: impl PinInit + 'a, + ) -> impl PinInit, Error> + 'a { + Devres::new( + parent.as_ref(), + try_pin_init!(Self { + ops <- ops, + classdev <- Opaque::try_ffi_init(|ptr: *mut bindings::led_= classdev| { + // SAFETY: `try_ffi_init` guarantees that `ptr` is val= id for write. + // `led_classdev` gets fully initialized in-place by + // `led_classdev_register_ext` including `mutex` and `= list_head`. + unsafe { + ptr.write(bindings::led_classdev { + brightness_set: (!T::BLOCKING) + .then_some(Adapter::::brightness_set_ca= llback), + brightness_set_blocking: T::BLOCKING + .then_some(Adapter::::brightness_set_bl= ocking_callback), + brightness_get: T::HAS_BRIGHTNESS_GET + .then_some(Adapter::::brightness_get_ca= llback), + blink_set: T::HAS_BLINK_SET.then_some(Adapter:= :::blink_set_callback), + max_brightness: T::MAX_BRIGHTNESS, + brightness: init_data.initial_brightness, + default_trigger: init_data + .default_trigger + .map_or(core::ptr::null(), CStrExt::as_cha= r_ptr), + color: init_data.color as u32, + ..bindings::led_classdev::default() + }) + }; + + let mut init_data_raw =3D bindings::led_init_data { + fwnode: init_data + .fwnode + .as_ref() + .map_or(core::ptr::null_mut(), |fwnode| fwnode= .as_raw()), + default_label: core::ptr::null(), + devicename: init_data + .devicename + .map_or(core::ptr::null(), CStrExt::as_char_pt= r), + devname_mandatory: init_data.devname_mandatory, + }; + + // SAFETY: + // - `parent.as_raw()` is guaranteed to be a pointer t= o a valid `device` + // or a null pointer. + // - `ptr` is guaranteed to be a pointer to an initial= ized `led_classdev`. + to_result(unsafe { + bindings::led_classdev_register_ext( + parent.as_ref().as_raw(), + ptr, + &raw mut init_data_raw, + ) + })?; + + core::mem::forget(init_data.fwnode); // keep the refer= ence count incremented + + Ok::<_, Error>(()) + }), + }), + ) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + unsafe fn from_raw<'a>(led_cdev: *mut bindings::led_classdev) -> &'a S= elf { + // SAFETY: The function's contract guarantees that `led_cdev` poin= ts to a `led_classdev` + // field embedded within a valid `led::Device`. `container_of!` ca= n therefore + // safely calculate the address of the containing struct. + unsafe { &*container_of!(Opaque::cast_from(led_cdev), Self, classd= ev) } + } + + fn parent(&self) -> &device::Device { + // SAFETY: + // - `self.classdev.get()` is guaranteed to be a valid pointer to = `led_classdev`. + unsafe { device::Device::from_raw((*(*self.classdev.get()).dev).pa= rent) } + } +} + +struct Adapter { + _p: PhantomData, +} + +impl Adapter { + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// This function is called on setting the brightness of a led. + unsafe extern "C" fn brightness_set_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained in `T= ::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent()) }; + + let _ =3D classdev.ops.brightness_set(parent, classdev, brightness= ); + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// This function is called on setting the brightness of a led immedia= tely. + unsafe extern "C" fn brightness_set_blocking_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained i= n `T::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent())= }; + + classdev.ops.brightness_set(parent, classdev, brightness)?; + Ok(0) + }) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// This function is called on getting the brightness of a led. + unsafe extern "C" fn brightness_get_callback(led_cdev: *mut bindings::= led_classdev) -> u32 { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained in `T= ::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent()) }; + + classdev.ops.brightness_get(parent, classdev) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// `delay_on` and `delay_off` must be valid pointers to `usize` and h= ave + /// exclusive access for the period of this function. + /// This function is called on enabling hardware accelerated blinking. + unsafe extern "C" fn blink_set_callback( + led_cdev: *mut bindings::led_classdev, + delay_on: *mut usize, + delay_off: *mut usize, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained i= n `T::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent())= }; + + classdev.ops.blink_set( + parent, + classdev, + // SAFETY: The function's contract guarantees that `delay_= on` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_on }, + // SAFETY: The function's contract guarantees that `delay_= off` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_off }, + )?; + Ok(0) + }) + } +} + +#[pinned_drop] +impl PinnedDrop for Device { + fn drop(self: Pin<&mut Self>) { + let raw =3D self.classdev.get(); + // SAFETY: The existence of `self` guarantees that `self.classdev.= get()` is a pointer to a + // valid `struct led_classdev`. + let dev: &device::Device =3D unsafe { device::Device::from_raw((*r= aw).dev) }; + + let _fwnode =3D dev + .fwnode() + // SAFETY: the reference count of `fwnode` has previously been + // incremented in `led::Device::new`. + .map(|fwnode| unsafe { ARef::from_raw(NonNull::from(fwnode)) }= ); + + // SAFETY: The existence of `self` guarantees that `self.classdev`= has previously been + // successfully registered with `led_classdev_register_ext`. + unsafe { bindings::led_classdev_unregister(self.classdev.get()) }; + } +} diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index f812cf120042..231818e0614b 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -108,6 +108,7 @@ pub mod jump_label; #[cfg(CONFIG_KUNIT)] pub mod kunit; +pub mod led; pub mod list; pub mod maple_tree; pub mod miscdevice; --=20 2.52.0 From nobody Sun Feb 8 07:58:24 2026 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E69336AB40 for ; Mon, 2 Feb 2026 13:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770040348; cv=none; b=pO43xCQGDRbb8uG0P6Qaiw0pm4/n0k79aqjMD8gD0ErT0WX+r9OeGnhpn4Q/TdaGzrPt6QYiF8eYtkp4bN7Sj9HD3yJ3jkmtDzwlbt39gzCkouYn7iPA1+6tvfmOQTIKTb/5H9rKpl+SUiULE8V1doEKz9jQohgTK7LYSvvV0gg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770040348; c=relaxed/simple; bh=H5Q0+I+fCGBDR9OHnNWrd4iwIe5aKb5v7THFJ6Mz3PA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nSkY1GWdsSPdG5IdSOhQb47mH2pJnvR3wdUONxlIQmv1zVUd2ehrrjIYLy59Bptnh8e/vXLu8YoWrf9AdugEepvcbiiAQhK5E4pt3yN5JrsTacVBO4Hlda2K7lbHZo/Go76XEPWDm+wI2nCCtfBBnMy8mgKvdsmrxHW7nGXaFrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=RgnGOeau; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="RgnGOeau" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1E7B1240029 for ; Mon, 2 Feb 2026 14:52:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017; t=1770040344; bh=RZjaAAmHGfavWhX/1IOS4rgZCyYkSQLl+Y1dLntXLmQ=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=RgnGOeau1k6KdxDNJHw69YFWcYN3B4YR0M0HNDKwe/cKNcIILzcCCHVFtAMLI4Jyl 79YRRUjV4b8O5kNh9mTtzpArmDQ8bPSRILD62g0NKyNQjKOGO8cPD/yEWz/U3xMFlZ /87XMLBtnsk4yjNFBStkCU7yomUjHNNB2XcGcTLKpT/wvuK9HXd2BFjqh94Ij52HP0 oEUNEO590Yg+Dx422hSF/MCDX4mGtVmfJ1dfiu/Ur//B5ojSSdHcl3UBaHszyQVZ/w yCL+Pxd9RA69rldweNY77KO8IruiP0CYbgFSxOPwEsQtZev2sh+XCY3B2y3YeQJDuv 56xqJ3UWbbwJA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4f4SjJ3HHMz6tyc; Mon, 2 Feb 2026 14:52:20 +0100 (CET) From: Markus Probst Date: Mon, 02 Feb 2026 13:52:22 +0000 Subject: [PATCH v11 2/3] rust: leds: split generic and normal led classdev abstractions up Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260202-rust_leds-v11-2-585d1c8be20c@posteo.de> References: <20260202-rust_leds-v11-0-585d1c8be20c@posteo.de> In-Reply-To: <20260202-rust_leds-v11-0-585d1c8be20c@posteo.de> To: Lee Jones , Pavel Machek , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= Cc: rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=23730; i=markus.probst@posteo.de; h=from:subject:message-id; bh=H5Q0+I+fCGBDR9OHnNWrd4iwIe5aKb5v7THFJ6Mz3PA=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBpgKwKh4Lu43OayWOiixjqrplanDiqWrD5zeWsw hy5ZPhJPcGJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaYCsChsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMSwyLDIACgkQNHYf+OetQ9JSeBAAgj+4uXFlPa8gzIj72fBY4fpvFcjSXk4 DnKrpFKOzLn3uvKw6AVAq4YUAUbSnTn9WHvH4MCAzq3cV5ULg3cdZrC/Kms39Y69iLYotkPlm0j XoTbniH2qWPSgTcMvYbr1W5m5srElnjxoymu0oVJwnKslqWDOc97ew1ULr2okGtZnUWyYWFndn+ 5ObN4Hft1ngU9W2B8b1sHkmJH+EZHsHYmPZIPHtllLEnNVDHsrj/C65SR8zCQlF6tRSSMVr2/72 d+FDOHc1FJKPA/9FB51Epw7B7TNcECRXZ0TcutqlAxOOFT4KGbJxz/7Tj6d8ZCSotae4jCazaMc xm6a9MGxfWXvxjEVo6czTNI3lbvP6io595O3gZbvOiQHeOnS6EAJpIThZiCeAGYjdVKWfqzg0Na wd4Jwdj1+TrG7yhC15bRdv4FLH2+y7TXg9JjyqafE0FFs5R3X6quUm1iTf2eKTcdbZUvZUb/GNQ tQK0B9lqmxYZzVJzHNjgwg89/BBHQLIMzDzWY8DerybsaL8REz10HRv8YF2Cj63I0HGvNQZyas5 VAw1ag0vhtuPFlLXRkuh4w4l4G6sue0YVpFYvDBXjNPXsnohmIBsXumO/wQfij4AAE7F5URrHeF lKtVN95G1KXW8SAHQmtak9WI3kotekccUIP3LaTzFpk3B/my/Rx0= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Move code specific to normal led class devices into a separate file and introduce the `led::Mode` trait to allow for other types of led class devices in `led::LedOps`. Signed-off-by: Markus Probst --- MAINTAINERS | 1 + rust/kernel/led.rs | 245 ++++++------------------------------------= ---- rust/kernel/led/normal.rs | 226 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 259 insertions(+), 213 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 26765fecb9a9..5f8b59678785 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14285,6 +14285,7 @@ L: linux-leds@vger.kernel.org L: rust-for-linux@vger.kernel.org S: Maintained F: rust/kernel/led.rs +F: rust/kernel/led/ =20 LEGO MINDSTORMS EV3 R: David Lechner diff --git a/rust/kernel/led.rs b/rust/kernel/led.rs index 9acb6946f3da..a32473d61c61 100644 --- a/rust/kernel/led.rs +++ b/rust/kernel/led.rs @@ -33,16 +33,9 @@ }, // }; =20 -/// The led class device representation. -/// -/// This structure represents the Rust abstraction for a C `struct led_cla= ssdev`. -#[pin_data(PinnedDrop)] -pub struct Device { - #[pin] - ops: T, - #[pin] - classdev: Opaque, -} +mod normal; + +pub use normal::{Device, Normal}; =20 /// The led init data representation. /// @@ -135,6 +128,7 @@ pub fn color(self, color: Color) -> Self { /// #[vtable] /// impl led::LedOps for MyLedOps { /// type Bus =3D platform::Device; +/// type Mode =3D led::Normal; /// const BLOCKING: bool =3D false; /// const MAX_BRIGHTNESS: u32 =3D 255; /// @@ -165,6 +159,12 @@ pub trait LedOps: Send + 'static + Sized { /// The bus device required by the implementation. #[allow(private_bounds)] type Bus: AsBusDevice; + + /// The led mode to use. + /// + /// See [`Mode`]. + type Mode: Mode; + /// If set true, [`LedOps::brightness_set`] and [`LedOps::blink_set`] = must perform the /// operation immediately. If set false, they must not sleep. const BLOCKING: bool; @@ -177,12 +177,17 @@ pub trait LedOps: Send + 'static + Sized { fn brightness_set( &self, dev: &Self::Bus, - classdev: &Device, + classdev: &::Device, brightness: u32, ) -> Result<()>; =20 /// Gets the current brightness level. - fn brightness_get(&self, _dev: &Self::Bus, _classdev: &Device) -= > u32 { + fn brightness_get( + &self, + dev: &Self::Bus, + classdev: &::Device, + ) -> u32 { + let _ =3D (dev, classdev); build_error!(VTABLE_DEFAULT_ERROR) } =20 @@ -196,11 +201,12 @@ fn brightness_get(&self, _dev: &Self::Bus, _classdev:= &Device) -> u32 { /// See also [`LedOps::BLOCKING`]. fn blink_set( &self, - _dev: &Self::Bus, - _classdev: &Device, - _delay_on: &mut usize, - _delay_off: &mut usize, + dev: &Self::Bus, + classdev: &::Device, + delay_on: &mut usize, + delay_off: &mut usize, ) -> Result<()> { + let _ =3D (dev, classdev, delay_on, delay_off); build_error!(VTABLE_DEFAULT_ERROR) } } @@ -251,203 +257,16 @@ fn try_from(value: u32) -> core::result::Result { } } =20 -// SAFETY: A `led::Device` can be unregistered from any thread. -unsafe impl Send for Device {} - -// SAFETY: `led::Device` can be shared among threads because all methods o= f `led::Device` -// are thread safe. -unsafe impl Sync for Device {} - -impl Device { - /// Registers a new led classdev. - /// - /// The [`Device`] will be unregistered on drop. - pub fn new<'a>( - parent: &'a T::Bus, - init_data: InitData<'a>, - ops: impl PinInit + 'a, - ) -> impl PinInit, Error> + 'a { - Devres::new( - parent.as_ref(), - try_pin_init!(Self { - ops <- ops, - classdev <- Opaque::try_ffi_init(|ptr: *mut bindings::led_= classdev| { - // SAFETY: `try_ffi_init` guarantees that `ptr` is val= id for write. - // `led_classdev` gets fully initialized in-place by - // `led_classdev_register_ext` including `mutex` and `= list_head`. - unsafe { - ptr.write(bindings::led_classdev { - brightness_set: (!T::BLOCKING) - .then_some(Adapter::::brightness_set_ca= llback), - brightness_set_blocking: T::BLOCKING - .then_some(Adapter::::brightness_set_bl= ocking_callback), - brightness_get: T::HAS_BRIGHTNESS_GET - .then_some(Adapter::::brightness_get_ca= llback), - blink_set: T::HAS_BLINK_SET.then_some(Adapter:= :::blink_set_callback), - max_brightness: T::MAX_BRIGHTNESS, - brightness: init_data.initial_brightness, - default_trigger: init_data - .default_trigger - .map_or(core::ptr::null(), CStrExt::as_cha= r_ptr), - color: init_data.color as u32, - ..bindings::led_classdev::default() - }) - }; - - let mut init_data_raw =3D bindings::led_init_data { - fwnode: init_data - .fwnode - .as_ref() - .map_or(core::ptr::null_mut(), |fwnode| fwnode= .as_raw()), - default_label: core::ptr::null(), - devicename: init_data - .devicename - .map_or(core::ptr::null(), CStrExt::as_char_pt= r), - devname_mandatory: init_data.devname_mandatory, - }; - - // SAFETY: - // - `parent.as_raw()` is guaranteed to be a pointer t= o a valid `device` - // or a null pointer. - // - `ptr` is guaranteed to be a pointer to an initial= ized `led_classdev`. - to_result(unsafe { - bindings::led_classdev_register_ext( - parent.as_ref().as_raw(), - ptr, - &raw mut init_data_raw, - ) - })?; - - core::mem::forget(init_data.fwnode); // keep the refer= ence count incremented - - Ok::<_, Error>(()) - }), - }), - ) - } - - /// # Safety - /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a - /// `led::Device`. - unsafe fn from_raw<'a>(led_cdev: *mut bindings::led_classdev) -> &'a S= elf { - // SAFETY: The function's contract guarantees that `led_cdev` poin= ts to a `led_classdev` - // field embedded within a valid `led::Device`. `container_of!` ca= n therefore - // safely calculate the address of the containing struct. - unsafe { &*container_of!(Opaque::cast_from(led_cdev), Self, classd= ev) } - } - - fn parent(&self) -> &device::Device { - // SAFETY: - // - `self.classdev.get()` is guaranteed to be a valid pointer to = `led_classdev`. - unsafe { device::Device::from_raw((*(*self.classdev.get()).dev).pa= rent) } - } -} - -struct Adapter { - _p: PhantomData, -} - -impl Adapter { - /// # Safety - /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a - /// `led::Device`. - /// This function is called on setting the brightness of a led. - unsafe extern "C" fn brightness_set_callback( - led_cdev: *mut bindings::led_classdev, - brightness: u32, - ) { - // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a - // `led_classdev` embedded within a `led::Device`. - let classdev =3D unsafe { Device::::from_raw(led_cdev) }; - // SAFETY: `classdev.parent()` is guaranteed to be contained in `T= ::Bus`. - let parent =3D unsafe { T::Bus::from_device(classdev.parent()) }; - - let _ =3D classdev.ops.brightness_set(parent, classdev, brightness= ); - } - - /// # Safety - /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a - /// `led::Device`. - /// This function is called on setting the brightness of a led immedia= tely. - unsafe extern "C" fn brightness_set_blocking_callback( - led_cdev: *mut bindings::led_classdev, - brightness: u32, - ) -> i32 { - from_result(|| { - // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a - // `led_classdev` embedded within a `led::Device`. - let classdev =3D unsafe { Device::::from_raw(led_cdev) }; - // SAFETY: `classdev.parent()` is guaranteed to be contained i= n `T::Bus`. - let parent =3D unsafe { T::Bus::from_device(classdev.parent())= }; - - classdev.ops.brightness_set(parent, classdev, brightness)?; - Ok(0) - }) - } - - /// # Safety - /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a - /// `led::Device`. - /// This function is called on getting the brightness of a led. - unsafe extern "C" fn brightness_get_callback(led_cdev: *mut bindings::= led_classdev) -> u32 { - // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a - // `led_classdev` embedded within a `led::Device`. - let classdev =3D unsafe { Device::::from_raw(led_cdev) }; - // SAFETY: `classdev.parent()` is guaranteed to be contained in `T= ::Bus`. - let parent =3D unsafe { T::Bus::from_device(classdev.parent()) }; - - classdev.ops.brightness_get(parent, classdev) - } - - /// # Safety - /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a - /// `led::Device`. - /// `delay_on` and `delay_off` must be valid pointers to `usize` and h= ave - /// exclusive access for the period of this function. - /// This function is called on enabling hardware accelerated blinking. - unsafe extern "C" fn blink_set_callback( - led_cdev: *mut bindings::led_classdev, - delay_on: *mut usize, - delay_off: *mut usize, - ) -> i32 { - from_result(|| { - // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a - // `led_classdev` embedded within a `led::Device`. - let classdev =3D unsafe { Device::::from_raw(led_cdev) }; - // SAFETY: `classdev.parent()` is guaranteed to be contained i= n `T::Bus`. - let parent =3D unsafe { T::Bus::from_device(classdev.parent())= }; - - classdev.ops.blink_set( - parent, - classdev, - // SAFETY: The function's contract guarantees that `delay_= on` points to a `usize` - // and is exclusive for the period of this function. - unsafe { &mut *delay_on }, - // SAFETY: The function's contract guarantees that `delay_= off` points to a `usize` - // and is exclusive for the period of this function. - unsafe { &mut *delay_off }, - )?; - Ok(0) - }) - } +/// The led mode. +/// +/// Each led mode has its own led class device type with different capabil= ities. +/// +/// See [`Normal`]. +pub trait Mode: private::Sealed { + /// The class device for the led mode. + type Device>; } =20 -#[pinned_drop] -impl PinnedDrop for Device { - fn drop(self: Pin<&mut Self>) { - let raw =3D self.classdev.get(); - // SAFETY: The existence of `self` guarantees that `self.classdev.= get()` is a pointer to a - // valid `struct led_classdev`. - let dev: &device::Device =3D unsafe { device::Device::from_raw((*r= aw).dev) }; - - let _fwnode =3D dev - .fwnode() - // SAFETY: the reference count of `fwnode` has previously been - // incremented in `led::Device::new`. - .map(|fwnode| unsafe { ARef::from_raw(NonNull::from(fwnode)) }= ); - - // SAFETY: The existence of `self` guarantees that `self.classdev`= has previously been - // successfully registered with `led_classdev_register_ext`. - unsafe { bindings::led_classdev_unregister(self.classdev.get()) }; - } +mod private { + pub trait Sealed {} } diff --git a/rust/kernel/led/normal.rs b/rust/kernel/led/normal.rs new file mode 100644 index 000000000000..1a17bb2a6d97 --- /dev/null +++ b/rust/kernel/led/normal.rs @@ -0,0 +1,226 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Led mode for the `struct led_classdev`. +//! +//! C header: [`include/linux/leds.h`](srctree/include/linux/leds.h) + +use super::*; + +/// The led mode for the `struct led_classdev`. Leds with this mode can on= ly have a fixed color. +pub enum Normal {} + +impl Mode for Normal { + type Device> =3D Device; +} +impl private::Sealed for Normal {} + +/// The led class device representation. +/// +/// This structure represents the Rust abstraction for a led class device. +#[pin_data(PinnedDrop)] +pub struct Device> { + #[pin] + ops: T, + #[pin] + classdev: Opaque, +} + +impl> Device { + /// Registers a new led classdev. + /// + /// The [`Device`] will be unregistered on drop. + pub fn new<'a>( + parent: &'a T::Bus, + init_data: InitData<'a>, + ops: impl PinInit + 'a, + ) -> impl PinInit, Error> + 'a { + Devres::new( + parent.as_ref(), + try_pin_init!(Self { + ops <- ops, + classdev <- Opaque::try_ffi_init(|ptr: *mut bindings::led_= classdev| { + // SAFETY: `try_ffi_init` guarantees that `ptr` is val= id for write. + // `led_classdev` gets fully initialized in-place by + // `led_classdev_register_ext` including `mutex` and `= list_head`. + unsafe { + ptr.write(bindings::led_classdev { + brightness_set: (!T::BLOCKING) + .then_some(Adapter::::brightness_set_ca= llback), + brightness_set_blocking: T::BLOCKING + .then_some(Adapter::::brightness_set_bl= ocking_callback), + brightness_get: T::HAS_BRIGHTNESS_GET + .then_some(Adapter::::brightness_get_ca= llback), + blink_set: T::HAS_BLINK_SET.then_some(Adapter:= :::blink_set_callback), + max_brightness: T::MAX_BRIGHTNESS, + brightness: init_data.initial_brightness, + default_trigger: init_data + .default_trigger + .map_or(core::ptr::null(), CStrExt::as_cha= r_ptr), + color: init_data.color as u32, + ..bindings::led_classdev::default() + }) + }; + + let mut init_data_raw =3D bindings::led_init_data { + fwnode: init_data + .fwnode + .as_ref() + .map_or(core::ptr::null_mut(), |fwnode| fwnode= .as_raw()), + default_label: core::ptr::null(), + devicename: init_data + .devicename + .map_or(core::ptr::null(), CStrExt::as_char_pt= r), + devname_mandatory: init_data.devname_mandatory, + }; + + // SAFETY: + // - `parent.as_ref().as_raw()` is guaranteed to be a = pointer to a valid + // `device`. + // - `ptr` is guaranteed to be a pointer to an initial= ized `led_classdev`. + to_result(unsafe { + bindings::led_classdev_register_ext( + parent.as_ref().as_raw(), + ptr, + &raw mut init_data_raw, + ) + })?; + + core::mem::forget(init_data.fwnode); // keep the refer= ence count incremented + + Ok::<_, Error>(()) + }), + }), + ) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + unsafe fn from_raw<'a>(led_cdev: *mut bindings::led_classdev) -> &'a S= elf { + // SAFETY: The function's contract guarantees that `led_cdev` poin= ts to a `led_classdev` + // field embedded within a valid `led::Device`. `container_of!` ca= n therefore + // safely calculate the address of the containing struct. + unsafe { &*container_of!(Opaque::cast_from(led_cdev), Self, classd= ev) } + } + + fn parent(&self) -> &device::Device { + // SAFETY: `self.classdev.get()` is guaranteed to be a valid point= er to `led_classdev`. + unsafe { device::Device::from_raw((*(*self.classdev.get()).dev).pa= rent) } + } +} + +// SAFETY: A `led::Device` can be unregistered from any thread. +unsafe impl + Send> Send for Device {} + +// SAFETY: `led::Device` can be shared among threads because all methods o= f `led::Device` +// are thread safe. +unsafe impl + Sync> Sync for Device {} + +struct Adapter> { + _p: PhantomData, +} + +impl> Adapter { + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// This function is called on setting the brightness of a led. + unsafe extern "C" fn brightness_set_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained in `T= ::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent()) }; + + let _ =3D classdev.ops.brightness_set(parent, classdev, brightness= ); + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// This function is called on setting the brightness of a led immedia= tely. + unsafe extern "C" fn brightness_set_blocking_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained i= n `T::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent())= }; + + classdev.ops.brightness_set(parent, classdev, brightness)?; + Ok(0) + }) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// This function is called on getting the brightness of a led. + unsafe extern "C" fn brightness_get_callback(led_cdev: *mut bindings::= led_classdev) -> u32 { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained in `T= ::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent()) }; + + classdev.ops.brightness_get(parent, classdev) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// `delay_on` and `delay_off` must be valid pointers to `usize` and h= ave + /// exclusive access for the period of this function. + /// This function is called on enabling hardware accelerated blinking. + unsafe extern "C" fn blink_set_callback( + led_cdev: *mut bindings::led_classdev, + delay_on: *mut usize, + delay_off: *mut usize, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained i= n `T::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent())= }; + + classdev.ops.blink_set( + parent, + classdev, + // SAFETY: The function's contract guarantees that `delay_= on` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_on }, + // SAFETY: The function's contract guarantees that `delay_= off` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_off }, + )?; + Ok(0) + }) + } +} + +#[pinned_drop] +impl> PinnedDrop for Device { + fn drop(self: Pin<&mut Self>) { + let raw =3D self.classdev.get(); + // SAFETY: The existence of `self` guarantees that `self.classdev.= get()` is a pointer to a + // valid `led_classdev`. + let dev: &device::Device =3D unsafe { device::Device::from_raw((*r= aw).dev) }; + + let _fwnode =3D dev + .fwnode() + // SAFETY: the reference count of `fwnode` has previously been + // incremented in `led::Device::new`. + .map(|fwnode| unsafe { ARef::from_raw(NonNull::from(fwnode)) }= ); + + // SAFETY: The existence of `self` guarantees that `self.classdev`= has previously been + // successfully registered with `led_classdev_register_ext`. + unsafe { bindings::led_classdev_unregister(raw) }; + } +} --=20 2.52.0 From nobody Sun Feb 8 07:58:24 2026 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EFA336AB4C for ; Mon, 2 Feb 2026 13:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770040355; cv=none; b=R5NuHqpHuQ3D7N2CKKW9WSzjsLPN3e8/NhnEyl3FkXI25siNdSlKk978Z/245NcjdNRbb3UPedjww6zOV2YIY2sKB+RkE4pUe+HyLh6QZYnHyIPtTSMip0EXbPVr0778237qciqC9p32RscjNX73XHWW+aO47FDlfufuMJgt5mc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770040355; c=relaxed/simple; bh=AItBGBhgJavwTN3rHLQitMzDQMkcEnbxLNOP1ZWTb4c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JpPlzGZHeFtLPbK2LgCEtO30axLdVZ7KisIkVdIWB9FJM5lqkE3CcUmTle7HNIAwY9OoqglLUM5EjqKzUoGUf1n1AoCbK56agVGR7LEfa+y9eBuLonKxAqtGpvoMILudL0/mvIelvk5EQv08bUAHlwdDyfev8/cb3Db6C+fsCQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=RUzhPVC6; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="RUzhPVC6" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 59D00240105 for ; Mon, 2 Feb 2026 14:52:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017; t=1770040346; bh=FzG3I5ILgWaK/JEO3oRiRJN8rlll8N4J4zsi8l4XlPc=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=RUzhPVC6gIGSyNfDIIC08UscCOMDlBcRA4nzuOKVCPW6UAHazKVD+DLcMdaE5t/nu wx2O7YBlKmd78gAI/mNvE9CvB1BBQacREEKO0dDrGZJXJRRXmGp/O43KDZqkm3yOyx CQnIpUsy43h3S9cAeA3Qsfrs5gWj3vSmwmI+XVssqaYa/VQlaQKDCDnXB7c1+BzOhX xkkjd3VdLUw2PqmJPP1Rs557+6nS/3pFvD+KtBDM13DjEJ3Qebr4FBKS+7vaJ572jF F9ORslnqCWqGzfbeMKKxLPN0k2JkCT9w6okSuX/v+5D8y4ZRxmSbEg63rb+jJoSJ+x eaXoXU5x3f2pA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4f4SjL6qKgz6v1h; Mon, 2 Feb 2026 14:52:22 +0100 (CET) From: Markus Probst Date: Mon, 02 Feb 2026 13:52:25 +0000 Subject: [PATCH v11 3/3] rust: leds: add multicolor classdev abstractions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260202-rust_leds-v11-3-585d1c8be20c@posteo.de> References: <20260202-rust_leds-v11-0-585d1c8be20c@posteo.de> In-Reply-To: <20260202-rust_leds-v11-0-585d1c8be20c@posteo.de> To: Lee Jones , Pavel Machek , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= Cc: rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=20372; i=markus.probst@posteo.de; h=from:subject:message-id; bh=AItBGBhgJavwTN3rHLQitMzDQMkcEnbxLNOP1ZWTb4c=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBpgKwNpFuDf+hWsVavjnwLK+CfvC4TfA6eEstyA jG+pbfwaPqJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaYCsDRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMSwyLDIACgkQNHYf+OetQ9Icmw/+NygFINdNoT7i0W34tgPdqH9koGKGPi+ K84mbIqKQa8X5mUJKz/3Z3TJ5aADAthvgPl2vu82/nkMXVWbFCS04xv7Xn1a7jfQLC0NzklsxAz rUdZnfEGL9bqXlhZFfkrDC+1fcUH0Q9jV3ABfN8HfPvJ4faBupkY+Yq8nD80ArUHzbHCo0Ez36X 9RAHqRp0lpU1S8Vx2YXFlncA2elhDhlpoIyESzWXweW22dP+bq9z8uD6rGRRmYFeRfF0+Jq5Eqz VpViFGKV+cJr+cpJtb8onDrwbkFx/4QXDjiVekRjw1iCM+Bg/9QdIvW61xuJ92hVXFLnqDIMrEQ 2dqOrhYbZkM9NWi5rbaMjOY0z0mcwLYluB8BGELj3glI2IJFQZkfufLqY/hagvEEd25XKA9DgEX zP2MOIjyGsEKqD7ngAOY1dAodBZScu+6DHcJMEatEbrmQBNqC3s+lN929OrfkYduqp05fYv9Soq 2qjviXR1aCbZYphJQXzj4zIGs3+cclNSP2cYN3ftI+q09awSTrsPj1ru/Xb6qg4hrVIZpvbNXN7 HoB94/kjSAhB3ThyTepxJzixOIH80/QShkT2idDK+2kiDBkkkTyzgcPLJ3nqkA1qMHYn2uAhCYE ZT+gvsgeHeMACEzY/c8bDWbtgtXLqPv+We4pI3hUJK2TQs4Innzk= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Implement the abstractions needed for multicolor led class devices, including: * `led::MultiColor` - the led mode implementation * `MultiColorSubLed` - a safe wrapper arround `mc_subled` * `led::MultiColorDevice` - a safe wrapper around `led_classdev_mc` Signed-off-by: Markus Probst --- rust/bindings/bindings_helper.h | 1 + rust/kernel/led.rs | 30 +++- rust/kernel/led/multicolor.rs | 382 ++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 412 insertions(+), 1 deletion(-) diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helpe= r.h index a067038b4b42..765a4198b85d 100644 --- a/rust/bindings/bindings_helper.h +++ b/rust/bindings/bindings_helper.h @@ -62,6 +62,7 @@ #include #include #include +#include #include #include #include diff --git a/rust/kernel/led.rs b/rust/kernel/led.rs index a32473d61c61..464e100ab3db 100644 --- a/rust/kernel/led.rs +++ b/rust/kernel/led.rs @@ -33,8 +33,12 @@ }, // }; =20 +#[cfg(CONFIG_LEDS_CLASS_MULTICOLOR)] +mod multicolor; mod normal; =20 +#[cfg(CONFIG_LEDS_CLASS_MULTICOLOR)] +pub use multicolor::{MultiColor, MultiColorDevice, MultiColorSubLed}; pub use normal::{Device, Normal}; =20 /// The led init data representation. @@ -229,7 +233,24 @@ pub enum Color { Violet =3D bindings::LED_COLOR_ID_VIOLET, Yellow =3D bindings::LED_COLOR_ID_YELLOW, Ir =3D bindings::LED_COLOR_ID_IR, + #[cfg_attr( + CONFIG_LEDS_CLASS_MULTICOLOR, + doc =3D "Use this color for a [`MultiColor`] led." + )] + #[cfg_attr( + not(CONFIG_LEDS_CLASS_MULTICOLOR), + doc =3D "Use this color for a `MultiColor` led." + )] + /// If the led supports RGB, use [`Color::Rgb`] instead. Multi =3D bindings::LED_COLOR_ID_MULTI, + #[cfg_attr( + CONFIG_LEDS_CLASS_MULTICOLOR, + doc =3D "Use this color for a [`MultiColor`] led with rgb support." + )] + #[cfg_attr( + not(CONFIG_LEDS_CLASS_MULTICOLOR), + doc =3D "Use this color for a `MultiColor` led with rgb support." + )] Rgb =3D bindings::LED_COLOR_ID_RGB, Purple =3D bindings::LED_COLOR_ID_PURPLE, Orange =3D bindings::LED_COLOR_ID_ORANGE, @@ -261,7 +282,14 @@ fn try_from(value: u32) -> core::result::Result { /// /// Each led mode has its own led class device type with different capabil= ities. /// -/// See [`Normal`]. +#[cfg_attr( + CONFIG_LEDS_CLASS_MULTICOLOR, + doc =3D "See [`Normal`] and [`MultiColor`]." +)] +#[cfg_attr( + not(CONFIG_LEDS_CLASS_MULTICOLOR), + doc =3D "See [`Normal`] and `MultiColor`." +)] pub trait Mode: private::Sealed { /// The class device for the led mode. type Device>; diff --git a/rust/kernel/led/multicolor.rs b/rust/kernel/led/multicolor.rs new file mode 100644 index 000000000000..7bd143d0646e --- /dev/null +++ b/rust/kernel/led/multicolor.rs @@ -0,0 +1,382 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Led mode for the `struct led_classdev_mc`. +//! +//! C header: [`include/linux/led-class-multicolor.h`](srctree/include/lin= ux/led-class-multicolor.h) + +use crate::alloc::KVec; + +use super::*; + +/// The led mode for the `struct led_classdev_mc`. Leds with this mode can= have multiple colors. +pub enum MultiColor {} +impl Mode for MultiColor { + type Device> =3D MultiColorDevice; +} +impl private::Sealed for MultiColor {} + +/// The multicolor sub led info representation. +/// +/// This structure represents the Rust abstraction for a C `struct mc_subl= ed`. +#[repr(C)] +#[derive(Copy, Clone, Debug)] +#[non_exhaustive] +pub struct MultiColorSubLed { + /// the color of the sub led + pub color: Color, + /// the brightness of the sub led. + /// + /// The value will be automatically calculated. + /// See `MultiColor::pre_brightness_set`. + pub brightness: u32, + /// the intensity of the sub led. + pub intensity: u32, + /// arbitrary data for the driver to store. + pub channel: u32, +} + +// We directly pass a reference to the `subled_info` field in `led_classde= v_mc` to the driver via +// `Device::subleds()`. +// We need safeguards to ensure `MultiColorSubLed` and `mc_subled` stay id= entical. +const _: () =3D { + use core::mem::offset_of; + + const fn assert_same_type(_: &T, _: &T) {} + + let rust_zeroed =3D MultiColorSubLed { + color: Color::White, + brightness: 0, + intensity: 0, + channel: 0, + }; + let c_zeroed =3D bindings::mc_subled { + color_index: 0, + brightness: 0, + intensity: 0, + channel: 0, + }; + + assert!(offset_of!(MultiColorSubLed, color) =3D=3D offset_of!(bindings= ::mc_subled, color_index)); + assert_same_type(&0u32, &c_zeroed.color_index); + + assert!( + offset_of!(MultiColorSubLed, brightness) =3D=3D offset_of!(binding= s::mc_subled, brightness) + ); + assert_same_type(&rust_zeroed.brightness, &c_zeroed.brightness); + + assert!(offset_of!(MultiColorSubLed, intensity) =3D=3D offset_of!(bind= ings::mc_subled, intensity)); + assert_same_type(&rust_zeroed.intensity, &c_zeroed.intensity); + + assert!(offset_of!(MultiColorSubLed, channel) =3D=3D offset_of!(bindin= gs::mc_subled, channel)); + assert_same_type(&rust_zeroed.channel, &c_zeroed.channel); + + assert!(size_of::() =3D=3D size_of::()); +}; + +impl MultiColorSubLed { + /// Create a new multicolor sub led info. + pub const fn new(color: Color) -> Self { + Self { + color, + brightness: 0, + intensity: 0, + channel: 0, + } + } + + /// Set arbitrary data for the driver. + pub const fn channel(mut self, channel: u32) -> Self { + self.channel =3D channel; + self + } + + /// Set the initial intensity of the subled. + pub const fn initial_intensity(mut self, intensity: u32) -> Self { + self.intensity =3D intensity; + self + } +} + +/// The multicolor led class device representation. +/// +/// This structure represents the Rust abstraction for a multicolor led cl= ass device. +#[pin_data(PinnedDrop)] +pub struct MultiColorDevice> { + #[pin] + ops: T, + #[pin] + classdev: Opaque, +} + +impl> MultiColorDevice { + /// Registers a new led classdev. + /// + /// The [`MultiColorDevice`] will be unregistered on drop. + pub fn new<'a>( + parent: &'a T::Bus, + init_data: InitData<'a>, + ops: impl PinInit + 'a, + subleds: &'a [MultiColorSubLed], + ) -> impl PinInit, Error> + 'a { + Devres::new( + parent.as_ref(), + try_pin_init!(Self { + ops <- ops, + classdev <- Opaque::try_ffi_init(|ptr: *mut bindings::led_= classdev_mc| { + let mut used =3D 0; + if subleds.iter().any(|subled| { + let bit =3D 1 << (subled.color as u32); + if (used & bit) !=3D 0 { + true + } else { + used |=3D bit; + false + } + }) { + dev_err!(parent.as_ref(), "duplicate color in mult= icolor led\n"); + return Err(EINVAL); + } + let mut subleds_vec =3D KVec::new(); + subleds_vec.extend_from_slice(subleds, GFP_KERNEL)?; + let (subled_info, num_colors, capacity) =3D subleds_ve= c.into_raw_parts(); + debug_assert_eq!(num_colors, capacity); + + // SAFETY: `try_ffi_init` guarantees that `ptr` is val= id for write. + // `led_classdev_mc` gets fully initialized in-place by + // `led_classdev_multicolor_register_ext` including `m= utex` and `list_head`. + unsafe { + ptr.write(bindings::led_classdev_mc { + led_cdev: bindings::led_classdev { + brightness_set: (!T::BLOCKING) + .then_some(Adapter::::brightness_se= t_callback), + brightness_set_blocking: T::BLOCKING + .then_some(Adapter::::brightness_se= t_blocking_callback), + brightness_get: T::HAS_BRIGHTNESS_GET + .then_some(Adapter::::brightness_ge= t_callback), + blink_set: T::HAS_BLINK_SET + .then_some(Adapter::::blink_set_cal= lback), + max_brightness: T::MAX_BRIGHTNESS, + brightness: init_data.initial_brightness, + default_trigger: init_data + .default_trigger + .map_or(core::ptr::null(), CStrExt::as= _char_ptr), + color: init_data.color as u32, + ..bindings::led_classdev::default() + }, + num_colors: u32::try_from(num_colors)?, + // CAST: The safeguards in the const block ens= ure that + // `MultiColorSubLed` has an identical layout = to `mc_subled`. + subled_info: subled_info.cast::(), + }) + }; + + let mut init_data_raw =3D bindings::led_init_data { + fwnode: init_data + .fwnode + .as_ref() + .map_or(core::ptr::null_mut(), |fwnode| fwnode= .as_raw()), + default_label: core::ptr::null(), + devicename: init_data + .devicename + .map_or(core::ptr::null(), CStrExt::as_char_pt= r), + devname_mandatory: init_data.devname_mandatory, + }; + + // SAFETY: + // - `parent.as_ref().as_raw()` is guaranteed to be a = pointer to a valid + // `device`. + // - `ptr` is guaranteed to be a pointer to an initial= ized `led_classdev_mc`. + to_result(unsafe { + bindings::led_classdev_multicolor_register_ext( + parent.as_ref().as_raw(), + ptr, + &raw mut init_data_raw, + ) + }) + .inspect_err(|_err| { + // SAFETY: `subled_info` is guaranteed to be a val= id array pointer to + // `mc_subled` with the length and capacity of `nu= m_colors`. + drop(unsafe { KVec::from_raw_parts(subled_info, nu= m_colors, num_colors) }); + })?; + + core::mem::forget(init_data.fwnode); // keep the refer= ence count incremented + + Ok::<_, Error>(()) + }), + }), + ) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + unsafe fn from_raw<'a>(led_cdev: *mut bindings::led_classdev) -> &'a S= elf { + // SAFETY: The function's contract guarantees that `led_cdev` poin= ts to a `led_classdev` + // field embedded within a valid `led::MultiColorDevice`. `contain= er_of!` can therefore + // safely calculate the address of the containing struct. + let led_mc_cdev =3D unsafe { container_of!(led_cdev, bindings::led= _classdev_mc, led_cdev) }; + + // SAFETY: It is guaranteed that `led_mc_cdev` points to a `led_cl= assdev_mc` + // field embedded within a valid `led::MultiColorDevice`. `contain= er_of!` can therefore + // safely calculate the address of the containing struct. + unsafe { &*container_of!(Opaque::cast_from(led_mc_cdev), Self, cla= ssdev) } + } + + fn parent(&self) -> &device::Device { + // SAFETY: `self.classdev.get()` is guaranteed to be a valid point= er to `led_classdev_mc`. + unsafe { device::Device::from_raw((*(*self.classdev.get()).led_cde= v.dev).parent) } + } + + /// Returns the subleds passed to [`Device::new_multicolor`]. + pub fn subleds(&self) -> &[MultiColorSubLed] { + // SAFETY: The existence of `self` guarantees that `self.classdev.= get()` is a pointer to a + // valid `led_classdev_mc`. + let raw =3D unsafe { &*self.classdev.get() }; + // SAFETY: `raw.subled_info` is a valid pointer to `mc_subled[num_= colors]`. + // CAST: The safeguards in the const block ensure that `MultiColor= SubLed` has an identical + // layout to `mc_subled`. + unsafe { + core::slice::from_raw_parts( + raw.subled_info.cast::(), + raw.num_colors as usize, + ) + } + } +} + +// SAFETY: A `led::MultiColorDevice` can be unregistered from any thread. +unsafe impl + Send> Send for MultiColorDevi= ce {} + +// SAFETY: `led::MultiColorDevice` can be shared among threads because all= methods of `led::Device` +// are thread safe. +unsafe impl + Sync> Sync for MultiColorDevi= ce {} + +struct Adapter> { + _p: PhantomData, +} + +impl> Adapter { + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + /// This function is called on setting the brightness of a led. + unsafe extern "C" fn brightness_set_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::MultiColorDevice`. + let classdev =3D unsafe { MultiColorDevice::::from_raw(led_cdev= ) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained in `T= ::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent()) }; + + // SAFETY: `classdev.classdev.get()` is guaranteed to be a pointer= to a valid + // `led_classdev_mc`. + unsafe { bindings::led_mc_calc_color_components(classdev.classdev.= get(), brightness) }; + + let _ =3D classdev.ops.brightness_set(parent, classdev, brightness= ); + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + /// This function is called on setting the brightness of a led immedia= tely. + unsafe extern "C" fn brightness_set_blocking_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::MultiColorDevice`. + let classdev =3D unsafe { MultiColorDevice::::from_raw(led_= cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained i= n `T::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent())= }; + + // SAFETY: `classdev.classdev.get()` is guaranteed to be a poi= nter to a valid + // `led_classdev_mc`. + unsafe { bindings::led_mc_calc_color_components(classdev.class= dev.get(), brightness) }; + + classdev.ops.brightness_set(parent, classdev, brightness)?; + Ok(0) + }) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + /// This function is called on getting the brightness of a led. + unsafe extern "C" fn brightness_get_callback(led_cdev: *mut bindings::= led_classdev) -> u32 { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::MultiColorDevice`. + let classdev =3D unsafe { MultiColorDevice::::from_raw(led_cdev= ) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained in `T= ::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent()) }; + + classdev.ops.brightness_get(parent, classdev) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + /// `delay_on` and `delay_off` must be valid pointers to `usize` and h= ave + /// exclusive access for the period of this function. + /// This function is called on enabling hardware accelerated blinking. + unsafe extern "C" fn blink_set_callback( + led_cdev: *mut bindings::led_classdev, + delay_on: *mut usize, + delay_off: *mut usize, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::MultiColorDevice`. + let classdev =3D unsafe { MultiColorDevice::::from_raw(led_= cdev) }; + // SAFETY: `classdev.parent()` is guaranteed to be contained i= n `T::Bus`. + let parent =3D unsafe { T::Bus::from_device(classdev.parent())= }; + + classdev.ops.blink_set( + parent, + classdev, + // SAFETY: The function's contract guarantees that `delay_= on` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_on }, + // SAFETY: The function's contract guarantees that `delay_= off` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_off }, + )?; + Ok(0) + }) + } +} + +#[pinned_drop] +impl> PinnedDrop for MultiColorDevice { + fn drop(self: Pin<&mut Self>) { + let raw =3D self.classdev.get(); + // SAFETY: The existence of `self` guarantees that `self.classdev.= get()` is a pointer to a + // valid `led_classdev_mc`. + let dev: &device::Device =3D unsafe { device::Device::from_raw((*r= aw).led_cdev.dev) }; + + let _fwnode =3D dev + .fwnode() + // SAFETY: the reference count of `fwnode` has previously been + // incremented in `led::Device::new`. + .map(|fwnode| unsafe { ARef::from_raw(NonNull::from(fwnode)) }= ); + + // SAFETY: The existence of `self` guarantees that `self.classdev`= has previously been + // successfully registered with `led_classdev_multicolor_register_= ext`. + unsafe { bindings::led_classdev_multicolor_unregister(raw) }; + + // SAFETY: `raw` is guaranteed to be a valid pointer to `led_class= dev_mc`. + let led_cdev =3D unsafe { &*raw }; + + // SAFETY: `subled_info` is guaranteed to be a valid array pointer= to `mc_subled` with the + // length and capacity of `led_cdev.num_colors`. See `led::Multico= lorDevice::new`. + drop(unsafe { + KVec::from_raw_parts( + led_cdev.subled_info, + led_cdev.num_colors as usize, + led_cdev.num_colors as usize, + ) + }); + } +} --=20 2.52.0