From nobody Sat Feb 7 04:47:20 2026 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F22CB25C818 for ; Mon, 2 Feb 2026 15:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770047952; cv=none; b=tcq6h72xQ/DQvDpw/B1zhzd90F21x9LPhR4S2fAQ3PUPzEgOx7W5FzP615Ei4gEMACk3ZVPyDz4Sus/0TxK5SntJVtU4u5zr5xfWvXFZsLS4zAkvBQxH82vg/nxJFts1HcICQsRzhQyR1jJcibR8yHrzq7lZQVCrXOcu8c0h9CU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770047952; c=relaxed/simple; bh=kARCeaAKhDeIKKAlMz1UbawFMFAokaEWYZvZ6sB7T4w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=GLl346nFil5VGG+B+oNBGfxcayXD0oDy2WUHbNhM72O5t2aTyDZE9gc7GthRciq/JExxAmaGZJyyas8xhUaJDcUt1VillfY0ICxB8BF47r7JX9vGHN2ussnz41PXR7JiRIe+ynOXhaE0fuT07ljJ0SA3ojV9LA9HghuNuZhq6eU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZBrXaunx; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZBrXaunx" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-43601e96f72so1058370f8f.2 for ; Mon, 02 Feb 2026 07:59:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770047949; x=1770652749; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=LZZm7iyAn8JIl9dQI6HiLl2VItdwuhdut+41offwFMw=; b=ZBrXaunxXywOGHZplQrwYyDCxtTARGDcrWmRVOJwHk7ZUQC8Br/bXkpHBMr7wxk8gy YnyxfSRHkvbYzYHY4ZJcCdsL8ezoGpze2TLiCjWbyF2Qyp/q5wrqPwcbzqqkYO7BGhCB pFDXiNLdH1oDPZz8h2/s/067IMAGMXMsX4ShoUzzj0xcZHWVJk4kvisAqze9iL7TM30S hk+gORVMwzHLRMvwy/9YqFp5SVqs4zkwUe/OilTiHur71DljQ915BLNRqJLE8mQjl5J6 gjdf2HtNMrM+wql2vCss3SBPjNOvGktDS7/4Oa+i6xYRGtP1H0ufzchnct0IB6XQ7+AW f8hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770047949; x=1770652749; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LZZm7iyAn8JIl9dQI6HiLl2VItdwuhdut+41offwFMw=; b=A9YvChBJeV2vgRMfha2wTm/uEmbVT2Y6zpBG9qkQ5PmqJlNfekM7QeY4aWALTuEZt7 Wujh1exTaShhTKds4JepVrBvLA5RdQ7gfbJJtTD8eCB/cneHVTtcymjXjRGHVqoWcur6 n7b/N7JPehkbczyjY1glIS2QlffXhXSI2jNemcJ1KQqFX1HFJvKpYjFSJbRU2rALI0zg atNCVnlQCLgejuG2OH0Q5lAO+QLVOOoxB7DXtugyFnotyenzQipC8YoxVniJwEiuItKT 78nq4OzyR3PbDrMsIhuVMV9/8TEuUExCq3j0Wo+dvYO/zP+TdUaZNm2E99AOODsnMPzM 7NiA== X-Forwarded-Encrypted: i=1; AJvYcCXQ79SqAkHncnybf5dpYKi3B84TjhCQKaTKWLN2+68vP30LKtq3VY84Eqbudrm+fmzQPQJMzPt2TKQg28o=@vger.kernel.org X-Gm-Message-State: AOJu0YyiVRa+c3w21g03+4Itgg2cHGfs/jNouwFrbdh70Oyv4Eo5DGp2 p+Xdf5TNQfxXKkkSCPA8eAhZzlAhhaw3FyPwll+QlJ54P0afERlm7Nvz X-Gm-Gg: AZuq6aLztFP9XucoUuy8yefgt/5lf0b+YiT9Tsoi4ojqfBYLqnDMXDW9vc8rR2G7aop WlxyDbDUnx9O8Zc905A4XQ2lSIdY8MKgAgZ/2UKSJTmrxVrEdJ2iijZ80raqPDjw4qFMsR5El0N 2T2U8YTsZJ4RkBqe8PxkLhJjQ/tF7Rej3opx+k/onfrXV+M5RamIFKNNtayffc4+evhvSBH0DTt eNlpc6FDowWmFlgSVimYI3kejlIHKS1JxFRN56M3KT5iKRQpzDFdgHOOfrT9waEku+YdPQyg1Kt to0VsGQULT3LDR+QnPk8tDptqZflO1tO7jsKeFT0615N3Lrnfe4OKmVf8K3QYhG5fm67/thXgSK 8wYLzmFE+Hav6hZ0GP/FwoehU/i0sSiXkcTk8HyDNu6wpFpk6B8OE3oBBsCmxjDmVT7hr3+nPDf V+UHIqt5iyQfvCPL61/wVFci2nGHKKR5pG3KCZEYqYY0VHzrpH64M= X-Received: by 2002:a05:6000:26c3:b0:435:b7b9:afe5 with SMTP id ffacd0b85a97d-435f3a66f53mr16112258f8f.1.1770047949225; Mon, 02 Feb 2026 07:59:09 -0800 (PST) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-435e131ce64sm46708334f8f.26.2026.02.02.07.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 07:59:08 -0800 (PST) From: Gabor Juhos Date: Mon, 02 Feb 2026 16:58:57 +0100 Subject: [PATCH] hwmon: gpio-fan: allow to stop FANs when CONFIG_PM is disabled Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260202-gpio-fan-stop-fix-v1-1-c7853183d93d@gmail.com> X-B4-Tracking: v=1; b=H4sIAMDJgGkC/x2MQQqAMAwEv1JyNqC1FPQr4qFoqrm0pRERin83e BmYgd0GQpVJYDYNKt0snJPK0BnYzpAOQt7VwfbW9wo8CmeMIaFcuWDkByeKbrM+TKN3oLtSSfP /uazv+wF5VnkcYwAAAA== X-Change-ID: 20260202-gpio-fan-stop-fix-9ef4c26a9364 To: Guenter Roeck , Alexander Stein Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 When CONFIG_PM is disabled, the GPIO controlled FANs can't be stopped by using the sysfs attributes since commit 0d01110e6356 ("hwmon: (gpio-fan) Add regulator support"). Using either the 'pwm1' or the 'fan1_target' attribute fails the same way: $ echo 0 > /sys/class/hwmon/hwmon1/pwm1 ash: write error: Function not implemented $ echo 0 > /sys/class/hwmon/hwmon1/fan1_target ash: write error: Function not implemented Both commands were working flawlessly before the mentioned commit. The issue happens because pm_runtime_put_sync() returns with -ENOSYS when CONFIG_PM is disabled, and the set_fan_speed() function handles this as an error. In order to restore the previous behaviour, change the error check in the set_fan_speed() function to ignore the -ENOSYS error code. Cc: stable@vger.kernel.org Fixes: 0d01110e6356 ("hwmon: (gpio-fan) Add regulator support") Signed-off-by: Gabor Juhos --- drivers/hwmon/gpio-fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index 516c34bb61c9cfa2927d31ee6459c8306be2fb5b..37645e9141dc7034fd440afed69= 5af57829ec900 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -148,7 +148,7 @@ static int set_fan_speed(struct gpio_fan_data *fan_data= , int speed_index) int ret; =20 ret =3D pm_runtime_put_sync(fan_data->dev); - if (ret < 0) + if (ret < 0 && ret !=3D -ENOSYS) return ret; } =20 --- base-commit: 1117702454262fb361869451be5b006c022eb08a change-id: 20260202-gpio-fan-stop-fix-9ef4c26a9364 Best regards, --=20 Gabor Juhos