From nobody Sat Feb 7 13:41:37 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C56F3EBF3D for ; Sun, 1 Feb 2026 18:19:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769969971; cv=none; b=GVkqMyaGZENR8wqGjWtcYS0f3C68Kxz/CdDkj+xnXNjpsrsPxuZcnOPwbQ6+LSqXxvNydQIzopKQr8LwFlvS9ZPHS96+SS0kJkOyEtdzeQ1j4v6qz2uY4PA36RjpWgb/CMU+/PyMXmtSYR61cdrfktetm0y6GZteiQJl/6KAavg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769969971; c=relaxed/simple; bh=9UEAYs8BOtkPMSZ+aZJXJjA/lA1oMnfd0ad1J+W/DCM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QLC+E21nlkWbfkYfiimHQeRd6SSJzfoVcaE7f8Hv093aH9XiLtklp/50FRHy3jnq2UGADT9cXjE9y9gGhU0mWQ8PmDbEPRdcqvyrS43trL+NDVJzkzDnkZbwLIRs0i5+DItY9YpuexIPjfoww8fMTQic5Fd4r6Z1n9swwCnOttQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zjy7kpwq; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zjy7kpwq" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a09d981507so26497225ad.1 for ; Sun, 01 Feb 2026 10:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769969970; x=1770574770; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=w0qHBL38GMK6RiP1vSDBko5Oah8ksm+tgX8bU2a4jHo=; b=Zjy7kpwq9NfZU3fX2L1si5S5AaLE653n+vGw9RmR4ZPo7eWAbEnr43AP3Ke/BN2y20 DQQGXCApr2TDmtRaNx1pMAQYxK9ipfMfodCqi6VwgT5HGnOddc/Viq4MPLsa/oMgD+rD yiaBbtxB0fUjnTAB9hoNgnqzSkhvkbrXHSC+NRyAQdjWeqzSXiZRBHfq3Hpl9A2vASaS mBdKapyCuGfniM8IZM8MC0dOJ2IVQ/WrJmQK1k5Z0Uari68OYlWYig/snmJQDGyyZj2k UL9fEnmXcUUE3PSTEbd8joEW+d8L5CUXkf7qGMECQXJDGrcGE1qZPR4gYkGrileovJZm a8tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769969970; x=1770574770; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w0qHBL38GMK6RiP1vSDBko5Oah8ksm+tgX8bU2a4jHo=; b=WmYjR0f1IM5rkQ3dWDqLAz5I81PtXWa7MCanQBDd0KNpnA+VvvyF+zpbXrjT9UKQNX hW3X0TcfAlrtPmeRupI52D/Q5838rvP1AG/oWwtFfNdiy/nuIAXYRAxmPFpO46m8fx6i /XPvdMWxK9TP8VKwXYnu+kyZCzvZ3lnzAqnidALEOcrGLe0aYwSyONnLHybvMJjU9pZ2 clNlYGCDQjyDGcEp7T0eB8AbHf+4eHvsk+5xsEaseF1DmoRv6WdPH2GPF5hRKKr/yG4z wSTRda0tVND5Pj8kXB2qFRTvVWrRas7vvehMAu2mNE/pePVBzEogFVuwVmrlOcyC+lG/ KvZQ== X-Gm-Message-State: AOJu0YxV9ydCbyZyNjkS4My/mUw/jlBS/sxzzc1bBj988BqBZb525bud ulDqPEwDbYEWbzJ103frBCC0HL9E8IHQzYMbm8hx0VRD9pmxcHxC8EXK2KmgFQ== X-Gm-Gg: AZuq6aIexsIzrsTWOIvn/N3BDf/uPm1ykI7hcBhVBdQhDUItywEfK0aI6Bmh847kVL3 BCQ5CxSiqzy6C1skRNqv39YnmsI0gCTMpAigLfUCobaDYHPxv9Sw7fvOtReAKM9LHZsc/+/UKcp 6FmlJ1LXvxxXnCP/GiXgKau/2MfRbjxuCKHwI4PGcsebkjQtbvCYwzjMLblxFn4pFGsn/Vlfjcj VbTPMtG6BELQO46FWWtMMfLTZq+wAFSMr2lgLVsUhcKSZXuXxodh7PLx1qsbqEjKmUAqkgqp/Bv +/3XR9tnHafd6jXfyNgKesTjgsCEsKn1ySixxEVGNcPNuT94/NfSVoP+43lqYMU8oMFZkZZfJW1 px0IF79WA4NUcWNu/YRlZB4f5w+MXDCb9QvlSSPOcWRi+H38+SNqdNyWPrwZnIzf1ipjTGpqizp z6ZHWI4g6/7ag8stxt2eYMopXV/zs= X-Received: by 2002:a17:903:2f86:b0:2a7:a6fa:eddf with SMTP id d9443c01a7336-2a8d99514femr91910555ad.17.1769969969660; Sun, 01 Feb 2026 10:19:29 -0800 (PST) Received: from gmail.com ([2409:4081:2d1d:b4be:89d5:e086:c91c:ec66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b7f9a9esm125644925ad.102.2026.02.01.10.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 10:19:29 -0800 (PST) From: Sumeet Pawnikar To: rafael@kernel.org, robert.moore@intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH] tools/power/acpi: Replace unsafe strcat with strncat in apfiles.c Date: Sun, 1 Feb 2026 23:48:24 +0530 Message-ID: <20260201181824.4999-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace unsafe strcat() calls with strncat() in apfiles.c to prevent potential buffer overflow vulnerabilities when constructing filenames. The strncat() function performs bounds checking to ensure the destination buffer is not overflowed. No functional change. Signed-off-by: Sumeet Pawnikar --- tools/power/acpi/tools/acpidump/apfiles.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/power/acpi/tools/acpidump/apfiles.c b/tools/power/acpi/t= ools/acpidump/apfiles.c index d6b8a201480b..c7b71579aae6 100644 --- a/tools/power/acpi/tools/acpidump/apfiles.c +++ b/tools/power/acpi/tools/acpidump/apfiles.c @@ -131,10 +131,12 @@ int ap_write_to_binary_file(struct acpi_table_header = *table, u32 instance) =20 if (instance > 0) { snprintf(instance_str, sizeof(instance_str), "%u", instance); - strcat(filename, instance_str); + strncat(filename, instance_str, + sizeof(filename) - strlen(filename) - 1); } =20 - strcat(filename, FILE_SUFFIX_BINARY_TABLE); + strncat(filename, FILE_SUFFIX_BINARY_TABLE, + sizeof(filename) - strlen(filename) - 1); =20 if (gbl_verbose_mode) { fprintf(stderr, --=20 2.43.0