From nobody Sun Feb 8 00:26:50 2026 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFAB015665C for ; Sun, 1 Feb 2026 15:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769961445; cv=none; b=Ybc2eks3nCgoj7Amnt8oNqC5SXlFg/hWZryFbeAHzw+D5OXgKJGtWZ0UfTN4VzXj/Shs1jeHWSBBgZWuGIupMDtvqmkfxyb1Lp/zphqqpXeV2J5QnNjRgLvXj18gUiLcXTgeNZJwu2HlmY8YiackLa6V92XqmKm40e3ZNU6Im1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769961445; c=relaxed/simple; bh=fTBRg750ujyzrVY0PIhgaUQeKBthwxG20Fv/y/qnnEw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gvRPtdruWiXAUWCtlJZx+KNhyzzfDAdXXm1DcTSjAzxADzVChbkQ37j0I59fEff5z8IEBaBucgYspFSAMTvcFjlY6lXvcT4aqnMQiocxuhy6kfHAWospD0wOud1GjfE5l98fjGbNo99IEC/1z3ZSey5FCGkNYYVvERn8bQaMaFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jJzwFqa9; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jJzwFqa9" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2b71557299dso3762838eec.1 for ; Sun, 01 Feb 2026 07:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769961443; x=1770566243; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=v62NnW7F51LkxZDVn9mSUadOypAxQ2Jh3WxYLgEsz8U=; b=jJzwFqa9mlYUfHU6NxprLuOww4hTiNbcNrDa27lVooBsWdd5dYIXoUqWpnUU60YOVG er7pyoUdQu+JWBLSPn4p5X0w83PTmqib1WaNWm/faH2rMjMLWcjTCZpO1NOSZtvEWp2K FuvMl9CqkrNCTZzYIT4zjPgzuQRiapLQsbPD/nxDv8PzNIjF6DDMk9+Pmb5vBTxTnkgR 2KdSF1l3o+CoSr3c0Nc6eFSbES3zHZikKx+wFmU3kErSheSfCmq/XckHab9DFLFlCPIu mapxwtcQb577p+8fqh80gRGbUFR1DqlkHqIG0uuLvB4L9vTHPX0Db5chxG3brYX+sPVk 6iEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769961443; x=1770566243; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v62NnW7F51LkxZDVn9mSUadOypAxQ2Jh3WxYLgEsz8U=; b=ErPXzNMZ/VabrGLaLy3abe0vsWa6DvRTIu4MeLcPidILk+LwSCabtib1P2+Jwx/KY0 FhMlEFL1oR7qwZXHwzMkXihvLQTavMaOlMuCu1MUk4XV1qyjAj0KBvXcBHEBd6BAT62x UyTXyoRiu1fHgs/dDF6s8Jxb/1+vg9WWtqyMuxOsRdIVo9HKa5kwdOesr+sCFQsfFwaR +ciWrkBnfdr4YrPrXq31PtJrsSpeqAwDmt/GZxmoHfUYI2Vu5/PKGZJuHNt8T3Ci2VTF gXpJzFervs1Xe48EYa/ZDbiGSuyaY7lWNqb1NJFKJzsEpS5PkpLrc/nLesrsLj44x3DA Agfw== X-Forwarded-Encrypted: i=1; AJvYcCUgvdiOW/N5W4W1tBqZlmLFu0QJj4Hs9p37ArEF+DAuaT40jEnh/uX/MnUKJ+SlSmR8m2nRUf+loyCtaHA=@vger.kernel.org X-Gm-Message-State: AOJu0YxlL3YxTFOxJQcRxUTo6fPXaUeZHFN4FY/CgP2ADNwX5TrXb0Zb 8FEtstFLDFTdUb2kbvSErR5s2K4lznZ7dAKCmlML/Zi/NQAqUVwrq6cm X-Gm-Gg: AZuq6aKtKf6fLqoJBAQkPuLOqXlA3KGA2CDdh1CotqRYWcALhC2WqqMoEVPiKm/mytC kQ/Asoy76kJ5DPsIbZ/fBxp3Nhy9kl4S9UKxZG1QRGgFc3yvbxCA82YuQsplnb/2pm3q1mQ9Jc0 fM+n+aSxZL0nE55B6NGn974gRuxCqsRrJ8oEhd0nq5D+UccBbWHYI7Cflgxy1c90jEQNztSVwTj T/8iRpvM6enXyXAOLo8PAYiiwa+rOiJgCx7MpAZ9oH7bcyS8NA3W5iyjG7poZCKM6h7jn6bHIfN NQQdHusOBcUwTW24Kq+yOw4QiBSaQz5YhDoT5thTNwo6I9Jfe1/k0YjuN7eHHf0nY9Y6hxsWa/9 PA2D6c+5Hrdhe4fpFtgPvXSYTJhh3vKwQCLyv2nnPqYyZm+faW7VWGSbiTE83NO3H0BYR9k99p4 4ZczmZPZwOdbW2WXOjWqIFP6Jk4VrePjW2N4q9iwyDHXGp8jKoLUQjiaO/ZNRhboE= X-Received: by 2002:a05:7300:4354:b0:2ae:5f34:e93f with SMTP id 5a478bee46e88-2b7c8655810mr4511543eec.15.1769961442543; Sun, 01 Feb 2026 07:57:22 -0800 (PST) Received: from jason-hall-A520-B.. ([2600:8800:41a0:8000:38f6:2506:345b:4004]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7a1af88c4sm18053683eec.31.2026.02.01.07.57.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 07:57:21 -0800 (PST) From: Jason Hall To: apw@canonical.com, joe@perches.com, ojeda@kernel.org Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Hall Subject: [PATCH] scripts: checkpatch: warn on Rust panicking methods Date: Sun, 1 Feb 2026 08:57:18 -0700 Message-ID: <20260201155718.1623802-1-jason.kei.hall@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Added regex check in checkpatch.pl for common Rust panicking methods like unwrap() and expect(). Allowed an exception if the line contains a '// PANIC:' comment. Suggested-by: Miguel Ojeda Link: https://github.com/Rust-for-linux/linux/issues/1191 Signed-off-by: Jason Hall --- scripts/checkpatch.pl | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c0250244cf7a..fa9f55031129 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3834,6 +3834,17 @@ sub process { # check we are in a valid source file if not then ignore this hunk next if ($realfile !~ /\.(h|c|rs|s|S|sh|dtsi|dts)$/); =20 +# check for Rust unwrap/expect + if ($realfile =3D~ /\.rs$/ && $line =3D~ /^\+/) { + if ($line =3D~ /\b(unwrap|expect)\s*\(/ && + $rawline !~ /\/\/\s*PANIC/ && + $line !~ /^\+\s*\/\// && + $line !~ /^\+\s*assert/) { + WARN("RUST_UNWRAP", + "Avoid unwrap() or expect() in Rust code; use proper error handling (= Result) or justify with a '// PANIC: ...' comment.\n" . $herecurr); + } + } + # check for using SPDX-License-Identifier on the wrong line number if ($realline !=3D $checklicenseline && $rawline =3D~ /\bSPDX-License-Identifier:/ && --=20 2.43.0