From nobody Sun Feb 8 14:12:59 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32C7632D0E3 for ; Sun, 1 Feb 2026 11:40:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769946028; cv=none; b=ucRVkoK6Nkss4HlFh1/8em/Kgm0m4x5I3BoUu68YRnX15RQX6kcLNq0E7aM+V28WvXVDsCSLKgPw+zLzRcUAW7V9lRj4sOFJHU8pI4FNJP/ixur6dbzvjMH21w94w/qR3Ch7fyCmwsLGhvdBZVLCwMUTzIXzHdyDLJpWHgOaqRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769946028; c=relaxed/simple; bh=P/hMXlaUikZWedH2by3kb/6y3OXEBSzVILcuMMRz9ho=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b34+8wCcfl3WVNQjYbBxdgjD045uUjC4Vs/FNDOKy3FQFUVSUB69OXMqSls6X3aR4M4zGaUvl0ebqJYUkuGI84MojCnxwP1kIBebOq/70i1/yc7h5Fsi24cO/EeIjS08guK82cRU9h73tczBJBE3R7fOuQotte3wEdkg4HXp+bA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cgXwektW; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cgXwektW" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2a7bced39cfso37008905ad.1 for ; Sun, 01 Feb 2026 03:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769946024; x=1770550824; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Azjvx2/0kDlRgS0fUfLnzitfRTr8Okc+7JuFReuYNgw=; b=cgXwektWjD2XkvJXDTkZmjUHdylJz46jfnsYWx2K/uWU4oDSO1FO8uIsYgWRKKraJS uHeAWMh6YfUficwLknWNcbTqYhCOpbje1vlDqnSxW0GGnjV75FJaQoX+0M+bD/CEdy9e zjvx6y3rVHQDpZOpmm/s4gmslrqhHzEfdA6B29tJko3FChp9h3Y/t2c8717jNTKSHZV5 IqONblZSx5ANeiC8KmlbKLRFjjvaWkv30poHctBb5ojM9D+Qqcdu67UFnAzSJ6hW7LNq 8UyqxwVenIevI3P+wXTBF0++EKKGtzoVBF5HYt004E73sVV1cZf5CiVtK32A1aYZSl4y l3Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769946024; x=1770550824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Azjvx2/0kDlRgS0fUfLnzitfRTr8Okc+7JuFReuYNgw=; b=OqVAkemjl3DlOWeDa58K6MGR2tldyR0Yi6NmU9Mmdd3Cl9eK1AMDKHRBwZXukDy5fe xTMmg7vwmZevmwuTkQAfLE4vENmeqh21phX/GnpYiLKA6TbFay1GVJN/c6x2jDb2IgV4 Q96kSBh01o9gzVmQyREWV6mkdYSkr1YtJg+cOvkPLCPUZKbdB3lQkW5eMpNtMxMiO8cC McvO/hION6L8TLxx99IzMRPlMO31P2ABKCQE1hr3p9eHTkeZvNf7RmvD/7Mk+KjjSkFq qtdNiQ9yPr3yixfqDvRxNrbKViTfd9pf1x+mfPweEVlFli7hq+6XveXrZzaErk1yNWaH rKsA== X-Forwarded-Encrypted: i=1; AJvYcCVUoUObAXjzol/ZcRcSVOX0mmNdc100Mzoq5R6UpSk65VSirZEGYB5nCK6hw/giDzgEsdtOUaOPV1/sSII=@vger.kernel.org X-Gm-Message-State: AOJu0YxTkmKgOVrECQJInMWR5rWFl3srE/uesOzdXn43LGHmgh56YrUI 8DcnI6RynKJOtruZv9nzedid7SP5e1vc846cwIyAzla25FhLLlHLGwc2 X-Gm-Gg: AZuq6aLuMW2A3OOKPjejw74ap2rn/VaR+H5PpdZ9HW+Y+hy5IjhA26P5zaWXIFJKOdJ JrQYWbzoOAcXwG5rG14PcJ9lLsK4HdIJymbut/7JRyAP34wX7iBkjrTPyf2ZpgS8cbp+lCtIYnK 2dCO2bOdfJWe79revOqx+Bmx9K+UZayJOBWKjFu/JsqvkvXVAQtJIVBjtDkBbpM5gQoTRvWyBEM jaIzMZz26kElXgnOGmDJVW0neqHlhfg72x7vveDmYPH6Mi/EQYXA7MmzBLQG0fZg4wDOLVp83fv dF32MG1qQBAJZF9PDFGOV67Haj4v/Gk1PVBG5HQIM9D1Jjeqcs1N4ARDv+7F/LWbXM5tNLehiXN XTARVepksgxoTp+ODAY2cc0fh1ujQ08Vn0Qge5ORaY6S4UEfl1hB6gf6ro+11A5AUOIQE3sOSh3 fEK6FqfHYFmaoTUvC11xdIkNXtdR4= X-Received: by 2002:a17:902:e887:b0:2a0:b02b:2114 with SMTP id d9443c01a7336-2a8d96a6e14mr86819405ad.11.1769946024303; Sun, 01 Feb 2026 03:40:24 -0800 (PST) Received: from snowman ([2401:4900:614d:8c00:9d3:b11e:236d:377a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b7f7caasm121156675ad.101.2026.02.01.03.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 03:40:23 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH v6 3/4] staging: rtl8723bs: simplify boolean expressions Date: Sun, 1 Feb 2026 17:08:36 +0530 Message-ID: <20260201113837.8531-4-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201113837.8531-1-khushalchitturi@gmail.com> References: <20260201113837.8531-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify boolean expressions across rtl8723bs to comply with the kernel coding style. Signed-off-by: Khushal Chitturi --- Changelog: v5 -> v6: Extend boolean simplification to ioctl_cfg80211.c and rtw_ioctl_set.c v4 -> v5: Rebased onto current staging-testing. v3 -> v4: Fixed alignment and removed extra parentheses. v2 -> v3: Resubmitted as a versioned series to avoid threading confusion. v1 -> v2: Corrected commit messages. .../staging/rtl8723bs/core/rtw_ioctl_set.c | 63 +++++++++---------- drivers/staging/rtl8723bs/core/rtw_xmit.c | 40 ++++++------ .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 14 ++--- 3 files changed, 58 insertions(+), 59 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index 2d37ac4c50ef..dab20b8a9b18 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -61,14 +61,11 @@ u8 rtw_do_join(struct adapter *padapter) /* when set_ssid/set_bssid for rtw_do_join(), but scanning queue is empt= y */ /* we try to issue sitesurvey firstly */ =20 - if (pmlmepriv->link_detect_info.busy_traffic =3D=3D false - || rtw_to_roam(padapter) > 0 - ) { + if (!pmlmepriv->link_detect_info.busy_traffic || rtw_to_roam(padapter) >= 0) { /* submit site_survey_cmd */ ret =3D rtw_sitesurvey_cmd(padapter, &pmlmepriv->assoc_ssid, 1, NULL, 0= ); if (ret !=3D _SUCCESS) pmlmepriv->to_join =3D false; - } else { pmlmepriv->to_join =3D false; ret =3D _FAIL; @@ -84,7 +81,7 @@ u8 rtw_do_join(struct adapter *padapter) pmlmepriv->to_join =3D false; _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else { - if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { /* submit createbss_cmd to change to a ADHOC_MASTER */ =20 /* pmlmepriv->lock has been acquired by caller... */ @@ -113,7 +110,7 @@ u8 rtw_do_join(struct adapter *padapter) =20 /* when set_ssid/set_bssid for rtw_do_join(), but there are no desired= bss in scanning queue */ /* we try to issue sitesurvey firstly */ - if (pmlmepriv->link_detect_info.busy_traffic =3D=3D false || + if (!pmlmepriv->link_detect_info.busy_traffic || rtw_to_roam(padapter) > 0) { ret =3D rtw_sitesurvey_cmd(padapter, &pmlmepriv->assoc_ssid, 1, NULL,= 0); if (ret !=3D _SUCCESS) @@ -143,32 +140,32 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, stru= ct ndis_802_11_ssid *ssid) netdev_dbg(padapter->pnetdev, "set ssid [%s] fw_state =3D 0x%08x\n", ssid->ssid, get_fwstate(pmlmepriv)); =20 - if (padapter->hw_init_completed =3D=3D false) { + if (!padapter->hw_init_completed) { status =3D _FAIL; goto exit; } =20 spin_lock_bh(&pmlmepriv->lock); =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) goto handle_tkip_countermeasure; - else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) =3D=3D true) + else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) goto release_mlme_lock; =20 - if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) =3D=3D t= rue) { + if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE)) { if ((pmlmepriv->assoc_ssid.ssid_length =3D=3D ssid->ssid_length) && (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length)= )) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D false) { - if (rtw_is_same_ibss(padapter, pnetwork) =3D=3D false) { + if (!check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { + if (!rtw_is_same_ibss(padapter, pnetwork)) { /* if in WIFI_ADHOC_MASTER_STATE | WIFI_ADHOC_STATE, create bss or re= join again */ rtw_disassoc_cmd(padapter, 0, true); =20 - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_LINKED)) rtw_indicate_disconnect(padapter); =20 rtw_free_assoc_resources(padapter, 1); =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { _clr_fwstate_(pmlmepriv, WIFI_ADHOC_MASTER_STATE); set_fwstate(pmlmepriv, WIFI_ADHOC_STATE); } @@ -181,12 +178,12 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, stru= ct ndis_802_11_ssid *ssid) } else { rtw_disassoc_cmd(padapter, 0, true); =20 - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_LINKED)) rtw_indicate_disconnect(padapter); =20 rtw_free_assoc_resources(padapter, 1); =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { _clr_fwstate_(pmlmepriv, WIFI_ADHOC_MASTER_STATE); set_fwstate(pmlmepriv, WIFI_ADHOC_STATE); } @@ -199,7 +196,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct= ndis_802_11_ssid *ssid) goto release_mlme_lock; } =20 - if (rtw_validate_ssid(ssid) =3D=3D false) { + if (!rtw_validate_ssid(ssid)) { status =3D _FAIL; goto release_mlme_lock; } @@ -207,7 +204,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct= ndis_802_11_ssid *ssid) memcpy(&pmlmepriv->assoc_ssid, ssid, sizeof(struct ndis_802_11_ssid)); pmlmepriv->assoc_by_bssid =3D false; =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) pmlmepriv->to_join =3D true; else status =3D rtw_do_join(padapter); @@ -227,10 +224,10 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u= 8 *bssid, struct ndis_802_1 bool ssid_valid =3D true; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 - if (!ssid || rtw_validate_ssid(ssid) =3D=3D false) + if (!ssid || !rtw_validate_ssid(ssid)) ssid_valid =3D false; =20 - if (!bssid || rtw_validate_bssid(bssid) =3D=3D false) + if (!bssid || !rtw_validate_bssid(bssid)) bssid_valid =3D false; =20 if (!ssid_valid && !bssid_valid) { @@ -238,7 +235,7 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 = *bssid, struct ndis_802_1 goto exit; } =20 - if (padapter->hw_init_completed =3D=3D false) { + if (!padapter->hw_init_completed) { status =3D _FAIL; goto exit; } @@ -248,9 +245,9 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 = *bssid, struct ndis_802_1 netdev_dbg(padapter->pnetdev, FUNC_ADPT_FMT " fw_state =3D 0x%08x\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv)); =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) goto handle_tkip_countermeasure; - else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) =3D=3D true) + else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) goto release_mlme_lock; =20 handle_tkip_countermeasure: @@ -271,7 +268,7 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 = *bssid, struct ndis_802_1 pmlmepriv->assoc_by_bssid =3D false; } =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) pmlmepriv->to_join =3D true; else status =3D rtw_do_join(padapter); @@ -300,15 +297,15 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter = *padapter, =20 spin_lock_bh(&pmlmepriv->lock); =20 - if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) || (*pold_state = =3D=3D Ndis802_11IBSS)) + if (check_fwstate(pmlmepriv, _FW_LINKED) || *pold_state =3D=3D Ndis802_1= 1IBSS) rtw_disassoc_cmd(padapter, 0, true); =20 - if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) + if (check_fwstate(pmlmepriv, _FW_LINKED) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) rtw_free_assoc_resources(padapter, 1); =20 - if ((*pold_state =3D=3D Ndis802_11Infrastructure) || (*pold_state =3D=3D= Ndis802_11IBSS)) { - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) + if (*pold_state =3D=3D Ndis802_11Infrastructure || *pold_state =3D=3D Nd= is802_11IBSS) { + if (check_fwstate(pmlmepriv, _FW_LINKED)) rtw_indicate_disconnect(padapter); /* will clr Linked_state; before th= is function, we must have checked whether issue dis-assoc_cmd or not */ } =20 @@ -351,7 +348,7 @@ u8 rtw_set_802_11_disassociate(struct adapter *padapter) =20 spin_lock_bh(&pmlmepriv->lock); =20 - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) { + if (check_fwstate(pmlmepriv, _FW_LINKED)) { rtw_disassoc_cmd(padapter, 0, true); rtw_indicate_disconnect(padapter); /* modify for CONFIG_IEEE80211W, none 11w can use it */ @@ -373,13 +370,13 @@ u8 rtw_set_802_11_bssid_list_scan(struct adapter *pad= apter, struct ndis_802_11_s res =3D false; goto exit; } - if (padapter->hw_init_completed =3D=3D false) { + if (!padapter->hw_init_completed) { res =3D false; goto exit; } =20 - if ((check_fwstate(pmlmepriv, _FW_UNDER_SURVEY|_FW_UNDER_LINKING) =3D=3D = true) || - (pmlmepriv->link_detect_info.busy_traffic =3D=3D true)) { + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING) || + pmlmepriv->link_detect_info.busy_traffic) { /* Scan or linking is in progress, do nothing. */ res =3D true; =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index bff8f8e76a63..06537f21bbe6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -384,8 +384,9 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * } else { while (true) { /* IOT action */ - if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en =3D=3D true) && - (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_)) { + if (pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS && + pattrib->ampdu_en && + padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_) { pattrib->vcs_mode =3D CTS_TO_SELF; break; } @@ -420,7 +421,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * /* to do list: check MIMO power save condition. */ =20 /* check AMPDU aggregation for TXOP */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -482,10 +483,10 @@ static s32 update_attrib_sec_info(struct adapter *pad= apter, struct pkt_attrib *p memset(pattrib->dot11tkiptxmickey.skey, 0, 16); pattrib->mac_id =3D psta->mac_id; =20 - if (psta->ieee8021x_blocked =3D=3D true) { + if (psta->ieee8021x_blocked) { pattrib->encrypt =3D 0; =20 - if ((pattrib->ether_type !=3D 0x888e) && (check_fwstate(pmlmepriv, WIFI_= MP_STATE) =3D=3D false)) { + if (pattrib->ether_type !=3D 0x888e && !check_fwstate(pmlmepriv, WIFI_MP= _STATE)) { res =3D _FAIL; goto exit; } @@ -639,8 +640,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p memcpy(pattrib->dst, ðerhdr.h_dest, ETH_ALEN); memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); memcpy(pattrib->ta, pattrib->src, ETH_ALEN); } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -704,7 +705,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (!psta) { /* if we cannot get psta =3D> drop the pkt */ res =3D _FAIL; goto exit; - } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) && (!(p= sta->state & _FW_LINKED))) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) && + !(psta->state & _FW_LINKED)) { res =3D _FAIL; goto exit; } @@ -881,7 +883,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr SetFrameSubType(fctrl, pattrib->subtype); =20 if (pattrib->subtype & WIFI_DATA_TYPE) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { /* to_ds =3D 1, fr_ds =3D 0; */ =20 { @@ -895,7 +897,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pqospriv->qos_option) qos_option =3D true; - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* to_ds =3D 0, fr_ds =3D 1; */ SetFrDs(fctrl); memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); @@ -904,8 +906,8 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pattrib->qos_en) qos_option =3D true; - } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + } else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN); memcpy(pwlanhdr->addr3, get_bssid(pmlmepriv), ETH_ALEN); @@ -963,7 +965,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr pattrib->ampdu_en =3D true; =20 /* re-check if enable ampdu by BA_starting_seqctrl */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { u16 tx_seq; =20 tx_seq =3D psta->BA_starting_seqctrl[pattrib->priority & 0x0f]; @@ -1114,7 +1116,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 frg_inx++; =20 - if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { + if (bmcst || rtw_endofpktfile(&pktfile)) { pattrib->nr_frags =3D frg_inx; =20 pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + @@ -1140,7 +1142,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 xmitframe_swencrypt(padapter, pxmitframe); =20 - if (bmcst =3D=3D false) + if (!bmcst) update_attrib_vcs_info(padapter, pxmitframe); else pattrib->vcs_mode =3D NONE_VCS; @@ -1977,14 +1979,14 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_bu= ff **ppkt) do_queue_select(padapter, &pxmitframe->attrib); =20 spin_lock_bh(&pxmitpriv->lock); - if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) =3D=3D true)= { + if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) { spin_unlock_bh(&pxmitpriv->lock); return 1; } spin_unlock_bh(&pxmitpriv->lock); =20 /* pre_xmitframe */ - if (rtw_hal_xmit(padapter, pxmitframe) =3D=3D false) + if (!rtw_hal_xmit(padapter, pxmitframe)) return 1; =20 return 0; @@ -2028,7 +2030,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x signed int bmcst =3D is_multicast_ether_addr(pattrib->ra); bool update_tim =3D false; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D false) + if (!check_fwstate(pmlmepriv, WIFI_AP_STATE)) return ret; psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) @@ -2153,7 +2155,7 @@ static void dequeue_xmitframes_to_sleeping_queue(stru= ct adapter *padapter, struc =20 ret =3D xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); =20 - if (true =3D=3D ret) { + if (ret) { ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8= *)(&ac_index)); =20 ptxservq->qcnt--; diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 62b249cc23ef..a6f12541b1a7 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1072,7 +1072,7 @@ static int cfg80211_rtw_change_iface(struct wiphy *wi= phy, =20 rtw_wdev->iftype =3D type; =20 - if (rtw_set_802_11_infrastructure_mode(padapter, networkType) =3D=3D fals= e) { + if (!rtw_set_802_11_infrastructure_mode(padapter, networkType)) { rtw_wdev->iftype =3D old_type; ret =3D -EPERM; goto exit; @@ -1283,7 +1283,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } spin_unlock_bh(&pmlmepriv->lock); =20 - if (_status =3D=3D false) + if (!_status) ret =3D -1; =20 check_need_indicate_scan_done: @@ -1585,7 +1585,7 @@ static int cfg80211_rtw_join_ibss(struct wiphy *wiphy= , struct net_device *ndev, ret =3D rtw_cfg80211_set_auth_type(psecuritypriv, NL80211_AUTHTYPE_OPEN_S= YSTEM); rtw_set_802_11_authentication_mode(padapter, psecuritypriv->ndisauthtype); =20 - if (rtw_set_802_11_ssid(padapter, &ndis_ssid) =3D=3D false) { + if (!rtw_set_802_11_ssid(padapter, &ndis_ssid)) { ret =3D -1; goto exit; } @@ -1611,7 +1611,7 @@ static int cfg80211_rtw_leave_ibss(struct wiphy *wiph= y, struct net_device *ndev) =20 rtw_wdev->iftype =3D NL80211_IFTYPE_STATION; =20 - if (rtw_set_802_11_infrastructure_mode(padapter, Ndis802_11Infrastructur= e) =3D=3D false) { + if (!rtw_set_802_11_infrastructure_mode(padapter, Ndis802_11Infrastructu= re)) { rtw_wdev->iftype =3D old_type; ret =3D -EPERM; goto leave_ibss; @@ -1764,7 +1764,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, =20 /* rtw_set_802_11_encryption_mode(padapter, padapter->securitypriv.ndisen= cryptstatus); */ =20 - if (rtw_set_802_11_connect(padapter, (u8 *)sme->bssid, &ndis_ssid) =3D=3D= false) { + if (!rtw_set_802_11_connect(padapter, (u8 *)sme->bssid, &ndis_ssid)) { ret =3D -1; goto exit; } @@ -2070,7 +2070,7 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entry= (struct sk_buff *skb, struc u32 len =3D skb->len; u8 category, action; =20 - if (rtw_action_frame_parse(buf, len, &category, &action) =3D=3D false) + if (!rtw_action_frame_parse(buf, len, &category, &action)) goto fail; =20 /* starting alloc mgmt frame to dump it */ @@ -2551,7 +2551,7 @@ static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, = struct wireless_dev *wdev, /* indicate ack before issue frame to avoid racing with rsp frame */ rtw_cfg80211_mgmt_tx_status(padapter, *cookie, buf, len, ack, GFP_KERNEL); =20 - if (rtw_action_frame_parse(buf, len, &category, &action) =3D=3D false) + if (!rtw_action_frame_parse(buf, len, &category, &action)) goto exit; =20 rtw_ps_deny(padapter, PS_DENY_MGNT_TX); --=20 2.52.0