From nobody Mon Feb 9 15:26:12 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF76B3246F3 for ; Sun, 1 Feb 2026 10:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769942657; cv=none; b=FfgpcaQqzhY9NWBnvC5IHnZsTYAxU1MQk34q69CNfYvtNQDKS/rPpMGEzR5OENPDc/3J7SwiFX6G2T4C/hwWDSZ7VNchEZCb6chC9H7ubDiZCqhoNs86w2R3C1WjtmrVQQ7s5qPSSQQwO//afxY3xApJJ7SOk2fgB06BRadB3Dw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769942657; c=relaxed/simple; bh=MmvcjAHmY9aFurBioYKxYGT+fXCRvKADDio6QvZg5Do=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JX02af+4rkKg382Y3rR8vqqdy8J4J0/8UpAqVgWrjHSqPBlBva8qkc3F0SsrNl9DJqGfkU+SbvzrTKyUFxf6zRbRFYhkp83XdiBEDkMVTfpgpZJ/3mGkTSf+ekdnM3lToRjznMWjKfAgwmtW85hqcnCINKyjQ6L5dBi5O6Fk7A8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IK8fV1qZ; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IK8fV1qZ" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-432da746749so2005573f8f.0 for ; Sun, 01 Feb 2026 02:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769942653; x=1770547453; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FW0JM8bdWfKfSamq7DjcZL13sVfyz7u3bs6KeiNnLcY=; b=IK8fV1qZjVEFFQ1iUfVaNwe6Vf2H/FmtinypcsKPqdJrqOWRAlySQ3NZyoUEdDC15p bt6VHwibGoUZZrq8dxj+GYXTPc6cGEOx4jGLHWD/yih9EPXr/lyDNr1H9WR7sN6j1idw GbxYYAC1dVqlmygLc7A7ZbtkKZy6bgDTF+bRKFSppdcboLweRhiVtdDwgyoszY9eX7I9 Mq61VocPi84A7iKq3Y0hjS5v7GwLX7hGQxzwhb247D4+yRcOrZ+0WV+V+w+nBv90pi9l S+Ac7tq6G0c7CQAbyvIfONi9PvK9sp3YPZ+ri+I5fSH4xAmcAbZFxd+pK8EE4yfCjzzz 7mFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769942653; x=1770547453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FW0JM8bdWfKfSamq7DjcZL13sVfyz7u3bs6KeiNnLcY=; b=pvUMss9zsTsm2MRw8lVnovyZ+Bq011Ptd0FOqU083CMi7Ip2Dbfi4WcEAm+5CUZ9bl mT+loxan3rHjfAOqS3+j0wifOrAwMG8iRz1HbAXii/l2pkZF0Cswbq/j0UTvWMQldLlm n9qp+n53Z46Vk/QtIlMiYN82V+zkrEySiQPb/XMEUizuxXOrcm6TuY28yDULq4kczr98 Niyf/Gidos/MbYaWifL3XuPae6IzjeH/anYfVmvjiNL2dq/RmrhrvdL5a/xgKLYcCi/n F7BHCFbI8+SVlFQzaPUjvLWxIyxvqHmFcDgD72fxpQyKW7kDoAqmFvtnSebOOk5IuOz1 AF9g== X-Forwarded-Encrypted: i=1; AJvYcCVwBz0SHDqfW+mlfW497LRok1TX3S1D0yjflyF5Oh21z11YjnNfEfF//JIAX+9l23AC5SL7flJ5BU1lni4=@vger.kernel.org X-Gm-Message-State: AOJu0YxxxDvvrxnmIkoNk4zMa70YZQhgB/2kwn1tgF4rxeDQohSJ73FZ f97vZzf5iFmbSKiYBVcBo/pvIbfkLG8xv8Dj69mq8Ds3RqBhb6Hjn2Ke X-Gm-Gg: AZuq6aJLBOxJaRS8bL+3HcTqyYHy5JZcAYkH/9/ZMZdymJAHKsXQGo4DPAxEngBpdyX 5y/wboAJmrH7IzthHC7gjhDIIr8OUOHUYR1hTPDJ0qmimr2lsUqtnPTtSvVRzLPRSX6KJ5E2F/h RieOomu1wDmLPaNTyrIIGGmFS4KesuzWPxzpAsR1fpuAdWSmf2WNzC2HSSmSjzCffsmRINk0RE0 UmHv39GsLU3QOAf6T4lpDbWqPlXaD0ZQ0zXicSUmMckyJ4VACSD168z417e4ndW1yzj7eF9Nh1n T2asdSG9o/3LLQxeipBENBhCxJgq4KPbwU07wJqX/HaT5Clh/DkR5Aj/FYk1gxaD0nW8BpF7SoQ G9tdRHuphp18UENQLly0DMEGB1AvV4P52TIek6Eoc7uOmFopPXv1yloJUSl0T0n+6aNfywSH8oK 4T X-Received: by 2002:a05:600c:1385:b0:480:6852:8d94 with SMTP id 5b1f17b1804b1-482db499781mr103571145e9.27.1769942653146; Sun, 01 Feb 2026 02:44:13 -0800 (PST) Received: from xeon ([188.163.112.49]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce56490sm308947455e9.12.2026.02.01.02.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 02:44:12 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v1 2/9] misc: Support Asus Transformer's EC access device Date: Sun, 1 Feb 2026 12:43:36 +0200 Message-ID: <20260201104343.79231-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260201104343.79231-1-clamor95@gmail.com> References: <20260201104343.79231-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add support for accessing Embedded Controller of Asus Transformer devices. This will be used by the EC MFD drivers. Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel --- drivers/misc/Kconfig | 9 + drivers/misc/Makefile | 1 + drivers/misc/asus-dockram.c | 327 ++++++++++++++++++++++++++++++++++++ include/linux/mfd/asus-ec.h | 18 ++ 4 files changed, 355 insertions(+) create mode 100644 drivers/misc/asus-dockram.c create mode 100644 include/linux/mfd/asus-ec.h diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index dd1ab7e445ac..e7faa7ab4199 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -50,6 +50,15 @@ config AD525X_DPOT_SPI To compile this driver as a module, choose M here: the module will be called ad525x_dpot-spi. =20 +config ASUS_DOCKRAM + tristate "Asus Transformer's EC DockRAM" + depends on I2C + help + Select this if you are building for Asus Transformer's. + + To compile this driver as a module, choose M here: the + module will be called asus-dockram. + config DUMMY_IRQ tristate "Dummy IRQ handler" help diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index bfad6982591c..d2287e912d59 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_IBMVMC) +=3D ibmvmc.o obj-$(CONFIG_AD525X_DPOT) +=3D ad525x_dpot.o obj-$(CONFIG_AD525X_DPOT_I2C) +=3D ad525x_dpot-i2c.o obj-$(CONFIG_AD525X_DPOT_SPI) +=3D ad525x_dpot-spi.o +obj-$(CONFIG_ASUS_DOCKRAM) +=3D asus-dockram.o obj-$(CONFIG_ATMEL_SSC) +=3D atmel-ssc.o obj-$(CONFIG_DUMMY_IRQ) +=3D dummy-irq.o obj-$(CONFIG_ICS932S401) +=3D ics932s401.o diff --git a/drivers/misc/asus-dockram.c b/drivers/misc/asus-dockram.c new file mode 100644 index 000000000000..d98dcf5ef2d4 --- /dev/null +++ b/drivers/misc/asus-dockram.c @@ -0,0 +1,327 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * ASUS EC: DockRAM + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct dockram_ec_data { + struct mutex ctl_lock; /* prevent simultaneous access */ + char ctl_data[DOCKRAM_ENTRY_BUFSIZE]; +}; + +int asus_dockram_read(struct i2c_client *client, int reg, char *buf) +{ + int rc; + + memset(buf, 0, DOCKRAM_ENTRY_BUFSIZE); + rc =3D i2c_smbus_read_i2c_block_data(client, reg, DOCKRAM_ENTRY_BUFSIZE, = buf); + if (rc < 0) + return rc; + + if (buf[0] > DOCKRAM_ENTRY_SIZE) { + dev_err(&client->dev, "bad data len; buffer: %*ph; rc: %d\n", + DOCKRAM_ENTRY_BUFSIZE, buf, rc); + return -EPROTO; + } + + dev_dbg(&client->dev, "got data; buffer: %*ph; rc: %d\n", + DOCKRAM_ENTRY_BUFSIZE, buf, rc); + + return 0; +} +EXPORT_SYMBOL_GPL(asus_dockram_read); + +int asus_dockram_write(struct i2c_client *client, int reg, const char *buf) +{ + if (buf[0] > DOCKRAM_ENTRY_SIZE) + return -EINVAL; + + dev_dbg(&client->dev, "sending data; buffer: %*ph\n", buf[0] + 1, buf); + + return i2c_smbus_write_i2c_block_data(client, reg, buf[0] + 1, buf); +} +EXPORT_SYMBOL_GPL(asus_dockram_write); + +int asus_dockram_access_ctl(struct i2c_client *client, + u64 *out, u64 mask, u64 xor) +{ + struct dockram_ec_data *priv =3D i2c_get_clientdata(client); + char *buf =3D priv->ctl_data; + u64 val; + int ret =3D 0; + + guard(mutex)(&priv->ctl_lock); + + ret =3D asus_dockram_read(client, ASUSEC_DOCKRAM_CONTROL, buf); + if (ret < 0) + goto exit; + + if (buf[0] !=3D ASUSEC_CTL_SIZE) { + ret =3D -EPROTO; + goto exit; + } + + val =3D get_unaligned_le64(buf + 1); + + if (out) + *out =3D val; + + if (mask || xor) { + put_unaligned_le64((val & ~mask) ^ xor, buf + 1); + ret =3D asus_dockram_write(client, ASUSEC_DOCKRAM_CONTROL, buf); + } + +exit: + if (ret < 0) + dev_err(&client->dev, "Failed to access control flags: %d\n", + ret); + + return ret; +} +EXPORT_SYMBOL_GPL(asus_dockram_access_ctl); + +static ssize_t dockram_read(struct file *filp, struct kobject *kobj, + const struct bin_attribute *attr, + char *buf, loff_t off, size_t count) +{ + struct i2c_client *client =3D kobj_to_i2c_client(kobj); + unsigned int reg; + ssize_t n_read =3D 0; + char *data; + int ret; + + reg =3D off / DOCKRAM_ENTRY_SIZE; + off %=3D DOCKRAM_ENTRY_SIZE; + + if (!count) + return 0; + + data =3D kmalloc(DOCKRAM_ENTRY_BUFSIZE, GFP_KERNEL); + + while (reg < DOCKRAM_ENTRIES) { + unsigned int len =3D DOCKRAM_ENTRY_SIZE - off; + + if (len > count) + len =3D count; + + ret =3D asus_dockram_read(client, reg, data); + if (ret < 0) { + if (!n_read) + n_read =3D ret; + break; + } + + memcpy(buf, data + 1 + off, len); + n_read +=3D len; + + if (len =3D=3D count) + break; + + count -=3D len; + buf +=3D len; + off =3D 0; + ++reg; + } + + kfree(data); + + return n_read; +} + +static int dockram_write_one(struct i2c_client *client, int reg, + const char *buf, size_t count) +{ + struct dockram_ec_data *priv =3D i2c_get_clientdata(client); + int ret; + + if (!count || count > DOCKRAM_ENTRY_SIZE) + return -EINVAL; + if (buf[0] !=3D count - 1) + return -EINVAL; + + guard(mutex)(&priv->ctl_lock); + + priv->ctl_data[0] =3D (u8)count; + memcpy(priv->ctl_data + 1, buf, count); + ret =3D asus_dockram_write(client, reg, priv->ctl_data); + + return ret; +} + +static ssize_t dockram_write(struct file *filp, struct kobject *kobj, + const struct bin_attribute *attr, + char *buf, loff_t off, size_t count) +{ + struct i2c_client *client =3D kobj_to_i2c_client(kobj); + unsigned int reg; + int ret; + + if (off % DOCKRAM_ENTRY_SIZE !=3D 0) + return -EINVAL; + + reg =3D off / DOCKRAM_ENTRY_SIZE; + if (reg >=3D DOCKRAM_ENTRIES) + return -EINVAL; + + ret =3D dockram_write_one(client, reg, buf, count); + + return ret < 0 ? ret : count; +} + +static ssize_t control_reg_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct i2c_client *client =3D to_i2c_client(dev); + u64 val; + int ret; + + ret =3D asus_dockram_access_ctl(client, &val, 0, 0); + if (ret < 0) + return ret; + + return sysfs_emit(buf, "%016llx\n", val); +} + +static ssize_t control_reg_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct i2c_client *client =3D to_i2c_client(dev); + u64 val; + int ret; + + ret =3D kstrtoull(buf, 16, &val); + if (ret < 0) + return ret; + + ret =3D asus_dockram_access_ctl(client, NULL, ~0ull, val); + if (ret < 0) + return ret; + + return count; +} + +static BIN_ATTR_RW(dockram, DOCKRAM_ENTRIES * DOCKRAM_ENTRY_SIZE); +static DEVICE_ATTR_RW(control_reg); + +static struct attribute *dockram_attrs[] =3D { + &dev_attr_control_reg.attr, + NULL +}; + +static const struct bin_attribute *dockram_bin_attrs[] =3D { + &bin_attr_dockram, + NULL +}; + +static const struct attribute_group dockram_group =3D { + .attrs =3D dockram_attrs, + .bin_attrs =3D dockram_bin_attrs, +}; + +static int asus_dockram_probe(struct i2c_client *client) +{ + struct dockram_ec_data *priv; + + if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_I2C_BLOCK)) + return dev_err_probe(&client->dev, -ENXIO, + "I2C bus is missing required SMBus block mode support\n"); + + priv =3D devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + i2c_set_clientdata(client, priv); + mutex_init(&priv->ctl_lock); + + return devm_device_add_group(&client->dev, &dockram_group); +} + +static const struct of_device_id asus_dockram_ids[] =3D { + { .compatible =3D "asus,dockram" }, + { } +}; +MODULE_DEVICE_TABLE(of, asus_dockram_ids); + +static struct i2c_driver asus_dockram_driver =3D { + .driver =3D { + .name =3D "asus-dockram", + .of_match_table =3D of_match_ptr(asus_dockram_ids), + }, + .probe =3D asus_dockram_probe, +}; +module_i2c_driver(asus_dockram_driver); + +static void devm_i2c_device_release(struct device *dev, void *res) +{ + struct i2c_client **pdev =3D res; + struct i2c_client *child =3D *pdev; + + if (child) + put_device(&child->dev); +} + +static struct i2c_client *devm_i2c_device_get_by_phandle(struct device *de= v, + const char *name, + int index) +{ + struct device_node *np; + struct i2c_client **pdev; + + pdev =3D devres_alloc(devm_i2c_device_release, sizeof(*pdev), + GFP_KERNEL); + if (!pdev) + return ERR_PTR(-ENOMEM); + + np =3D of_parse_phandle(dev_of_node(dev), name, index); + if (!np) { + devres_free(pdev); + dev_err(dev, "can't resolve phandle %s: %d\n", name, index); + return ERR_PTR(-ENODEV); + } + + *pdev =3D of_find_i2c_device_by_node(np); + of_node_put(np); + + if (!*pdev) { + devres_free(pdev); + return ERR_PTR(-EPROBE_DEFER); + } + + devres_add(dev, pdev); + + return *pdev; +} + +struct i2c_client *devm_asus_dockram_get(struct device *parent) +{ + struct i2c_client *dockram =3D + devm_i2c_device_get_by_phandle(parent, "asus,dockram", 0); + + if (IS_ERR(dockram)) + return dockram; + if (!dockram->dev.driver) + return ERR_PTR(-EPROBE_DEFER); + if (dockram->dev.driver !=3D &asus_dockram_driver.driver) + return ERR_PTR(-EBUSY); + + return dockram; +} +EXPORT_SYMBOL_GPL(devm_asus_dockram_get); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer's dockram driver"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/mfd/asus-ec.h b/include/linux/mfd/asus-ec.h new file mode 100644 index 000000000000..bc4efa37f5ba --- /dev/null +++ b/include/linux/mfd/asus-ec.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __MISC_ASUS_EC_H +#define __MISC_ASUS_EC_H + +struct i2c_client; + +/* dockram comm */ +int asus_dockram_read(struct i2c_client *client, int reg, char *buf); +int asus_dockram_write(struct i2c_client *client, int reg, const char *buf= ); +int asus_dockram_access_ctl(struct i2c_client *client, + u64 *out, u64 mask, u64 xor); +struct i2c_client *devm_asus_dockram_get(struct device *parent); + +#define DOCKRAM_ENTRIES 0x100 +#define DOCKRAM_ENTRY_SIZE 32 +#define DOCKRAM_ENTRY_BUFSIZE (DOCKRAM_ENTRY_SIZE + 1) + +#endif /* __MISC_ASUS_EC_H */ --=20 2.51.0