From nobody Sun Feb 8 21:46:51 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6C313246EB for ; Sun, 1 Feb 2026 10:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769940137; cv=none; b=fnFwSoeBeifjFIsVEvv0L6OpWcPDA26g9EylxGWMNCR9NdC650c4pYYud1w4hDaeQ35en2Wv7lNplYK+FlZeGoy5u+TqNplqPI+8iqwlCBK8btTPp8BiCns0rJ1Tof90vx/bui50fRStdWVuJul0aW01q/wk+cSm303v9qkIt04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769940137; c=relaxed/simple; bh=c3yatG1BN5HWt92BTkz9Te8xKfLiFa8V+pN6bUfo2KQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tOFmmy1+bNatCfez8vMHWSfa+pvBM+R1SeAWGkw0SK4nTHKc+7LXb/uXLu/Yx50DTT7jgHe900J1FmeiSTyBN9FBDjrOKxL5UP7ff2Q+9DTOnY1dZfoo5lsv+TK7cqOu+CtKuD5w765vedlLsL16aSNf8Gy5zGV6snSrz2DTHfI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KMCP4g0z; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KMCP4g0z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769940136; x=1801476136; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=c3yatG1BN5HWt92BTkz9Te8xKfLiFa8V+pN6bUfo2KQ=; b=KMCP4g0zP0IFGsWBD3ggozWWLavfsvb2xvwyUqeP2dfcJlgVbkz8QHbF vip4tqzq0FvVa/bNgV5PgyW3w9LtaxxVlxK4ShPpWAzUxi0iYp1nCfB+I +WKaToP9RxhI1ZKF2CD0vv10ZfTXFJuCWvXrZiYaczwgISISlWYXmbi8d YkR7NkqZt/oTL+mlrvJ1754ONiN2FpepZ5v4gE3An5ew0p8mjpHTQloSb GM/DSaEX7FWR+0K/BPz3+Os6fwalDP9pwcN6SuAoOeq4bEqAMF/Xf2H4l Mygyclghsqqh69BxTTfGOdj+JGumfXSsqnSofDkkQ1MWkLoeP/D2AO9tR w==; X-CSE-ConnectionGUID: 5f4itG9UTWqno9znrMBIHQ== X-CSE-MsgGUID: NFUJgn29RnejmBQJyy46BQ== X-IronPort-AV: E=McAfee;i="6800,10657,11688"; a="93780122" X-IronPort-AV: E=Sophos;i="6.21,266,1763452800"; d="scan'208";a="93780122" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2026 02:02:16 -0800 X-CSE-ConnectionGUID: SsNgMlH8Tmam/tMNK62RxA== X-CSE-MsgGUID: XWL/LacLS/+B69v/mfNmcA== X-ExtLoop1: 1 Received: from sannilnx-dsk.jer.intel.com ([10.12.231.107]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2026 02:02:14 -0800 From: Alexander Usyskin To: Greg Kroah-Hartman Cc: Menachem Adin , Alexander Usyskin , linux-kernel@vger.kernel.org, Mika Westerberg Subject: [char-misc-next 7/7] mei: csc: wake device while reading firmware status Date: Sun, 1 Feb 2026 11:43:58 +0200 Message-ID: <20260201094358.1440593-8-alexander.usyskin@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260201094358.1440593-1-alexander.usyskin@intel.com> References: <20260201094358.1440593-1-alexander.usyskin@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The CSC has firmware status registers in MMIO and they may be unaccessible while device is suspended. Wake device while reading firmware status via sysfs. Reviewed-by: Mika Westerberg Signed-off-by: Alexander Usyskin --- drivers/misc/mei/main.c | 18 ++++++++++++++---- drivers/misc/mei/mei_dev.h | 2 ++ drivers/misc/mei/pci-csc.c | 2 ++ 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 6f26d5160788..54f70f513482 100644 --- a/drivers/misc/mei/main.c +++ b/drivers/misc/mei/main.c @@ -4,6 +4,7 @@ * Intel Management Engine Interface (Intel MEI) Linux driver */ =20 +#include #include #include #include @@ -13,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -982,14 +984,22 @@ static DEVICE_ATTR_RO(trc); static ssize_t fw_status_show(struct device *device, struct device_attribute *attr, char *buf) { - struct mei_device *dev =3D dev_get_drvdata(device); + struct mei_device *mdev =3D dev_get_drvdata(device); struct mei_fw_status fw_status; int err, i; ssize_t cnt =3D 0; =20 - mutex_lock(&dev->device_lock); - err =3D mei_fw_status(dev, &fw_status); - mutex_unlock(&dev->device_lock); + if (mdev->read_fws_need_resume) { + err =3D pm_runtime_resume_and_get(mdev->parent); + if (err) { + dev_err(device, "read fw_status resume error =3D %d\n", err); + return err; + } + } + scoped_guard(mutex, &mdev->device_lock) + err =3D mei_fw_status(mdev, &fw_status); + if (mdev->read_fws_need_resume) + pm_runtime_put_autosuspend(mdev->parent); if (err) { dev_err(device, "read fw_status error =3D %d\n", err); return err; diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h index 1796c6793a94..d8634a726990 100644 --- a/drivers/misc/mei/mei_dev.h +++ b/drivers/misc/mei/mei_dev.h @@ -491,6 +491,7 @@ struct mei_dev_timeouts { * * @recvd_hw_ready : hw ready message received flag * @pg_blocked : low power mode is not allowed + * @read_fws_need_resume: the FW status handler needs HW woken from sleep * * @wait_hw_ready : wait queue for receive HW ready message form FW * @wait_pg : wait queue for receive PG message from FW @@ -577,6 +578,7 @@ struct mei_device { =20 bool recvd_hw_ready; bool pg_blocked; + bool read_fws_need_resume; =20 /* * waiting queue for receive message from FW diff --git a/drivers/misc/mei/pci-csc.c b/drivers/misc/mei/pci-csc.c index 15e170b1e0b6..70792bf9b3c0 100644 --- a/drivers/misc/mei/pci-csc.c +++ b/drivers/misc/mei/pci-csc.c @@ -67,6 +67,8 @@ static int mei_csc_probe(struct pci_dev *pdev, const stru= ct pci_device_id *ent) if (!mdev) return -ENOMEM; =20 + mdev->read_fws_need_resume =3D true; + hw =3D to_me_hw(mdev); =20 /* --=20 2.43.0