From nobody Mon Feb 9 03:52:56 2026 Received: from mail-m49198.qiye.163.com (mail-m49198.qiye.163.com [45.254.49.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05BE62FF646; Sun, 1 Feb 2026 09:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.198 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769939033; cv=none; b=e69ZY8gy7+PndHJKOmx3vFU3578P+7JOy5ZiN5Lmz8rOW1+JKHIABz1NKLFTTZ5rs/eNGRhuM+b0EjnrkkRKMOCq5A83g3QUw5f874xo647zYjoSeOW24YRDpn8MdIwfMroQBWg+cgf6kUxeP3ELhB734MGVsViRLaeJMGOZB7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769939033; c=relaxed/simple; bh=2ObiOpzCaf9ENAnYzhBU1+zOAzT0emyGOCV/x8Us02k=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=q7bwFxUUl3q5F1/9zIL1lmNQD1w2bvAri1XZP+H4fcg559OxMF9tnB6xOwbR1JYQK8qjRdkzvVUW5yn6LNlljyek/Ew/zG3z75FMK9B2Uar6wk8LsV9Vorr8Zd5stzCGIZxAdeKzDi+i8uP+QhlYh7E/sRbEJKyYzeclekye7x8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn; spf=pass smtp.mailfrom=seu.edu.cn; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b=MQ+dWn85; arc=none smtp.client-ip=45.254.49.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b="MQ+dWn85" Received: from LAPTOP-N070L597.localdomain (unknown [58.241.16.34]) by smtp.qiye.163.com (Hmail) with ESMTP id 32af8973b; Sun, 1 Feb 2026 15:21:10 +0800 (GMT+08:00) From: Zilin Guan To: hansg@kernel.org Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com, andy@kernel.org, gregkh@linuxfoundation.org, hverkuil@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, jianhao.xu@seu.edu.cn, Zilin Guan Subject: [PATCH] media: atomisp: Fix memory leak in atomisp_fixed_pattern_table() Date: Sun, 1 Feb 2026 07:21:07 +0000 Message-Id: <20260201072107.1797351-1-zilin@seu.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9c1813b1c303a1kunm8b6aea461ae0a7 X-HM-MType: 10 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlCGBoYVkhDGBgeGU8fTUkeS1YeHw5VEwETFhoSFy QUDg9ZV1kYEgtZQVlOQ1VJT0pVSk1VSE9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhOQ0NVSktLVUtZBg ++ DKIM-Signature: a=rsa-sha256; b=MQ+dWn85mOd3MjBDwIDEa9BuwqqBGFGY8lefo0nQQU0K5KFmoFpsYvxKzgWAGfTkK7ZY6x/YSR7H2V0bmliTG+LTIVo+OGKTN7mfSTEmtONCJxUumu4Njup5EHUitIkbiZbm5ohTyVaFvkCdlVYuBXwRoW54DeST/g8dZxjHT4U=; s=default; c=relaxed/relaxed; d=seu.edu.cn; v=1; bh=rgoitE7qtyFWwjN0r8rJPt+r3t28ghan/rSe1cVwWic=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" atomisp_v4l2_framebuffer_to_css_frame() allocates memory for raw_black_frame, which must be released via ia_css_frame_free(). However, if sh_css_set_black_frame() fails, the function returns immediately without performing this cleanup, leading to a memory leak. Fix this by assigning the error code to ret and allowing the code to fall through to the ia_css_frame_free() call. Compile tested only. Issue found using a prototype static analysis tool and code review. Fixes: 85b606e02ad7 ("media: atomisp: get rid of a bunch of other wrappers") Signed-off-by: Zilin Guan --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/stag= ing/media/atomisp/pci/atomisp_cmd.c index 3a4eb4f6d3be..208ff85cd7fb 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -3369,7 +3369,7 @@ int atomisp_fixed_pattern_table(struct atomisp_sub_de= vice *asd, =20 if (sh_css_set_black_frame(asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL].= stream, raw_black_frame) !=3D 0) - return -ENOMEM; + ret =3D -ENOMEM; =20 ia_css_frame_free(raw_black_frame); return ret; --=20 2.34.1