From nobody Mon Feb 9 13:24:54 2026 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3E0B22126D for ; Sat, 31 Jan 2026 22:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769898803; cv=none; b=IhMlZZaOmUPZdMXttKQL4jISi0cLkaLHIsppjiA3othHRkIAXiwTlnq9LBfcQThiDKvajHP05Z/cVBLYNguHC3nu7XyQlgEzqDg9ZhrISbwo16T5oTuohuNYxj9Epl+pq/IgCh/qGhAnnPo98W6ePpuFS1J6T1iH7p9+lLl4bt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769898803; c=relaxed/simple; bh=9ZL1kVsmxIHymtukOhAgGD9pMSg4xnHN1ETY/Rj8BV0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jfQRjkvYO3F84F/js8pT4h09gem2kNOnZcz4UbwZ7ItnGKD5QXmfrrmQnG6hM+uw5kOVPpzl03BlFuoH5Yc/M61aDSDPA+x2QLbIFBngi2g4iZRUKbodCgw0SbMwaxfiz6L6LmeVVV47x2IkbrqS/SBxbtFS9u5WMLAbP1mMsjw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu; spf=pass smtp.mailfrom=u.northwestern.edu; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b=fs3sH5Zn; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b="fs3sH5Zn" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7d1890f7cefso2725121a34.3 for ; Sat, 31 Jan 2026 14:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u-northwestern-edu.20230601.gappssmtp.com; s=20230601; t=1769898801; x=1770503601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CwZ3HyYM4JA3OOkLPTfUKiaLejqAh3clwdl3x61RyzU=; b=fs3sH5ZncwCwoHtcOAH10v3zwXKRr67YkVnBxGyYljz+W1TYDN5g83UTq0tuaGTcSO Ck+Lec567J+VYNzgku6xTpq5Gl3gxrrXHLSycktQkepNxMVFGSSnnmUWaJqX86VmD7lu IsAspU1b0ay8zCFxpggKWSnoGYB3a7oatyn+obK2/uP8t4aKjzXzvHP04oG33OEo/F+L 9hIDvASxFqCS8Ih3KyyqUDIEffuKFkhcd2Zqduzjq5FphFRRVhBKEZUkuGbQ6kmivREd p4EhgLMhZkgCbwil3zQUOZjPyu+YM/dOTK/Zff8t1i0rDSnwKuYmQdIxiohpqbag3BUm e0WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769898801; x=1770503601; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CwZ3HyYM4JA3OOkLPTfUKiaLejqAh3clwdl3x61RyzU=; b=mUai2RuCQEc5ma8ij6gXe1uqIhakFuBT/OFndFe3Ali3YC3IwPPWLUUCsGP7wS4V3g 1gOXZEVDxhsMYkS5A6nmqfFS04ApTPigHstkWFEgrN2V36pGYRcBbCBC2lkhzeujqOo5 rE3qfncPEZaNy5ErLk5afU9NDFTvtrolUd12wlnHKvbcyhNQCUUGo1CS8/wIOyhaFLCa ZDbnGPGzOuRprquKwGS+30usDjz7mOoey8EWcuA7FHBdQ5qIf8dN7SbpLYwdM1C0wszz NYa1mtQw3fFD4hQbV6AIE7dWmlJo2J9Yjv9ne7i9fqTnWH7IIZI6+UgbU2kHq6N2YVVy PFFQ== X-Forwarded-Encrypted: i=1; AJvYcCVesSSbNoZaO1lSlxtgGSEkIunQGkQUyuAK0PqqXQYIknGTlxUzE6W9dX1cVq2tqXFP9pGLdNJ8HYB45hc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5JOlNKnneHR/OBa0/ELwFRLgrLArv5thQksJ10PXNe3YWXHj6 /7s2MQBinxeU+ezDA5lBnih8QqdOgJbKdQfs7do2h8NZNLdojas0G24iB5V27f+bcx4TdmLEwxZ BNGwL X-Gm-Gg: AZuq6aKr4PH9QqAlumpkxY5dahB1vXBmbxF/dJX4s2VLzM5PRL97d9A9Z47FAJgDgD6 eYjl35e8OsvZWiuyyfCt/L02kNjSXhEEBvB2vnrjO75FM2CY+HGBPx0W9u6mylOUO7egNotvWq2 ird3aVbQLLtcAr2rG7tFBOdjDX3A9ngY2bmBeDRQHNDjliyjUvd9c83DtadNNbcbHunF9W8dQ63 uT3Li9Gv8QYu9tz0Ep1ysZUGXUGR4t2KEW7N1yTCaHT6OUKa3e7VRBNwoXnIks8XjK4DBKFyzlA chaHimLXj3XK8XyVgNoMG9ot5gP/luKJfZ++Rpx5ahX1mzFYw1jxlEq2FM0t8aDIa15Nl1lF52o zD6JzfWFxu5Wr2JQiV+O1juzC1DjG+CA1pLO21+ZJySQJsuuJQG8RNwJvuHF1sd+d2Q3LrUOn6y QgXmVkl7AvufUCyc8Xp9Z6eKJlZxbM4xgH+YlzSnYD1jEgbjNVUaRVaQxKjcaPtsz7gessHE+jP MJksN7AJirO6llkkh7SbiVWW5WDsyE= X-Received: by 2002:a05:6830:4983:b0:7cf:dd63:3d52 with SMTP id 46e09a7af769-7d1a531b4a7mr4745087a34.18.1769898800777; Sat, 31 Jan 2026 14:33:20 -0800 (PST) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d1a6dd4423sm3805951a34.28.2026.01.31.14.33.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 14:33:20 -0800 (PST) From: Ziyi Guo To: Simon Trimmer , Charles Keepax , Richard Fitzgerald Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Ziyi Guo Subject: [PATCH] firmware: cs_dsp: fix missing pwr_lock in cs_dsp_signal_event_controls() Date: Sat, 31 Jan 2026 22:33:17 +0000 Message-Id: <20260131223317.3328639-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cs_dsp_signal_event_controls() calls cs_dsp_coeff_write_acked_control() which has lockdep_assert_held(&dsp->pwr_lock), but the lock is not held. Add mutex_lock()/mutex_unlock() around the control list iteration in cs_dsp_signal_event_controls() to fix the missing lock protection. Signed-off-by: Ziyi Guo --- drivers/firmware/cirrus/cs_dsp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_= dsp.c index 525ac0f0a75d..0067cf292c62 100644 --- a/drivers/firmware/cirrus/cs_dsp.c +++ b/drivers/firmware/cirrus/cs_dsp.c @@ -972,6 +972,8 @@ static void cs_dsp_signal_event_controls(struct cs_dsp = *dsp, struct cs_dsp_coeff_ctl *ctl; int ret; =20 + mutex_lock(&dsp->pwr_lock); + list_for_each_entry(ctl, &dsp->ctl_list, list) { if (ctl->type !=3D WMFW_CTL_TYPE_HOSTEVENT) continue; @@ -985,6 +987,8 @@ static void cs_dsp_signal_event_controls(struct cs_dsp = *dsp, "Failed to send 0x%x event to alg 0x%x (%d)\n", event, ctl->alg_region.alg, ret); } + + mutex_unlock(&dsp->pwr_lock); } =20 static void cs_dsp_free_ctl_blk(struct cs_dsp_coeff_ctl *ctl) --=20 2.34.1