From nobody Mon Feb 9 15:12:18 2026 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8A3838A289 for ; Sat, 31 Jan 2026 22:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769897952; cv=none; b=dJ8g0joVy8C8Pj22SIIDMGrgKkJ8MokLwKhvlg2AdZ63nZKtIsPtbtezAsj/84qnenlKhjAnicqqNRQGY6bhF/IZuZD9OHRygAEMrA5+zoXG7xBOEpCcWJOBLjGtycOh7JAWnxvnEz3GaTEKDm7OAJOayXPxD+i4KpbBjin0U54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769897952; c=relaxed/simple; bh=XQzXV5RsU1ucKWmL9/NTjI6ZtXNXLK+awDZjr+Wac7w=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Y+3wA+VGW5B7IBIQ0wfo3rDIRWP8DnqjwUAXFWYFqx/SFYUz1cBm571FbtMgqYPUuFD2g8HgqlVNSjKl71SpvXoJVstHafB0UeUl8G0o1GKHP2iNRJi1zqntbCM1Fay2/lXCErk/qGEJ09jQDeSHPclxmPZeaJVkU5JcWm/h11w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu; spf=pass smtp.mailfrom=u.northwestern.edu; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b=bG6F9UWI; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b="bG6F9UWI" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-45c838069e5so2234385b6e.0 for ; Sat, 31 Jan 2026 14:19:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u-northwestern-edu.20230601.gappssmtp.com; s=20230601; t=1769897950; x=1770502750; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=M+GROKcYP9TzY9wl/o9M+TDsv2+lescxpK+bfyqozIU=; b=bG6F9UWIb1+TMhK1z2vdkv+v/x5WGntqUOFpj01U1CX1F8Hrf6wJ9tYFIUiK8AIZYa v/Ph3wUouBiZlQBAloqMfxh5dNewblQG7/CkGUg3VJJcxjSOwb6WR2/HlnzaEaG85eTv gVPWBGy2FH03dY3jpmjvGYnhAO7PiZUBvTPIT3rdfBXR/k2pvhOLdzRLbuScUZkjOmuL Ev1usp+kNZFG50NB2+6SNrcD2SjANkoo3CcwDfjysKjUizQyHZOS4ssvbG455Ao7vt/p n709jYXgY0fzLvU7Sw+sQ2QO25edHBKB5Dzz1NWRO0xvXLEO68G7ch7dkah8IFuqIwdC OSEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769897950; x=1770502750; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M+GROKcYP9TzY9wl/o9M+TDsv2+lescxpK+bfyqozIU=; b=bRBQrAK7i7MCPTi80z74fQiLGn7CczrZj/xtgurwTwSCg+HQ7dNrBzZ3aCmIb2OxCE dp0brd3J1BpHY8SaHUPuo3ZgHb4B//81dVEqYFwHZM9Lom/DI8/7LCnqksv18pzqYTh0 TmARbUZ858AkbjvkYL6GGWicj20vy6Orb6ghOVe70sQF4cKlLAEiDx4R3w4TFQ5tQp8X wDYOXxNSOd0lLr59aeSjelAFGrlAmMSbLfETXSzJYF2hW4dut72WF+XMiluQDxKsvT0x 4MU2LlXCQMsdu5Wmztv0SIJhjNN3+KdAYwILXL4dBB14Z5PawQSkJbHo/0VfCjE8cDBd GQZg== X-Forwarded-Encrypted: i=1; AJvYcCW4AU5b5zApsX4E0My+YmEUhTkT7DZizjscHxV7MPDq0iS3VtVB2PDnbk1lxDF3lOnt6iHp8oTf29jQIiI=@vger.kernel.org X-Gm-Message-State: AOJu0YyQnXnIT9iRD1CotAA+SeLrT2Z+gSqJBZuJ4RqNzRkZpqzGqZf8 Ssv9kR9mpiwCi6xN0rNwo4d+mbEFiKdqMhIcx0jo4+7HquNbGAmFcLNJ7qHm5eWMNFM= X-Gm-Gg: AZuq6aLY4KNM5aC90HWWmNOdAItui3gsyGtjhiDcO3xOiAOCzezzGsFFiodF5ObZRJ7 ogh6zhpb0j8BByIHsBSnjHRdl+KrU/kCzKMGFS1is0UcHMkB0j/bVspLYI4X4mUiGYU56rdhmfw xVPrhtpTg8i7tLxiAvBwW2Mm2Nvun33BrYwUc1wKCPF4xD2tJKuOm/6jSN8SyCSIA9M+WKfBxdG 7AvO/wfN0O6J/idnjSk9oDCqPoEDbkdzEKkTbz+BauJrZIIGer5jAhORa/tAPp20uP650aHWYyG 4drdiTcPpz0JL/PnWXmUMJJHGHXlCH7uvFiJsNkqdG1mrPeOU5JZ9+7JYtN8rgHmKtMyrGQr9ao 9AEOy1upXGkzYcT0bVncu3F2K8CtUhF0Tjes8NPkcdawF57EkJfGjmWSgVzpECdRyZPx9Htio2D kD/k/8IRAMgm6iLNis8J/UxD9UfExmLO4EA2HNZJ0YG/X2ptFQhp5vMdwsC22aeToPzd6QYbSIm BpDc/4jlRed9y1lkysM/EPyv0AiCOw= X-Received: by 2002:a05:6808:1596:b0:459:a26c:2c3c with SMTP id 5614622812f47-45f34b9d012mr3573161b6e.26.1769897949848; Sat, 31 Jan 2026 14:19:09 -0800 (PST) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45f08fb82f5sm6765485b6e.22.2026.01.31.14.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 14:19:09 -0800 (PST) From: Ziyi Guo To: Nas Chung , Jackson Lee Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ziyi Guo Subject: [PATCH] media: chips-media: wave5: add missing spinlock protection for handle_dynamic_resolution_change() Date: Sat, 31 Jan 2026 22:19:07 +0000 Message-Id: <20260131221907.3313423-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" initialize_sequence() calls handle_dynamic_resolution_change() without holding inst->state_spinlock. However, handle_dynamic_resolution_change() has lockdep_assert_held(&inst->state_spinlock) indicating that callers must hold this lock. Other callers of handle_dynamic_resolution_change() properly acquire the spinlock: - wave5_vpu_dec_finish_decode() - wave5_vpu_dec_device_run() Add spin_lock_irqsave()/spin_unlock_irqrestore() around the handle_dynamic_resolution_change() call in initialize_sequence() to fix the missing lock protection. Signed-off-by: Ziyi Guo --- drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c b/dri= vers/media/platform/chips-media/wave5/wave5-vpu-dec.c index e3038c18ca36..73f21f60e7f5 100644 --- a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c @@ -1533,6 +1533,7 @@ static int initialize_sequence(struct vpu_instance *i= nst) { struct dec_initial_info initial_info; int ret =3D 0; + unsigned long flags; =20 memset(&initial_info, 0, sizeof(struct dec_initial_info)); =20 @@ -1554,7 +1555,9 @@ static int initialize_sequence(struct vpu_instance *i= nst) return ret; } =20 + spin_lock_irqsave(&inst->state_spinlock, flags); handle_dynamic_resolution_change(inst); + spin_unlock_irqrestore(&inst->state_spinlock, flags); =20 return 0; } --=20 2.34.1