From nobody Sat Feb 7 13:41:39 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9AA223373D for ; Sat, 31 Jan 2026 15:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769872599; cv=none; b=QFt/2zErzgwRaJLp7c5tlmfmxdFgBFvo04fILd4M8UqHtu6RgG0FJu5mzNG5gayJgie3hLLmQzD2SWvThC8awxN5PlyWDgM2iyc189JaKJ5d8l4016zkJJujIE/4V/Kr8gB8hz5Ibn2gkFHzAuC2jPPnWrYOf5pRUMf824qeoeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769872599; c=relaxed/simple; bh=QklRex04lsv9sydApIJql2WafhSZODxLKXRvx39yn4M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VyZIFtFsFCdNpCDyhjtZyufR8yNlNJwGKdvONpVm9CCp75Dbcd2C1zg96M+qsjT5NMIoqW6XEeB8lm9U6a2rtd2QvoLnxCNbcHS3tjkehRj2uAwyDxPXEoWiSZE4QDqQs+M4XssYVowawdVVmN9R6LehsM73ilQGcXJNVN1dDS4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jkjZIKPs; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jkjZIKPs" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a07fac8aa1so22815385ad.1 for ; Sat, 31 Jan 2026 07:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769872597; x=1770477397; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CGDyJsMy6AHy/TBRAYTPojspsnlgHkAhmaua/x9b1+0=; b=jkjZIKPsyxYLTIYclDIhAPVQ5r4HtnIAX+XzoJ96qu63x2f6f8gF7Fz7lqsFPLPg8m wlQHanlgJ60jMD/7/ZzfH+Q4W63B3MUed/TJz5B/iZAtzREOf/XcOI0zKIh2HezOMK5A omxfVxHqugggSxJSnHk223mVyhxuthcBT13tr5pYpxE8pBedlzdWNBagydhKr9R71uME zD5ZeKjqv25L7l1kb5/LFR7a9RvBSQT9EZDKN+j+xq6GZllTvrM1OO2qZFefC9e4T78V bvMOYbNxstcBSQirHd+N06weK5OScWSCh5ebtidByJh1PP68DH1BhAPNMGvWEtF+c+ML 3qNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769872597; x=1770477397; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CGDyJsMy6AHy/TBRAYTPojspsnlgHkAhmaua/x9b1+0=; b=JSWMc+2zYxSzGARAujZ9WbN0jaAkAdJ8aVwKFEjpwa/a9Mb1un3UWBF07vKwKMXbKS U5pXbuZdtypYgR1Tyls+4F2Nh4v5jspAZrzl2uARD3uGewyFuiiF5B9x8O2ZJRJl9mPc 3qcqT7na4H0gj3PwDEhCOengM2Dp5Q8p1iwIY0YAjVzxyFrhOikBGzJHhtgWa15dX7LS I4kOKm7QthETCrwh50gW5ErLlaCeynqPAI1h6y9pulZXjQiyrjB4UV7muxwcA9OMlCyY LTpVDI3CIbBq9eegwvg1ZoGCfEybjyQCXysxhJwHIFWlw5kSBbYRgVT1lR+uEa/GBL1s sjMw== X-Gm-Message-State: AOJu0YzhwWlqJFXImZfweG7bx38JT0cB8CpzDGUXQecPpl9uyCGW8s1K vYEsd/IST/YDV8DqA/h4/ahqUiLqkiqz4cdOpNOFTxJvCdMTknVZcWbs X-Gm-Gg: AZuq6aLCD+DYSIcsC2CASo7kGL9pxK3BEoPhKDbo5tsGWECWhtBJMVAsqGvovD8orzr KB1OulxJLVPKU+uUcogwRCT6xdPvy9QDZKWYhvBdvxrMEkviZkhbhd7QzkjNUmm1nZIVP+vmP0V JcGEx6tnMenzDv5nBXzJdQIVJheSzCnDCL+ReDvyEyxyLmWSuMjR++6/7fP9jdicvnxiWKCbah8 8lJ9x16mO1a8xhfacINA9kij5qrq8cVM4YvKHuWJI9q/yPITeVsmVPCqsXXYoF4D8waxDNKYLeq eKCa9do1BF4C0483GJLezixnwryWSRp8VEBpoxRhEi7y/Q+mesF7AVC5aZdcEJa1veqPAJ9zgjM lKeqn1spcivLIjGzNPaRkuzPnidZeKeGRU9Gz8mAGtPSQIwGKE/2wHnst4pvPzJSVGCDjJNBnpX pTMsV/sw82m7LeHkh9/HHxUX0Hog== X-Received: by 2002:a17:903:38c8:b0:295:5da6:6011 with SMTP id d9443c01a7336-2a8d7eb595emr68327685ad.11.1769872597120; Sat, 31 Jan 2026 07:16:37 -0800 (PST) Received: from gmail.com ([2402:e280:3e9b:22f:1ecb:768f:dd7b:8c69]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b6e4110sm97826815ad.84.2026.01.31.07.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 07:16:36 -0800 (PST) From: Sumeet Pawnikar To: rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH] drivers: thermal: intel: tcc_cooling: remove unused variable Date: Sat, 31 Jan 2026 20:46:15 +0530 Message-ID: <20260131151615.6230-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the unused variable 'ret' in tcc_cooling_init() and simplify the error handling path. The variable 'ret' was declared but only used to store the return value of PTR_ERR(tcc_cdev) before immediately returning it, which is redundant. Remove the duplicate variable declaration where both 'ret' and 'err' were declared, but only 'err' was actually needed. Also, simplify the error path by directly returning PTR_ERR(tcc_cdev) instead of storing it in an intermediate variable. Signed-off-by: Sumeet Pawnikar --- drivers/thermal/intel/intel_tcc_cooling.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/intel/intel_tcc_cooling.c b/drivers/thermal/in= tel/intel_tcc_cooling.c index f352ecafbedf..a5b31b25225e 100644 --- a/drivers/thermal/intel/intel_tcc_cooling.c +++ b/drivers/thermal/intel/intel_tcc_cooling.c @@ -72,12 +72,10 @@ MODULE_DEVICE_TABLE(x86cpu, tcc_ids); =20 static int __init tcc_cooling_init(void) { - int ret; + int err; u64 val; const struct x86_cpu_id *id; =20 - int err; - id =3D x86_match_cpu(tcc_ids); if (!id) return -ENODEV; @@ -103,10 +101,9 @@ static int __init tcc_cooling_init(void) tcc_cdev =3D thermal_cooling_device_register("TCC Offset", NULL, &tcc_cooling_ops); - if (IS_ERR(tcc_cdev)) { - ret =3D PTR_ERR(tcc_cdev); - return ret; - } + if (IS_ERR(tcc_cdev)) + return PTR_ERR(tcc_cdev); + return 0; } =20 --=20 2.43.0