From nobody Sat Feb 7 17:48:38 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 958E81F2B88 for ; Sat, 31 Jan 2026 12:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769861399; cv=none; b=EgjnrK3IAum0CWQOpo/bohkbGVsGAo6d2z9VZmT0obdhAzNKB04XEAqYLKvFehJzSqLgduzIANBbb3aUEbeld/xYnoHMpL6G2CqfKIPROSDVYF2v0V1XHYuPXeMOpRaVjH3sJPgZMfdJaac0ONyuPzEJUCg0xOcuDFYCfnHKA4c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769861399; c=relaxed/simple; bh=rMzAW8Tvi16sTxs5PK+vFKJOoqG4dS0PAuHS+VYTYV8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MrgxfKaSeeKkFg5Q7kF9e1d0UJh82HEBmADFgS6IJHjFKVhr/aPAqDrQrxxqwMKbJP4E+eAIVS5hj3w2gMYeNQbOcSoHRuTqijnQgk8qAzAbMMnA9racrIwNBiJG6YvHW8y7O0xVpr96zfme3stskHISr4dDfxSrIPJXmaWKCw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LmfbvN05; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LmfbvN05" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42fed090e5fso2380730f8f.1 for ; Sat, 31 Jan 2026 04:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769861397; x=1770466197; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nzVXjnGSiTdhf8KobmZDXpopEOGZjc9s6VBPnFoRjnY=; b=LmfbvN05VaE2qWnodeHB1As9wh41Y9NQXjN3qUCBDHdrABDiNTe5EYWit8nehkSi32 ZGmWJ8lR6Tuof8ivA5IN8OX8eiGvZdRpHzltRs3alwIHxMrf5zPRVAcGTPofOsHUfFSI b3y7kG6CmCRixU+9GD4J0l4C0hTeKx2E2OX8W/OifUXm3leyDMRTLxi21KPVRi+n3Ej4 1lZnVvM7Qfb0uf0z7sH66uBpTT2MEl7uQqm02P1rvanIScMBd2LaYNui7LvIpIX5p66H 3/izLx+8kdQpjZB17KP6LTtCatfo7b6HgH/5DRGYfaw6GJnXxv+M47+Dn3aQy02kQqnl NlaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769861397; x=1770466197; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nzVXjnGSiTdhf8KobmZDXpopEOGZjc9s6VBPnFoRjnY=; b=ehAcxZZ2Md/8oKcpT/+WdvsvjXmqXZ4u7GPrd6TDIFvKg6PxUP15yvA83XFufXm7or UEb28gQaRtcrdG8KC0+KzfT8JyYgE3LMx9moydBw1WmHAlAwBnC1DkdxeZpz2TcUMVsD R1+IZkwGh1Ly+cq2PGKt9HlBfANTcYaiMlkobI3gQwgIyMLeDOJKSTjRYo8/nUBDR8yN CKoW7bhWhpEKo1ytvDuHg05pdaRZKkUG0TFtDrvja+tvw3LHuxSKXXTMJISCqU5ZCUq8 SCjMxuY7O1P6RZTJ6umnfIUtYkriMLLV7zJGYbxZsKPhiTDdOgLNimPn/PlmmWX7QwyS NPaA== X-Gm-Message-State: AOJu0YzG9EAa9D9YRRjxFAwCEdNv21fSdf6cS7joBSAC1OTgA8EvQOlS zNzfEO4XSoMpgYRi8Met36ONVSTYJa0zBH25STYHuuQ20QGpR04thrbt X-Gm-Gg: AZuq6aJb8ThPb66GOAWvnkCmlABZUiJkrmJhPdxqUHw13tm6+GynIQa4BEoSyX6AXgi NUOEVppk5d9UDxokekd7CammfrNkEX0YTVutx3Iy693hZXTvpQvtc2deOusxwvX/2b9XqDlGyJ/ 2YhrINQOsLH8c3JSJS0c6DvjufKXm5cXDRzT7p27b2oQUElWoqGkF08uLs3+8kZxpuQGeWVQj97 jbHF+1oVT91dJhASNDtItdIae7gij0mEyLJj6jBM9b6oVpnsdOy8hrg8XvoWnb+EiDnMhWVfVdM uQihdfluMC7nRymCz8hEsZOdCYGFK9lbvELe0wDhY4otxY8jvuxzCgV7JpsubOKqVwE3FfNxACt tVA34PsWfhv6dAheuWS/MFu8ZE6/GGAxY4urEmbPoipTizUAt+zZo38Qg0dbUHDRBfIG15sbGIS BowZZytGQHNW8YERpQh4+hTOuiRg== X-Received: by 2002:a05:6000:2881:b0:435:94c1:3713 with SMTP id ffacd0b85a97d-435f3aaff90mr8247498f8f.37.1769861396802; Sat, 31 Jan 2026 04:09:56 -0800 (PST) Received: from localhost.localdomain ([196.235.54.191]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e131ce93sm28329539f8f.24.2026.01.31.04.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 04:09:56 -0800 (PST) From: Salah Triki To: Peter Rosin Cc: linux-kernel@vger.kernel.org, Salah Triki Subject: [PATCH] mux: core: fix reference count leak in mux_chip_register() Date: Sat, 31 Jan 2026 13:09:48 +0100 Message-ID: <20260131120948.254947-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Once `mux_chip_alloc()` is called, the underlying `struct device` is initialized via `device_initialize()`, and its reference count is set to 1. Any error path occurring after this point must call `put_device()` to ensure proper cleanup of the device and its associated resources. Currently, if `mux_control_set()` fails or if `device_add()` fails, the function returns an error code directly. This leaves the `mux_chip` structure and its internal device's memory leaking, as the release callback is never triggered. Fix this by ensuring that `put_device()` is called on all error paths within `mux_chip_register()`. Fixes: a3b02a9c6591c ("mux: minimal mux subsystem") Signed-off-by: Salah Triki --- drivers/mux/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mux/core.c b/drivers/mux/core.c index a3840fe0995f..2ffb175bbbf6 100644 --- a/drivers/mux/core.c +++ b/drivers/mux/core.c @@ -173,14 +173,19 @@ int mux_chip_register(struct mux_chip *mux_chip) ret =3D mux_control_set(mux, mux->idle_state); if (ret < 0) { dev_err(&mux_chip->dev, "unable to set idle state\n"); - return ret; + goto err_put_device; } } =20 ret =3D device_add(&mux_chip->dev); - if (ret < 0) + if (ret < 0) { dev_err(&mux_chip->dev, "device_add failed in %s: %d\n", __func__, ret); + goto err_put_device; + } + +err_put_device: + put_device(&mux_chip->dev); return ret; } EXPORT_SYMBOL_GPL(mux_chip_register); --=20 2.43.0