From nobody Sat Feb 7 18:55:35 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3FC72EA73D for ; Sat, 31 Jan 2026 09:47:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769852877; cv=none; b=C705eEupCq/0NHY8LXcUuvWJSYTl9I/PSUJIjvNcfDIW0YKIEJTw2YodKzTUk1RkmdNuZMmHMU4lTuDOwzlalM77C2+iPfEmuLmEI2LWvOR6/4qGk5519OmLTuVLTi0hIv/HIpCx7YB9kZHoMb3WJQqVrj4b67tvrLAY1XE6Fbo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769852877; c=relaxed/simple; bh=pUay4F0GP4gxgWcbFJdTI+7qYKrQwO+dB5mfgkhaPzk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oiEvmSxitOepAbhbQLE4jUFyjZ/BfDyCjLf4x0092z0E/dHL2iGnHo7ntojWgyramv6WpPsTv+wv1GjGFqLU51bLg91EMLBxTV6MguBDmr9lScWWEduNxjbOLVXcMTPI8crEDWE1eR8SGB+T74z62s1R5JHWA/okK9rjfF7hTUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LXZ/BUF6; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LXZ/BUF6" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48068127f00so24403475e9.3 for ; Sat, 31 Jan 2026 01:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769852874; x=1770457674; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=41b2lp5MCGmdPrwLlPmtni1+lYC20ahMKNi6z3QB48U=; b=LXZ/BUF6//bbvCW1/QM1gCHbCJJLCoatFomvOZddbR2nal+4EJFYGAFEQksa2VoMZQ tqdTjyI/onpx3koE5LybsTKEigF78tA5UweZbw7I6S268ErkD2KlRCXKJbGC37MurHnV w6pSXKOm/92gnLYoKX8BWknEGiNaeJKf3k64lCUKnf7vvc9jgiInPDlmlzJ5z2ZqWDyb eW5mA2pgAGGXuiqdcviZACPAwQqQoSq6nwDXuk7GN/Kvr4Oeh+5O/KBE7PnCyk5xqO6x f8gntC3lRf1mKAahGPs4ZxtsGmZoVQ6mQ292EIfXR3KC+isLbIsPJILliDZAokZ0+m+I 6lBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769852874; x=1770457674; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=41b2lp5MCGmdPrwLlPmtni1+lYC20ahMKNi6z3QB48U=; b=ryln5xvO77/iSmeO0h7tgHGZKHws/Si/P/cDWIfzR0CYoWnSo2QEuaaolSKQ8he4dF /yqTpS/GDIM8fL9bg0F9yREnbk6ywSA27LWh2xYTET8RiSmwZebJN05ksIMAicYrsTzm o8Rs4jnMQM8lsr3NusWCnotlVKuDno38qtJps0zunM1lGi7OSUdlI3t+WrcFbgW77920 8Uqt7KjXu08ow6gH9MSBdVqtPbffAV3NIr2bKJia172Pq6dM0IwGqDqSAafszyJ/8vOq FwBlK0NX7GJmFwGmCqzbVUb1kNl6r2two0o0TsEYoioFXSUsg5PH/2q3sdPS20pdOkLd DxKg== X-Gm-Message-State: AOJu0YwO9v0AsD/nSIrJlFDr07bW9iHTdK4VdAfDsJKPvKW6FvXivmGT 9nhXzYb48yBiBnFNwCP1QCRf/Ae0xyYwRlcaVGs5k14N7zR+2lxpFBBw X-Gm-Gg: AZuq6aJbDukkDu3LMlQbtrLEAfk9qX0VASwf8YMpjw+/n/rmd84cLtTFNgrr+3WJyK5 sw1Fo3kE1kKH1BD4Os/ezqj0FsIJ8DinhfuSGrrn9TX1mr3qtpLFMSO9qqYLnf4os2uIK1xQL9z x+ZYbq+l4S+TOT89Utxtswn8f4+13COL4iRRiRn3iAtLF5fTEsdsK3O0BRhuTwP2OUVjeHk+a7b AherasgaWmHXllvuOJTrP8ud9kzvfXfnQFkQhAzLNT0/l7PtLlJT3hcat3V5JnZuSQ0uIMJKLDw zBX4hUzJIHWPPGnHEu3tiKdiEFxvwasJp0FHSXbUKSuci15x0yEJUG9p7OYku/PhFbj1mr5t6f4 5TleiG/iw+Sc5RoR43VdbVzyk8HT1SZ+B38PSWg/tnxKwtcndSVzA3SZPF/RzMzMVZL6qVaPFSE 84BZw0Q4cAN5Cgr9NGFv7E26406A== X-Received: by 2002:a05:600c:6814:b0:480:699c:abe9 with SMTP id 5b1f17b1804b1-482db4b21c6mr58825185e9.37.1769852874156; Sat, 31 Jan 2026 01:47:54 -0800 (PST) Received: from localhost.localdomain ([196.235.54.191]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cde00e8sm255836935e9.6.2026.01.31.01.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 01:47:53 -0800 (PST) From: Salah Triki To: =?UTF-8?q?Marek=20Beh=C3=BAn?= Cc: linux-kernel@vger.kernel.org, Salah Triki Subject: [PATCH] bus: moxtet: fix reference count leak in moxtet_add_device() Date: Sat, 31 Jan 2026 10:47:48 +0100 Message-ID: <20260131094748.249160-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If `device_add()` fails, the reference count of the device is not dropped. This leads to a memory leak of the device and its associated resources. `put_device()` must be called if `device_add()` fails to properly clean up the device structure. Fixes: 5bc7f990cd98f ("bus: Add support for Moxtet bus") Signed-off-by: Salah Triki Acked-by: Marek Beh=C3=BAn --- drivers/bus/moxtet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c index 7ce61d629a87..35795deba2a9 100644 --- a/drivers/bus/moxtet.c +++ b/drivers/bus/moxtet.c @@ -179,9 +179,11 @@ static int moxtet_add_device(struct moxtet_device *dev) goto done; =20 ret =3D device_add(&dev->dev); - if (ret < 0) + if (ret < 0) { dev_err(dev->moxtet->dev, "can't add %s, status %d\n", dev_name(dev->moxtet->dev), ret); + put_device(&dev->dev); + } =20 done: mutex_unlock(&add_mutex); --=20 2.43.0