From nobody Mon Feb 9 05:14:10 2026 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 505E6221F20; Sat, 31 Jan 2026 05:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769838773; cv=none; b=kqCpQteBc+zI/CDxQZIz+YVoXQYlcHo4Krtt8DExjPHwFIzpBrI2OjmhSQOVh4BLcJs1Fai9TETPsAt7kd6/nwshD1riZ4JhwQ+O0oGIuqrqnyYAZu92oAnnA4oX8OByfBJGAqn38t3jCGsFx50hiA6qFUlegjvoG0MDUY9TOC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769838773; c=relaxed/simple; bh=PmbAJYJkov8V5YggkGt6mnyWmVPIBHeFOH5at+c+duk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BrXbp0GX1mZNMXyd9Sg7PSC8fJBMRD9M7oWPVRB248VNbsvqJLmFr5BIt4XZ2b1lvBVhLiEHEU3kghRiHXjtbl1XTkAWYlgajb4deJA/wAk/GxcRKSkyeqhzYi9eT30N8D0M16Fj4EiYisZr3W3ak+aPAdsxAsE5fPn4exGetR4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.223]) by APP-05 (Coremail) with SMTP id zQCowAAXpgmSmH1pKjcfBw--.29939S2; Sat, 31 Jan 2026 13:52:19 +0800 (CST) From: Haoxiang Li To: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, daniel@iogearbox.net, magnus.karlsson@intel.com, bjorn@kernel.org Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Haoxiang Li , stable@vger.kernel.org Subject: [PATCH v2] i40e: add an error handling path in i40e_xsk_pool_enable() Date: Sat, 31 Jan 2026 13:52:17 +0800 Message-Id: <20260131055217.729048-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAAXpgmSmH1pKjcfBw--.29939S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KF4xJF4DJF43uF13Aw1UZFb_yoW8Gw17pr 4j9a95Cr1rXFW5Wa9rJF4j9an8Ja1ftry0gF4fGanY9r15ta17JF1xtFWFgFy8ZrW8Janx KF1DArs8CFn8J3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9014x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4j6r 4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x kEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCw CI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1x MIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIda VFxhVjvjDU0xZFpf9x0JUd-B_UUUUU= X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiCRAEE2l9cjNJQwAAsR Content-Type: text/plain; charset="utf-8" In i40e_xsk_pool_enable(), add an error handling path to prevent potential memory leaks. Fixes: 1742b3d52869 ("xsk: i40e: ice: ixgbe: mlx5: Pass buffer pool to driv= er instead of umem") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li --- Changes in v2: - Add a Fixes tag. Thanks, Paul! - Replace unmap with i40e_xsk_pool_disable() to prevent a limbo state of queues. Thanks, Maciej!=20 --- drivers/net/ethernet/intel/i40e/i40e_xsk.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ether= net/intel/i40e/i40e_xsk.c index 9f47388eaba5..a72a309540c3 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c @@ -108,23 +108,26 @@ static int i40e_xsk_pool_enable(struct i40e_vsi *vsi, if (if_running) { err =3D i40e_queue_pair_disable(vsi, qid); if (err) - return err; + goto err_out; =20 err =3D i40e_realloc_rx_xdp_bi(vsi->rx_rings[qid], true); if (err) - return err; + goto err_out; =20 err =3D i40e_queue_pair_enable(vsi, qid); if (err) - return err; + goto err_out; =20 /* Kick start the NAPI context so that receiving will start */ err =3D i40e_xsk_wakeup(vsi->netdev, qid, XDP_WAKEUP_RX); if (err) - return err; + goto err_out; } =20 return 0; + +err_out: + i40e_xsk_pool_disable(vsi, qid); } =20 /** --=20 2.25.1