From nobody Mon Feb 9 05:10:30 2026 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 682C51D5160 for ; Sat, 31 Jan 2026 03:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769831536; cv=none; b=QPu53r00Y5UoUo1D/f+gJjbWn4/dnJP0m3tcgk3iSB3JOd2gH2AdrhoU8n39kk3V3MPcmJ4Ugyqz91oB7U/g5xlajYkYx9iNHlmu/CACoySWgOrfWn/8ioeDRJcQhuo+hiN0Lm4pAO76fjQd/CLQTOxFTCbeWgr9Je01mOpt1Qo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769831536; c=relaxed/simple; bh=GuQRayMdtq0K4ZAP4rpnMcjmlMbRz1yFN4dBUoBskrI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=S37Efua5YmCSUCMFSc2LGppCE8aelc8e/7PiiuSsSSoDO+Zysv+WgAwdQiwz51tOVwxo0PWykvWQ5lzT/DY2NhUZg4aVqeTn+bmgfnwndDaFT+hvoORFUdeJ2RqKgu/tnp5bWEcAoK29bIC7CYBa/6Y0ycIbdO6JtBaLD1D2E4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu; spf=pass smtp.mailfrom=u.northwestern.edu; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b=g/JnKIQQ; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b="g/JnKIQQ" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7d18d02af68so1772288a34.2 for ; Fri, 30 Jan 2026 19:52:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u-northwestern-edu.20230601.gappssmtp.com; s=20230601; t=1769831533; x=1770436333; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=a+tuxKzfIwGph4KGmy/W4D3saam1yAaOrHAbmg45lyE=; b=g/JnKIQQOukUFU79+0k2rBNNRCaoHdkURyi3lS5n0WDnawOpb8NYiY66Dp4J/m4fqN 3Hm3I1tmFgsbyOA65hLTqeM4CFb41rTyJ3ZaqfnBGgkwtFrTQqAYP2QP38o0Y8sHStw3 cpjGTNb0ErT6yuZXWgT91HVZdh41KYz4+enKEQIuE/GNdnNuF5qEYpHBCC1DaFAnuERG fUQnJkv5cs+7D9HWiUXHg5UZOcm9JJo5RsSJcKcOBCjHCkpQ69dT8/t+Pi2ewkARnR+z /hftBtNnUs2z/0djVxjz26j3SJXTtmw8GWvAhUxzINDVocSio+5/Us5S7rODaJr4XIZB eKpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769831533; x=1770436333; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a+tuxKzfIwGph4KGmy/W4D3saam1yAaOrHAbmg45lyE=; b=uYujpo/zmeyTMbgdrAmwZ2Up4fe5qbtl9L6FqOr0pXJiOIoW8QUiKXnLVyVcAOYWVR oCsQJxLKpYVR1RIWVYWuSIEi5C4NeuL9sIh4nQCJo4z55HOpLCI+CAlXaiMx+8NO0If6 YaYfrtOKjat0d9SS5wUOR1IGZRmjv7Cqqnf/O3xmVz8Uqv3RyX1s674LZC0OEw7PRrxx KcHEvZoeyUFd4MYBO9I84YVFG0tGsBQHygTCmpgOvkH7ty/eV8XLzRJkt1BbAYFdwL/L byXzXVGKvNRqajgNwhn/uM+Kxe7djdsk2cZT27C09waUhfuM5UwJEfH+aU2K4YKBdnug lIXQ== X-Forwarded-Encrypted: i=1; AJvYcCX+4JlpTPJEK4RaXzfrALRd309D2n5KwviF3mNPBaqKj1JcFpa5snQd1t5YA1x4U/1DBhOGLCJ0503om6I=@vger.kernel.org X-Gm-Message-State: AOJu0YynP0amRfF/4w1kVtk08vIoOyeBtxHN48P0Nuts8QCdVwjZ1jUA UcekraXp3iM2Kf/SfLp8k8kfUzTyCjxol+DCq1SdGCbVMJytZ2vyPg4Jx2zp191JwK4= X-Gm-Gg: AZuq6aLFdhbIvwMZyJiEZYKyKojDij4+ZKXzaAJWIaA8xNDFFJhYs7oNqPfSTzqUhZh pMzywjVnyg8q706T2ePy1V4ZcbrEiqxNgvdQAqWBcLT5KIA+JhhMKHRSuKfeXfsTX83F+FZ0XSU efarmyPhLwfc76F92B/LQuKfppKIeXgXWOS1Eg/H8q6KVL0zrl1AN39P2G3+b6rUSXed/M0sBwT rTo6tgGjDY9/rNZ8u6Kb8nRvBXHHlk5KLeDGLbVpestHG5iqyyUNEVM85qGmExM4WNu8MDTjY8l CChGmnJIXiHTeP/MWyCvnM0KdiMNT+0Wjxnu3Aa9k1SDb/nyezlw4Bo6PNevK1Fx8JW/+92QNod RWnRihgmbEnj3Z3Et9hBH4QrBcD306rZyCwjUA4lkBoKNegno0TeT8obN8D+n5seSeGFSywEEg8 yGmFYwFz/F9YvoT3Xo0h0KWSC5feRDk9dTjtkO40awHQp4Rvta11D7pemZH+U/4g9IOmQ5+1AnL 9LVE+/4r51MP5FNt3qaNgehxbSG2vo= X-Received: by 2002:a05:6830:6738:b0:7cf:d96d:7882 with SMTP id 46e09a7af769-7d1a5250f74mr3189657a34.3.1769831533374; Fri, 30 Jan 2026 19:52:13 -0800 (PST) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d18c69ac16sm6727975a34.7.2026.01.30.19.52.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 19:52:12 -0800 (PST) From: Ziyi Guo To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Ziyi Guo Subject: [PATCH v2] wifi: mt76: add missing lock protection in mt76_sta_state for sta_event callback Date: Sat, 31 Jan 2026 03:52:10 +0000 Message-Id: <20260131035210.2198259-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mt76_sta_state() calls the sta_event callback without holding dev->mutex. However, mt7915_mac_sta_event() (MT7915 implementation of this callback) calls mt7915_mac_twt_teardown_flow() which has lockdep_assert_held(&dev->mt76.mutex) indicating that callers must hold this lock. The locking pattern in mt76_sta_state() is inconsistent: - mt76_sta_add() acquires dev->mutex before calling dev->drv->sta_add - mt76_sta_remove() acquires dev->mutex before calling __mt76_sta_remove - But sta_event callback is called without acquiring the lock Add mutex_lock()/mutex_unlock() around the mt7915_mac_twt_teardown_flow invocation to fix the missing lock protection and maintain consistency with the existing locking pattern. Signed-off-by: Ziyi Guo --- v2: - Move the locking to MT7915 driver to avoid deadlock in other drivers drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net= /wireless/mediatek/mt76/mt7915/main.c index 90d5e79fbf74..e212e964fda0 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c @@ -851,8 +851,10 @@ int mt7915_mac_sta_event(struct mt76_dev *mdev, struct= ieee80211_vif *vif, return mt7915_mcu_add_sta(dev, vif, sta, CONN_STATE_PORT_SECURE, false); =20 case MT76_STA_EVENT_DISASSOC: + mutex_lock(&dev->mt76.mutex); for (i =3D 0; i < ARRAY_SIZE(msta->twt.flow); i++) mt7915_mac_twt_teardown_flow(dev, msta, i); + mutex_unlock(&dev->mt76.mutex); =20 mt7915_mcu_add_sta(dev, vif, sta, CONN_STATE_DISCONNECT, false); msta->wcid.sta_disabled =3D 1; --=20 2.34.1