From nobody Sat Feb 7 15:22:05 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BC922FDC4D for ; Sat, 31 Jan 2026 03:23:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769829821; cv=none; b=EvcwQmGwr8BC37a8zhOEL0n6yRfL7d9CY23eqCrekrgjPCHk8NgBFwXHOyd/WY4kPqti7kNT+nqBq5D8FtkVR/y4Zl3ZNZ9QOxoR5Ii02Zs18G0sKBmpvBF0hiNaczpA4Qw6VCLbN+CYKx5eudumS7s7WaPzERVqozdmmr77G0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769829821; c=relaxed/simple; bh=f7buuNNvFtDmukyogGbs+jVUhY6SUOSxrOaRIzwfSc0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=J1rG1/J95J8YZ+N5WpUwVJp1hMYrmvIMmzqfPnsDVuYOWwqW1T9yCz4VZxOqt4IiK1CLDuLwo2SH3LDvAqUUaurcd1dNHf/NOhGR5DKTeis5ov3UqsXvBr8OyyzkHFUDo/vnzpO34i+bfNc/SsJRqDgcHcIKIDlMCE0IKbIFOa4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VWiniAzy; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VWiniAzy" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-29f30233d8aso17785355ad.0 for ; Fri, 30 Jan 2026 19:23:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769829820; x=1770434620; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Fb5TlTnvI6KGifi3UIljVd7X8aloyriFgviWVutVtk8=; b=VWiniAzyWLS6YGGeLM9Prrx7kEJ1j6+Yr0/opIZBhZAOye358YD0zRARNF6Tt67xAO T4H0u8qZc8bhDxVNVBt0esUSJN+SQvq06Cwls+mPpE/PweHOc004IKFuWSAAeZFhcWAX KKz1jlcwTgQPxmPQokbL4ltjXlmglrII4C81OiAu6H3TPLMnrj5VnCaEAT6Os+W3oh5v u/ooxcZ2/79LBwWdwUxCFsKIT8Mh7Be4ab5kIO455055Lg3fngkVuh08ccNPvUPMlpsi pZ+j6Q4BxEvCi+VPxAJnYBlsyl667GxK53Y8K4AHYSgIQr1XMbixQttWq6eIsVusNCsx vWGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769829820; x=1770434620; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Fb5TlTnvI6KGifi3UIljVd7X8aloyriFgviWVutVtk8=; b=MoK4ecHqg/m38VbdWc//1mPEVV3IqGXfDCrutcGx8wE6g7IkL1KJO7LU1mIyGDQtPr 5FNQuRq+gllr5jdnx/1OgG9TfAiDP9Y1Vy5LygGI9ui4J3Oo7LCTBPppggcTqHecDMWQ HDMo8tCi/lrsa7KTv/GWDA0+BWmaMhBMy7s4k6z8qebuZUjkyaH58vo0BI7uIJTCEhAm HdNPPuE29PrTp2l9LhXyeR2GarmiV996WabZ2XOHe2M2BIl3rPwsDOdDXdeMoEB1YANK viydnXJxo0bA1Wkr85dDrTvdXEtNduY0jxVERTBWf3Z9nzOqBwPOgB2k4HvsdCzoqDDq MWeQ== X-Forwarded-Encrypted: i=1; AJvYcCX2/Ri+7GAg/Nm8fU3CVcPYWELVFyvQrK9WNswpQV9zVt6u0mLQ0vBBWWxwrON44RR/zSTobdb1ZCRKYGI=@vger.kernel.org X-Gm-Message-State: AOJu0YyLOBW5qPhm0xlpU4I20c9cfhz2mCuE1+bMraqALNSGjHcGa8fC ByTyQ9gV/XKOzBcLTfXWRViYP6F4awHt6ybq5bTij2OX+uF12bGvFY4aBBDYDQ== X-Gm-Gg: AZuq6aIlaKNmWkxlKJlrZ/mqYxgz8wnAZZ2wXgTp6U/NI3sNVrYo/xEGLWA5LrQeZig J4zeF5aO7ghGTM1Wo8SVEoPm28zgyjfQdDmekDbqebwWVj3kyC+ODwKZ5sH3uHVVJ9LBBBXHnJs f+oNmGaiTYLX66pr4XX0g/QUsRSLARiOcr9LKw6ykzSseA5YK/MRwBabU1JfVtG12YN95s9F79v 9zZQCfp5D5UvGJQ7SIL84uzLselQV7UrQixeyxo8VH5QJr3xPGwlvYPaf1Va0zwOm11GOcwLDXK GkgUxD0u5osyV68xccvm4JhMBDm64kAsWPc4uWRlsi5R9UnCAbL4TYQLdJK6VR2D3TLijlYwzlJ 2fyXYuA3ZWLeQgo6wU1INnUZiUKfMUgIa7zvMNMn848ZSFMllp5Gt5rtC05In6aDwD7QhmIu7kt S2Jw+GqJNac2Ps5cui1YIlapY06X4OJxAUkaL/doHKVno= X-Received: by 2002:a17:903:b48:b0:2a8:7814:47d0 with SMTP id d9443c01a7336-2a8d7ed6d32mr47355535ad.22.1769829819595; Fri, 30 Jan 2026 19:23:39 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:5a43:d240:8ceb:9a37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b4c4665sm87609455ad.64.2026.01.30.19.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 19:23:39 -0800 (PST) From: Chintan Patel To: neil.armstrong@linaro.org Cc: dianders@chromium.org, jesszhan0024@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chintan Patel Subject: [PATCH] drm/panel: jdi-lt070me05000: Use MIPI DSI multi functions Date: Fri, 30 Jan 2026 19:23:21 -0800 Message-ID: <20260131032321.6332-1-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert to the non-deprecated mipi_dsi_*_multi() helpers per the TODO list. These reduce boilerplate error checking while providing proper error accumulation via mipi_dsi_multi_context. Also use mipi_dsi_msleep()/mipi_dsi_usleep_range() macros for all delays, which automatically skip on error. Suggested-by: Doug Anderson Signed-off-by: Chintan Patel --- .../gpu/drm/panel/panel-jdi-lt070me05000.c | 105 ++++-------------- 1 file changed, 23 insertions(+), 82 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/d= rm/panel/panel-jdi-lt070me05000.c index 3513e5c4dd8c..50272364d9d4 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -48,34 +48,16 @@ static inline struct jdi_panel *to_jdi_panel(struct drm= _panel *panel) static int jdi_panel_init(struct jdi_panel *jdi) { struct mipi_dsi_device *dsi =3D jdi->dsi; - struct device *dev =3D &jdi->dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_soft_reset(dsi); - if (ret < 0) - return ret; - - usleep_range(10000, 20000); - - ret =3D mipi_dsi_dcs_set_pixel_format(dsi, MIPI_DCS_PIXEL_FMT_24BIT << 4); - if (ret < 0) { - dev_err(dev, "failed to set pixel format: %d\n", ret); - return ret; - } - - ret =3D mipi_dsi_dcs_set_column_address(dsi, 0, jdi->mode->hdisplay - 1); - if (ret < 0) { - dev_err(dev, "failed to set column address: %d\n", ret); - return ret; - } + mipi_dsi_dcs_soft_reset_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 10000, 20000); =20 - ret =3D mipi_dsi_dcs_set_page_address(dsi, 0, jdi->mode->vdisplay - 1); - if (ret < 0) { - dev_err(dev, "failed to set page address: %d\n", ret); - return ret; - } + mipi_dsi_dcs_set_pixel_format_multi(&dsi_ctx, MIPI_DCS_PIXEL_FMT_24BIT <<= 4); + mipi_dsi_dcs_set_column_address_multi(&dsi_ctx, 0, jdi->mode->hdisplay - = 1); + mipi_dsi_dcs_set_page_address_multi(&dsi_ctx, 0, jdi->mode->vdisplay - 1); =20 /* * BIT(5) BCTRL =3D 1 Backlight Control Block On, Brightness registers @@ -83,90 +65,49 @@ static int jdi_panel_init(struct jdi_panel *jdi) * BIT(3) BL =3D 1 Backlight Control On * BIT(2) DD =3D 0 Display Dimming is Off */ - ret =3D mipi_dsi_dcs_write(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, - (u8[]){ 0x24 }, 1); - if (ret < 0) { - dev_err(dev, "failed to write control display: %d\n", ret); - return ret; - } + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 24); =20 /* CABC off */ - ret =3D mipi_dsi_dcs_write(dsi, MIPI_DCS_WRITE_POWER_SAVE, - (u8[]){ 0x00 }, 1); - if (ret < 0) { - dev_err(dev, "failed to set cabc off: %d\n", ret); - return ret; - } + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 - ret =3D mipi_dsi_dcs_exit_sleep_mode(dsi); - if (ret < 0) { - dev_err(dev, "failed to set exit sleep mode: %d\n", ret); - return ret; - } - - msleep(120); - - ret =3D mipi_dsi_generic_write(dsi, (u8[]){0xB0, 0x00}, 2); - if (ret < 0) { - dev_err(dev, "failed to set mcap: %d\n", ret); - return ret; - } + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + mipi_dsi_msleep(&dsi_ctx, 120); =20 - mdelay(10); + mipi_dsi_generic_write_multi(&dsi_ctx, (u8[]){0xB0, 0x00}, 2); + mipi_dsi_msleep(&dsi_ctx, 10); =20 /* Interface setting, video mode */ - ret =3D mipi_dsi_generic_write(dsi, (u8[]) - {0xB3, 0x26, 0x08, 0x00, 0x20, 0x00}, 6); - if (ret < 0) { - dev_err(dev, "failed to set display interface setting: %d\n" - , ret); - return ret; - } + mipi_dsi_generic_write_multi(&dsi_ctx, (u8[]){0xB3, 0x26, 0x08, 0x00, 0x2= 0, 0x00}, 6); + mipi_dsi_msleep(&dsi_ctx, 20); =20 - mdelay(20); + mipi_dsi_generic_write_multi(&dsi_ctx, (u8[]){0xB0, 0x03}, 2); =20 - ret =3D mipi_dsi_generic_write(dsi, (u8[]){0xB0, 0x03}, 2); - if (ret < 0) { - dev_err(dev, "failed to set default values for mcap: %d\n" - , ret); - return ret; - } - - return 0; + return dsi_ctx.accum_err; } =20 static int jdi_panel_on(struct jdi_panel *jdi) { struct mipi_dsi_device *dsi =3D jdi->dsi; - struct device *dev =3D &jdi->dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_set_display_on(dsi); - if (ret < 0) - dev_err(dev, "failed to set display on: %d\n", ret); + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 - return ret; + return dsi_ctx.accum_err; } =20 static void jdi_panel_off(struct jdi_panel *jdi) { struct mipi_dsi_device *dsi =3D jdi->dsi; - struct device *dev =3D &jdi->dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_set_display_off(dsi); - if (ret < 0) - dev_err(dev, "failed to set display off: %d\n", ret); - - ret =3D mipi_dsi_dcs_enter_sleep_mode(dsi); - if (ret < 0) - dev_err(dev, "failed to enter sleep mode: %d\n", ret); + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 - msleep(100); + mipi_dsi_msleep(&dsi_ctx, 100); } =20 static int jdi_panel_disable(struct drm_panel *panel) --=20 2.43.0