From nobody Mon Feb 9 03:31:28 2026 Received: from azure-sdnproxy.icoremail.net (azure-sdnproxy.icoremail.net [13.75.44.102]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3553423A566; Sat, 31 Jan 2026 02:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.75.44.102 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769827685; cv=none; b=FNoYpFOxCPdbAWQouQE631+qEJ2YdSCehs0PCVzpYZ7jZE84afPOliRS8qz68TzYf9dn8UZxOwV42+HQ3TKNJPEwhzfdEbPy29iNrtsPNSfuZZ4zSDekuJzRS/746KbIUUcAoPGya/1HsbRmdBZT3rLfaGAkkQLZu4JWqA5Q8uQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769827685; c=relaxed/simple; bh=0/3v3UVkmH93Y3LuHKtr1ma8J5XqzK6fkm8rB8S2OwI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=kR3Hn3+76jsHqmVzLjb5bgdJ56UwIZk0xmSyjBmklQ3FEZ4kzwp1XXjRIwredISm14RpYl1UGZSyGgoTjiQzf9/thbWDrLkX6zpl7G4CB0OujRAKj3IXm6iuDUvTcpP87rNcA8054RSXfjZ0egkRVY/ioYJNnBwLK/Wpl8fQBk4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn; spf=fail smtp.mailfrom=zju.edu.cn; arc=none smtp.client-ip=13.75.44.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=zju.edu.cn Received: from zju.edu.cn (unknown [218.12.16.80]) by mtasvr (Coremail) with SMTP id _____wDn73NKbX1p7mRjAA--.1562S3; Sat, 31 Jan 2026 10:47:39 +0800 (CST) Received: from ubuntu.localdomain (unknown [218.12.16.80]) by mail-app2 (Coremail) with SMTP id zC_KCgAHH0NFbX1pJeyZBQ--.46417S2; Sat, 31 Jan 2026 10:47:37 +0800 (CST) From: Duoming Zhou To: linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, kuba@kernel.org, rex.lu@mediatek.com, Duoming Zhou Subject: [PATCH] wifi: mt76: mt7996: fix use-after-free bugs in mt7996_mac_dump_work() Date: Sat, 31 Jan 2026 10:47:31 +0800 Message-Id: <20260131024731.18741-1-duoming@zju.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zC_KCgAHH0NFbX1pJeyZBQ--.46417S2 X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAwcHAWl9CYYARQAis+ X-CM-DELIVERINFO: =?B?nx7eAAXKKxbFmtjJiESix3B1w3uoVhYI+vyen2ZzBEkOnu5chDpkB+ZdGnv/zQ0PbP CR17BdU0YDZAV/2Ln4UAAcl16DGRBFtdZlxZ1QrbH4wGfx32Jfz4aN3dUbt+We9+91Yi8K fgiSaWccdsHHI9sjkRU1Sfihgbwg4TzFg1kDojip5H+f+rmxSWW3Qj0hUa1qOA== X-Coremail-Antispam: 1Uk129KBj93XoW7Zr1xKr15CFykKF15KFWkZrc_yoW8Ww43p3 yrCa4j934UurZrJw4DAF4IvF1UG3Z3Kw4UGrZ5W3s0q3s3GF9ayw4DAFyDuF1jkFs2yFWY yr4jq3s8WFyYvFXCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9Eb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AK xVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0Y48IcxkI7V AKI48G6xCjnVAKz4kxM4IIrI8v6xkF7I0E8cxan2IY04v7MxAIw28IcxkI7VAKI48JMxC2 0s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI 0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE 14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20x vaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8 JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU801v3UUUUU== Content-Type: text/plain; charset="utf-8" When the mt7996 pci chip is detaching, the mt7996_crash_data is released in mt7996_coredump_unregister(). However, the work item dump_work may still be running or pending, leading to UAF bugs when the already freed crash_data is dereferenced again in mt7996_mac_dump_work(). The race condition can occur as follows: CPU 0 (removal path) | CPU 1 (workqueue) mt7996_pci_remove() | mt7996_sys_recovery_set() mt7996_unregister_device() | mt7996_reset() mt7996_coredump_unregister() | queue_work() vfree(dev->coredump.crash_data) | mt7996_mac_dump_work() | crash_data-> // UAF Fix this by ensuring dump_work is properly canceled before the crash_data is deallocated. Add cancel_work_sync() in mt7996_unregister_device() to synchronize with any pending or executing dump work. Fixes: 878161d5d4a4 ("wifi: mt76: mt7996: enable coredump support") Signed-off-by: Duoming Zhou --- drivers/net/wireless/mediatek/mt76/mt7996/init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/init.c b/drivers/net= /wireless/mediatek/mt76/mt7996/init.c index 00a8286bd13..0ccaa5dce19 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/init.c @@ -1726,6 +1726,7 @@ int mt7996_register_device(struct mt7996_dev *dev) =20 void mt7996_unregister_device(struct mt7996_dev *dev) { + cancel_work_sync(&dev->dump_work); cancel_work_sync(&dev->wed_rro.work); mt7996_unregister_phy(mt7996_phy3(dev)); mt7996_unregister_phy(mt7996_phy2(dev)); --=20 2.34.1