From nobody Mon Feb 9 09:10:18 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EF743195EA for ; Sat, 31 Jan 2026 02:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769825964; cv=none; b=ADFriEp6yg8q1Oo32zhpaqU4vU+gm125V3SzUr+9SMECatun9fOBekou86zXxhJjsfKfSvcRaNBbcC4Pj2L8zzUIVHArJGwDn6mK8UR9dspEv8RbRL5+/qzhKbD3bJbpbWJg6pfWT2kcKvUZflQqFuLOm6YCnJGfAQhV7+1snZc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769825964; c=relaxed/simple; bh=JNfZjVJy3Gbq22U1MyVQxdU67pv8yfXpNgGIJG63XRo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l8T97eG9OqLujU0JWJCCxMAHI7dR66d/p3TVxtI9+Jt09IZ95flLP4AWC1v3KolXbv7YHLrJoMAB2GIDNFAXdjqaNVWKlzRz9G4uFuH0aPH7jMaOBXyfbEc7MLM1vva2CSRL/G0T42Kz9kEZc8uY2hC+/dbye5kD60M0DtS3zhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m6aWqjbP; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m6aWqjbP" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a12ed4d205so16087835ad.0 for ; Fri, 30 Jan 2026 18:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769825963; x=1770430763; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7pMp86pItBZRraa325LpN+qOAaq2YtbzQhkPFaWHWDc=; b=m6aWqjbPVASqzq2K4e0eO7hOPVUs7bwA5S37T7VXJ5gHJp3FvCaGqC4DJ3Q2KMTPWD kuw3Ixqu7WmcQC9/8b+aQv8jEB+pqSTBOJeb83WHYxx6rLfLHkwIuhdcIM9SjUju2gCP EvxOAuK/G7V6tYf2lgMbjl7vdHbPROgtt10udZqjqyhUvr9/jj8o2zaWHJNlN0f69vmi 31g7hCQiHlVky63lbghf8hANiEN5ypL2QC++hiYK6srXiSwvico5DiECkcLYHr9C3JBA ha3Ii2iaglgV+zjWoPsMnp5gvf7rv+zwiwu8uyGYnJdAVd7/r5pmgVk7KGzXyMDJ1E1I IlSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769825963; x=1770430763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7pMp86pItBZRraa325LpN+qOAaq2YtbzQhkPFaWHWDc=; b=HWLPzgQB1trBMxxF+R2xzxeOs7nyz2eSaBrzXWTd+1GodpYjeB12dUm24uV/bDiibo 1xwGYXVRZc8D3/EYdR9u5EDQUvPt9/osmWxEK6VwXeX6Ea9orG0P30HCRTHwksIbDlqj nnGBjAHjRrFUlWrxeMJzYXc/ljszNjTGWCctoflHTXnFzqlWR85gwJA5tTDcmBiJlCmw k4Cb+GU4YywJZwaNqVQt159ZE1wOJIRWRJ7w8w2xdITMsWzymKgo94O0fOasJOnITkaI Pn6D2TMNOp8JPi6lCQoXRAgAICuaawVhUOQj2MnbFLFJjFaVRuQbmcXcvs3sJhHUmc5I 3q4w== X-Forwarded-Encrypted: i=1; AJvYcCWK11B26Y5zvBRJkpMFO+pXTTWAq0QSpOXFdJwlWZsD5oJuitFqZTqKO91uy2MHg0A44Q4hH5wDJ+dIcaU=@vger.kernel.org X-Gm-Message-State: AOJu0YyC/5qHpDzws04mEMEZNRyAkRc3Sg3Ngkm2tD/lxQzvEjxx3K9I +W4EysO/rCH0TqjhuyjCUQ06+DRp2qEtv+A7OMk+ZgLJO9A8jPPWJeaG X-Gm-Gg: AZuq6aI7Sq5y5adZdxw8HF2Emn9ru1OSt+68MWs333Sn8i9VDUDXv68UUelWKJF0P2y lNV1UMsEHHkmWWPf6WmDVNiHtThmRVj7am2fyFAUMpCzXJIDMWFy199LmJMpon1ELeogcwO/qpX zLUJ91tXaN/USzudk4GGfsit9gayvb7NT8U9FjNgILzsWCIExlrBU+zb7ZllUw+X/q3QGgrZ46G znU5AihAe4FdGT45HYfJcZeu8AhsZVoEL1EUFtRSN/zdsxDomXTI1O1njafSTvUp03/AxvfVQ0S 9/sHetJJT8tNLTK4+1SGHZKdh41Eq/spzrabvbhn/6CCseZIHEi8N8Z7T58SHWQKPqJQZtDY5sK PsX98HbgiDp1D4EcdzlJhoL9OYAtbyu2fZNmlPWcoaLoe6GbU3JZ496oXnYQ/D0L75Yq17aWnk5 hU/NvpDI9OmH3+3vANG2ZG9NpisCfZaN3XIOY= X-Received: by 2002:a17:903:38c8:b0:2a7:b039:4b52 with SMTP id d9443c01a7336-2a8d9591c81mr45042115ad.1.1769825962631; Fri, 30 Jan 2026 18:19:22 -0800 (PST) Received: from d.home.mmyangfl.tk ([2a09:bac1:7680:d30::4:384]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b3eeebcsm83427365ad.10.2026.01.30.18.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 18:19:22 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Russell King , linux-kernel@vger.kernel.org Subject: [PATCH net-next v6 4/5] net: dsa: yt921x: Refactor yt921x_chip_setup() Date: Sat, 31 Jan 2026 10:18:50 +0800 Message-ID: <20260131021854.3405036-5-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260131021854.3405036-1-mmyangfl@gmail.com> References: <20260131021854.3405036-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" yt921x_chip_setup() is already pretty long, and is going to become longer. Split it into parts. Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 35 ++++++++++++++++++++++++----------- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index c2998b6ae535..3128fe97b50f 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -2903,7 +2903,7 @@ static int yt921x_chip_reset(struct yt921x_priv *priv) return 0; } =20 -static int yt921x_chip_setup(struct yt921x_priv *priv) +static int yt921x_chip_setup_dsa(struct yt921x_priv *priv) { struct dsa_switch *ds =3D &priv->ds; unsigned long cpu_ports_mask; @@ -2921,16 +2921,6 @@ static int yt921x_chip_setup(struct yt921x_priv *pri= v) if (res) return res; =20 - /* Enable and clear MIB */ - res =3D yt921x_reg_set_bits(priv, YT921X_FUNC, YT921X_FUNC_MIB); - if (res) - return res; - - ctrl =3D YT921X_MIB_CTRL_CLEAN | YT921X_MIB_CTRL_ALL_PORT; - res =3D yt921x_reg_write(priv, YT921X_MIB_CTRL, ctrl); - if (res) - return res; - /* Setup software switch */ ctrl =3D YT921X_CPU_COPY_TO_EXT_CPU; res =3D yt921x_reg_write(priv, YT921X_CPU_COPY, ctrl); @@ -2983,6 +2973,29 @@ static int yt921x_chip_setup(struct yt921x_priv *pri= v) if (res) return res; =20 + return 0; +} + +static int yt921x_chip_setup(struct yt921x_priv *priv) +{ + u32 ctrl; + int res; + + ctrl =3D YT921X_FUNC_MIB; + res =3D yt921x_reg_set_bits(priv, YT921X_FUNC, ctrl); + if (res) + return res; + + res =3D yt921x_chip_setup_dsa(priv); + if (res) + return res; + + /* Clear MIB */ + ctrl =3D YT921X_MIB_CTRL_CLEAN | YT921X_MIB_CTRL_ALL_PORT; + res =3D yt921x_reg_write(priv, YT921X_MIB_CTRL, ctrl); + if (res) + return res; + /* Miscellaneous */ res =3D yt921x_reg_set_bits(priv, YT921X_SENSOR, YT921X_SENSOR_TEMP); if (res) --=20 2.51.0