From nobody Sat Feb 7 13:41:30 2026 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C35ED279DAD for ; Sat, 31 Jan 2026 02:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769824833; cv=none; b=pDp1weqKlEeWQHEzcOPq8aqA+Tk9tAckrjNvfZue4p5FVOQw0Dsw0tIQSDkAZPNJXtz5oR1VSqoAwYk/Jl4GJmGmWk5X95CVnMiIV1fBR3o+rBuxiKjtpxU0qz12R4t3Qf2G+lG0s/8cTibQCoGr+GBGoHAlqq0ExutwLdI2qzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769824833; c=relaxed/simple; bh=h4DuCJtsa6oFVhcQbMmmqY+3LH39t82n+QVj7zkHUm0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KyVKHhl7gK6nK7Ag2vMrLw1JkZziV6lI8Yxg4xxN2rOG5W4Dq9FKOuyLJXvCEsiniSxK1Y9x+IYoiJDzAyRaG5j+kWoAU63ghFSagX4awxUweOS9A2fF/g0Yn3jPk6rV3FG/QfPRBjk/VDsGVu9tFwWt3nxltV/d6fzJPQNRivk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CuUg0Eo2; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CuUg0Eo2" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-1233b953bebso3828157c88.1 for ; Fri, 30 Jan 2026 18:00:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769824831; x=1770429631; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dNSviLengAEJ8WT3Zmebz4rAVGoLIbhrdruQZP8hmfs=; b=CuUg0Eo2/WNY1akg0M8WWSBnT1rSoDiu3iUhTVxfr2shr8WbOfArPj+yR14y/+FFD+ IdeS2hlPQef0jqQngzgfGJ2FH387KLSuFEsrdhkUeS85uHg2PfShlfTwKj1ufmPR5rQW SyEZUBNcBMfiEMPuKclrNDwjE0yaCkwsDE3/W44jGdgNm40InLoKg/wurOmIHzK6gsyn CfpbvhIXZQAr2Mb64rOtxi/WKoHUNTQYCYNLUP/6nHICNM1Ai70ikjUo6r48nwC/sL8J rUafZMLJuGTI1Xlr75FY9UvJ4vP54tQgyiMao5KANuISKwfN1OxWYuyWZAf87FwyEP+N mOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769824831; x=1770429631; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dNSviLengAEJ8WT3Zmebz4rAVGoLIbhrdruQZP8hmfs=; b=ClLmSbmvQg6vPg/9hiqqvpAuZaDkjr4/lLS7SNkGRggF5TOdBJJ/eqmgIevejyJRAg Vryt3LH8d8lSAK8KvqX8CAWG/l/OshAjes+M+TDZtax4vZBpxQj78PWi/qSA9qcA/psk gLv/iCQR81Tux4GzDZYTcjmxmuTW2IQeYklxGG2xaMySjW5f9+2DLpLwYmxdO6MoB7Z7 DKFWKI/ubVh/buoxa4kwvh5D1HpThFPl7o0xQNXJSiti1hc+9rtMSQ9b80/ZuCqB0m8v Ld6kpn+LhycnJ1old3RYOzBabBrCxthpxSdiB2Rv9H6rIHsjbIVIjXlqpFZiQowayfjI Sw6Q== X-Gm-Message-State: AOJu0Yxe61d63fdaef2gQFcmSuKZYHkl2Szy1s1sC5HcU7lxbIjJFBAB ZJNGKZVNUKPOPhXRQwLOdPVYAczm3RoB+seg0bVpS/qld8kcnS8Dbwf/quGWR56F X-Gm-Gg: AZuq6aIxNs75FChPhQzI4/NfuJNIR1Os5R6KQGAq3R++XCrcSMrfITi7QPtxyUQDmST 8Q0OOxROgwPwSlHylUg1348h4wYfVRfarIqd4we9vqQa/C0wEJwJCX47t+Lq+Th6/dNDWeHgkyn wn0i8W7hkVL3r1NtgkHzYgb6yQ/eTQ5PaSL7Dt3wzF2w7UHktRRLkqg266lHbPxs61r30JuLvjO z77qdVfumMfJqYBg5NgeGT7+lz0ZfGEgTh66RTb+rUKKGr0fI+X1AqMlvpDig11t99ZYwOfqNfM nNsk38Ut1sEKZ4BRDL/TBwvisYiyjIa3OUxRHqFJHcBo6dK2mQ5e+k6LfRtnSdg0Pg0kDTXFB4f L9ptjn9hDa2QIuTUyLFQSzCM5mM9t69Yy+OIuPdN1kyMNjA3YdEv3TTQrUfhENcWvzpzPxLjm88 LAW4EzzvvyaqbB6GSmrZ/AxceArKZVHU/1mRYBbKG1tv2csarxArzqoooaZ2zrhkdIoBANK8LL9 4GHrijoPrDyC4Lara7MFIbPZnbB1t1jzqQMzJQgIwVX/HGmLXZbvTvf8VIrDjsy4R1vzktwULW8 s+/7JsY4ueGFmgw= X-Received: by 2002:a05:7022:6981:b0:119:e56b:c73e with SMTP id a92af1059eb24-125c0f8b219mr2895119c88.3.1769824830744; Fri, 30 Jan 2026 18:00:30 -0800 (PST) Received: from ethan-latitude5420.. (host-127-24.cafrjco.fresno.ca.us.clients.pavlovmedia.net. [68.180.127.24]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9cdcbcfsm14668041c88.0.2026.01.30.18.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 18:00:30 -0800 (PST) From: Ethan Nelson-Moore To: linux-kernel@vger.kernel.org Cc: Ethan Nelson-Moore , David Airlie , Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH] char: remove unnecessary module_init/exit functions Date: Fri, 30 Jan 2026 18:00:26 -0800 Message-ID: <20260131020027.45775-1-enelsonmoore@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Two char drivers have unnecessary module_init and module_exit functions that are empty or just print a message. Remove them. Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded. Signed-off-by: Ethan Nelson-Moore --- drivers/char/agp/backend.c | 16 ---------------- drivers/char/nsc_gpio.c | 14 -------------- 2 files changed, 30 deletions(-) diff --git a/drivers/char/agp/backend.c b/drivers/char/agp/backend.c index 1776afd3ee07..5f0d9fc6455c 100644 --- a/drivers/char/agp/backend.c +++ b/drivers/char/agp/backend.c @@ -323,18 +323,6 @@ int agp_try_unsupported_boot; EXPORT_SYMBOL(agp_off); EXPORT_SYMBOL(agp_try_unsupported_boot); =20 -static int __init agp_init(void) -{ - if (!agp_off) - printk(KERN_INFO "Linux agpgart interface v%d.%d\n", - AGPGART_VERSION_MAJOR, AGPGART_VERSION_MINOR); - return 0; -} - -static void __exit agp_exit(void) -{ -} - #ifndef MODULE static __init int agp_setup(char *s) { @@ -351,7 +339,3 @@ MODULE_AUTHOR("Dave Jones, Jeff Hartmann"); MODULE_DESCRIPTION("AGP GART driver"); MODULE_LICENSE("GPL and additional rights"); MODULE_ALIAS_MISCDEV(AGPGART_MINOR); - -module_init(agp_init); -module_exit(agp_exit); - diff --git a/drivers/char/nsc_gpio.c b/drivers/char/nsc_gpio.c index da930c72bc74..2c9b12b85435 100644 --- a/drivers/char/nsc_gpio.c +++ b/drivers/char/nsc_gpio.c @@ -121,20 +121,6 @@ EXPORT_SYMBOL(nsc_gpio_write); EXPORT_SYMBOL(nsc_gpio_read); EXPORT_SYMBOL(nsc_gpio_dump); =20 -static int __init nsc_gpio_init(void) -{ - printk(KERN_DEBUG NAME " initializing\n"); - return 0; -} - -static void __exit nsc_gpio_cleanup(void) -{ - printk(KERN_DEBUG NAME " cleanup\n"); -} - -module_init(nsc_gpio_init); -module_exit(nsc_gpio_cleanup); - MODULE_AUTHOR("Jim Cromie "); MODULE_DESCRIPTION("NatSemi GPIO Common Methods"); MODULE_LICENSE("GPL"); --=20 2.43.0