From nobody Sat Feb 7 15:12:24 2026 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F102241CB7 for ; Sat, 31 Jan 2026 03:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769830256; cv=none; b=Je1WiYQ4TEnCRW4Ah97YOwQb08gK2xwYwXRd1U4eQExIcZhsk5sVBIXeNC1ZJaQGhZNgW/8gNZ3Xk8lGi8WzfKVlqEucFM3FPBIRccNwRkZfzDk/Ic1LNkcqSXkqxHw8cud2FPXL2KEJ1RXad8VSstyvL0ekdgNYYKIg1ilKnHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769830256; c=relaxed/simple; bh=rx9l325aZl6zmg7t27UFxcPIbu3nEcgR2jjyufFuqp8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Al9ttbz2Svi9Ld8qHgOvcE1/qtBbYZbiHQpwICehnVoov6X4SMfF7kx6vUQsjeNM708z8QbGV9LAif0+7JKusUxBID/UuX7UTHZZnrpSkxPGWpeCC0NFwDdGfwp+l09je9ltLB3X9sBZj+F2s7jXmkzz2KP1WiZi/FiyqaZ3po0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YHxeN4q7; arc=none smtp.client-ip=209.85.210.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YHxeN4q7" Received: by mail-ot1-f67.google.com with SMTP id 46e09a7af769-7d196a2334fso2422401a34.1 for ; Fri, 30 Jan 2026 19:30:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769830254; x=1770435054; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wZcgzHgaenh6qdTT7Q42CASdPe/pPQEefUgknkYmJKs=; b=YHxeN4q7n1HR/FyIbQH5A3svPnMUBwFo4WSz1vDsnmoiXpOMFe6TmDjj6tdyY0OgEw NXKhVJRSA7pnCmaQfONgP9xye6XqMjKv8srqDItLd53Djrk5qogh97v0xCZDMxHcGOum b2UnV5qBSgeAEqJzR/KDXrOlz36NboP53oB3rMplqhV2b0062Dm5kn8ozuktkN+vXz7H KiKBAsndfKlLnXErW6qrxdxa1YnCCbuzk+UvBd6PphA1JXA8j3WEV8RZpLjCLjUkvkLO X5Ln0NESm4U6IYbh2abw1mdSIrXNyW3tty++r2ZCuBcj+7UuWku89XQosM+uX8iszXDh 7zxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769830254; x=1770435054; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wZcgzHgaenh6qdTT7Q42CASdPe/pPQEefUgknkYmJKs=; b=G4yNONLDGCd9xw9D+1RNtsT2AtTmvMCW8REdZDwCP3pTDHRNva0HNod3RQdXUdCmJ9 1lw7+ZW1jTe74VrtVnnX3kdhVzFVCsTxc/dj6LvfFWg1+JwUgD/ExmD5HbuAiS/SHH5+ OWypDOcQIztRYfVfXwkU6ve5nGFW5Os2QLvFrt0ZvAVC35Blo+gUnNHPXty5qtTlQIkF mO4ekI1x5yt02wt5fq5aPO+vffkg7yxpxAA46oZGSK+qVqU3fjE3IWQFthkP8NBl6wnA PT2SkhHVktz+UYchK9hqkooYjN+7LjUeEcwKaSyDK4dkdOxPsPGWS3daWtnRNKiOxJGU Kp9Q== X-Gm-Message-State: AOJu0YwtatBgOTKxVASFxTg/VRUO7825vnbI3iGjEZrh4bXIkwaihqw7 zQzu3W69l+DxyUG972mlnZPReIsVA1mkew9XvnQfsHqbTi6KVEEkVi/6PUpgbZbB X-Gm-Gg: AZuq6aJKTO8GIx8zRAElDlcYfze3/znpIH7lSO3dD0Vn98kiGM3Q5ZPlxSup/UIJ1DD SXnVODkECaUzibwioU3+A0rF9EcDJlxitkl+Dl4vXPPHZU3hC5wWrqGhwIys8lGmtVVjU4BPKjh TcngRI4B9wkM1wDGB74yEiI+HAm6NJ8Fq1ERF4FhZEKqwpciCDLRoRv8u8jYnmFxk33JsfqEOfV wlsGVO8oaOWJmTUFffxwmrJOUjYDn97wxPkfduRZ44tBRSJJzdHbZq5qWfXnhWc0TQQAU2PRN7+ ADiAvPJ9U5xvik5M1eu/GiURHqCJkvmytRUczoZ9xMlEMVm+fqjJuuYLIqx4QJJrijKtxWYtZY6 7VlaIYee6dptBRnTVCuDp0pungwYuSpi6cHzOacctZnRtS1LgGs3RDaGAMPXLWjeB5f82+YBpFj kxvdRQ8RUpM56501hjlL11BHjHDgcMBp5sDBcv4o172V8Qa/RoHHdAkl4BtWUCVR3w3LPxVZjFm ZhSXM5vGu41bEmrFbb9dAvLtjiS78qbpDrc+5a3KaGmocFJaSZwGryEIQX5K6Ff7PfYBMzaZYh0 Qbc2 X-Received: by 2002:a05:7301:9bc9:b0:2af:f2c2:3bdb with SMTP id 5a478bee46e88-2b7b178ad50mr4560582eec.2.1769823508489; Fri, 30 Jan 2026 17:38:28 -0800 (PST) Received: from ethan-latitude5420.. (host-127-24.cafrjco.fresno.ca.us.clients.pavlovmedia.net. [68.180.127.24]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7a16eab72sm13169035eec.8.2026.01.30.17.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 17:38:28 -0800 (PST) From: Ethan Nelson-Moore To: linux-kernel@vger.kernel.org Cc: Ethan Nelson-Moore , Ian Abbott , H Hartley Sweeten , Greg Kroah-Hartman Subject: [PATCH] comedi: remove unnecessary module_init/exit functions Date: Fri, 30 Jan 2026 17:36:52 -0800 Message-ID: <20260131013810.32265-1-enelsonmoore@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Many Comedi drivers have unnecessary empty module_init and module_exit functions. Remove them. Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded. Signed-off-by: Ethan Nelson-Moore Reviewed-by: Ian Abbott --- drivers/comedi/comedi_pci.c | 11 ----------- drivers/comedi/comedi_pcmcia.c | 11 ----------- drivers/comedi/comedi_usb.c | 11 ----------- drivers/comedi/drivers/addi_watchdog.c | 11 ----------- drivers/comedi/drivers/amplc_dio200_common.c | 11 ----------- drivers/comedi/drivers/amplc_pc236_common.c | 11 ----------- drivers/comedi/drivers/comedi_8254.c | 11 ----------- drivers/comedi/drivers/comedi_8255.c | 11 ----------- drivers/comedi/drivers/comedi_isadma.c | 11 ----------- drivers/comedi/drivers/das08.c | 11 ----------- drivers/comedi/drivers/mite.c | 11 ----------- drivers/comedi/drivers/ni_labpc_common.c | 11 ----------- drivers/comedi/drivers/ni_labpc_isadma.c | 11 ----------- drivers/comedi/drivers/ni_tio.c | 11 ----------- drivers/comedi/drivers/ni_tiocmd.c | 11 ----------- drivers/comedi/kcomedilib/kcomedilib_main.c | 12 ------------ 16 files changed, 177 deletions(-) diff --git a/drivers/comedi/comedi_pci.c b/drivers/comedi/comedi_pci.c index cc2581902195..da618f5e3a4d 100644 --- a/drivers/comedi/comedi_pci.c +++ b/drivers/comedi/comedi_pci.c @@ -211,17 +211,6 @@ void comedi_pci_driver_unregister(struct comedi_driver= *comedi_driver, } EXPORT_SYMBOL_GPL(comedi_pci_driver_unregister); =20 -static int __init comedi_pci_init(void) -{ - return 0; -} -module_init(comedi_pci_init); - -static void __exit comedi_pci_exit(void) -{ -} -module_exit(comedi_pci_exit); - MODULE_AUTHOR("https://www.comedi.org"); MODULE_DESCRIPTION("Comedi PCI interface module"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/comedi_pcmcia.c b/drivers/comedi/comedi_pcmcia.c index c53aad0fc2ce..17962bf66892 100644 --- a/drivers/comedi/comedi_pcmcia.c +++ b/drivers/comedi/comedi_pcmcia.c @@ -192,17 +192,6 @@ void comedi_pcmcia_driver_unregister(struct comedi_dri= ver *comedi_driver, } EXPORT_SYMBOL_GPL(comedi_pcmcia_driver_unregister); =20 -static int __init comedi_pcmcia_init(void) -{ - return 0; -} -module_init(comedi_pcmcia_init); - -static void __exit comedi_pcmcia_exit(void) -{ -} -module_exit(comedi_pcmcia_exit); - MODULE_AUTHOR("https://www.comedi.org"); MODULE_DESCRIPTION("Comedi PCMCIA interface module"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/comedi_usb.c b/drivers/comedi/comedi_usb.c index d11ea148ebf8..75d65171c76d 100644 --- a/drivers/comedi/comedi_usb.c +++ b/drivers/comedi/comedi_usb.c @@ -134,17 +134,6 @@ void comedi_usb_driver_unregister(struct comedi_driver= *comedi_driver, } EXPORT_SYMBOL_GPL(comedi_usb_driver_unregister); =20 -static int __init comedi_usb_init(void) -{ - return 0; -} -module_init(comedi_usb_init); - -static void __exit comedi_usb_exit(void) -{ -} -module_exit(comedi_usb_exit); - MODULE_AUTHOR("https://www.comedi.org"); MODULE_DESCRIPTION("Comedi USB interface module"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/addi_watchdog.c b/drivers/comedi/driver= s/addi_watchdog.c index ed87ab432020..b778c88d4c11 100644 --- a/drivers/comedi/drivers/addi_watchdog.c +++ b/drivers/comedi/drivers/addi_watchdog.c @@ -124,17 +124,6 @@ int addi_watchdog_init(struct comedi_subdevice *s, uns= igned long iobase) } EXPORT_SYMBOL_GPL(addi_watchdog_init); =20 -static int __init addi_watchdog_module_init(void) -{ - return 0; -} -module_init(addi_watchdog_module_init); - -static void __exit addi_watchdog_module_exit(void) -{ -} -module_exit(addi_watchdog_module_exit); - MODULE_DESCRIPTION("ADDI-DATA Watchdog subdevice"); MODULE_AUTHOR("H Hartley Sweeten "); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/amplc_dio200_common.c b/drivers/comedi/= drivers/amplc_dio200_common.c index b1a9b4c4a185..d61f51900976 100644 --- a/drivers/comedi/drivers/amplc_dio200_common.c +++ b/drivers/comedi/drivers/amplc_dio200_common.c @@ -901,17 +901,6 @@ int amplc_dio200_common_attach(struct comedi_device *d= ev, unsigned int irq, } EXPORT_SYMBOL_GPL(amplc_dio200_common_attach); =20 -static int __init amplc_dio200_common_init(void) -{ - return 0; -} -module_init(amplc_dio200_common_init); - -static void __exit amplc_dio200_common_exit(void) -{ -} -module_exit(amplc_dio200_common_exit); - MODULE_AUTHOR("Comedi https://www.comedi.org"); MODULE_DESCRIPTION("Comedi helper for amplc_dio200 and amplc_dio200_pci"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/amplc_pc236_common.c b/drivers/comedi/d= rivers/amplc_pc236_common.c index 326ca72c24ec..c3692f50bdb9 100644 --- a/drivers/comedi/drivers/amplc_pc236_common.c +++ b/drivers/comedi/drivers/amplc_pc236_common.c @@ -176,17 +176,6 @@ int amplc_pc236_common_attach(struct comedi_device *de= v, unsigned long iobase, } EXPORT_SYMBOL_GPL(amplc_pc236_common_attach); =20 -static int __init amplc_pc236_common_init(void) -{ - return 0; -} -module_init(amplc_pc236_common_init); - -static void __exit amplc_pc236_common_exit(void) -{ -} -module_exit(amplc_pc236_common_exit); - MODULE_AUTHOR("Comedi https://www.comedi.org"); MODULE_DESCRIPTION("Comedi helper for amplc_pc236 and amplc_pci236"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/comedi_8254.c b/drivers/comedi/drivers/= comedi_8254.c index 6beca2a6d66e..1140d1060e86 100644 --- a/drivers/comedi/drivers/comedi_8254.c +++ b/drivers/comedi/drivers/comedi_8254.c @@ -724,17 +724,6 @@ struct comedi_8254 *comedi_8254_mm_alloc(void __iomem = *mmio, } EXPORT_SYMBOL_GPL(comedi_8254_mm_alloc); =20 -static int __init comedi_8254_module_init(void) -{ - return 0; -} -module_init(comedi_8254_module_init); - -static void __exit comedi_8254_module_exit(void) -{ -} -module_exit(comedi_8254_module_exit); - MODULE_AUTHOR("H Hartley Sweeten "); MODULE_DESCRIPTION("Comedi: Generic 8254 timer/counter support"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/comedi_8255.c b/drivers/comedi/drivers/= comedi_8255.c index a933ef53845a..fd6b1cf621a7 100644 --- a/drivers/comedi/drivers/comedi_8255.c +++ b/drivers/comedi/drivers/comedi_8255.c @@ -259,17 +259,6 @@ unsigned long subdev_8255_regbase(struct comedi_subdev= ice *s) } EXPORT_SYMBOL_GPL(subdev_8255_regbase); =20 -static int __init comedi_8255_module_init(void) -{ - return 0; -} -module_init(comedi_8255_module_init); - -static void __exit comedi_8255_module_exit(void) -{ -} -module_exit(comedi_8255_module_exit); - MODULE_AUTHOR("Comedi https://www.comedi.org"); MODULE_DESCRIPTION("Comedi: Generic 8255 digital I/O support"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/comedi_isadma.c b/drivers/comedi/driver= s/comedi_isadma.c index 020b3d1e1ac0..6a490d2d1068 100644 --- a/drivers/comedi/drivers/comedi_isadma.c +++ b/drivers/comedi/drivers/comedi_isadma.c @@ -249,17 +249,6 @@ void comedi_isadma_free(struct comedi_isadma *dma) } EXPORT_SYMBOL_GPL(comedi_isadma_free); =20 -static int __init comedi_isadma_init(void) -{ - return 0; -} -module_init(comedi_isadma_init); - -static void __exit comedi_isadma_exit(void) -{ -} -module_exit(comedi_isadma_exit); - MODULE_AUTHOR("H Hartley Sweeten "); MODULE_DESCRIPTION("Comedi ISA DMA support"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/das08.c b/drivers/comedi/drivers/das08.c index 49944ce1f813..a3298a3238e7 100644 --- a/drivers/comedi/drivers/das08.c +++ b/drivers/comedi/drivers/das08.c @@ -453,17 +453,6 @@ int das08_common_attach(struct comedi_device *dev, uns= igned long iobase) } EXPORT_SYMBOL_GPL(das08_common_attach); =20 -static int __init das08_init(void) -{ - return 0; -} -module_init(das08_init); - -static void __exit das08_exit(void) -{ -} -module_exit(das08_exit); - MODULE_AUTHOR("Comedi https://www.comedi.org"); MODULE_DESCRIPTION("Comedi common DAS08 support module"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/mite.c b/drivers/comedi/drivers/mite.c index 88f3cd6f54f1..45c3df18e777 100644 --- a/drivers/comedi/drivers/mite.c +++ b/drivers/comedi/drivers/mite.c @@ -921,17 +921,6 @@ void mite_detach(struct mite *mite) } EXPORT_SYMBOL_GPL(mite_detach); =20 -static int __init mite_module_init(void) -{ - return 0; -} -module_init(mite_module_init); - -static void __exit mite_module_exit(void) -{ -} -module_exit(mite_module_exit); - MODULE_AUTHOR("Comedi https://www.comedi.org"); MODULE_DESCRIPTION("Comedi helper for NI Mite PCI interface chip"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/ni_labpc_common.c b/drivers/comedi/driv= ers/ni_labpc_common.c index 7e0ce0ce0adf..21b838a9d9ec 100644 --- a/drivers/comedi/drivers/ni_labpc_common.c +++ b/drivers/comedi/drivers/ni_labpc_common.c @@ -1357,17 +1357,6 @@ void labpc_common_detach(struct comedi_device *dev) } EXPORT_SYMBOL_GPL(labpc_common_detach); =20 -static int __init labpc_common_init(void) -{ - return 0; -} -module_init(labpc_common_init); - -static void __exit labpc_common_exit(void) -{ -} -module_exit(labpc_common_exit); - MODULE_AUTHOR("Comedi https://www.comedi.org"); MODULE_DESCRIPTION("Comedi helper for ni_labpc, ni_labpc_pci, ni_labpc_cs"= ); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/ni_labpc_isadma.c b/drivers/comedi/driv= ers/ni_labpc_isadma.c index 0652ca8345b6..125797f655f2 100644 --- a/drivers/comedi/drivers/ni_labpc_isadma.c +++ b/drivers/comedi/drivers/ni_labpc_isadma.c @@ -164,17 +164,6 @@ void labpc_free_dma_chan(struct comedi_device *dev) } EXPORT_SYMBOL_GPL(labpc_free_dma_chan); =20 -static int __init ni_labpc_isadma_init_module(void) -{ - return 0; -} -module_init(ni_labpc_isadma_init_module); - -static void __exit ni_labpc_isadma_cleanup_module(void) -{ -} -module_exit(ni_labpc_isadma_cleanup_module); - MODULE_AUTHOR("Comedi https://www.comedi.org"); MODULE_DESCRIPTION("Comedi NI Lab-PC ISA DMA support"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/ni_tio.c b/drivers/comedi/drivers/ni_ti= o.c index da6826d77e60..763264c745da 100644 --- a/drivers/comedi/drivers/ni_tio.c +++ b/drivers/comedi/drivers/ni_tio.c @@ -1826,17 +1826,6 @@ void ni_gpct_device_destroy(struct ni_gpct_device *c= ounter_dev) } EXPORT_SYMBOL_GPL(ni_gpct_device_destroy); =20 -static int __init ni_tio_init_module(void) -{ - return 0; -} -module_init(ni_tio_init_module); - -static void __exit ni_tio_cleanup_module(void) -{ -} -module_exit(ni_tio_cleanup_module); - MODULE_AUTHOR("Comedi "); MODULE_DESCRIPTION("Comedi support for NI general-purpose counters"); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/drivers/ni_tiocmd.c b/drivers/comedi/drivers/ni= _tiocmd.c index ab6d9e8269f3..9c166703626b 100644 --- a/drivers/comedi/drivers/ni_tiocmd.c +++ b/drivers/comedi/drivers/ni_tiocmd.c @@ -494,17 +494,6 @@ void ni_tio_set_mite_channel(struct ni_gpct *counter, } EXPORT_SYMBOL_GPL(ni_tio_set_mite_channel); =20 -static int __init ni_tiocmd_init_module(void) -{ - return 0; -} -module_init(ni_tiocmd_init_module); - -static void __exit ni_tiocmd_cleanup_module(void) -{ -} -module_exit(ni_tiocmd_cleanup_module); - MODULE_AUTHOR("Comedi "); MODULE_DESCRIPTION("Comedi command support for NI general-purpose counters= "); MODULE_LICENSE("GPL"); diff --git a/drivers/comedi/kcomedilib/kcomedilib_main.c b/drivers/comedi/k= comedilib/kcomedilib_main.c index baa9eaaf97d4..517e60ffd81b 100644 --- a/drivers/comedi/kcomedilib/kcomedilib_main.c +++ b/drivers/comedi/kcomedilib/kcomedilib_main.c @@ -351,15 +351,3 @@ int comedi_get_n_channels(struct comedi_device *dev, u= nsigned int subdevice) return n; } EXPORT_SYMBOL_GPL(comedi_get_n_channels); - -static int __init kcomedilib_module_init(void) -{ - return 0; -} - -static void __exit kcomedilib_module_exit(void) -{ -} - -module_init(kcomedilib_module_init); -module_exit(kcomedilib_module_exit); --=20 2.43.0