From nobody Sun Feb 8 17:42:11 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A9F81D5151 for ; Sat, 31 Jan 2026 00:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769819490; cv=none; b=UMQrnJtGr+SGl0oou0clBI46Tn55OldveW+aZMOvtM67bLFzBi7qLQXIKdSAYx9y42e26qck/z7E9A51Jnl4pvH5Xbb57KoAqYkZqgDB3kp93uDS6Io3jVdRSOgwmc3op3gYNDwDk32bj2XDmY26QEbQqQTNhTtaDXVKgHhNCIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769819490; c=relaxed/simple; bh=9oBcU60APrXdRDUwgOJ/YVbZTh/KIjGr/FLUseRN3zo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ozG3NfQlhrj1OYaZ7prR1CwKlVBD4roB27Lzkwd2leQIxhPloOPDeacAWUR4LnQEtkKeWLYJcui6BRniRhd9SL6oTj3fXMBA7Kre8sOd36vyWT3wYRbTH47FbVo2yZqJqVGOLJ9x4SxgSfxYkzPcrqjDNcc7KVPCTat0FTZTAMg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=heUjay/2; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="heUjay/2" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c06cb8004e8so1056999a12.0 for ; Fri, 30 Jan 2026 16:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1769819488; x=1770424288; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nNet+qCw5kKXXKdFjfZxFhD9/MzzBmPNM66XEuqgsbs=; b=heUjay/2bOLDS3cGfZWOcCaK24YcgEukJXeHlRJ/7+wwMfELzdQB6hbnoi/xE/bTEY UmFMVwbXVr1MBJx+Mhocw9/u8fHkFZYkZA7ImJNWDgRu6mo2xaV1tUoaYmjO3w9Zzkng ABuLtzEttUzTrt+qF0QJRKZryCENlbYgZAUf2kWyXVELXn4P8RV+eDtUUQ6J09BGGiBp g6d7DnmkbtqhqhWgGEZR590ziCVaFkYGTAKAm6OZeb+6dKhhtsedcJ3nWZC0/J/yFgNd n4+UVsdCZCFpVt8vc1eVb3MuBQwT3OpUpN1nCjBva5tMEM+WBPAg0z6fsYv0C/9XEQ0D /e6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769819488; x=1770424288; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nNet+qCw5kKXXKdFjfZxFhD9/MzzBmPNM66XEuqgsbs=; b=aD8t4wkT1D5ksYX9fvHafJ7w86AHgRej2/QOGGg2w4cNvH+GucNtLhTRd714e7xeCo 1ph+4e71EHwUCYJd1MCUmR3r/ipMQd4+VZvFuECeHLJ8706WrBJkzd3f45sW2MmPPkoG VKjifJDWLKJLqSse0n+hBNqneOqVeS/w3DQrf7hFGd+bY2c80dyZmGHRH6Cng3w8PYoC tSA+ccCJRbdEWKAZpQJGbLMZfm2Tqf30M0BWlZQrEBkYTvr41abit+qpFba11QgPEoFv mNpfAN3EPCcfL69/vjhovSpu56cy+z52bTNVNC8Fg+eotecCMMiogVz0RycLxpPHRIBR 0/Eg== X-Forwarded-Encrypted: i=1; AJvYcCXHpf60DsHJoa/G5cctkXoNXzI8u0o3yn6w4kmu1NhEMzj93OjoNX8x9OaWjOs7hqWBS1En5o1ZyH2jqN4=@vger.kernel.org X-Gm-Message-State: AOJu0YxfZ0vCLLGP84iohSUxYYABtPRZpbRVBj723s7OCk/f74jHIOV5 BMjaEMQmDJQiOlgYrkGso+b73GgxgLla1lTrRfTIWAwluLuK6qk4nSuRijnP9nJtepUQ2lSsfW1 6Ieaz X-Gm-Gg: AZuq6aI94Z7+ibvavkQBgX5t1mqXOq16fsDgrc3kXX8eshbbTU6Ob04Q8SN2x5Jsoyf r/M8noSA3kqOhZD4dFSLvwM8K28jobZybcvvP8ehjSpix9UxLVK0VTYLCDPBPw5Y3OMkX3SbkOz 94Rc145yfc74Egixkb1m3PTyB94ucQPTIeang4r011hNOgMyaCcSWBF66++FBzFTVpyba8dAb2l rknhJZi0hWbeqF3UJ2ex4NKLo5/kW7rn80NiQrxECGq+rKto8+jv9uyiQJRjBXhR93S8KQervB4 LpHdsk0pxRWobHsesXw7HwOjs+3cv9fFAMJKSu9qjzSlTEFRfl4zrNhhvC/IE1JyB5aFS4qK8/E eZCy/mPDg8IoitCNu3y2zosi8JSoliBue92qFXgIrVj1pOL4AqnhK+ob+mzczcTT+pETsro7a4Z /fv0c= X-Received: by 2002:a17:90b:2e41:b0:340:bb51:17eb with SMTP id 98e67ed59e1d1-3543b34fcbcmr4748872a91.15.1769819487720; Fri, 30 Jan 2026 16:31:27 -0800 (PST) Received: from localhost ([2a03:2880:2ff:71::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c1eeebsm9213290b3a.45.2026.01.30.16.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 16:31:27 -0800 (PST) From: Joe Damato To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: shruti.parab@broadcom.com, Joe Damato Subject: [PATCH net-next v3] bnxt_en: Allow ntuple filters for drops Date: Fri, 30 Jan 2026 16:30:41 -0800 Message-ID: <20260131003042.2570434-1-joe@dama.to> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It appears that in commit 7efd79c0e689 ("bnxt_en: Add drop action support for ntuple"), bnxt gained support for ntuple filters for packet drops. However, support for this does not seem to work in recent kernels or against net-next: % sudo ethtool -U eth0 flow-type udp4 src-ip 1.1.1.1 action -1 rmgr: Cannot insert RX class rule: Operation not supported Cannot insert classification rule The issue is that the existing code uses ethtool_get_flow_spec_ring_vf, which will return a non-zero value if the ring_cookie is set to RX_CLS_FLOW_DISC, which then causes bnxt_add_ntuple_cls_rule to return -EOPNOTSUPP because it thinks the user is trying to set an ntuple filter for a vf. Fix this by first checking that the ring_cookie is not RX_CLS_FLOW_DISC. After this patch, ntuple filters for drops can be added: % sudo ethtool -U eth0 flow-type udp4 src-ip 1.1.1.1 action -1 Added rule with ID 0 % ethtool -n eth0 44 RX rings available Total 1 rules Filter: 0 Rule Type: UDP over IPv4 Src IP addr: 1.1.1.1 mask: 0.0.0.0 Dest IP addr: 0.0.0.0 mask: 255.255.255.255 TOS: 0x0 mask: 0xff Src port: 0 mask: 0xffff Dest port: 0 mask: 0xffff Action: Drop Reviewed-by: Michael Chan Signed-off-by: Joe Damato --- v3: - Removed unused vf variable as suggested by Michael Chan - Added Michael Chan's Reviewed-by v2: https://lore.kernel.org/netdev/20260130002323.2561266-1-joe@dama.to/ - Extract the FLOW_MAC_EXT and FLOW_EXT check so it happens unconditional= ly.=20 - Eliminate the local variable ring, which was used in only one place and call ethtool_get_flow_spec_ring instead. v1: https://lore.kernel.org/netdev/20260128222718.1679581-1-joe@dama.to/ drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/ne= t/ethernet/broadcom/bnxt/bnxt_ethtool.c index 6b15fedbb16f..53a83b6680c4 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -1346,16 +1346,17 @@ static int bnxt_add_ntuple_cls_rule(struct bnxt *bp, struct bnxt_l2_filter *l2_fltr; struct bnxt_flow_masks *fmasks; struct flow_keys *fkeys; - u32 idx, ring; + u32 idx; int rc; - u8 vf; =20 if (!bp->vnic_info) return -EAGAIN; =20 - vf =3D ethtool_get_flow_spec_ring_vf(fs->ring_cookie); - ring =3D ethtool_get_flow_spec_ring(fs->ring_cookie); - if ((fs->flow_type & (FLOW_MAC_EXT | FLOW_EXT)) || vf) + if (fs->flow_type & (FLOW_MAC_EXT | FLOW_EXT)) + return -EOPNOTSUPP; + + if (fs->ring_cookie !=3D RX_CLS_FLOW_DISC && + ethtool_get_flow_spec_ring_vf(fs->ring_cookie)) return -EOPNOTSUPP; =20 if (flow_type =3D=3D IP_USER_FLOW) { @@ -1481,7 +1482,7 @@ static int bnxt_add_ntuple_cls_rule(struct bnxt *bp, if (fs->ring_cookie =3D=3D RX_CLS_FLOW_DISC) new_fltr->base.flags |=3D BNXT_ACT_DROP; else - new_fltr->base.rxq =3D ring; + new_fltr->base.rxq =3D ethtool_get_flow_spec_ring(fs->ring_cookie); __set_bit(BNXT_FLTR_VALID, &new_fltr->base.state); rc =3D bnxt_insert_ntp_filter(bp, new_fltr, idx); if (!rc) { base-commit: 6ad42b24413630199cb9f35d073f71768788f8dc --=20 2.47.3