From nobody Sun Feb 8 11:06:01 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26B4C1DDC28 for ; Fri, 30 Jan 2026 17:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793232; cv=none; b=ESJFgKEZqxMvtVDrWu4Dh/uioU2xIoExrNfjRbRf9ZgosujnNw+oRjsQkkifwXq9ZJueX/2ZOaV7A160KJP8Xu+gS+Au7wcxHX2zxo2wksHtsdphNu/no+mj0T4Z1I5HzdtqWc3D/onoB1RU0IPa5jszkOqvd6XmC7DssBPWTHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793232; c=relaxed/simple; bh=zQFkLl8vLd3yE93SFtPa9RDDctRlJ5Y1xPmbVjbRxro=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=XPd2cncE4ZPy4lwC427R6Dn7FIEcOSaT8CkcuMhZW727GbZfANL8EZqYR2YYRqF4mylu2Chca0JQvy9gYN+yFnb3utgWZCaUzmuK8YKbrbPn0sJkezYj5J7X/uZEgbGqUibhKhpSZvzBCAAXJXdFJ5oXdG2CYsBb6Qelh26j5Ls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZuX992Et; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZuX992Et" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-82318702afbso2076862b3a.1 for ; Fri, 30 Jan 2026 09:13:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769793230; x=1770398030; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=iLoRIcL4OXpyIuIVCDABYSmuqLX/Cp2Jv1keM52pYFg=; b=ZuX992EtaRt+0cO82hpEnXsppLEIMs5LsMnizObICnH9W1AUrqwd8gM0r+RjqVQC4D xpfBtp43fLbHsQxCpXKgsVo7dtQgeM/F0Btahl3K33KP9kmZ432PozuDPj/94nghY79L 3+EWF9/xfKP7xd+4/AISP/fWGPvg1nDXsHK7GBnwbMbNiztXpYMNiYdI5GV5P8kuL/Wx uR/6sOCgZLOjDSiviWz/EfCNyKkclIyelGg4fzEDI4Ac3rRQO9gJnQc7qbUVN3QPPuuD VPWISswERJpZOnZZRvHm0GGfMXLgfV6ySiIsiG9XqvN7FGgB4Ub3vJCyN4qJIlsEXVe0 8Efw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769793230; x=1770398030; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iLoRIcL4OXpyIuIVCDABYSmuqLX/Cp2Jv1keM52pYFg=; b=kmCG4yMmYXswxI88PPTcPCy+rBL1847QXqpoD0cSQMUcl/te8OvRZoNVwZYaYITdti xuYlEknbdM/mjj/zRsqbdOw56WZ0yHaUDd29WQ/G2pi+pRJJzI3LnySa7hRa5M8YG3wR NN3EuPXLe1YyPwUAdXYsoRvw9mg02bnsKvV/kfQZp/9MFeqdPNfUebIbbMpqHSrytXlz BkIFzeIesT0oGaKy1hDLF4f63eS8DkwaHcz8T28CuqmUYADhjENwIDSTi5T31YQ1vJL/ ci7WGT5AiEVq6m4YFb5sKZ9REkJEShxGHBxc7U6O4qhOI2MDYMUqwboUq4+3MmHwQ8Kf cufQ== X-Forwarded-Encrypted: i=1; AJvYcCUyL5vu6SLq0E8GtC/S9cW0DQPEBn7FhO+GMJbJyMrBMvpJUULyNW8e7MiX9ThMBq+oTRwRpCSy06/fPX8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+ti4SjX0JnJrhtpbUtMFOHp/dVXnjkUPZnMJsl6gk+gV/Lmjj Q+cIkJwdmpvSNgs8E/IV40fa4yrocAAv3Yv4Amb54+jLQAmp4CflE2QSkAvbUe/X X-Gm-Gg: AZuq6aLEW96HVjsCJAFE0CYXFB3UZ9C3nLgbbMb83yXMJy9oMzVnDfpRxCslNxcJVpB KpiTUDIiiNhNBI1Oqq3xPlVj5mLzO/MbURX4oF5HBK5iCNjqHXkUiKO4K4L729CgQg1mnYvJ/Yo rf1kIEmkGroR8TpA73tV2lTPYIT4s+9pfcjqsKP5auz/qghS60XA4L7+q7nEl0M0F8HoJZZpDm0 Q0S9EFu2gWWsWHKoxqBJmdPMx4YF5rESsVDlgU+yW+JORATRLD/omZHWMsGlLvFWts3irOfNebv 9vGRmQRZAcI1NJNKcV+QNyDJACifsl2NBC0rZAQE0JWmIPaW/djskdzn0v+gtgEHnWDi74E6pLz xGX2SqF7V/1mpuLbgfkT+568Yi7wCWl2CSf40CNIRZXYYoTLClDXVeJQS9cGSyBLCvIVxOLUEwP KvXl6HV83AjiisXrzoueH5q1uZmBnwTLfovtc= X-Received: by 2002:a05:6a20:cf82:b0:38f:870c:bc3f with SMTP id adf61e73a8af0-392e01095cdmr3199455637.40.1769793230099; Fri, 30 Jan 2026 09:13:50 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:53f:14bb:e0fe:f839]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3540f2cb0a7sm8725490a91.2.2026.01.30.09.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 09:13:49 -0800 (PST) From: Felix Gu Date: Sat, 31 Jan 2026 01:13:45 +0800 Subject: [PATCH] cache: starfive: fix device node leak in starlink_cache_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260131-starlink-v1-1-30985722d51f@gmail.com> X-B4-Tracking: v=1; b=H4sIAMjmfGkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDQ2ND3eKSxKKczLxs3SQj46Q008Rkc2MjYyWg8oKi1LTMCrBR0bG1tQB AW4l0WgAAAA== X-Change-ID: 20260131-starlink-b23bf5ac7323 To: Conor Dooley , Jonathan Cameron , Joshua Yeong Cc: Conor Dooley , linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769793227; l=1241; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=zQFkLl8vLd3yE93SFtPa9RDDctRlJ5Y1xPmbVjbRxro=; b=yMG2oMTzj4KGrMP7aPilTYtYzKS+hFgObq/Ywg1WoaRNBkFzwgJZPZN1i0VWpEHRFE8lpZbr2 FP1Td2YUOp7Dsf00zF58EsxwE2w9nhMnnlwMVKSqEvpoL8wkl36fLbO X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= of_find_matching_node() returns a device_node with refcount incremented. Use __free(device_node) attribute to automatically call of_node_put() when the variable goes out of scope, preventing the refcount leak. Fixes: cabff60ca77d ("cache: Add StarFive StarLink cache management") Signed-off-by: Felix Gu Reviewed-by: Jonathan Cameron --- drivers/cache/starfive_starlink_cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cache/starfive_starlink_cache.c b/drivers/cache/starfi= ve_starlink_cache.c index 24c7d078ca22..3a25d2d7c70c 100644 --- a/drivers/cache/starfive_starlink_cache.c +++ b/drivers/cache/starfive_starlink_cache.c @@ -102,11 +102,11 @@ static const struct of_device_id starlink_cache_ids[]= =3D { =20 static int __init starlink_cache_init(void) { - struct device_node *np; u32 block_size; int ret; =20 - np =3D of_find_matching_node(NULL, starlink_cache_ids); + struct device_node *np __free(device_node) =3D + of_find_matching_node(NULL, starlink_cache_ids); if (!of_device_is_available(np)) return -ENODEV; =20 --- base-commit: 33a647c659ffa5bdb94abc345c8c86768ff96215 change-id: 20260131-starlink-b23bf5ac7323 Best regards, --=20 Felix Gu