From nobody Sun Feb 8 18:32:38 2026 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B688925B31D for ; Sat, 31 Jan 2026 08:11:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769847108; cv=none; b=XSMrUY0NiA1V+Hf7Z02vxzk+RIMQY8eMtzDUdIKBQ7vVpQuS7+fgToho6aKumRVrTKpkHGYc71qk0Jee8LFHwltJ4mAC4u0nwfVc+kWft8pjw3MeiCXaoLLNVtTqKOktOOAQ251KtaW6m1aKG9HD15bKaqY2BOMny/vegZoibuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769847108; c=relaxed/simple; bh=9OAQjhZI4G9NDVTt9f0prwiTo7Qoj04+zj9JpK/zoHA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TxjUprMWamdPUolljaBvQgpm0tcNAlNk+LzHl07dYcKTLUUCMppOgkOuHWnCqHIEpPa+YSB51JcmZtZ4UglMIKu79M6B1BYBJL4DyVo8xPAGWJPuXyRf9grxswkuQauPos0QSQAHB6+SEklH2B5Hd63T4PnC+pYsV2oZM2SvV2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IZ/Eo5LA; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IZ/Eo5LA" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2a0c20ee83dso26028115ad.2 for ; Sat, 31 Jan 2026 00:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769847106; x=1770451906; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E79QyFHl6v9hrcpW7a0gJg/ST+Ia1jTsFgjOY9hJneE=; b=IZ/Eo5LADarTchcYf5LfYhz+JW5qdzj6qiuXGPH72zSwZmCay4kRAPUcHhpIqN0i4+ VZBpg5T2id4lbKyW4+lT00xdAT/7OoTuGzPhDwucBMqh2HQPzYzv/akR6sn4vD3cQ4XG kL8j/EltSDxluEM43+tL8xx449BnZRHSGKVyewaEB50xLTjWIBHlGgZ70cTi3FWDsJAj FRtuvE5bnZE0RmNA1PIaRgN1nJeOHMQrV60A3TmOoWFRYLgUFZWGf+29uP7foC7VYYEe iqjekl/2G/rPVZNuAwVwLlH5W1CNw8AInrr9v+XMrEHif4KbZVprQrYN1+zwQSEtXGBO 0ROw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769847106; x=1770451906; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=E79QyFHl6v9hrcpW7a0gJg/ST+Ia1jTsFgjOY9hJneE=; b=VoJEYYBdrM2JTPMq/s9KUzSqWjMM9J8Klu3WECcEJvkAQPjHLxLsPpqMQGDpbWSy4E 7v+jo+TVLAiZLMsWdYdWdecr2G/hNtHaFgHxIXNuvNzCmEJXjYPE7YDvNbcMMefPRNzL QXt5bdyd+wPbAMBVbqSWDm6BNULIhqGGpxAqNAtlzwP41DL11LZ6iq5PzIJiMCj7L16f xariBWetypU6tsPyvfCg5uj7zB8ud4v4BzGve5swx2gAdYFvz96CjAuwBoitBxz74zhb FSCX54nchRME/aR9div+FBT6+tgpGcUACr/KvOJJXj1C4VBNtIlWFw2I2JVrEP7GMJYc 0Z7Q== X-Forwarded-Encrypted: i=1; AJvYcCWqTqUf1IlH+iTQA0cw8AZrEfJRepdFCTFrrK+EIZN53wTLw8knLLpcA3vtZItj4cfzymULLFaPp6nHCoE=@vger.kernel.org X-Gm-Message-State: AOJu0YxPWF8Nt1scfc3G8w7Y5+nRf37vYX7d0IwB/7W/nlrYiBd2Kz0F T+LDq+ZwgH94TCTWXhBM0TooTPE8UGdzcV6FYQlRgEOqIneRHUo3Ly/M X-Gm-Gg: AZuq6aJYZEYWkS/FnK8VwIxNKExuu3HHth8iStzE9PiOmXKmtjjzjHLjpZWdBStzUWx x/iP3MJ7lbGUe7xKVB3F6ccN1WyWAj4jMzzn5abLpn3gCl/tSFNdpiFHTdwgkYMIPhChFmv3Ym1 QnYNRJDDVLzPdfS1Gs71wJgXISxV+lwj6q/46lgUuOCSidrAFpEGkfN9PTbA0gHi2WrpojZxDOe 9tzwlK7BW2stbi9nGrldji4tBV2EAh/SYtokaiu70wjznoO4q3qrpKfS/9RqWibO09okq9V50rJ uwz9RkinkPQSVtJ/+zU5V4zSNacJ3DkW2bOX8EFEH8czAm+wCgsRd5ftyPVmz4JWswvbqCIh2sX HdlMAz2756HqB2W1AnN6CpsbgWOky4X+6kKYZmDbxnmkLfo+DsEE1L/yfWZM3ykaWhF61iFi8IP O1oH74SOY= X-Received: by 2002:a17:902:8218:b0:2a7:7c72:42b6 with SMTP id d9443c01a7336-2a8d96a221fmr44250135ad.18.1769847105996; Sat, 31 Jan 2026 00:11:45 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52::3a87]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b5d92a9sm92115125ad.69.2026.01.31.00.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 00:11:45 -0800 (PST) From: Felix Gu Date: Sat, 31 Jan 2026 16:11:34 +0800 Subject: [PATCH v2 1/2] clk: imx: imx6q: Fix device node reference leak in pll6_bypassed() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260131-clk-imx6q-v2-1-70471ddc99e0@gmail.com> References: <20260131-clk-imx6q-v2-0-70471ddc99e0@gmail.com> In-Reply-To: <20260131-clk-imx6q-v2-0-70471ddc99e0@gmail.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Lucas Stach , Philipp Zabel , Akshay Bhat , Ranjani Vaidyanathan , Shawn Guo Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769847097; l=1258; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=9OAQjhZI4G9NDVTt9f0prwiTo7Qoj04+zj9JpK/zoHA=; b=Amf+HD1p3lcCeTT2eWu8v7JUo6k/cHzSXe1AmMAfSN8hyokQgHe/dh6dj/P7sHbmDWKqueAlg HSqNr6tFh10C/GLl9mZ/HUETAF9ASs8izJZ1BX+ZQlQJkLbXzj1mf8y X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The function pll6_bypassed() calls of_parse_phandle_with_args() but never calls of_node_put() to release the reference, causing a memory leak. Fix this by adding proper cleanup calls on all exit paths. Fixes: 3cc48976e9763 ("clk: imx6q: handle ENET PLL bypass") Signed-off-by: Felix Gu --- drivers/clk/imx/clk-imx6q.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c index bf4c1d9c9928..1d8e8f0891a3 100644 --- a/drivers/clk/imx/clk-imx6q.c +++ b/drivers/clk/imx/clk-imx6q.c @@ -238,8 +238,11 @@ static bool pll6_bypassed(struct device_node *node) return false; =20 if (clkspec.np =3D=3D node && - clkspec.args[0] =3D=3D IMX6QDL_PLL6_BYPASS) + clkspec.args[0] =3D=3D IMX6QDL_PLL6_BYPASS) { + of_node_put(clkspec.np); break; + } + of_node_put(clkspec.np); } =20 /* PLL6 bypass is not part of the assigned clock list */ @@ -249,6 +252,7 @@ static bool pll6_bypassed(struct device_node *node) ret =3D of_parse_phandle_with_args(node, "assigned-clock-parents", "#clock-cells", index, &clkspec); =20 + of_node_put(clkspec.np); if (clkspec.args[0] !=3D IMX6QDL_CLK_PLL6) return true; =20 --=20 2.43.0 From nobody Sun Feb 8 18:32:38 2026 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B30932F74B for ; Sat, 31 Jan 2026 08:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769847112; cv=none; b=n15Iob1Myl7w1Uh/+1HnJOYxVDWIhO/6emgpn+uWIs58hTwhoUb20uUK1WFztZOj6eYwzzhSt3Cc66FVMx8sqWpjA7qw6vqsuj3JNgCcZJeSZKLX2mqATag5ippitJiavSM6XXuvcA6b1lN+tmLvrXtblhqTJ+RpCIiSQeMYxI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769847112; c=relaxed/simple; bh=8z6Jwe22roU0IcUq5EjPKimwprqUXrkhxOXSXzExrCg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Djg4hTej3tabpSXaygepJdgCNORKPd01JOv8A8Vad6uKv6+jmL4q47t3GcrjIVjsRbaN+A0hP4Mm7B4tlYpJ/Z0nDPrktzSFMWSUMhAzzvfNC1Y7nUzHvUIKDE7Fq6v1TPpUrQ/p4NLeA/bxP97o2PDZvckORxvyiewzuX6X7/o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BtQh+d3X; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BtQh+d3X" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2a77c1d5c3bso12779455ad.0 for ; Sat, 31 Jan 2026 00:11:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769847111; x=1770451911; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FjfAJsvyjCO/vjM7jBeWQxefgcvpbHgFUQ72gcagyLo=; b=BtQh+d3X6ZJf8Y7tBkPZZ0wEyajSbDy3d4GBxmel4Vkg00X544G70M9IzzpvGrwwKV mb2PrmnrmTEkhUJ7Cy2ptl0316YP+ukcUtkipRFkja3QtxefRE7yF5UCZbjUOtAP8cED k+FvMaxJr2CdNfC1SjaZEOWfYbkkSirMhkClErZOTIMk0nAqakZIieMdJ1t1XyGg6Dff eES8DxjI7eTXyAOiAglRGpYHL4wHiNuNkj2KfGKq27asbblpCm6djpXW/rzfYIpB9+rL 1WMK8+vW2c2f1y18CA8v8CK7S4GBUYD6E/RiiuXQQSDM4HCMALhcINS5Wg6DsjrpoL5e UMqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769847111; x=1770451911; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FjfAJsvyjCO/vjM7jBeWQxefgcvpbHgFUQ72gcagyLo=; b=BWOL/wWNwUSGXouYMz1eOEHdnGXNGa5aLvGm2YaCZmo53lJSdy3EiljdwDGDXeAaUw g4RP6quWH2manMZdDuU2+hZgbrbyjD/PGJvbTRlcY/4uf9VqtCwWF7oAR4KywOFRP6Di qR92kk4u6MEfBE8SiBaD+xHknRYaIk3KHn2a9LNfmhjPQ0LWhJsLgmSrIttgJfdE39ff wqaKDoAyo4GfOngfziWQehDABYoAufLsbz1Q9DwZ1WadOcsnLmaIB10l0XIJPNVWGyVx BAsnGyhwjRKO76BLW5dh2FPH78+Q+b2D/LPdcmMIMIFcq+o/55BZUAgZt/CGdU0Nm3Db +bLg== X-Forwarded-Encrypted: i=1; AJvYcCX7Eld6GAcyRhvVOlcFHcxbOLaoI8AjAtTT6FK2F87WAc3RxOPXl1Bx22pzVFZNU9Cw2OF+OG5lVZX9mWE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+7VeJQYLS3xdO+jnpsIKqOX5IxL0Dnt++3pJAuZmm0Y7L7rh6 ncRqo68ylbyot0VCbCQ6pa2n4HtWcjqBHmnflt0f+6eUNOxpOxsaOstL X-Gm-Gg: AZuq6aINh942XFSeJkJs4HRdwx6rxZ25we9BL5iNg62V1uN8oWEpC/XVwWs4UEHw1aF ifWMZJ4vu6QFHWdtWwYZ5/Z+5eFm005nkw/4uLelQdTOQ3E4Bw1U7H3TfJH5KDQ5FM1JCozC64y KLfewJ3JhWUatnCCHP/Vh7AOwVoa4RPks1Y5zjsGPmKkAowCB2/jyHweU7AsB8ZZ1gbyR3PiyDu bKToKgnsXcg71ZJnt4yJBG5xSA7VS06FAmiN1O8+iEf1x7szv0vztBwKE0BLIrPt5KL8ISEltb+ u8XasGuJ8vXaLjluDSlLH/Skf/bE90ILtEyRrXOu8u2HtAqEXpU2raqCh/xHd6m6xD2OiLsUxkT i76wpiZJ9JGxm8Xd2F/2e2Xv4J+hsa+tP9n5LZcI/f5zsHHLbAJy1bfqgSyJGIyhNqjC5vGwqBc ymGp/lRLk= X-Received: by 2002:a17:902:f544:b0:2a0:fb1c:143d with SMTP id d9443c01a7336-2a8d9592938mr50396115ad.1.1769847110853; Sat, 31 Jan 2026 00:11:50 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52::3a87]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b5d92a9sm92115125ad.69.2026.01.31.00.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 00:11:50 -0800 (PST) From: Felix Gu Date: Sat, 31 Jan 2026 16:11:35 +0800 Subject: [PATCH v2 2/2] clk: imx: imx6q: Fix device node reference leak in of_assigned_ldb_sels() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260131-clk-imx6q-v2-2-70471ddc99e0@gmail.com> References: <20260131-clk-imx6q-v2-0-70471ddc99e0@gmail.com> In-Reply-To: <20260131-clk-imx6q-v2-0-70471ddc99e0@gmail.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Lucas Stach , Philipp Zabel , Akshay Bhat , Ranjani Vaidyanathan , Shawn Guo Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769847097; l=1463; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=8z6Jwe22roU0IcUq5EjPKimwprqUXrkhxOXSXzExrCg=; b=oiRk1okIysEjvHlGj/5wAp4PFaBltdhhMRDvFAiXGskFVm57xO67i5mEoNGJaNojLeDz5+wu+ WdOTQp1dMycC//jtDtoXsQb3Te+V7M8qOzaj4IqkCVqdZ0e5zHzDORo X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The function of_assigned_ldb_sels() calls of_parse_phandle_with_args() but never calls of_node_put() to release the reference, causing a memory leak. Fix this by adding proper cleanup calls on all exit paths. Fixes: 5d283b083800 ("clk: imx6: Fix procedure to switch the parent of LDB_= DI_CLK") Signed-off-by: Felix Gu --- drivers/clk/imx/clk-imx6q.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c index 1d8e8f0891a3..58882dbc3a11 100644 --- a/drivers/clk/imx/clk-imx6q.c +++ b/drivers/clk/imx/clk-imx6q.c @@ -188,9 +188,11 @@ static void of_assigned_ldb_sels(struct device_node *n= ode, } if (clkspec.np !=3D node || clkspec.args[0] >=3D IMX6QDL_CLK_END) { pr_err("ccm: parent clock %d not in ccm\n", index); + of_node_put(clkspec.np); return; } parent =3D clkspec.args[0]; + of_node_put(clkspec.np); =20 rc =3D of_parse_phandle_with_args(node, "assigned-clocks", "#clock-cells", index, &clkspec); @@ -198,9 +200,11 @@ static void of_assigned_ldb_sels(struct device_node *n= ode, return; if (clkspec.np !=3D node || clkspec.args[0] >=3D IMX6QDL_CLK_END) { pr_err("ccm: child clock %d not in ccm\n", index); + of_node_put(clkspec.np); return; } child =3D clkspec.args[0]; + of_node_put(clkspec.np); =20 if (child !=3D IMX6QDL_CLK_LDB_DI0_SEL && child !=3D IMX6QDL_CLK_LDB_DI1_SEL) --=20 2.43.0