From nobody Mon Feb 9 15:08:23 2026 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E4638A71E for ; Fri, 30 Jan 2026 22:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769812591; cv=none; b=UzFvfQiYFuSktJgvN1CNlcwUQ2ldAptmoX2egsq0a4pCvlU+8RkQDaiWVtu5IaUoCc14tNY1e3LUJhjmXGMbHXlXmLHq6FlE2uGfwm4rW/YJHEvN+6IRoiTbgCOAkioB3lIwgsX9KXnuu4Yp0YvGCw12t4YQehiPBI+tKq7Efpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769812591; c=relaxed/simple; bh=r03Sk0joiETzSq+0ZPvKaeDMCFA6xVpQcIfUtvPeUt0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OTbOUmM60ADGz2+FVYPQ5+AqBzB4aYK8DYsGJ2ej5cS/A7NN7GEKhgVltYQjLUXRYlzl1sn3amGmS4MDjjz/4PtiBMVhH64/tHcHAiEHNUc27JazQAHApIBCaijIRYgO/S07MQ19L8QTC+tnfbs3dPoPtdaz9AknXOx38UBxg5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=HJ2QwqQB; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="HJ2QwqQB" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-12336c0a8b6so3674821c88.1 for ; Fri, 30 Jan 2026 14:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1769812589; x=1770417389; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BAKqZ559mBTag/q6sjzJcnNya5CtOd9zWOEoYKABV/Q=; b=HJ2QwqQBrkC9XHRvwWt+uCF1GyFOZDaKX1bOcmmtA5kw1K6odAqb72G48aXKE6bwsG hIQMJOvKxLoBJ+bnrUrBdNz5IQBEGz0+WlGR2HBbjDoOQL4I7OkpJOvlDJy39qvY+s2x lY+05oUGpHijm6B4V+RvDNuI16p7k7rF4oj4uvEVQOEQv8df0qXsjTiDOuJzddjQd5hl b7xhbivV4BeEvJVd7sEKb1zPnDuUG/uRbLp1b5CiQmKNp8mjPscoVLS8F08yGy7WmgMT nycHrFCCKSO20gjV7jyFXFvbmxi2+m8CTYDN2gk4pd+tkvoiSvsBP7mXUl5njdXL4ICQ CKSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769812589; x=1770417389; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BAKqZ559mBTag/q6sjzJcnNya5CtOd9zWOEoYKABV/Q=; b=Ojm02khatnS2UINvj4QiPGJiD+PR3eQPWhN0tCzJ85CjlhiPlVs510wLK/i6k52JlW L7TKbBj2wKEAbr5mrGhe1/zfRBr0i5GizaBOGOMVeFDbxkJH1bk9l73KSzF0AYfmFuVz KoTxBlIB8OOahwTqm5VvAXgaBbRqzgoRfnBqq3jFa4Vs5ZDOXw2Gle17y6ihIHPtJmel eRzgMWdHOJ2BTV6rm7Qc0hk9rDOdBaUNTuR4QxIQjN1BCCUDv5IoERrS92tL+mix1f71 V1czjhxhooTb5k5UkXGH6kXtnb8J13A1EOzENmadsK8cXWazgzniVHaaSvuh5zB/cG6v F6ew== X-Forwarded-Encrypted: i=1; AJvYcCUSJbnBDpleOndG0eO3T3ElORZ899T2g5CJjuCoyW6UsOZik8ky5JJI7qTtH03zvEtgds2v+6UcbBpOJ0I=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9sSiCkVezjJ6UX9TQ9E27IYdYAunvUnPGMbNUGcizq9R7GtXl j/Q8K849Kx+/M3gw5Arr2g1X9zTKSVxR0dvQfIQkZJHS2/IKKOnaK3jU8ANk9v7Im5Q= X-Gm-Gg: AZuq6aKpIy8ybOM37Ni9u3qOVMIlfuqVW0Tw1B+xGXbXXxt/c0gvYrYLvnW5Roh+opa p8nsjYsTYE3mhNHeFlXQXQ8yZ18fmHnDe/XGA2um8iGcZzTJ2v6wMD83Wz5uA09pjn0173T80hs zQdz5SO74swdizNNY4/ZxTq0ose8kkQZWKP9IdoZwFIXsgT2u5OnDWmzIksWInlsEM2GDepgB3U OJRmspfjR41fZK25cfroioeEqbMIGbp/181qU/LxwbApJ0SjhrNX8BVeSXxH8kbLKNoUKU6ftAs Gr6u57O2ysafmqbNdmbwK0Uj0pl/gwDE4/GeYkwV1h0xbn2RRFacpK9oL6Y12lx8SeoDwVfgjE7 Lt51p/h7/dQdU+JnmYMnzdPOcBvrH3JhwNuIl7Dy6vXH0e351RkBVtmE1pvHhXhZDJjXYdCdgRw jwH6WxtYumChgPJf9qI/W+ZCBiYdjifXJIaw== X-Received: by 2002:a05:7022:68aa:b0:119:e569:fbb2 with SMTP id a92af1059eb24-125c1008c5cmr2553740c88.33.1769812588458; Fri, 30 Jan 2026 14:36:28 -0800 (PST) Received: from apollo.purestorage.com ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-124a9d6b906sm13161717c88.4.2026.01.30.14.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 14:36:28 -0800 (PST) From: Mohamed Khalfella To: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH v2 05/14] nvmet: Send an AEN on CCR completion Date: Fri, 30 Jan 2026 14:34:09 -0800 Message-ID: <20260130223531.2478849-6-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130223531.2478849-1-mkhalfella@purestorage.com> References: <20260130223531.2478849-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Send an AEN to initiator when impacted controller exists. The notification points to CCR log page that initiator can read to check which CCR operation completed. Signed-off-by: Mohamed Khalfella Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/target/core.c | 25 ++++++++++++++++++++++--- drivers/nvme/target/nvmet.h | 3 ++- include/linux/nvme.h | 3 +++ 3 files changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 54dd0dcfa12b..ae2fe9f90bcd 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -202,7 +202,7 @@ static void nvmet_async_event_work(struct work_struct *= work) nvmet_async_events_process(ctrl); } =20 -void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, +static void nvmet_add_async_event_locked(struct nvmet_ctrl *ctrl, u8 event= _type, u8 event_info, u8 log_page) { struct nvmet_async_event *aen; @@ -215,13 +215,19 @@ void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u= 8 event_type, aen->event_info =3D event_info; aen->log_page =3D log_page; =20 - mutex_lock(&ctrl->lock); list_add_tail(&aen->entry, &ctrl->async_events); - mutex_unlock(&ctrl->lock); =20 queue_work(nvmet_wq, &ctrl->async_event_work); } =20 +void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, + u8 event_info, u8 log_page) +{ + mutex_lock(&ctrl->lock); + nvmet_add_async_event_locked(ctrl, event_type, event_info, log_page); + mutex_unlock(&ctrl->lock); +} + static void nvmet_add_to_changed_ns_log(struct nvmet_ctrl *ctrl, __le32 ns= id) { u32 i; @@ -1788,6 +1794,18 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_all= oc_ctrl_args *args) } EXPORT_SYMBOL_GPL(nvmet_alloc_ctrl); =20 +static void nvmet_ctrl_notify_ccr(struct nvmet_ctrl *ctrl) +{ + lockdep_assert_held(&ctrl->lock); + + if (nvmet_aen_bit_disabled(ctrl, NVME_AEN_BIT_CCR_COMPLETE)) + return; + + nvmet_add_async_event_locked(ctrl, NVME_AER_NOTICE, + NVME_AER_NOTICE_CCR_COMPLETED, + NVME_LOG_CCR); +} + static void nvmet_ctrl_complete_pending_ccr(struct nvmet_ctrl *ctrl) { struct nvmet_subsys *subsys =3D ctrl->subsys; @@ -1803,6 +1821,7 @@ static void nvmet_ctrl_complete_pending_ccr(struct nv= met_ctrl *ctrl) list_for_each_entry(ccr, &sctrl->ccr_list, entry) { if (ccr->ctrl =3D=3D ctrl) { ccr->ctrl =3D NULL; + nvmet_ctrl_notify_ccr(sctrl); break; } } diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index 93d6ac41cf85..00528feeb3cd 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -44,7 +44,8 @@ * Supported optional AENs: */ #define NVMET_AEN_CFG_OPTIONAL \ - (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_ANA_CHANGE) + (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_ANA_CHANGE | \ + NVME_AEN_CFG_CCR_COMPLETE) #define NVMET_DISC_AEN_CFG_OPTIONAL \ (NVME_AEN_CFG_DISC_CHANGE) =20 diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 3e189674b69e..f6d66dadc5b1 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -863,12 +863,14 @@ enum { NVME_AER_NOTICE_FW_ACT_STARTING =3D 0x01, NVME_AER_NOTICE_ANA =3D 0x03, NVME_AER_NOTICE_DISC_CHANGED =3D 0xf0, + NVME_AER_NOTICE_CCR_COMPLETED =3D 0xf4, }; =20 enum { NVME_AEN_BIT_NS_ATTR =3D 8, NVME_AEN_BIT_FW_ACT =3D 9, NVME_AEN_BIT_ANA_CHANGE =3D 11, + NVME_AEN_BIT_CCR_COMPLETE =3D 20, NVME_AEN_BIT_DISC_CHANGE =3D 31, }; =20 @@ -876,6 +878,7 @@ enum { NVME_AEN_CFG_NS_ATTR =3D 1 << NVME_AEN_BIT_NS_ATTR, NVME_AEN_CFG_FW_ACT =3D 1 << NVME_AEN_BIT_FW_ACT, NVME_AEN_CFG_ANA_CHANGE =3D 1 << NVME_AEN_BIT_ANA_CHANGE, + NVME_AEN_CFG_CCR_COMPLETE =3D 1 << NVME_AEN_BIT_CCR_COMPLETE, NVME_AEN_CFG_DISC_CHANGE =3D 1 << NVME_AEN_BIT_DISC_CHANGE, }; =20 --=20 2.52.0