From nobody Mon Feb 9 09:10:07 2026 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D21938A724 for ; Fri, 30 Jan 2026 22:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769812589; cv=none; b=Ymz0ZUiTQ4iWFzoIsPOwOB0zjiM72nZCB91vmlO9CAqQvimoQBw3US0Bn6h6uAomVwICV9KpKXAEFRKE+11zu89Ay7lbD+4S8ysqHyhr/LAv67D/j62d43AMmzBjFuWxjHOereiKmXNtlZpKPDNWDdM6EL6TBrAblBeTaDMKeOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769812589; c=relaxed/simple; bh=Ok8YjddGySHfJBNHeM3Vds8mfYwv2GCUrjELYN69mLA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uDdwV80SJofk8jIF7G3f+vmPTMEyLTAnNBLw6LKoMYoHELyDcDrTTR1IJUgKRi6XBbeJEWcGhJvcPTHlVmzGdXQU4boDCjDBEBnGYXfHossQEPaYEyLJPuGy+qXd7VfuMzHYh9wrXdL8AFIaA+NiV1aw8zDAJ8PfEAIyBSoTWQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=V0HsLeUR; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="V0HsLeUR" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-12336c0a8b6so3674791c88.1 for ; Fri, 30 Jan 2026 14:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1769812588; x=1770417388; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zdXGSegTzhmsQ5qZhBP6CsinO53oPJTvN/vUTL8HtC8=; b=V0HsLeURTUyVEMYKXXcfY4W9LtS1rtoyo4fHPQ3mTjcuhJTlCKXyX0LZs5n5VB96A1 IYTr6FotrpX7PmRLpRJ+sN/TGD5uP2KTZTFE4GSH/y04cwRehM5gaMhZMV3n4Bgfj3Gn aZMAEr3o1N7A2H6dy8nJevoT5xWwjcX037brUtDyIaq+ruUdLSjJqm/henjq685/4r+D 0uBy0SetTwapbc/hE2Ry+Gp9FsoAbpc4xI9TmNg55kAB3SQREwUWviEElqg7AtMynRiA TE15tXK0cMgoLigjGVC+wXR5ILgxSd+sYPQ5aYKViKlk3zrw54UkXvm50Vyhqyqp6t0I NyXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769812588; x=1770417388; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zdXGSegTzhmsQ5qZhBP6CsinO53oPJTvN/vUTL8HtC8=; b=pqQfjvQqL9VJM/LBEhWnsOw/YM2KceI3ugX/Hb4blRxz2QZmrJ86okBaoLwGa1jTDg Rly3g4W6gU2qob7XdVJjjXT3nNxLGtTV8YUbrAdywCNyEkqSrTyDt+TddiVOBPVvvQmt +IhO5ErSiggPvL6jpFs6lbCW3a3ScsorDMDol1ila18F0YdR2L4Agr+YCPnAOxjZsYvA rYj6wz7ctJT52gpCkwzbXmPfeYR3+zCtEU3l/HTxRVB9dRkazcf5IWHaiEayPiucXBZP Z7WVvRKs75Cp2mWDKbg+0pJZz1FZ2UGDcoX0AWA8lEAJ2PIToktsuJMcNPQYhk1C89Ov if0Q== X-Forwarded-Encrypted: i=1; AJvYcCXFaC70b9ror9MXA2mJeXG1LtfElos+3rvA6+ed4DDDDwrzQW2czkfPIhl/NoHpIS7PTZvv5ihuQXOPgOs=@vger.kernel.org X-Gm-Message-State: AOJu0YyCQx/1AgLO5SNNolmHM8CkD4ARfROINafNVeRgmffPFnC/7SWV cvKUIeUBFtjqru+ZAMp1EkBu91mdqwReTpW8q7QoBjTZYkQ/m1DozhWjili7CB+X+R4= X-Gm-Gg: AZuq6aIOmfuiUDqlKwD+FRWM3H7wgvmTXjX3B7CuSAK0CO5FEdHNmOpb5urmBuhdqRK zcSzkTOQdV8xxfYcQIFvHEi8ruPyit77/k/DNYTrOap9PM+VV5W+mRUToYEhXneYlz2vPyedNBK g2+5XwXxNiM0rG2UKMipB0+gSUbZaEFWYPKnm92JdmsIj7fM5YVRI30/e+0Ry5UiNXU0db2Jx82 cqCAIkIH8F9JsgtMoSKhxPzOX3fBoNvcIh5p41ol8go4j+8uHA4B0RHmdkvY1X1zR0KSJPxtLyZ qfeAH144xUZAeU5lbRl38HG2TpZuOprEC34oVVSb5QDOJeWIw6uN0JmdvtP2owM8sy9UDZfcwln e2oIZWr2kZniZL0u0NAUtcBOk/l3aMsaAnnD6tfqbWbkK6/3ByxSJo9+zDvv5cK0LPWSDugP0YM bmnCIIeUNoYjnYhBJ8b+OkbL5++uyIT0+g8w== X-Received: by 2002:a05:7022:419:b0:11e:163:be60 with SMTP id a92af1059eb24-125c0fff8f3mr1909114c88.31.1769812587500; Fri, 30 Jan 2026 14:36:27 -0800 (PST) Received: from apollo.purestorage.com ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-124a9d6b906sm13161717c88.4.2026.01.30.14.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 14:36:27 -0800 (PST) From: Mohamed Khalfella To: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH v2 04/14] nvmet: Implement CCR logpage Date: Fri, 30 Jan 2026 14:34:08 -0800 Message-ID: <20260130223531.2478849-5-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130223531.2478849-1-mkhalfella@purestorage.com> References: <20260130223531.2478849-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Defined by TP8028 Rapid Path Failure Recovery, CCR (Cross-Controller Reset) log page contains an entry for each CCR request submitted to source controller. Implement CCR logpage for nvme linux target. Signed-off-by: Mohamed Khalfella Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/target/admin-cmd.c | 44 +++++++++++++++++++++++++++++++++ include/linux/nvme.h | 29 ++++++++++++++++++++++ 2 files changed, 73 insertions(+) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cm= d.c index c0fd8eca2e44..fdeb79ec348a 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -220,6 +220,7 @@ static void nvmet_execute_get_supported_log_pages(struc= t nvmet_req *req) logs->lids[NVME_LOG_FEATURES] =3D cpu_to_le32(NVME_LIDS_LSUPP); logs->lids[NVME_LOG_RMI] =3D cpu_to_le32(NVME_LIDS_LSUPP); logs->lids[NVME_LOG_RESERVATION] =3D cpu_to_le32(NVME_LIDS_LSUPP); + logs->lids[NVME_LOG_CCR] =3D cpu_to_le32(NVME_LIDS_LSUPP); =20 status =3D nvmet_copy_to_sgl(req, 0, logs, sizeof(*logs)); kfree(logs); @@ -608,6 +609,47 @@ static void nvmet_execute_get_log_page_features(struct= nvmet_req *req) nvmet_req_complete(req, status); } =20 +static void nvmet_execute_get_log_page_ccr(struct nvmet_req *req) +{ + struct nvmet_ctrl *ctrl =3D req->sq->ctrl; + struct nvmet_ccr *ccr; + struct nvme_ccr_log *log; + int index =3D 0; + u16 status; + + log =3D kzalloc(sizeof(*log), GFP_KERNEL); + if (!log) { + status =3D NVME_SC_INTERNAL; + goto out; + } + + mutex_lock(&ctrl->lock); + list_for_each_entry(ccr, &ctrl->ccr_list, entry) { + u8 flags =3D NVME_CCR_FLAGS_VALIDATED | NVME_CCR_FLAGS_INITIATED; + u8 status =3D ccr->ctrl ? NVME_CCR_STATUS_IN_PROGRESS : + NVME_CCR_STATUS_SUCCESS; + + log->entries[index].icid =3D cpu_to_le16(ccr->icid); + log->entries[index].ciu =3D ccr->ciu; + log->entries[index].acid =3D cpu_to_le16(0xffff); + log->entries[index].ccrs =3D status; + log->entries[index].ccrf =3D flags; + index++; + } + + /* Cleanup completed CCRs if requested */ + if (req->cmd->get_log_page.lsp & 0x1) + nvmet_ctrl_cleanup_ccrs(ctrl, false); + mutex_unlock(&ctrl->lock); + + log->ne =3D cpu_to_le16(index); + nvmet_clear_aen_bit(req, NVME_AEN_BIT_CCR_COMPLETE); + status =3D nvmet_copy_to_sgl(req, 0, log, sizeof(*log)); + kfree(log); +out: + nvmet_req_complete(req, status); +} + static void nvmet_execute_get_log_page(struct nvmet_req *req) { if (!nvmet_check_transfer_len(req, nvmet_get_log_page_len(req->cmd))) @@ -641,6 +683,8 @@ static void nvmet_execute_get_log_page(struct nvmet_req= *req) return nvmet_execute_get_log_page_rmi(req); case NVME_LOG_RESERVATION: return nvmet_execute_get_log_page_resv(req); + case NVME_LOG_CCR: + return nvmet_execute_get_log_page_ccr(req); } pr_debug("unhandled lid %d on qid %d\n", req->cmd->get_log_page.lid, req->sq->qid); diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 0f305b317aa3..3e189674b69e 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -1435,6 +1435,7 @@ enum { NVME_LOG_FDP_CONFIGS =3D 0x20, NVME_LOG_DISC =3D 0x70, NVME_LOG_RESERVATION =3D 0x80, + NVME_LOG_CCR =3D 0x1E, NVME_FWACT_REPL =3D (0 << 3), NVME_FWACT_REPL_ACTV =3D (1 << 3), NVME_FWACT_ACTV =3D (2 << 3), @@ -1458,6 +1459,34 @@ enum { NVME_FIS_CSCPE =3D 1 << 21, }; =20 +/* NVMe Cross-Controller Reset Status */ +enum { + NVME_CCR_STATUS_IN_PROGRESS, + NVME_CCR_STATUS_SUCCESS, + NVME_CCR_STATUS_FAILED, +}; + +/* NVMe Cross-Controller Reset Flags */ +enum { + NVME_CCR_FLAGS_VALIDATED =3D 0x01, + NVME_CCR_FLAGS_INITIATED =3D 0x02, +}; + +struct nvme_ccr_log_entry { + __le16 icid; + __u8 ciu; + __u8 rsvd3; + __le16 acid; + __u8 ccrs; + __u8 ccrf; +}; + +struct nvme_ccr_log { + __le16 ne; + __u8 rsvd2[6]; + struct nvme_ccr_log_entry entries[NVMF_CCR_PER_PAGE]; +}; + /* NVMe Namespace Write Protect State */ enum { NVME_NS_NO_WRITE_PROTECT =3D 0, --=20 2.52.0