From nobody Mon Feb 9 05:59:02 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 631DB34B19A for ; Fri, 30 Jan 2026 18:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799457; cv=none; b=bScDKsVlr28UmKUrm/jz/JbzFm2lHsYENLUmvjxfsOI0z0dU8RHHDCd6BlRtyEhIEJdyWWYFdpUFhiROMpSAUscCZskUCX1iZku0/RdBHW21fznieooDuEPxJfo7w5h8AfXVNpynvgpKMTbqjhQMloC1F+mb14yNLQUP6eYhFJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799457; c=relaxed/simple; bh=BTGD8PKhmsfkb+4Q1sKuryoutQRF30cIq9URLzQ0h4I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CCvzJ+QF4BA8xets9PlMaBwfvpUppwwTa0WrhmPXxapiNnC97eY2fcjSrLmnut8mKY1WS07uNMxpPnranBBvG3YoJ5W3pdayIKD/c0a0Mj17dGGOwxggQ9ZUf6lozPlD3BsZfXNVINICJ2q8UjZY25UjjVJkAuVrsIV9c+OkdF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UK6j1W+9; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UK6j1W+9" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4801bc32725so18581265e9.0 for ; Fri, 30 Jan 2026 10:57:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799455; x=1770404255; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HRDtc7+pH6qw1+quaRjh9oBVjXVe884KC2sSKvso1A4=; b=UK6j1W+9uK1YpOfGwLXqPhB7BFLP9vO6jlG9NEvaeZObAJKJ7Ilgq9GaeixAGHdr6t xN+5lpuWZKbEF5U6aOl7HFm3xYUIpc8SSp6rsgBg/9UhdVzACq1jeTp4aYua+fYYptK1 LJS5urSYva52HR6Jg4UsRG9R2jqA2UJ0Pstx5AJchu+dlUbdGp79YcOScLXwQDydq4Ao J70SDeHlkC2/DSQfl+acbcSPph8DdUVI9pI8qOJowjZJFjJb+iX2nyuX8T5swhwWW+nV FSy+JX8w6x05iJQ71qICs8UpMvrM370+oQ/K8rhsRPng9oxWt6RjA2OrJQ1ecBuY3Jsc SB1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799455; x=1770404255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HRDtc7+pH6qw1+quaRjh9oBVjXVe884KC2sSKvso1A4=; b=nEPB391BIAExRZyi3VJ50LgaHpzS5p3z0c1FZUrhr2VK17emY9sbRP0As5uV/ViL71 BYbxKwKoPpf8yyN4dx7L7q47xZT6yem9OONijnOZCeHpA22BkyJoTgv2ANOCKyEQS9RQ d3CM6qLEzaD4pdAhW9V8Po9ReYYydnsTI2iSxRlfU6UVelQVnCvv9BgUVIzjVDQlCTm0 Ixk1CpmFd0dd8KZs4hiSxCx+HGjGohk9OgRbn7Scm6g+0z23qevxsqDkJZ6Z9GLeoB+x wLdid7s4XYwEgXSPrTraKkxDGEKU4fQfDOmgau7Rh1sWVFZAQ9xCD2HiiMGMA4Fgl3VC We5Q== X-Forwarded-Encrypted: i=1; AJvYcCWWNYbo/dTG2eygZ6Ah8+9qzgZHPyB5hNnarKigkB8KAjqu3LfXyt3KKVT/ihHjDbgnGB7Px2g+Z7d8LfY=@vger.kernel.org X-Gm-Message-State: AOJu0YxYdn2NUnym7AMPehiTEJXjusjUgb0NpK1w4ZYad5n9I7iZvv7p lFLQZDRV5KfFr3ToEfkcCXLmDPpAtEqeGY3XAO/FWRBc/CkuShuxonQ= X-Gm-Gg: AZuq6aI+ckD2jSt1zHOcMFeSruKVqhVLzmSbdHPMLKaZbJPemEkfxA0cdtw+qzpI2eY HrIm5nDUhwTVCWp+YTaZ4PDZbD7xBg3Nm8FlRr6Z8gZZFBsw8C3O9VpS5ZwuRxMtX59ZWZuwfd6 gfWjMDJOFD9ZhCiwv84Yv/dQBSBpDhj9j4VsrtOm1/pWAaTa7moKFfGCq6tBt99ATLg3laPRJ73 QOhljag1o6BlnKbmtfmkA1lFXaCv6Hz07MZ6DwENHVDQwlC6cWhhdSBB2TKwc2Ilag1cwYen2AM BrYM68W183jZ9Awnjq4sRqVmJVS975nAKIiNq+mvTaQrLQItjesX73P0j0qB3OEEPL29dIO/mJC ceVwNyr4bcV1NCN/teo4Qal6sxvGY2fSJUqbpjtIVq2efBUZwtWhRcbxqYtzZHoIfmklax/w+G8 0SH+MlnqnXwdDKGOiqnWWt27dGtXrx77+xjb+YfpM9QJmYH0fOFvXRUM27JpnT6Q== X-Received: by 2002:a05:600c:3155:b0:47e:e9bf:dd8a with SMTP id 5b1f17b1804b1-482db4b5a1dmr45681835e9.37.1769799454682; Fri, 30 Jan 2026 10:57:34 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edf62sm26474164f8f.13.2026.01.30.10.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:57:34 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v6 2/5] staging: rtl8723bs: rename u1bTmp to val Date: Fri, 30 Jan 2026 19:56:55 +0100 Message-ID: <20260130185658.207785-3-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185658.207785-1-lukagejak5@gmail.com> References: <20260130185658.207785-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0