From nobody Sun Feb 8 22:58:24 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CE5B385EEF for ; Fri, 30 Jan 2026 18:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799455; cv=none; b=tuu+i79s9krjRnIvR5zKhli2r6cOvLtHwK7T1+WpIDC546UiOo59wHfsicrKQ0zr8KT+TXOZ/Hu2RcSgGotG1LnywulCWyvzzL42nRFetA9HkwHN3e1s5IgM0YDBq1tkHlsWAXnTq8bV4wF18bKbmzhdtNh3q1shjjQbaaCMkWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799455; c=relaxed/simple; bh=54jF80axLN2UJAh0SY0zu8J2BqHK+0mKcS7a+qODr54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d/xVJBjXP05ew5pA81bIfnqxBGQN8KJXmbYlSdqVn8nAngv+9wqva2CeVav3wx54TCJ2yhJmqJFqkFKFOB6Ep4sEFUqRIk4VIMKOuV+SpE6kztFrTyngCHtZOkEnky0+G8h8suW+KvBWvWl5fcUmUot/XRfSEFAA8NHO2tPTQEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EGg129+g; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EGg129+g" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-4327790c4e9so1605408f8f.2 for ; Fri, 30 Jan 2026 10:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799453; x=1770404253; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=EGg129+gaCIw5YZ2hFewK7PC5nvYslLDZjLVDYQfJJpfSjne+MATYsP6l4twJZA7xx W54CTZumHyp/dgu9PdJ6x4P5GwbJpAivcFv2/ajfuM3Ogf4AKulu9i9IC4CnPz0tP7ar ZRseyYd6t4kALb/7fJBULtXLxVexpHtWZJ+dX9jwe0ki4/9XdHTD1pn7V0mLB9o1wXyv 0L7H/0sIi2uXNcDIQBqx+SUSp8hnlDfCmBKNzoha5gSgEh68SU+oTTKMl2pzBMO8du/4 n0kxX+kO1AQldTVpRQem551wanPac+ao4EdjlEUWLKh78C9VJwHKr6luYsi7IFZjB7W5 +lHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799453; x=1770404253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=l+Y8Kcp6jCMYeA26jyA/rtJTdYVMy41NamhXFaFgy0rY4Ut1cnAzcA42IwUqsHm9bd iYqAFlaBUL70TUSh5tmq/C7Gu0CnZMGSok4mBt8nPtpGcK4G6U4catBLDMndaln/liSy TL31EEv+ynqSLWGtCmxSUXIikeHDfL4d269O8jTHBDFYXxXeyOBeJtZdHVb4s/ddvGXZ Dj18L5slPfrqAAousLcw7glpJ/rQ1UooBIc9CYMjxa4/OKP6tTWQm93u5jyiiS9oRW75 O42+/bkduCUBl8RRadLzwMHhdTDqQRdN2XwPRN4h6yInEPhGxggfsIKojVQlc5c738G8 g/LQ== X-Forwarded-Encrypted: i=1; AJvYcCXrD1cfbNEpNZono09uIv7B3+pPXrGmoX8c/ur4Agc6ZApM+MAFpLA5uTs4RmbttZJ4QWE+zd5owBceKZs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4fJeCSfAhexZ7jcbMImibybt9OzR9UmmC4XeTdW4s2Rfcz0Gp TdEpwImrF88QpqxcVu5a3koXsHlog3cQq4kw77DrKS03CJfrUlL6Tiw= X-Gm-Gg: AZuq6aJrAKDYIJJ9g1JomLU6dhRP8xLJCbj1WT1Z+VkvsRJhN65KVu920sAcPH/0E0y lPmb26/7vawDtEQ/h/Hq/AD4VO05IWg/qjuaXC635bGetAIG+kgroqeRzDdnuL2YNYwzioabfCF dRchwhiH6sVDnIFSJ+Bt7NByRdlpqRrqcz8xWV3T53DFbbAk+CEePHsBlZXQxL/Lv4na7m7lvP/ uAbSIXl/PGz1icTtlIOYReQGXVcd3P6GKleh99/Aw/jZcU445gZqqtCQzlCQT5+6UIH8Lh1lkMZ vdqQgCIw/SdYzg55GzYOToy+uIas37ENPXxxYIMmOPSvdXdyq8hqHiIxpO1W7fAQ9dBhQaTzFVB bHbU3jB7b21Eypy91TMjDK1RZS/YKu/AWU7JydodYS4sz8eaCptFQ4O1y7U9ecW3lXn4Zj4H5a4 J8b2IAPqVAUGKQV58pWBUwgMW35ZbC85Yf/OUFlHeGJuOpOu7HGQ9+h/LTgie1ZQ== X-Received: by 2002:a05:6000:420d:b0:435:960c:5286 with SMTP id ffacd0b85a97d-435f3aba816mr6032365f8f.58.1769799452718; Fri, 30 Jan 2026 10:57:32 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edf62sm26474164f8f.13.2026.01.30.10.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:57:32 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak , stable@vger.kernel.org Subject: [PATCH v6 1/5] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie Date: Fri, 30 Jan 2026 19:56:54 +0100 Message-ID: <20260130185658.207785-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185658.207785-1-lukagejak5@gmail.com> References: <20260130185658.207785-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 = *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength =3D initial_out_len; =20 - if (in_ie[i] =3D=3D 0xDD && in_ie[i+2] =3D=3D 0x00 && in_ie[i+3] =3D=3D = 0x50 && in_ie[i+4] =3D=3D 0xF2 && in_ie[i+5] =3D=3D 0x02 && i+5 < in_len) = { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] =3D=3D 0xDD && in_ie[i + 2] =3D=3D 0x00 && + in_ie[i + 3] =3D=3D 0x50 && in_ie[i + 4] =3D=3D 0xF2 && + in_ie[i + 5] =3D=3D 0x02) { for (j =3D i; j < i + 9; j++) { out_ie[ielength] =3D in_ie[j]; ielength++; --=20 2.52.0