From nobody Sun Feb 8 06:22:19 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CE5B385EEF for ; Fri, 30 Jan 2026 18:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799455; cv=none; b=tuu+i79s9krjRnIvR5zKhli2r6cOvLtHwK7T1+WpIDC546UiOo59wHfsicrKQ0zr8KT+TXOZ/Hu2RcSgGotG1LnywulCWyvzzL42nRFetA9HkwHN3e1s5IgM0YDBq1tkHlsWAXnTq8bV4wF18bKbmzhdtNh3q1shjjQbaaCMkWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799455; c=relaxed/simple; bh=54jF80axLN2UJAh0SY0zu8J2BqHK+0mKcS7a+qODr54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d/xVJBjXP05ew5pA81bIfnqxBGQN8KJXmbYlSdqVn8nAngv+9wqva2CeVav3wx54TCJ2yhJmqJFqkFKFOB6Ep4sEFUqRIk4VIMKOuV+SpE6kztFrTyngCHtZOkEnky0+G8h8suW+KvBWvWl5fcUmUot/XRfSEFAA8NHO2tPTQEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EGg129+g; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EGg129+g" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-4327790c4e9so1605408f8f.2 for ; Fri, 30 Jan 2026 10:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799453; x=1770404253; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=EGg129+gaCIw5YZ2hFewK7PC5nvYslLDZjLVDYQfJJpfSjne+MATYsP6l4twJZA7xx W54CTZumHyp/dgu9PdJ6x4P5GwbJpAivcFv2/ajfuM3Ogf4AKulu9i9IC4CnPz0tP7ar ZRseyYd6t4kALb/7fJBULtXLxVexpHtWZJ+dX9jwe0ki4/9XdHTD1pn7V0mLB9o1wXyv 0L7H/0sIi2uXNcDIQBqx+SUSp8hnlDfCmBKNzoha5gSgEh68SU+oTTKMl2pzBMO8du/4 n0kxX+kO1AQldTVpRQem551wanPac+ao4EdjlEUWLKh78C9VJwHKr6luYsi7IFZjB7W5 +lHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799453; x=1770404253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=l+Y8Kcp6jCMYeA26jyA/rtJTdYVMy41NamhXFaFgy0rY4Ut1cnAzcA42IwUqsHm9bd iYqAFlaBUL70TUSh5tmq/C7Gu0CnZMGSok4mBt8nPtpGcK4G6U4catBLDMndaln/liSy TL31EEv+ynqSLWGtCmxSUXIikeHDfL4d269O8jTHBDFYXxXeyOBeJtZdHVb4s/ddvGXZ Dj18L5slPfrqAAousLcw7glpJ/rQ1UooBIc9CYMjxa4/OKP6tTWQm93u5jyiiS9oRW75 O42+/bkduCUBl8RRadLzwMHhdTDqQRdN2XwPRN4h6yInEPhGxggfsIKojVQlc5c738G8 g/LQ== X-Forwarded-Encrypted: i=1; AJvYcCXrD1cfbNEpNZono09uIv7B3+pPXrGmoX8c/ur4Agc6ZApM+MAFpLA5uTs4RmbttZJ4QWE+zd5owBceKZs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4fJeCSfAhexZ7jcbMImibybt9OzR9UmmC4XeTdW4s2Rfcz0Gp TdEpwImrF88QpqxcVu5a3koXsHlog3cQq4kw77DrKS03CJfrUlL6Tiw= X-Gm-Gg: AZuq6aJrAKDYIJJ9g1JomLU6dhRP8xLJCbj1WT1Z+VkvsRJhN65KVu920sAcPH/0E0y lPmb26/7vawDtEQ/h/Hq/AD4VO05IWg/qjuaXC635bGetAIG+kgroqeRzDdnuL2YNYwzioabfCF dRchwhiH6sVDnIFSJ+Bt7NByRdlpqRrqcz8xWV3T53DFbbAk+CEePHsBlZXQxL/Lv4na7m7lvP/ uAbSIXl/PGz1icTtlIOYReQGXVcd3P6GKleh99/Aw/jZcU445gZqqtCQzlCQT5+6UIH8Lh1lkMZ vdqQgCIw/SdYzg55GzYOToy+uIas37ENPXxxYIMmOPSvdXdyq8hqHiIxpO1W7fAQ9dBhQaTzFVB bHbU3jB7b21Eypy91TMjDK1RZS/YKu/AWU7JydodYS4sz8eaCptFQ4O1y7U9ecW3lXn4Zj4H5a4 J8b2IAPqVAUGKQV58pWBUwgMW35ZbC85Yf/OUFlHeGJuOpOu7HGQ9+h/LTgie1ZQ== X-Received: by 2002:a05:6000:420d:b0:435:960c:5286 with SMTP id ffacd0b85a97d-435f3aba816mr6032365f8f.58.1769799452718; Fri, 30 Jan 2026 10:57:32 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edf62sm26474164f8f.13.2026.01.30.10.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:57:32 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak , stable@vger.kernel.org Subject: [PATCH v6 1/5] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie Date: Fri, 30 Jan 2026 19:56:54 +0100 Message-ID: <20260130185658.207785-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185658.207785-1-lukagejak5@gmail.com> References: <20260130185658.207785-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 = *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength =3D initial_out_len; =20 - if (in_ie[i] =3D=3D 0xDD && in_ie[i+2] =3D=3D 0x00 && in_ie[i+3] =3D=3D = 0x50 && in_ie[i+4] =3D=3D 0xF2 && in_ie[i+5] =3D=3D 0x02 && i+5 < in_len) = { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] =3D=3D 0xDD && in_ie[i + 2] =3D=3D 0x00 && + in_ie[i + 3] =3D=3D 0x50 && in_ie[i + 4] =3D=3D 0xF2 && + in_ie[i + 5] =3D=3D 0x02) { for (j =3D i; j < i + 9; j++) { out_ie[ielength] =3D in_ie[j]; ielength++; --=20 2.52.0 From nobody Sun Feb 8 06:22:19 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 631DB34B19A for ; Fri, 30 Jan 2026 18:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799457; cv=none; b=bScDKsVlr28UmKUrm/jz/JbzFm2lHsYENLUmvjxfsOI0z0dU8RHHDCd6BlRtyEhIEJdyWWYFdpUFhiROMpSAUscCZskUCX1iZku0/RdBHW21fznieooDuEPxJfo7w5h8AfXVNpynvgpKMTbqjhQMloC1F+mb14yNLQUP6eYhFJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799457; c=relaxed/simple; bh=BTGD8PKhmsfkb+4Q1sKuryoutQRF30cIq9URLzQ0h4I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CCvzJ+QF4BA8xets9PlMaBwfvpUppwwTa0WrhmPXxapiNnC97eY2fcjSrLmnut8mKY1WS07uNMxpPnranBBvG3YoJ5W3pdayIKD/c0a0Mj17dGGOwxggQ9ZUf6lozPlD3BsZfXNVINICJ2q8UjZY25UjjVJkAuVrsIV9c+OkdF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UK6j1W+9; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UK6j1W+9" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4801bc32725so18581265e9.0 for ; Fri, 30 Jan 2026 10:57:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799455; x=1770404255; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HRDtc7+pH6qw1+quaRjh9oBVjXVe884KC2sSKvso1A4=; b=UK6j1W+9uK1YpOfGwLXqPhB7BFLP9vO6jlG9NEvaeZObAJKJ7Ilgq9GaeixAGHdr6t xN+5lpuWZKbEF5U6aOl7HFm3xYUIpc8SSp6rsgBg/9UhdVzACq1jeTp4aYua+fYYptK1 LJS5urSYva52HR6Jg4UsRG9R2jqA2UJ0Pstx5AJchu+dlUbdGp79YcOScLXwQDydq4Ao J70SDeHlkC2/DSQfl+acbcSPph8DdUVI9pI8qOJowjZJFjJb+iX2nyuX8T5swhwWW+nV FSy+JX8w6x05iJQ71qICs8UpMvrM370+oQ/K8rhsRPng9oxWt6RjA2OrJQ1ecBuY3Jsc SB1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799455; x=1770404255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HRDtc7+pH6qw1+quaRjh9oBVjXVe884KC2sSKvso1A4=; b=nEPB391BIAExRZyi3VJ50LgaHpzS5p3z0c1FZUrhr2VK17emY9sbRP0As5uV/ViL71 BYbxKwKoPpf8yyN4dx7L7q47xZT6yem9OONijnOZCeHpA22BkyJoTgv2ANOCKyEQS9RQ d3CM6qLEzaD4pdAhW9V8Po9ReYYydnsTI2iSxRlfU6UVelQVnCvv9BgUVIzjVDQlCTm0 Ixk1CpmFd0dd8KZs4hiSxCx+HGjGohk9OgRbn7Scm6g+0z23qevxsqDkJZ6Z9GLeoB+x wLdid7s4XYwEgXSPrTraKkxDGEKU4fQfDOmgau7Rh1sWVFZAQ9xCD2HiiMGMA4Fgl3VC We5Q== X-Forwarded-Encrypted: i=1; AJvYcCWWNYbo/dTG2eygZ6Ah8+9qzgZHPyB5hNnarKigkB8KAjqu3LfXyt3KKVT/ihHjDbgnGB7Px2g+Z7d8LfY=@vger.kernel.org X-Gm-Message-State: AOJu0YxYdn2NUnym7AMPehiTEJXjusjUgb0NpK1w4ZYad5n9I7iZvv7p lFLQZDRV5KfFr3ToEfkcCXLmDPpAtEqeGY3XAO/FWRBc/CkuShuxonQ= X-Gm-Gg: AZuq6aI+ckD2jSt1zHOcMFeSruKVqhVLzmSbdHPMLKaZbJPemEkfxA0cdtw+qzpI2eY HrIm5nDUhwTVCWp+YTaZ4PDZbD7xBg3Nm8FlRr6Z8gZZFBsw8C3O9VpS5ZwuRxMtX59ZWZuwfd6 gfWjMDJOFD9ZhCiwv84Yv/dQBSBpDhj9j4VsrtOm1/pWAaTa7moKFfGCq6tBt99ATLg3laPRJ73 QOhljag1o6BlnKbmtfmkA1lFXaCv6Hz07MZ6DwENHVDQwlC6cWhhdSBB2TKwc2Ilag1cwYen2AM BrYM68W183jZ9Awnjq4sRqVmJVS975nAKIiNq+mvTaQrLQItjesX73P0j0qB3OEEPL29dIO/mJC ceVwNyr4bcV1NCN/teo4Qal6sxvGY2fSJUqbpjtIVq2efBUZwtWhRcbxqYtzZHoIfmklax/w+G8 0SH+MlnqnXwdDKGOiqnWWt27dGtXrx77+xjb+YfpM9QJmYH0fOFvXRUM27JpnT6Q== X-Received: by 2002:a05:600c:3155:b0:47e:e9bf:dd8a with SMTP id 5b1f17b1804b1-482db4b5a1dmr45681835e9.37.1769799454682; Fri, 30 Jan 2026 10:57:34 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edf62sm26474164f8f.13.2026.01.30.10.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:57:34 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v6 2/5] staging: rtl8723bs: rename u1bTmp to val Date: Fri, 30 Jan 2026 19:56:55 +0100 Message-ID: <20260130185658.207785-3-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185658.207785-1-lukagejak5@gmail.com> References: <20260130185658.207785-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sun Feb 8 06:22:19 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A92B385EDC for ; Fri, 30 Jan 2026 18:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799460; cv=none; b=tmj0UPqC5EpAECc1ILxpga8jqneIGa0opME6IsDfncabh/L6czOgEJ1Z/ZCwQ+JKqzYZaRt8VujxVx25hFqG9kNSk6hQ2QpLyYLsXgvh6Tgl6ZOTIw5qQba6jAIHgpN1fUuGXIITiJkoV42knJrej+oPdJs1o494n0JqGk3QMCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799460; c=relaxed/simple; bh=rydnYZqJ+NFeWlELYNoZjjVmnW/PmZZQ4nMY0FQMv2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I0jx5c0LhVPeUR+QgDmn/UXDvEbBD0NwnKLskxZYNMsHalpu9DDgfpHhZhtUs+ewDjd5LR5OFGbvWi1SGwP2Ntq1nQmmDH+4ZNbyrOPT/GXRysNFxvYFAW6gjMnQh8Qu13JLiwhjcDZeeumRwnV6pCjn5zsbxGxdCqmQIqlJTFo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JrfPBd/b; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JrfPBd/b" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48068ed1eccso22341365e9.2 for ; Fri, 30 Jan 2026 10:57:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799457; x=1770404257; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=JrfPBd/bhkUebmIrCBIJXRNnD6eDJsROxWcEqS3m4V48gDpsi/i6rDY7Xz43TRX60Q G/MJsapWc0XxywOeDGI362L9UEfVMc9IrK1OSnyYGjzEHO3UU60rfzExQDofS6joMJ/6 SB+oxZrNK41EG1JKEBky3oN5ARGkhojEh8hXEOTcmJ03a+bjgFUoZ/pu2ZVvfB84XlTf IgCPs4QegZttDFSG4pLgpgEduhE27qny1iJf+pfUNS2/1ds6Ga/NuN7QOQm9OxdDhiY7 h29O2Elfw/rINXujUzM3y4xJ9qTHcl9FeHM19V5W2lxKoC5T9jbUyD4ikl9k1/H8zE/X 36hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799457; x=1770404257; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=c+jqSBHWFJ29BtloMrKmBpYcvZg4TXTDoy1cKGCPJxe1YQ91g7240g5l76dI5RhMN2 ssxJ3M/eTkHFy/0uOT/gPvmsu3bo729ffc58XxKTuynhoUqa2DwBYtKjHtK96eDBcFMz Q4/VPhZ0chV38mIsPft4+H63j6MID16lIgv3cxA7SDVHHSkrEE6YbNKIg0sFHLJ0Ffh0 3MDPuZboR5iEkrgBwIpCQi/kuUdUR00rmX5fzXOGQiNC8OLar6hY8XiLSbcqe0Lkjk7H rHqkw0Z6qx8EhgHxuYiDJDIroc3lAZ+1VDIo06WVzivvtYyULpuXNvb+RlaZgSkF5VQJ 35gQ== X-Forwarded-Encrypted: i=1; AJvYcCVFVSlIfbR1luTW712O0BzjGy9B9kV7icLda5zKR6b9xLShllYZIy+wGcWyCplY7Job+vK8pQiXjV0TYdU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzpb+FDZDb8Po2jSkXZPHMMyO4/vZnhLQcq2XfZPxK1LY3wVJua Hl0WMCU0E6lWeGy7BVflGNtBswlniQfxA0plNTqBxsKGi8FKxJpxwTE= X-Gm-Gg: AZuq6aKd3Ybf/NELJmf/xjESkjEQqalVFRx8/s/L/xOhzDCfuliJpd6nX3f95J653Hg fCVKXxSRHvfcbrXdqIAjntTuIwp7LXk0ZMPjWviQ5qnP6DcsWQq/2jARMILPUjZ3xXb+UZqx51G g2Ia3G7ftt55sDINX0RJ5s6S3bldDjGyV5d1ElBKg3JvIY5lAxYJWL66jChgWpc7beLO8R0NZyg gLiQtI1pO1unY/yA/ml7Qpz+6AqG+7LOvrMg+zHGseY8T90Zq2EqK+SnsllDqLljdf5Jnld+K52 gFOx6Hb83FWKSJU50OkjcvbLn0O76XgcgdfLuEHKapuWO32OH2r8FJ149XSAADyJcOFiLFrJc2K D2jJ7Fc04BeZ08uXbwgniKWMnQjjplKLYzUoa/TRhPDOuUOT02W44eNVWWoCIAL5R/Q1tOEa/22 KGOa0/kxGEpzlakUMdhn1TZsC4RMuxEU4f8S2wuaiLjR3NsutQARgjxyzGIsuS3Q== X-Received: by 2002:a05:6000:1786:b0:435:dd81:4f4d with SMTP id ffacd0b85a97d-435f3a7bf2fmr6863728f8f.26.1769799456973; Fri, 30 Jan 2026 10:57:36 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edf62sm26474164f8f.13.2026.01.30.10.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:57:36 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v6 3/5] staging: rtl8723bs: fix spacing around operators Date: Fri, 30 Jan 2026 19:56:56 +0100 Message-ID: <20260130185658.207785-4-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185658.207785-1-lukagejak5@gmail.com> References: <20260130185658.207785-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix coding style issues by adding missing spaces around operators. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 28 +++++++++---------- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index d75a63fd8a6b..ae5e4980ed06 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -17,8 +17,8 @@ static void _FWDownloadEnable(struct adapter *padapter, b= ool enable) =20 if (enable) { /* 8051 enable */ - tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, tmp|0x04); + tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04); =20 tmp =3D rtw_read8(padapter, REG_MCUFWDL); rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); @@ -158,23 +158,23 @@ void _8051Reset8723(struct adapter *padapter) /* Reset 8051(WLMCU) IO wrapper */ /* 0x1c[8] =3D 0 */ /* Suggested by Isaac@SD1 and Gimmy@SD1, coding by Lucas@20130624 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst &=3D ~BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); =20 /* Enable 8051 IO wrapper */ /* 0x1c[8] =3D 1 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst |=3D BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); } =20 u8 g_fwdl_chksum_fail; @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val & (~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index c774a9009e95..668616efa68a 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -875,7 +875,7 @@ static void CardDisableRTL8723BSdio(struct adapter *pad= apter) rtw_write8(padapter, REG_RSV_CTRL + 1, val); val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); val |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, val); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sun Feb 8 06:22:19 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9680E387348 for ; Fri, 30 Jan 2026 18:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799462; cv=none; b=kPOrKdGnyjHnLBlKvuiof3ifPimr9DJPiO498yAvpfnNzKdQtkV/LElnmgUk8zEneXZZByGbNZI955rsGi+zK0ZAy8COWci49L4qtzd+YPT0ZEiO4auUqAD9X6R4s8NCksdSnOfa9YeLHUVeSI5VXEKrTTafl2UTYWRDcHQTNWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799462; c=relaxed/simple; bh=uMjtgTE2oQaSlXZ2RpWzD0PdmDQs8ivpMUqvhD1eH6k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fddvf8NcYnEyYbgBQdyzzoW8Bx4p+L1lsqc0vzRiALLd+rWLCKbfLOMIJelaRNHg6Pj2Kvsp2x/Q7+k1O7pAEtyGYvkjQdh5TY3TaMhjwkwcXoNnrmvdyik6WYqjvccU6kAD6zLLVj0taP8Dro+F4eF22Xnd9vTU5oLfEsnjkTI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lhwu+gCN; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lhwu+gCN" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4806bf03573so13371605e9.2 for ; Fri, 30 Jan 2026 10:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799459; x=1770404259; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qVrBPCMwxLFaPKXm7iV49koCmmnJv5JcMuWXxCdjyKc=; b=Lhwu+gCNDJO2acoSzUpnL4D13514s1zGnh0mHHtL1kYWgo3dt1e/P217ylzMBKA/vT X2Lddb+MrNpG0Agn5Zww5k5ix9b7lFdqutTecd/PUD16/6oz4grf1fwUADiq7tE8i1Q1 lbN8V8zgNOx7wy4nZjBLcaFlJKAUnvg/Gz3vk+EPSewmJ53Ew8ezcmVqZ1kzRq6iI797 eJrkEwcrHqMAchkdLbigPucPpJJ/+U6JJ2EOKFPT57FNEwIpkmy2/6aGZSkVueqnKc5l tFUxn8Ki4XYDjBgkaTGHYSTNJrzQ2jHKeRmx5eU1xGR+E3EFM8eWZjjfrPuW5Yrisztu 2hFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799459; x=1770404259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qVrBPCMwxLFaPKXm7iV49koCmmnJv5JcMuWXxCdjyKc=; b=LLB9AnMl7jayVKXpGPbFCO04QwyPXXpKVlFVfczDZucs+XRgDaPDlhJGQcnqdn4Y8S 8FCZLuLK59BxYG13rAzBbpwX+1UjBG2wkwoLMXBwip93dVB7RIds68yUM4H2xzVhMRDE joT+doSOuCRo+rWr7rLQmbajjgJuWyjkPAVbXgCRauFnnEZ2WL0fqivZjR4cTjxqHmNa xZfJKVQe9LWuFb46O3dGprRNTNTXbz8VLOaXksCmMrhMtXO0RYbaanVxSJGkPg8E/PDV H+wjbZuzQm7OjLJABh8JOYTdp6Nv6LLOLV+pQz74Z3MS+izB956YAAIP9ULzuTVZB4ys KmrQ== X-Forwarded-Encrypted: i=1; AJvYcCVByfLxXMfQei2DdE2hnG/4SqwAp+OXhGDHE36gb8pVYLgwxc0PoKmVpCP8d5KGLmxyFWRLWBw8H6AHNsY=@vger.kernel.org X-Gm-Message-State: AOJu0YxLnkLuQRPm/99ST6kvKDZW3v8Zp5YMFvdO89zW4uzNjx6avAmT vuhh3dbapRK2JURoYgKcqj2b5nqKhRVVAvaJRa6Wi93XEgLNjiKmq34= X-Gm-Gg: AZuq6aKWR1XaPSsC3eFpX+y4dOLqeCIJgsfQgJtj4yu3+JHx2JukD4pcox7+ZiGPWm4 qldKFgCMJfhhrOvYEkwP8kJPYuQePd9dHio8BN5zDopZgTlDh2u85AjlL6v7Ek2q9UH2kWtsFPy p3Q7SMqS6zZaR4DnJLlPZQHiEvZaIuPP63Njs3BZhdr/Mv7XIi8DiFptYJ63v7e0l21gKN4G++t SH9l/ykw0SBz4YA9iLX7Z+cUSbOFzW2AsGEoaiM+OI7u8Vjf2TCK30dOS/mrg3aabUw7fJPqEWe BxfPjXAeUZKpiVIRizpb1XiK9RUtCW9Zqj4KCUmbAxW9QIUxo/RtpDB4iN52JXCtxoWfbCP1E8u 0GMjo0UfdfyGiGfzzcwdSLEoMMNXt+oOv3TNSHGcmFBrTByGbjZhc5YZGkj2SWb6WU5qYN3dTjh 8olRR+Ed9DAZrIM1WqnFhnkjRMrP1hq9v6kMZCv96Nz0FWJ4GCR9IB/1qMEasQSw== X-Received: by 2002:a5d:5e01:0:b0:431:32f:3159 with SMTP id ffacd0b85a97d-435f3a69048mr4920418f8f.7.1769799458876; Fri, 30 Jan 2026 10:57:38 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edf62sm26474164f8f.13.2026.01.30.10.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:57:38 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v6 4/5] staging: rtl8723bs: modernize hex output in rtw_report_sec_ie Date: Fri, 30 Jan 2026 19:56:57 +0100 Message-ID: <20260130185658.207785-5-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185658.207785-1-lukagejak5@gmail.com> References: <20260130185658.207785-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the manual hex-printing loop with the standard kernel '%*ph' format string. This simplifies the code and uses modern logging practices. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 7dfc2678924e..5e79a720710f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2071,7 +2071,7 @@ static int rtw_append_pmkid(struct adapter *Adapter, = int iEntry, u8 *ie, uint ie static void rtw_report_sec_ie(struct adapter *adapter, u8 authmode, u8 *se= c_ie) { uint len; - u8 *buff, *p, i; + u8 *buff, *p; union iwreq_data wrqu; =20 buff =3D NULL; @@ -2087,8 +2087,7 @@ static void rtw_report_sec_ie(struct adapter *adapter= , u8 authmode, u8 *sec_ie) len =3D sec_ie[1] + 2; len =3D (len < IW_CUSTOM_MAX) ? len : IW_CUSTOM_MAX; =20 - for (i =3D 0; i < len; i++) - p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), "%02x", sec_ie[i]); + p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), " %*ph", len, sec_ie); =20 p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), ")"); =20 --=20 2.52.0 From nobody Sun Feb 8 06:22:19 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7C0233C534 for ; Fri, 30 Jan 2026 18:57:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799464; cv=none; b=s+9rixkWCVUDa6CY8k5btbv55Eo5nm+eSKO5fkk5iGG058QAdG88rLeg++tJJluS8Jj9X/vjnd2GQwcXJNx6ktMsehN4LY71YV4dubFZRxlWnm68CQWWbAdRhc+HHenA1sd6Q0NLxnaIyzSqwS4dScJZrb8tV1zk5ToZNx24OZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799464; c=relaxed/simple; bh=FZZvYnP51QX0dNB1MW147bXp1WMORAQQSIU33mEW2yU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ku1Czi2erHWx81EBdAGZIGqjCsl+HQI6cxf28ZUg+arQMrIKdTl+muKQUwhC/kvOD6tKPqx5YrRXRyALrlJJqhLMNlNAygYfNm+DF8y9LKSW+nWS+X7wNFORR1CaB5lw8F2dkWcpRwSsEb6WSfBLeqRnnhDfHRt7rzbCTqQwyA0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FVdyPPgP; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FVdyPPgP" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so2126899f8f.2 for ; Fri, 30 Jan 2026 10:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799461; x=1770404261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7q66IcrlcJI8pRbK+Fca3eWQA2yovR85OACWrbeMFzM=; b=FVdyPPgPR1Pz7WHb5iY+5rz3Pke9hDGpJTohL06UG13alrLQuOzKyFnjMU3DfiYO7Y XW74T4+731BtBraXU6dP+LQwmS1OljnF7om9vvfJfUGqXLv8aLUBHm9+6OYVshqdhRnC 5B+5E0uqMJHhbuwuGhcV0MNwRROJBN9h+/KH+eTxbGXQjzBaCuaZBwZnlYy5Krprp2Xp SHWDr+9/1E11ZLtqbKdQRj7Og9IHUO9mKYyCzApOUEfozLEnOJP4kqKZ0w7XySOz7MbS MvXEDiIlqiIfLr07Pz1pPDfz+Fh43WpXrcdhAY/J1vNZSVprmxjmvTtiFBhEq2eTIyn7 JpMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799461; x=1770404261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7q66IcrlcJI8pRbK+Fca3eWQA2yovR85OACWrbeMFzM=; b=vh/2E1AW0O82HQlvm39x00kush0hGcgqNYXhN3wWUAZ0tyolkoT/8B3zv5/znkcpP+ E5vui6ShYt6j5CY/nq4vrbtPzvpSgZf26igOjyGJQBWfNo5/4BCO+oeOo8Yh9sFTqf7K +iXQHCWAxqEnFvQLTJJmbsDpZ7e9RUwJynqRcCEnNOAQQasxxxM41ZTbp/wwHscfwtAX 2Cu2ruavXFJL+Yx9gYQyJCdjSzirJjon0wmkkO2uMA+DEy4S98wFQzCsRZeWW20JUICA NLqwaFqPkRjKesa2E07EbntHMCjyqNLP1I9VTiIxY9uAxxzWUOiDypc9yOK+CigqUFB9 J6TQ== X-Forwarded-Encrypted: i=1; AJvYcCXthMc3yGpDUEUd4FVemV595QkkhFTMLMcreBsKpUNN75vWE0hkukvHVB/FJJlwzwmpUOB9FfgbIy3myAM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx8RJ43mdVIO8S2mf7tgz1B0efmGMJ3UTN2w0KdFjSKqVVazxY evVCoc4jvX5p2OO/9kImTMN8p2yOQfxF3b/BHyYysM+PiKiuYepUb54= X-Gm-Gg: AZuq6aI41q3/bt8C1PgwDQewxteWB63UjBNIpZl3ekYb4ivQvZXcqj0ft5AhpNkuSg+ 2h4pz4IdAvqRqCByEOg9VhXSHwRCNVfxReQkTInztHo1Wa5TY8RI+Ta2HKPbaL3tWibuZuBv1RI RZY4B+Nm6bFpIddkzj+cKtGPOt6mwQSjdOCktaroCa++lURru55u1oYczwPVrKlbIsiJGvniuCd oGbiHCdxVtqdNUzQulTStpgJjAA875tf6MWcPLk/kI8IRjW1dSdcWC1RZZ2GG1aI7i3gxfLnnBS x1DZ9lmFAPq3X3L3oys7lFs6EFFllEelFYWfNdlnxu+5QHnUxFp/0Da1Hg3JBrwNryq0AtAEGov ZIrjFDqfdwyIHxIH8/O9yK0rNubAlx7HYU/BOi+EENxIi9eiw7FFYbpeTmGExc6AtAYbdF+t/rZ EsKV3ORwIOO8L8YcmKjJ0ampisGukmWcwJcFIDhRaOY/mwE3AqEVfcQ1hGIuUazF48t1XLXWCi X-Received: by 2002:a05:6000:240c:b0:430:fcf5:495c with SMTP id ffacd0b85a97d-435f3a62ec3mr5823254f8f.4.1769799460921; Fri, 30 Jan 2026 10:57:40 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edf62sm26474164f8f.13.2026.01.30.10.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:57:40 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v6 5/5] staging: rtl8723bs: remove dead debugging code in rtw_mlme_ext.c Date: Fri, 30 Jan 2026 19:56:58 +0100 Message-ID: <20260130185658.207785-6-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185658.207785-1-lukagejak5@gmail.com> References: <20260130185658.207785-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the unused local variable 'pattrib' and the unreachable 'if (0)' debug block in OnAction_sa_query to clean up the driver code. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index ac49bfbaa5bb..b61841bf16a5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1849,7 +1849,6 @@ unsigned int OnAction_ht(struct adapter *padapter, un= ion recv_frame *precv_frame unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame = *precv_frame) { u8 *pframe =3D precv_frame->u.hdr.rx_data; - struct rx_pkt_attrib *pattrib =3D &precv_frame->u.hdr.attrib; struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); unsigned short tid; =20 @@ -1865,14 +1864,6 @@ unsigned int OnAction_sa_query(struct adapter *padap= ter, union recv_frame *precv default: break; } - if (0) { - int pp; - - netdev_dbg(padapter->pnetdev, "pattrib->pktlen =3D %d =3D>", pattrib->pk= t_len); - for (pp =3D 0; pp < pattrib->pkt_len; pp++) - pr_cont(" %02x ", pframe[pp]); - pr_cont("\n"); - } =20 return _SUCCESS; } --=20 2.52.0